Re: r244389 - [analyzer] Add checkers for OS X / iOS localizability issues

NP, thanks for the quick fixes! On Fri, Aug 7, 2015 at 9:56 PM Anna Zaks ga...@apple.com wrote: Sorry about the breakage! I’ve reverted the commit in r244394. Anna. On Aug 7, 2015, at 9:08 PM, Chandler Carruth chandl...@google.com wrote: Note that this is still failing on bots even after

r245320 - Update to reflect the library set in LLVM changing.

Author: chandlerc Date: Tue Aug 18 12:59:33 2015 New Revision: 245320 URL: http://llvm.org/viewvc/llvm-project?rev=245320view=rev Log: Update to reflect the library set in LLVM changing. Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified: cfe/trunk/tools/driver/CMakeLists.txt URL:

Re: [PATCH] D12087: always_inline codegen rewrite

chandlerc added a comment. FYI, we should send an RFC to llvm-dev about the design change of always_inline and make sure folks generally like the IR-level direction as well. We can point at this review as an example. I'm happy to write that up and send it if that's useful? Repository: rL

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as not null, and use them in cstring

chandlerc added a comment. I agree with both Marshall and Hal. However, I'm also not opposed to platforms opting out if this if they want to. If a particular platform wants to define the behavior of null pointers passed to these functions, that seems like a reasonable thing to support here.

Re: [PATCH] D11983: Make getToolChain actually cache its result, as documented in Driver.h

chandlerc added a comment. This isn't necessary. The TC that we assign to is a reference to the pointer in the map. It should already be caching. http://reviews.llvm.org/D11983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r250418 - [CodeGen] Remove dead code. NFC.

Is it possible to add a unittest that exercises this extension point in-tree? For example the way I did for AA extension hooks? On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits

r246375 - Update for several APIs in LLVM that now use StringRefs rather than

Author: chandlerc Date: Sun Aug 30 02:51:18 2015 New Revision: 246375 URL: http://llvm.org/viewvc/llvm-project?rev=246375view=rev Log: Update for several APIs in LLVM that now use StringRefs rather than const char pointers. In turn, push this through Clang APIs as well, simplifying a number of

Re: [PATCH] D12622: [Shave]: add a -MT option to moviCompile if there wasn't one

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM i guess... I'm a tiny bit surprised that you have to handle this here rather than something else handling this for you... But not a lit surprised...

Re: r246991 - When building the alloca for a local variable, set its name

None of my performance concerns were relevant to this change FWIW. I think the reason that this got "fixed" was because people had a tendancy to *rely* on the name downstream when we made it always present. =/ Personally, I like having *no* names in a no-asserts build because it ensures that

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

On Thu, Sep 10, 2015 at 7:27 PM John McCall wrote: > On Sep 10, 2015, at 16:09, Chandler Carruth wrote: > > > On Thu, Sep 10, 2015 at 3:26 PM John McCall wrote: > >> On Sep 10, 2015, at 3:22 PM, Chandler Carruth

r248980 - Patch over a really horrible bug in our vector builtins that showed up

Author: chandlerc Date: Wed Sep 30 21:21:34 2015 New Revision: 248980 URL: http://llvm.org/viewvc/llvm-project?rev=248980=rev Log: Patch over a really horrible bug in our vector builtins that showed up recently when we started using direct conversion to model sign extension. The __v16qi type we

[PATCH] D13324: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char.

chandlerc created this revision. chandlerc added a reviewer: rsmith. chandlerc added a subscriber: cfe-commits. This further testing uncovered that AVX-2 has a broken cmpgt for 8-bit elements, and has for a long time. This is fixed in the same way as SSE4 handles the case. The other ISA

Re: r248980 - Patch over a really horrible bug in our vector builtins that showed up

Note that http://reviews.llvm.org/D13324 is the promised improved fix here, awaiting review. =] On Wed, Sep 30, 2015 at 7:23 PM Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Wed Sep 30 21:21:34 2015 > New Revision: 24898

r249097 - Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly

Author: chandlerc Date: Thu Oct 1 18:40:12 2015 New Revision: 249097 URL: http://llvm.org/viewvc/llvm-project?rev=249097=rev Log: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char. This further

Re: [PATCH] D13324: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249097: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly (authored by chandlerc). Changed prior to commit: http://reviews.llvm.org/D13324?vs=36178=36321#toc Repository: rL LLVM

Re: [PATCH] D12747: Implement [depr.c.headers]

Marshall, I think Richard has responded to your concerns. Anything left? This is blocking some things on our end. On Wed, Sep 16, 2015 at 2:04 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow > wrote: >

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Sorry I was a bit slow -- was out when commented in Nov, and was slow catching back up the past two weeks. I've done some more testing, and the check-libomp is passing very nicely now!

Re: [PATCH] D15087: [PATCH] Add CERT license clarification

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Danny's OK is enough for me. LGTM http://reviews.llvm.org/D15087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r244070 - [CMake] First pass at adding support for clang bootstrap builds to CMake

Hey Chris, I just noticed that this option is only available when you build Clang as a standalone project, as opposed to building all of LLVM. Was that intentional? Is there any plan to support this in more normal whole-LLVM builds? It seems substantially more useful for stuff like picking up

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

Uh, did you intend to commit this prior to Justin or others giving an LGTM? On Fri, Dec 18, 2015 at 4:59 PM Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL256069: [CMake] Support a

r256629 - [ptr-traits] Some compilers (older Clang? unsure) on build bots need

Author: chandlerc Date: Wed Dec 30 00:21:02 2015 New Revision: 256629 URL: http://llvm.org/viewvc/llvm-project?rev=256629=rev Log: [ptr-traits] Some compilers (older Clang? unsure) on build bots need this constructor to be out of line in order to not require the complete type of TemplateDecl.

r256630 - [ptr-traits] Add another complete type that is necessary for at least

Author: chandlerc Date: Wed Dec 30 00:38:29 2015 New Revision: 256630 URL: http://llvm.org/viewvc/llvm-project?rev=256630=rev Log: [ptr-traits] Add another complete type that is necessary for at least some of the build bots. Still can't reproduce these failures locally. Modified:

r272453 - Revert "[ASTMatchers] New forEachOverriden matcher."

Author: chandlerc Date: Fri Jun 10 23:45:38 2016 New Revision: 272453 URL: http://llvm.org/viewvc/llvm-project?rev=272453=rev Log: Revert "[ASTMatchers] New forEachOverriden matcher." This reverts commit r272386. It doesn't compile with MSVC and those bots have been red the entire day as a

Re: r272386 - [ASTMatchers] New forEachOverriden matcher.

This has broken Windows build bots all day. Here are some recent examples: http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/8506/steps/ninja%20check%201/logs/stdio http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12981/steps/ninja%20check%201/logs/stdio Please pay

r272454 - Revert "Strip Android version when looking up toolchain paths."

Author: chandlerc Date: Fri Jun 10 23:57:29 2016 New Revision: 272454 URL: http://llvm.org/viewvc/llvm-project?rev=272454=rev Log: Revert "Strip Android version when looking up toolchain paths." This reverts commit r272413. The tests here have been failing on several different build bots for

Re: r272413 - Strip Android version when looking up toolchain paths.

This broke several bots that have now been red most of the day. Here are recent builds that show the failure: http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4611 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/6331

r272456 - Fix this test to handle NDEBUG builds which don't have a name for the

Author: chandlerc Date: Sat Jun 11 01:32:56 2016 New Revision: 272456 URL: http://llvm.org/viewvc/llvm-project?rev=272456=rev Log: Fix this test to handle NDEBUG builds which don't have a name for the basic block. Modified: cfe/trunk/test/CodeGen/avx512vlbw-builtins.c Modified:

Re: r271761 - Revert commit r271708

On Fri, Jun 3, 2016 at 8:21 PM Taewook Oh via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: twoh > Date: Fri Jun 3 22:14:43 2016 > New Revision: 271761 > > URL: http://llvm.org/viewvc/llvm-project?rev=271761=rev > Log: > Revert commit r271708 > Please actually explain why you are

Re: r262232 - Implement new interfaces for code-formatting when applying replacements.

On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: klimek > Date: Mon Feb 29 10:27:41 2016 > New Revision: 262232 > > URL: http://llvm.org/viewvc/llvm-project?rev=262232=rev > Log: > Implement new interfaces for code-formatting when

r261054 - [cmake] Revert r260742 (and r260744) to improve order file support.

Author: chandlerc Date: Tue Feb 16 20:13:35 2016 New Revision: 261054 URL: http://llvm.org/viewvc/llvm-project?rev=261054=rev Log: [cmake] Revert r260742 (and r260744) to improve order file support. This appears to be passing '-Wl,-order_file' to Linux link commands, which then causes the linker

Re: r260742 - [CMake] Improve the clang order-file generation workflow

FYI, I had to revert this in r261054 because it caused Linux links to write the output to 'rder_file' in all cases. See that commit for some details, and I think several build bots hit this as well. Happy to chat to help figure out what to do long term. -Chandler On Fri, Feb 12, 2016 at 1:41 PM

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

chandlerc added a subscriber: chandlerc. chandlerc added a comment. If we're not going to fully implement "fdelete-null-pointer-checks" we shouldn't claim to... I'm really worried about us accepting that flag and not actually honoring it. However, I *do* think this should be guarded by a flag,

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

chandlerc added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:660-663 @@ -660,1 +659,6 @@ + OwnsVMContext(!_VMContext) { +#ifdef NDEBUG + _VMContext.setDiscardValueNames(true); +#endif +} joker.eph wrote: > chandlerc wrote: > > I'm surprised

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

chandlerc added a comment. FYI, I'd lik eto hold off on submitting here until we're on the same page with Philip on the original LLVM review (http://reviews.llvm.org/D17946), but some comments on how this is working are below... Comment at:

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D18024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263210 - Update to include the new header file providing createGVNPass.

Author: chandlerc Date: Fri Mar 11 03:02:43 2016 New Revision: 263210 URL: http://llvm.org/viewvc/llvm-project?rev=263210=rev Log: Update to include the new header file providing createGVNPass. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

chandlerc added a comment. Change these tests to use %clang_cc1 rather than add all the messy regex to handle arguments losing names? Comment at: lib/Driver/Tools.cpp:3715 @@ -3714,1 +3714,3 @@ CmdArgs.push_back("-disable-llvm-verifier"); + // Disable LLVM value names in

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

chandlerc added a comment. In http://reviews.llvm.org/D17993#371454, @hfinkel wrote: > In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > > > If we're not going to fully implement "fdelete-null-pointer-checks" we > > shouldn't claim to... I'm really worried about us accepting that

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Looks good with the two test nits below fixed. Comment at: test/CodeGen/mips-zero-sized-struct.c:8-10 @@ -7,5 +7,5 @@ -// O32: define void @fn28(%struct.T2* noalias

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with the comments from David addressed and the comment below addressed. Comment at: lib/Basic/Targets.cpp:6000-6001 @@ +5999,4 @@ + break; +default: +

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

chandlerc added a comment. I don't know anything about MIPS and this seems a highly MIPS specific change, so I can't provide any useful review here. You have someone with MIPS specific knowledge on the review though, so you seem to have the appropriate people looped in...

Re: [PATCH] D18617: Call TargetMachine::addEarlyAsPossiblePasses from BackendUtil.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Minor tweak, but with that LGTM once the LLVM side is in place. Comment at: lib/CodeGen/BackendUtil.cpp:347 @@ +346,3 @@ +

Re: [PATCH] D18648: make __builtin_isfinite more efficient (PR27145)

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, nice! http://reviews.llvm.org/D18648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18617: Call TargetMachine::addEarlyAsPossiblePasses from BackendUtil.

chandlerc added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:347 @@ +346,3 @@ +PassManagerBuilder::EP_EarlyAsPossible, +[&](const PassManagerBuilder &, legacy::PassManagerBase ) { + TM->addEarlyAsPossiblePasses(PM); Wow, C++

Re: r262817 - [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb{128|256|512}

On Mon, Mar 7, 2016 at 12:33 AM Michael Zuckerman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mzuckerm > Date: Mon Mar 7 02:29:10 2016 > New Revision: 262817 > > URL: http://llvm.org/viewvc/llvm-project?rev=262817=rev > Log: > [CLANG][AVX512][BUILTIN] Adding

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

chandlerc added a comment. In http://reviews.llvm.org/D17784#367601, @kparzysz wrote: > This seemed fine to me, but at the second thought, the lines 2610-2613 in the > original should be removed. I agree. I think using LLVM_PREFIX here in any capacity is incorrect.

r269549 - Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC""

Author: chandlerc Date: Sat May 14 00:39:45 2016 New Revision: 269549 URL: http://llvm.org/viewvc/llvm-project?rev=269549=rev Log: Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"" This reverts commit r269492 as the corresponding LLVM commit was reverted due to

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

This commit is missing a test. On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > Date: Fri Apr 15 19:11:11 2016 > New Revision: 266496 > > URL: http://llvm.org/viewvc/llvm-project?rev=266496=rev > Log: > [CUDA] Raise an error if

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

I don't really understand why having to change the test when we change the code it test changes... We have several fake install trees in the driver tests to check pretty much exactly these kinds of things? On Tue, Apr 19, 2016 at 11:31 AM Justin Lebar via cfe-commits <

Re: r266496 - [CUDA] Raise an error if the CUDA install can't be found.

Thanks! On Tue, Apr 19, 2016 at 11:58 AM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Committed a test in r266796. > > On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote: > >> I don't really understand why having to change the test when we change >

r268874 - Teach header search about GCC 4.9 header search paths in Gentoo, they

Author: chandlerc Date: Sun May 8 02:59:56 2016 New Revision: 268874 URL: http://llvm.org/viewvc/llvm-project?rev=268874=rev Log: Teach header search about GCC 4.9 header search paths in Gentoo, they now use the full GCC version in their weird suffix. Added:

r278202 - [x86] Fix a really nasty bug introduced in r276417 where alignment

Author: chandlerc Date: Wed Aug 10 02:32:47 2016 New Revision: 278202 URL: http://llvm.org/viewvc/llvm-project?rev=278202=rev Log: [x86] Fix a really nasty bug introduced in r276417 where alignment constraints were added to _mm256_broadcast_{pd,ps} intel intrinsics. The spec for these intrinics

Re: r276417 - [X86][AVX] Added support for lowering to VBROADCASTF128/VBROADCASTI128 with generic IR

On Fri, Jul 22, 2016 at 7:06 AM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Fri Jul 22 08:58:56 2016 > New Revision: 276417 > > URL: http://llvm.org/viewvc/llvm-project?rev=276417=rev > Log: > [X86][AVX] Added support for lowering to

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

On Sun, Jul 17, 2016 at 1:54 PM Arthur O'Dwyer wrote: > Given that this patch is basically Chandler's talk from CppCon 2015 ( > https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the > commit message isn't explicitly mentioning that; and surprised that >

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

chandlerc added a comment. I'd like someone more active on the Clang side to comment about this, but here is my 2 cents... It seems like it'd be nice to not populate or run or otherwise build up the legacy pass managers when using this option. I guess I would expect something to more split

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

chandlerc added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83 @@ +80,5 @@ + // + // FIXME: This is a hack to work around the fact that there's no way to do the + // equivalent of runToolOnCodeWithArgs without instantiating a full Driver. + // We

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D21810#471486, @jlebar wrote: > > But I think this is a reasonable workaround until such an API can be > > provided. > > > Should I take that as an LG, or are

Re: RFC: Default language standard mode policy

On Wed, Jun 29, 2016 at 12:47 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Jun 29, 2016 at 3:25 PM, Richard Smith > wrote: > >> Note that at this point I'd like to mainly focus on what our policy >> should be; >> > > Fair enough. I don't

r278897 - [PM] Update Clang for LLVM's r278896 which re-organized a header.

Author: chandlerc Date: Tue Aug 16 22:09:11 2016 New Revision: 278897 URL: http://llvm.org/viewvc/llvm-project?rev=278897=rev Log: [PM] Update Clang for LLVM's r278896 which re-organized a header. (sorry this didn't get landed closer in time...) Modified:

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

It's blast from the past time! On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel wrote: > Author: hfinkel > Date: Tue Sep 18 17:25:07 2012 > New Revision: 164177 > > URL: http://llvm.org/viewvc/llvm-project?rev=164177=rev > Log: > Add C/C++ header locations for the Freescale SDK. > >

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch wrote: > On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth > wrote: > > > +// The Freescale PPC SDK has the gcc libraries in > +// /usr/lib//x.y.z so have a look there as well. > +"/" +

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

I feel like this thread has two very unrelated concerns and it might be useful to separate them. 1) Should an application be changing the stack limit, or should the system be able to enforce this? Fortunately, there are two limits. One an application is allowed to change, one it isn't. It seems

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

On Wed, Sep 14, 2016 at 3:38 AM Martin Bohme via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mboehme > Date: Wed Sep 14 05:29:32 2016 > New Revision: 281453 > > URL: http://llvm.org/viewvc/llvm-project?rev=281453=rev > Log: > [clang-tidy] Add check 'misc-use-after-move' > >

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

(Somehow I missed this, sorry for silence...) On Wed, Sep 14, 2016 at 6:13 AM Martin Böhme wrote: > While I'm excited to see this go in anywhere, I have to say I'm a bit sad > it isn't going in as a warning and instead inside clang-tidy. This has been > a much requested

r279500 - Revert r279486 "Fix regression introduced by r279164"

Author: chandlerc Date: Mon Aug 22 21:00:51 2016 New Revision: 279500 URL: http://llvm.org/viewvc/llvm-project?rev=279500=rev Log: Revert r279486 "Fix regression introduced by r279164" Build bots seem unhappy and as Richard was leaving he asked me to revert this for him. Doing so. Modified:

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Reverted this per Richard's request in r279500. On Mon, Aug 22, 2016 at 3:33 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Aug 22 17:25:03 2016 > New Revision: 279486 > > URL: http://llvm.org/viewvc/llvm-project?rev=279486=rev > Log: > Fix

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580631, @mgorny wrote: > In https://reviews.llvm.org/D23754#580620, @chandlerc wrote: > > > I'm not sure it really makes sense for the Clang driver to go hunting for > > an LLVMgold.so from an unrelated build of Clang and LLVM. > > >

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580612, @mgorny wrote: > In https://reviews.llvm.org/D23754#580441, @chandlerc wrote: > > > In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > > > > > The difference is that LLVMgold.so is not used by LLVM or clang directly

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > In https://reviews.llvm.org/D23754#580268, @beanz wrote: > > > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional > > sense. It more closely aligns with the tools vended by LLVM even

[PATCH] D25604: Add support for Mageia Linux

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Please add a stub tree and tests. You can find similar tests for other Linux distros in 'tests/Driver'. https://reviews.llvm.org/D25604

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. I don't get it. There is nothing "RUNTIMES" about it. And this variable is actually used to produce real libraries: libclang, etc. It's just the LIBDIR_SUFFIX. That's it. The reason it is called CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581427, @mgorny wrote: > In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > > > I don't get it. > > > > There is nothing "RUNTIMES" about it. And this variable is actually used to > > produce real libraries: libclang,

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581436, @mgorny wrote: > This really doesn't solve the problems we have. We don't want to build and > install two almost-identical copies of compiler-rt and clang headers, when we > can just build one and make clang use it.

[PATCH] D26530: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

chandlerc updated this revision to Diff 77574. chandlerc added a comment. Update the tests accordingly. https://reviews.llvm.org/D26530 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td test/Parser/objc-property-syntax.m

[PATCH] D26530: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

chandlerc created this revision. chandlerc added a reviewer: rsmith. chandlerc added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. The latter agrees with most existing diagnostics and the C and C++ standards. https://reviews.llvm.org/D26530 Files:

r285946 - Using release to free memory is at best confusing -- one would expect

Author: chandlerc Date: Thu Nov 3 12:42:32 2016 New Revision: 285946 URL: http://llvm.org/viewvc/llvm-project?rev=285946=rev Log: Using release to free memory is at best confusing -- one would expect that its result is in fact used. Instead, use reset. This was pointed out by PVS-Studio.

r285950 - Instead of resetting the pointer, or releasing it which was the previous

Author: chandlerc Date: Thu Nov 3 13:03:14 2016 New Revision: 285950 URL: http://llvm.org/viewvc/llvm-project?rev=285950=rev Log: Instead of resetting the pointer, or releasing it which was the previous code, let's just assert that the DiagonsticEngine doesn't own the client because our

r285985 - Add some more asserts to clearly indicate that there are special cases

Author: chandlerc Date: Fri Nov 4 01:32:57 2016 New Revision: 285985 URL: http://llvm.org/viewvc/llvm-project?rev=285985=rev Log: Add some more asserts to clearly indicate that there are special cases which guarantee pointers are not null. These all seem to have useful properties and

r285983 - Delete a trivially true check for a variable 'S' being null.

Author: chandlerc Date: Fri Nov 4 01:16:09 2016 New Revision: 285983 URL: http://llvm.org/viewvc/llvm-project?rev=285983=rev Log: Delete a trivially true check for a variable 'S' being null. The exact same test guards entry into the loop in which this test occurs, and there is nothing inside

Re: r283963 - [CUDA] Make touching a kernel from a __host__ __device__ function a deferred error.

On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > > Date: Tue Oct 11 20:30:08 2016 > > New Revision: 283963 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=283963=rev > > Log: > > [CUDA] Make touching a kernel from a __host__

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Also need to pull in r291881. Sorry about that. On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: > On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth > wrote: > >> This isn't quite right, it should either be left as-is or dropped > >> completely. This

Re: r290450 - [PM] Introduce options to enable the (still experimental) new pass

(explicitly adding Richard so he sees this discussion as some of this involves a discussion between myself and him) On Tue, Jan 10, 2017 at 4:36 PM Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Chandler Carruth via cfe-commits <cfe-commits@lists.llvm

r291881 - Another fix for r291850 because there are apparently targets which add

Author: chandlerc Date: Thu Jan 12 20:47:34 2017 New Revision: 291881 URL: http://llvm.org/viewvc/llvm-project?rev=291881=rev Log: Another fix for r291850 because there are apparently targets which add "-mllvm" flags to the CC1 invocation (notably, Hexagon seems to hit this). Modified:

r291853 - Fix two test cases I missed updating in r291850. Sorry for the noise.

Author: chandlerc Date: Thu Jan 12 16:48:28 2017 New Revision: 291853 URL: http://llvm.org/viewvc/llvm-project?rev=291853=rev Log: Fix two test cases I missed updating in r291850. Sorry for the noise. Modified: cfe/trunk/test/CodeGen/always_inline.c

r291850 - Address review comments on r290392:

Author: chandlerc Date: Thu Jan 12 16:40:13 2017 New Revision: 291850 URL: http://llvm.org/viewvc/llvm-project?rev=291850=rev Log: Address review comments on r290392: - Don't break using '-mllvm -disable-llvm-optzns' (yet). - Don't add support for '-mllvm -disable-llvm-passes'. This is important

r291851 - Replace some stray uses of the old spelling of the flag with the new

Author: chandlerc Date: Thu Jan 12 16:43:37 2017 New Revision: 291851 URL: http://llvm.org/viewvc/llvm-project?rev=291851=rev Log: Replace some stray uses of the old spelling of the flag with the new spelling. NFC. Modified: cfe/trunk/test/CodeGen/ms-declspecs.c

r291036 - [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an

Author: chandlerc Date: Wed Jan 4 17:57:25 2017 New Revision: 291036 URL: http://llvm.org/viewvc/llvm-project?rev=291036=rev Log: [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an ODR use. These traits don't have a definition as they're intended to be used strictly at

Re: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

On Mon, Dec 26, 2016 at 4:34 AM Marina Yatsina via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: myatsina > Date: Mon Dec 26 06:23:42 2016 > New Revision: 290539 > > URL: http://llvm.org/viewvc/llvm-project?rev=290539=rev > Log: > [inline-asm]No error for conflict between

r290159 - Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

Author: chandlerc Date: Mon Dec 19 20:43:58 2016 New Revision: 290159 URL: http://llvm.org/viewvc/llvm-project?rev=290159=rev Log: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'. The latter agrees with most existing diagnostics and the C and C++ standards.

r290169 - Revert r290149: Add the alloc_size attribute to clang.

Author: chandlerc Date: Tue Dec 20 02:28:19 2016 New Revision: 290169 URL: http://llvm.org/viewvc/llvm-project?rev=290169=rev Log: Revert r290149: Add the alloc_size attribute to clang. This commit fails MSan when running test/CodeGen/object-size.c in a confusing way. After some discussion with

Re: r290399 - When merging two deduced non-type template arguments for the same parameter,

On Thu, Dec 22, 2016 at 5:41 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > == > --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original) > +++

r290417 - Add an assert to catch improperly constructed %diff sequences in

Author: chandlerc Date: Thu Dec 22 23:19:47 2016 New Revision: 290417 URL: http://llvm.org/viewvc/llvm-project?rev=290417=rev Log: Add an assert to catch improperly constructed %diff sequences in diagnostics and fix one such diagnostic. Sadly, this assert doesn't catch this bug because we have

Re: r290399 - When merging two deduced non-type template arguments for the same parameter,

On Fri, Dec 23, 2016 at 12:32 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 22 Dec 2016 9:32 pm, "Chandler Carruth via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > On Thu, Dec 22, 2016 at 5:41 PM Richard Smith via cfe-comm

r290450 - [PM] Introduce options to enable the (still experimental) new pass

Author: chandlerc Date: Fri Dec 23 14:44:01 2016 New Revision: 290450 URL: http://llvm.org/viewvc/llvm-project?rev=290450=rev Log: [PM] Introduce options to enable the (still experimental) new pass manager, and a code path to use it. The option is actually a top-level option but does contain

r290451 - [PM] Fix up from r290449 to start requiring the x86 target to be

Author: chandlerc Date: Fri Dec 23 15:19:16 2016 New Revision: 290451 URL: http://llvm.org/viewvc/llvm-project?rev=290451=rev Log: [PM] Fix up from r290449 to start requiring the x86 target to be available. It doesn't seem terribly important to test this with a specific target triple but without

r290398 - Cleanup the handling of noinline function attributes, -fno-inline,

Author: chandlerc Date: Thu Dec 22 19:24:49 2016 New Revision: 290398 URL: http://llvm.org/viewvc/llvm-project?rev=290398=rev Log: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone. These were really, really tangled together: - We used the

r290558 - [PH] Teach the new PM code path to support -disable-llvm-passes.

Author: chandlerc Date: Mon Dec 26 18:13:09 2016 New Revision: 290558 URL: http://llvm.org/viewvc/llvm-project?rev=290558=rev Log: [PH] Teach the new PM code path to support -disable-llvm-passes. This is kind of funny because I specifically did work to make this easy and then it didn't actually

r290560 - [PM] The new pass manager requires a registered target for these, and

Author: chandlerc Date: Mon Dec 26 18:31:34 2016 New Revision: 290560 URL: http://llvm.org/viewvc/llvm-project?rev=290560=rev Log: [PM] The new pass manager requires a registered target for these, and given that they hard code specific triples that seems reasonable so add the REQUIRES. Modified:

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

I suspect that this commit is responsible for a regression parsing widely used open source packages like Eigen. See the code in Eigen here:

r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Author: chandlerc Date: Thu Dec 22 18:23:01 2016 New Revision: 290392 URL: http://llvm.org/viewvc/llvm-project?rev=290392=rev Log: Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'. Much to my surprise, '-disable-llvm-optzns' which I thought was the magical flag I wanted to get at

  1   2   >