Author: dsanders
Date: Tue Oct 27 13:04:42 2015
New Revision: 251430
URL: http://llvm.org/viewvc/llvm-project?rev=251430=rev
Log:
[mips] Separated mips specific -Wa options, so that they are not checked on
other platforms.
Summary: This is a follow on to post review comments on revision
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits
Comment at: include/clang/Basic/Attr.td:841-842
@@ +840,4 @@
+def MipsInterrupt : InheritableAttr, TargetSpecificAttr {
+ // NOTE: if you add any
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
It's not for this patch but I think we need a general solution to the -Wa,...
options. It seems wrong to implement each assembler option twice (both with and
without the '-Wa,').
Author: dsanders
Date: Tue Sep 15 11:17:27 2015
New Revision: 247702
URL: http://llvm.org/viewvc/llvm-project?rev=247702=rev
Log:
Revert r247692: Replace Triple with a new TargetTuple in MCTargetDesc/* and
related. NFC.
Eric has replied and has demanded the patch be reverted.
Modified:
Author: dsanders
Date: Tue Sep 15 09:08:28 2015
New Revision: 247692
URL: http://llvm.org/viewvc/llvm-project?rev=247692=rev
Log:
Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and
related. NFC.
Summary:
This is the first patch in the series to migrate Triple's
Author: dsanders
Date: Tue Sep 15 08:17:40 2015
New Revision: 247683
URL: http://llvm.org/viewvc/llvm-project?rev=247683=rev
Log:
Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.
Summary:
This is the first patch in the series to migrate Triple's (which are ambiguous)
to
hat they are not checked on other platforms.
>
> On Thu, Sep 24, 2015 at 10:22:29AM +, Daniel Sanders via cfe-commits
> wrote:
> > I'm thinking something like:
>
> I think we really want to have an outer case, platform specific -Wa
> options are quite comm
Author: dsanders
Date: Thu Sep 24 05:22:17 2015
New Revision: 248481
URL: http://llvm.org/viewvc/llvm-project?rev=248481=rev
Log:
[mips] Relax -mnan=2008 acceptance to permit MIPS32R2 and MIPS64R2.
Summary:
Strictly speaking, the MIPS*R2 ISA's should not permit -mnan=2008 since this
feature was
dsanders added subscribers: rengolin, joerg.
dsanders added a comment.
+Renato and Joerg
I was going to say I think it's ok and the optimizer should be smart enough to
factor out the common IsMips check but I've just realized there may be a better
way. The current code is using an else after
Author: dsanders
Date: Tue Sep 22 08:52:32 2015
New Revision: 248276
URL: http://llvm.org/viewvc/llvm-project?rev=248276=rev
Log:
[mips] Added support for using the command line options -Wa,-msoft-float and
-Wa,-mhard-float.
Patch by Scott Egerton.
Reviewers: vkalintiris, dsanders
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
Strictly speaking, the MIPS*R2 ISA's should not permit -mnan=2008 since this
feature was added in MIPS*R3. However, other toolchains permit this and we
should do the same.
Author: dsanders
Date: Mon Oct 5 07:24:30 2015
New Revision: 249306
URL: http://llvm.org/viewvc/llvm-project?rev=249306=rev
Log:
[mips][p5600] Add -mcpu=p5600 option.
Summary:
Reviewers: vkalintiris, atanasyan
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D12234
Author: dsanders
Date: Fri Nov 27 12:00:36 2015
New Revision: 254204
URL: http://llvm.org/viewvc/llvm-project?rev=254204=rev
Log:
Revert r254203: [mips] Interrupt attribute support.
I forgot to credit the author.
Removed:
cfe/trunk/test/CodeGen/mips-interrupt-attr.c
Author: dsanders
Date: Fri Nov 27 13:49:24 2015
New Revision: 254208
URL: http://llvm.org/viewvc/llvm-project?rev=254208=rev
Log:
Fixed default label in fully covered switch warning that was introduced in
r254203.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified:
Author: dsanders
Date: Fri Nov 27 12:03:44 2015
New Revision: 254205
URL: http://llvm.org/viewvc/llvm-project?rev=254205=rev
Log:
[mips] Interrupt attribute support.
Summary: This patch adds support for the interrupt attribute for mips32r2+.
Patch by Simon Dardis.
Reviewers: dsanders,
Author: dsanders
Date: Fri Nov 27 11:39:20 2015
New Revision: 254203
URL: http://llvm.org/viewvc/llvm-project?rev=254203=rev
Log:
[mips] Interrupt attribute support.
Summary: This patch adds support for the interrupt attribute for mips32r2+.
Reviewers: dsanders, aaron.ballman
Subscribers:
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
With a couple small changes it will LGTM
Comment at: lib/Driver/Tools.cpp:2567-2568
@@ -2547,1 +2566,4 @@
}
+ StringRef MipsFeatureStringRef = MipsTargetFeature;
+
dsanders requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Driver/Tools.cpp:2501-2524
@@ -2500,2 +2500,26 @@
}
+
+const char *Feature = llvm::StringSwitch(Value)
+ .Case("-mips1",
Author: dsanders
Date: Tue Dec 22 06:59:30 2015
New Revision: 256240
URL: http://llvm.org/viewvc/llvm-project?rev=256240=rev
Log:
[mips] Add _GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
This fixes the 'pure virtual function called' failure with ThreadPool in a
clang-built clang. This fixes the
Author: dsanders
Date: Mon Jun 6 04:47:32 2016
New Revision: 271877
URL: http://llvm.org/viewvc/llvm-project?rev=271877=rev
Log:
[mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.
Summary:
Reviewers: atanasyan
Subscribers: cfe-commits, sdardis
Differential Revision:
dsanders closed this revision.
dsanders added a comment.
This has already been committed. I'm not sure why it didn't auto-close.
http://reviews.llvm.org/D18761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dsanders created this revision.
dsanders added subscribers: jfb, dschuff, cfe-commits.
dsanders added a dependency: D21070: Pass the ABI in the triple when
appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.
Herald added subscribers: sdardis, srhines, danalbert, tberghammer.
dsanders created this revision.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D21069: [mips] Require that ABI's are passed in
the triple within LLVM..
Herald added subscribers: srhines, danalbert, tberghammer.
'clang -cc1' and 'clang -cc1as' will mutate the triple to
dsanders abandoned this revision.
dsanders added a comment.
Part of this patch is missing. I'll repost it soon.
http://reviews.llvm.org/D21071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dsanders created this revision.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D21070: Pass the ABI in the triple when
appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.
Herald added subscribers: dschuff, jfb.
This stops cases such as '-target
Author: dsanders
Date: Mon Jun 6 07:02:21 2016
New Revision: 271884
URL: http://llvm.org/viewvc/llvm-project?rev=271884=rev
Log:
[mips] The default ABI depends on the CPU not the Arch on MTI and IMG vendor
triples.
Summary:
32-bit CPU's default to O32. 64-bit CPU's default to N64. The default
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
Herald added a subscriber: sdardis.
The validity of ABI/CPU pairs is no longer checked on the fly but is
instead checked after initialization. As a result, invalid CPU/ABI pairs
can be
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
Herald added a subscriber: sdardis.
32-bit CPU's default to O32. 64-bit CPU's default to N64. The default CPU
(mips32r2/mips64r2) still depends on the arch so there's no functional
Author: dsanders
Date: Fri Jun 3 05:11:01 2016
New Revision: 271647
URL: http://llvm.org/viewvc/llvm-project?rev=271647=rev
Log:
[mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC.
Summary:
Reviewers: atanasyan
Subscribers: atanasyan, cfe-commits
Differential Revision:
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
setABI() is still tied to the Arch component of the Triple to preserve existing
behaviour.
http://reviews.llvm.org/D20961
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
dsanders added inline comments.
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple::mips ||
+ getTriple().getArch() == llvm::Triple::mipsel)
+
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
dsanders added a dependency: D20678: [mips] Fold MipsTargetInfoBase subclasses
into MipsTargetInfoBase and rename to MipsTargetInfo. NFC.
There are no clang or llvm* tests for EABI and no EABI buildbots.
*There
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
dsanders added a dependency: D20679: [mips] Kill 'support' for untested EABI..
Depends on D20679
http://reviews.llvm.org/D20680
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
Author: dsanders
Date: Tue Jun 14 03:58:50 2016
New Revision: 272645
URL: http://llvm.org/viewvc/llvm-project?rev=272645=rev
Log:
[mips] Defer validity check for CPU/ABI pairs and improve error message for
invalid cases.
Summary:
The validity of ABI/CPU pairs is no longer checked on the fly but
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D20961: [mips] Replace almost all Arch checks in
MipsTargetInfo with ABI checks. NFC..
Herald added a subscriber: sdardis.
Depends on D20961
Thanks. r270962 seems to have fixed the buildbot.
> -Original Message-
> From: Daniel Sanders
> Sent: 26 May 2016 16:24
> To: 'Alexey Bataev'; cfe-commits@lists.llvm.org
> Subject: RE: r270838 - [OPENMP] Add option '-fopenmp-version=[31|40|45]'
> allowing choosing
>
> Hi,
>
> I think
Hi,
I think this commit may have caused the failure in
http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/13743. Could you
check? Buildbot will have supressed the usual email because the previous build
failed (for a different reason).
> -Original Message-
> From: cfe-commits
Author: dsanders
Date: Fri May 27 09:30:23 2016
New Revision: 270998
URL: http://llvm.org/viewvc/llvm-project?rev=270998=rev
Log:
[mips] Kill 'support' for untested EABI.
Summary:
There are no llvm backend tests* for EABI and no EABI buildbots. There were only
three clang tests, all of which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270998: [mips] Kill 'support' for untested EABI. (authored
by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D20679?vs=58772=58782#toc
Repository:
rL LLVM
dsanders added a comment.
Just to double-check: Do you still agree we should kill this now that the
number of tests covering EABI-specific behaviour is non-zero?
I think we should on the basis that we still have no backend tests and no
buildbots. The only tests we have check that the driver
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270984: [mips] Fold MipsTargetInfoBase subclasses into
MipsTargetInfoBase and rename… (authored by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D20678?vs=58604=58770#toc
Repository:
Author: dsanders
Date: Fri May 27 06:51:02 2016
New Revision: 270984
URL: http://llvm.org/viewvc/llvm-project?rev=270984=rev
Log:
[mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to
MipsTargetInfo. NFC
Summary:
This unifies mips/mipsel and mips64/mips64el into a
dsanders updated this revision to Diff 58772.
dsanders added a comment.
Herald added subscribers: sdardis, emaste.
Removed the 'eabi' from Tools.cpp this revealed three driver tests for passing
-mabi to the assembler but the ABI itself is still completely untested.
dsanders created this revision.
dsanders added subscribers: cfe-commits, atanasyan.
Herald added subscribers: dschuff, jfb.
This unifies mips/mipsel and mips64/mips64el into a single class so that we can
later support O32 on mips64/mips64el and N32/N64 on mips/mipsel (when an
appropriate CPU
Author: dsanders
Date: Thu Jun 23 04:29:38 2016
New Revision: 273552
URL: http://llvm.org/viewvc/llvm-project?rev=273552=rev
Log:
Attempt to fix MIPS buildbots after r273425.
MIPS has a 'signext' attribute that was causing the check to fail.
Modified:
dsanders added a comment.
This change agrees with what I think the calling convention is and the
documentation. However, I've hit quite a few discrepancies between the
documented calling convention and the de-facto one implemented by gcc so I'm
wary of going by that alone.
Have you tried
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
In that case the MIPS side of this LGTM. Someone more familiar with ARM should
approve it for ARM.
http://reviews.llvm.org/D21611
___
Hi Chris,
This doesn't seem to work when building clang separately from llvm. LLVMLinux
fails to build clang with:
CMake Error at CMakeLists.txt:104 (include):
include could not find load file:
VersionFromVCS
CMake Error at CMakeLists.txt:222
Thanks, that did the trick. I've removed the workaround from LLVMLinux.
> -Original Message-
> From: cbiene...@apple.com [mailto:cbiene...@apple.com] On Behalf Of
> Chris Bieneman
> Sent: 15 January 2016 17:55
> To: Daniel Sanders
> Cc: cfe-commits@lists.llvm.org
> Subject: Re: r257827 -
Did you get an answer to this question? I think it's just that the FreeBSD
class hasn't refactored to that style yet.
That switch statement is getting quite large so it would be a nice cleanup to
switch to that style.
> -Original Message-
> From: cfe-commits
-G isn't handled there at the moment but ClangAs::AddMIPSTargetArgs() and
Clang::AddMIPSTargetArgs() would be the right place to add it in the Linux
toolchain when we add it.
The cleanup I'm referring to is that someone hoisted the bulk of the code out
of the big switch-statement in
dsanders accepted this revision.
dsanders added a comment.
LGTM
http://reviews.llvm.org/D16613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
In my latests rc2+patches build I've also found that we need to rename
HAVE_CXX_ATOMICS_WITH_LIB to something like LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB.
It's currently re-using the result of LLVM's check which doesn't include 64-bit
atomics.
From:
module to figure out whether
we need to link with libatomic."
- [libcxx] r260524 - Fix r260515 - Correct typos in CMake changes
- [libcxx] r260531 - Rename CheckLibcxxAtomic.cmake variable result names so
they don't clash with LLVM
@Marshall Any objections?
On Thu, Feb 11, 2016 at 2:18 A
dsanders added inline comments.
Comment at: include/regex:980
@@ +979,3 @@
+#if defined(__GLIBC__)
+static const char_class_type __regex_word =
static_cast(_ISbit(15));
+#else
The static_cast is necessary to silence a false-positive warning on
dsanders added a comment.
I haven't fully proven this yet (because I haven't found the table), but I
think that C and C++ are sharing the same table and we're colliding with a bit
that only makes sense to C. This would explain why your tests don't fail but
regex_word still collides with
dsanders created this revision.
dsanders added reviewers: mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
On glibc, the bits used for the various character classes is endian dependant
(see _ISbit() in ctypes.h) but __regex_word does not account for this and uses
a spare bit that
dsanders added a comment.
The table is apparently inside locale-archive and it looks like C and C++ both
share this table. At this point I'm satisfied that the table also contains
information that C++ isn't interested in and it's this data that regex_word
collides with.
Are you happy to lift
Author: dsanders
Date: Thu Jan 28 10:51:36 2016
New Revision: 259058
URL: http://llvm.org/viewvc/llvm-project?rev=259058=rev
Log:
Merging r258920:
r258920 | dsanders | 2016-01-27 10:45:07 + (Wed, 27 Jan 2016) | 11 lines
Author: dsanders
Date: Thu Jan 28 15:03:16 2016
New Revision: 259092
URL: http://llvm.org/viewvc/llvm-project?rev=259092=rev
Log:
Merging r259046:
r259046 | dsanders | 2016-01-28 13:49:33 + (Thu, 28 Jan 2016) | 18 lines
n the
> review.
>
> From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Daniel
> Sanders via cfe-commits [cfe-commits@lists.llvm.org]
> Sent: 28 January 2016 13:49
> To: cfe-commits@lists.llvm.org
> Subject: [libcxx] r259046 - [libcxx] Wor
dsanders added a comment.
FWIW, the changes in the last revision look minor to me. I doubt it affects the
LGTM
> Do we have any test cases for arbitrary sized trivally copyable structures?
> That might also be needed.
The failures in 3.8.0rc1 (and presumably still occur in the 3.8.0rc2 that
Author: dsanders
Date: Thu Jan 28 07:49:33 2016
New Revision: 259046
URL: http://llvm.org/viewvc/llvm-project?rev=259046=rev
Log:
[libcxx] Work around for clang calling GAS after having already failed.
Summary:
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
Hi Hans,
Is it ok to merge this into 3.8? Eric Fiselier has already approved on the
review.
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Daniel
Sanders via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 28 January 2016 13:49
dsanders updated this revision to Diff 45531.
dsanders added a comment.
Added one more. It was also guarded by a check for ru_RU.UTF-8 so it was missed
on the first sweep.
http://reviews.llvm.org/D16406
Files:
test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp
dsanders added a comment.
Thanks. I've added one more which came up after enabling all the missing
locales except for en_US.UTF-8.
I'll commit this and find the other 8 with grep afterwards.
http://reviews.llvm.org/D16406
___
cfe-commits mailing
dsanders created this revision.
dsanders added reviewers: mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
http://reviews.llvm.org/D16406
Files:
test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258403: [libcxx] Add appropriate 'REQUIRE' directives to
tests that require en_US.UTF-8. (authored by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D16406?vs=45531=45533#toc
Repository:
Author: dsanders
Date: Thu Jan 21 09:35:15 2016
New Revision: 258403
URL: http://llvm.org/viewvc/llvm-project?rev=258403=rev
Log:
[libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.
Reviewers: mclow.lists, hans
Subscribers: bcraig, cfe-commits
Differential
dsanders added a comment.
Hi,
I'd like to merge this to the 3.8 branch once it has been accepted.
http://reviews.llvm.org/D16406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dsanders created this revision.
dsanders added reviewers: bcraig, mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
These are the tests that didn't fail in the release candidate because they were
covered by another 'REQUIRES' directive.
http://reviews.llvm.org/D16408
Files:
his OK for 3.8?
>
> Daniel, I assume we want reviews.llvm.org/D16408 too when that lands,
> right?
>
> Thanks,
> Hans
>
> On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
> <cfe-commits@lists.llvm.org> wrote:
> > Author: dsanders
> > Date: Thu Jan
sume we want
reviews.llvm.org/D16408<http://reviews.llvm.org/D16408> too when that lands,
right?
Thanks,
Hans
On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
<cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: dsanders
> Date: Thu
dsanders added a comment.
There's only 7 instead of the 8 we were expecting because one match turned out
to be the python script that checks for the availability of the locale.
http://reviews.llvm.org/D16408
___
cfe-commits mailing list
lt;http://reviews.llvm.org/D16408> too when that lands,
right?
Thanks,
Hans
On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits
<cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: dsanders
> Date: Thu Jan 21 09:35:15 2016
> New Revision:
I'm not sure why my reply-all dropped Hans from the recipients. Re-added him.
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Daniel Sanders via cfe-commits
Sent: 21 January 2016 17:31
To: Marshall Clow
Cc: cfe-commits
Subject: RE: [libcxx] r258403 - [libcxx] Add
dsanders added a comment.
Thanks.
> May want to wait on mclow though considering the trouble I helped cause with
> the last one of these.
Sure. That wasn't your fault though, it was mine. I should have asked for
clarification first.
http://reviews.llvm.org/D16408
dsanders created this revision.
dsanders added reviewers: EricWF, mclow.lists, hans.
dsanders added a subscriber: cfe-commits.
This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8
release. The clang bug is currently being investigated. It seems that clang
does not stop
Author: dsanders
Date: Wed Jan 27 04:45:07 2016
New Revision: 258920
URL: http://llvm.org/viewvc/llvm-project?rev=258920=rev
Log:
[libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.
Summary:
These are the tests that didn't fail in the release candidate because they were
dsanders added a comment.
Thanks
> @dsanders: What platform are you on that doesn't have en_US.UTF-8? If your
> serious about testing libc++ you should install the locale. (but I understand
> that's not always possible).
It's Debian Jessie but it was configured for the Europe/London region
dsanders added a comment.
Sorry for the early ping but I need to fix this for rc3 (which Hans is hoping
to tag mid-week) and I'm stuck as long as the requirement that the C++ tests in
r260527 fail without my patch is in place.
I'm happy to make this '#ifdef __mips__' if that helps.
omething like
>>>> LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB.
>>> Fixed in r260531.
>>>
>>> I think we will eventually want to merge the following commits, assuming
>>> they don't regress the build, especially with the -gcc-toolchain option.
>>>
>>
Thanks. I'll commit using a MIPS ifdef in the morning and merge once it's
through the buildbots.
From: Marshall Clow [mclow.li...@gmail.com]
Sent: 16 February 2016 22:37
To: Daniel Sanders; h...@chromium.org; mclow.li...@gmail.com
Cc:
Author: dsanders
Date: Wed Feb 17 07:16:31 2016
New Revision: 261088
URL: http://llvm.org/viewvc/llvm-project?rev=261088=rev
Log:
[libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc
systems
Summary:
On glibc, the bits used for the various character classes is endian
Author: dsanders
Date: Wed Feb 17 09:02:33 2016
New Revision: 261097
URL: http://llvm.org/viewvc/llvm-project?rev=261097=rev
Log:
Merging r261088:
r261088 | dsanders | 2016-02-17 13:16:31 + (Wed, 17 Feb 2016) | 21 lines
dsanders added a comment.
Can you explain what the problem was and why this change is needed?
I'm guessing it's something to do with the 'Features[CPU] = true' line.
Repository:
rL LLVM
http://reviews.llvm.org/D16139
___
cfe-commits mailing
dsanders added a comment.
In http://reviews.llvm.org/D17132#349993, @mclow.lists wrote:
> In r260527, I added some tests to catch this if it happens again.
>
> If those tests fail w/o this patch and succeed with, then I'm happy with
> applying it.
The tests in r260527, don't fail without this
Author: dsanders
Date: Tue Mar 1 15:57:22 2016
New Revision: 262409
URL: http://llvm.org/viewvc/llvm-project?rev=262409=rev
Log:
Explicitly select IAS on one more RUN line in new embed-bitcode.c test.
This should fix clang-cmake-mips builder since MIPS does not have IAS enabled
by default
No problem.
It seems I missed one of the relevant RUN lines on the first attempt. I've
fixed that in r262409.
From: steve...@apple.com [steve...@apple.com]
Sent: 01 March 2016 17:26
To: Daniel Sanders
Cc: cfe-commits@lists.llvm.org
Subject: Re: r262282 -
> > From: Eric Christopher [echri...@gmail.com]
> > Sent: 09 March 2016 06:50
> > To: reviews+d16139+public+275805419034a...@reviews.llvm.org; Bhushan
> > Attarde; Vasileios Kalintiris; Daniel Sanders
> > Cc: Sagar Thakur; Nitesh Jain; Mohit Bhakkad; Jaydeep Patil;
> > cfe-commits@lists.llvm.org
dsanders added a comment.
Thanks for working on this.
Comment at: llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2715-2718
@@ -2714,3 +2714,6 @@
- unsigned TrgReg;
+ // TrgReg should never normally be assigned NUM_TARGET_REGS.
+ // If you end up with NUM_TARGET_REGS, you
dsanders added subscribers: eugenis, ygorshenin.
dsanders added a comment.
I think it refers to MCTargetOptions::SanitizeAddress but I don't know where
we'd get that information from. Unfortunately, it seems that the original
author (@ygorshenin) might not be on the list anymore (phabricator
dsanders added a comment.
> > > b) CPUs are not subtarget features (or they shouldn't be), they're CPUs
> > > that contain features. They may be generic names for ISAs as well, but
> > > probably best to keep them separate.
> >
> > I agree, we have two separate concepts that happen to use
dsanders accepted this revision.
dsanders added a comment.
Thanks. LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D16139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dsanders added a comment.
In http://reviews.llvm.org/D16139#368217, @echristo wrote:
> This seems wrong. You should fix setCPU instead or set a default CPU.
We already set a default CPU in the constructor (e.g.
Mips32TargetInfoBase::Mips32TargetInfoBase() provides "mips32r2"). It's the CPU
Hi,
I've made a small change to the test case in r262350 to fix the
clang-cmake-mips builder. MIPS doesn't
enable the integrated assembler by default yet so it was failing to find the
-emit-obj option. I've fixed this by adding -fintegrated-as.
From:
Author: dsanders
Date: Tue Mar 1 11:15:11 2016
New Revision: 262350
URL: http://llvm.org/viewvc/llvm-project?rev=262350=rev
Log:
Explicitly select IAS in new embed-bitcode.c test.
This should fix clang-cmake-mips builder since MIPS does not have IAS enabled
by default (yet).
Modified:
dsanders added a subscriber: dsanders.
Comment at: test/Preprocessor/init.c:3295
@@ +3294,3 @@
+// MIPSN32BE: #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1
+// MIPSN32BE: #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1
+// MIPSN32BE-NOT: __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
Sorry for missing this when it was first posted. I've also been away for
roughly half of the two weeks since Petar added me to the review.
http://reviews.llvm.org/D17378
1 - 100 of 120 matches
Mail list logo
