r250477 - Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03.

Author: ericwf Date: Thu Oct 15 19:31:36 2015 New Revision: 250477 URL: http://llvm.org/viewvc/llvm-project?rev=250477=rev Log: Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03. Summary: The title says it all. Reviewers: rsmith Subscribers: cfe-commits Differential

[PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Currently we use '-nodefaultlibs' when building and running the libc++ tests. However we should prefer using '-stdlib=libc++'. This patch automatically detects when the

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

EricWF added a subscriber: EricWF. EricWF added a comment. Cool! I imagine that a lot of parts of libc++ could benefit from this. Having something like this that slices parameter packs would probably help libc++ compile times for tuple. Is that something your considering as well?

[libcxx] r250472 - Re-enable linker scripts after fixing bad CMake

Author: ericwf Date: Thu Oct 15 18:04:54 2015 New Revision: 250472 URL: http://llvm.org/viewvc/llvm-project?rev=250472=rev Log: Re-enable linker scripts after fixing bad CMake Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

> >> On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov > >> <eugeni.stepa...@gmail.com> wrote: > >>> > >>> Guess what this does to the -Wno-pedantic flag added by MSan? :) > >>> > >>> On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: ericwf > > Date: Tue Oct 13 18:56:33 2015 > > New Revision: 250256 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=250256=rev > > Log: > > Wo

[libcxx] r250452 - Fix handling of -Wno-pedantic

Author: ericwf Date: Thu Oct 15 15:27:15 2015 New Revision: 250452 URL: http://llvm.org/viewvc/llvm-project?rev=250452=rev Log: Fix handling of -Wno-pedantic Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[PATCH] D13790: Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03.

EricWF created this revision. EricWF added a reviewer: rsmith. EricWF added a subscriber: cfe-commits. The title says it all. http://reviews.llvm.org/D13790 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td Index:

[libcxx] r250469 - [libcxx] Make libc++.so a linker script by default on most platforms.

Author: ericwf Date: Thu Oct 15 17:41:51 2015 New Revision: 250469 URL: http://llvm.org/viewvc/llvm-project?rev=250469=rev Log: [libcxx] Make libc++.so a linker script by default on most platforms. Summary: This patch turns on `LIBCXX_ENABLE_ABI_LINKER_SCRIPT` by default whenever

[libcxx] r250471 - Quickly fix bad commit

Author: ericwf Date: Thu Oct 15 17:51:50 2015 New Revision: 250471 URL: http://llvm.org/viewvc/llvm-project?rev=250471=rev Log: Quickly fix bad commit Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Thanks for the update, I think this should be good to go. I'll give it a final once over tonight. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) ||

[libcxx] r250361 - Add links to libc++ code coverage and builders

Author: ericwf Date: Wed Oct 14 22:27:02 2015 New Revision: 250361 URL: http://llvm.org/viewvc/llvm-project?rev=250361=rev Log: Add links to libc++ code coverage and builders Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL:

Re: [PATCH] D12747: Implement [depr.c.headers]

Patch #10 LGTM. On Thu, Oct 8, 2015 at 4:28 PM, Richard Smith wrote: > On Thu, Oct 8, 2015 at 11:50 AM, Marshall Clow > wrote: >> >> On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith >> wrote: >>> >>> . This one is tricky: >>>

Re: [PATCH] D12747: Implement [depr.c.headers]

Patch #14 LGTM modulo pragmas. On Thu, Oct 8, 2015 at 7:39 PM, Eric Fiselier wrote: > Patch #13 LGTM after revision. > > a system header pragma needs to be added to the __need_wint_t path of wchar.h. > The existing pragma also needs fixing as previously discussed. > > On Thu, Oct

Re: [PATCH] D12747: Implement [depr.c.headers]

Patch #11 LGTM. Any reason you removed the "#pragma diagnostic ignored "-Wnonnull"" in test/std/depr/depr.c.headers/stdlib_h.pass.cpp? I would like to leave it in so this test doesn't fail with older clang versions. /Eric On Thu, Oct 8, 2015 at 6:47 PM, Eric Fiselier wrote: >

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM but this is still blocked by http://reviews.llvm.org/D13407. Ill let you know once that has landed. Comment at: include/__config:251 @@ +250,3 @@ +

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

EricWF added a comment. Whats preventing this from landing? @joerg @danalbert Do we want to use "posix_memalign" on Android or not? http://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r250003 - [Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you don't have the command line tools package installed.

Do we need to do with while building libc++ as well? Also please reuse lit.util.capture or lit.util.executeCommand instead of subprocess. /Eric On Sun, Oct 11, 2015 at 6:49 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Sun Oct 11 19:49:56

[PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. On OS X libc++ needs to reexport libc++abi's symbols in order for them to be provided. We explicitly list the symbols to reexport it libcxx/lib/libc++abi2.exp. This patch adds the symbols

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: [PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

EricWF updated this revision to Diff 36540. EricWF added a comment. I moved the symbols into `lib/libc++abi2.exp` since we didn't anticipate the need to exclude them. http://reviews.llvm.org/D13445 Files: lib/CMakeLists.txt lib/libc++abi2.exp Index: lib/libc++abi2.exp

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: [PATCH] D12747: Implement [depr.c.headers]

LGTM. On Tue, Oct 6, 2015 at 3:58 PM, Richard Smith wrote: > On Mon, Oct 5, 2015 at 7:10 PM, Eric Fiselier wrote: >> >> EricWF added a comment. >> >> I think thing change will help us close a number out outstanding bugs. I >> don't have any fundamental

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added a comment. Cool. I've reached out to some platform maintainers to make sure they don't see any problems. I'll commit this once I hear back. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12644: Using -isysroot on Apple platform

EricWF added a comment. You need to use the CMake option `CMAKE_OSX_SYSROOT` to manage the system root because `lib/CMakeLists.txt` uses "CMAKE_OSX_SYSROOT" to find the correct libc++abi.dylib. Have you tried that? It is unfortunate that Linux and OS X use different options for the same thing

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF updated this revision to Diff 36682. EricWF added a comment. Use `type` instead of `cat` on windows as suggested by @rnk. @eugenis does this address your concern? http://reviews.llvm.org/D13407 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake

r249787 - Skip NonNull sema checks in unevaluated contexts.

Author: ericwf Date: Thu Oct 8 19:17:57 2015 New Revision: 249787 URL: http://llvm.org/viewvc/llvm-project?rev=249787=rev Log: Skip NonNull sema checks in unevaluated contexts. Summary: Currently when a function annotated with __attribute__((nonnull)) is called in an unevaluated context with a

Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

EricWF updated the summary for this revision. EricWF updated this revision to Diff 36910. http://reviews.llvm.org/D13408 Files: lib/Sema/SemaChecking.cpp test/Sema/non-null-warning.c Index: test/Sema/non-null-warning.c === ---

Re: [PATCH] D12747: Implement [depr.c.headers]

Patch #13 LGTM after revision. a system header pragma needs to be added to the __need_wint_t path of wchar.h. The existing pragma also needs fixing as previously discussed. On Thu, Oct 8, 2015 at 7:25 PM, Eric Fiselier wrote: > Patch #12 needs revision. A bunch of function

Re: [libc++] PR25118: move include_next after #pragma system_header

The patch LGTM. However I would rather see the pragma in wrap itself in the `#if !defined(_LIBPP_HAS_NO_SYSTEM_HEADER_PRAGMA)`. I agree that we probably shouldn't include "<__config>". However people are still free to add the definition to the command line (line libc++ does when building and

[libcxx] r249936 - Get some of wchar_h.pass.cpp working on apple.

Author: ericwf Date: Fri Oct 9 21:54:41 2015 New Revision: 249936 URL: http://llvm.org/viewvc/llvm-project?rev=249936=rev Log: Get some of wchar_h.pass.cpp working on apple. Modified: libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp Modified:

Re: [PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

EricWF added a comment. Howard gave this approach and patch the thumbs up privately. @mclow.lists What's holding you back from approving this? http://reviews.llvm.org/D12502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF marked an inline comment as done. Comment at: include/CMakeLists.txt:38 @@ +37,3 @@ + COMMAND ${UNIX_CAT} ${LIBCXX_SOURCE_DIR}/include/__config >> ${LIBCXX_BINARY_DIR}/__generated_config + DEPENDS ${LIBCXX_SOURCE_DIR}/include/__config +)

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF marked an inline comment as done. EricWF added a comment. @eugenis I'll commit this tuesday morning If I don't hear anything over the weekend (Monday is a holiday for me). If you rebase the ABI patch to work with this I'll make sure to review it ASAP. Comment at:

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF updated this revision to Diff 37013. EricWF added a comment. Make the generated config dependent on the "__config_site" file. It probably didn't need this but it doesn't hurt to have. http://reviews.llvm.org/D13407 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake

Re: [PATCH] D12747: Implement [depr.c.headers]

Regarding Patch #15. 1. Tests under 'test/std' shouldn't directly include <__config> or depend on any libc++ implementation details. We are trying to make the test suite generic so refrain from referencing libc++ symbols. 2. "static_assert" is C++11 only but this test should work in C++03. Can

Re: [PATCH] D12747: Implement [depr.c.headers]

@Marshall, @Richard Have we fixed the Solaris build yet? On Fri, Oct 9, 2015 at 4:48 PM, Eric Fiselier wrote: > Regarding Patch #15. > > 1. Tests under 'test/std' shouldn't directly include <__config> or > depend on any libc++ implementation details. We are trying to make the >

[libcxx] r249939 - Turn off -pedantic by default when building due to #include_next. :-(

Author: ericwf Date: Fri Oct 9 22:34:52 2015 New Revision: 249939 URL: http://llvm.org/viewvc/llvm-project?rev=249939=rev Log: Turn off -pedantic by default when building due to #include_next. :-( Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[libcxx] r249938 - Revert r249931 - Remove same_decls.pass.cpp because it fails on OS X and in C++03 mode.

Author: ericwf Date: Fri Oct 9 22:31:23 2015 New Revision: 249938 URL: http://llvm.org/viewvc/llvm-project?rev=249938=rev Log: Revert r249931 - Remove same_decls.pass.cpp because it fails on OS X and in C++03 mode. Removed: libcxx/trunk/test/std/depr/depr.c.headers/same_decls.pass.cpp

Re: [libcxx] r249798 - Split out of .

I would rather not do this if possible but I understand why we need to do it. Richard is there a cost associated with the 'extern "C++"' construct? or by forcing the compiler to switch modes in general? On Mon, Oct 12, 2015 at 12:27 PM, Richard Smith wrote: > On Mon,

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Maintainers from Apple and FreeBSD gave this the thumbs up. http://reviews.llvm.org/D13407 ___ cfe-commits

[libcxx] r250235 - [libcxx] Capture configuration information when installing the libc++ headers

Author: ericwf Date: Tue Oct 13 17:12:02 2015 New Revision: 250235 URL: http://llvm.org/viewvc/llvm-project?rev=250235=rev Log: [libcxx] Capture configuration information when installing the libc++ headers Summary: Hi all, This patch is a successor to D11963. However it has changed dramatically

[libcxx] r250261 - Use __config_site when building libc++. Also cleanup ABI versioning doc

Author: ericwf Date: Tue Oct 13 19:22:05 2015 New Revision: 250261 URL: http://llvm.org/viewvc/llvm-project?rev=250261=rev Log: Use __config_site when building libc++. Also cleanup ABI versioning doc Added: libcxx/trunk/docs/DesignDocs/ABIVersioning.rst Removed: libcxx/trunk/docs/Abi.rst

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. http://reviews.llvm.org/D13407 has landed and this is good to go. Repository: rL LLVM http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r249798 - Split out of .

015 at 2:12 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I would rather not do this if possible but I understand why we need to do >> it. >> >> Richard is there a cost associated with the 'extern "C++"' construct? or >

[libcxx] r250256 - Workaround -pedantic flag added by LLVM

Author: ericwf Date: Tue Oct 13 18:56:33 2015 New Revision: 250256 URL: http://llvm.org/viewvc/llvm-project?rev=250256=rev Log: Workaround -pedantic flag added by LLVM Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@

Re: [PATCH] D13705: [libcxxabi] Set correct libc++ version in tests.

EricWF added a comment. This is fine as a temporary workaround but it's not complete. I would rather do something better. Repository: rL LLVM http://reviews.llvm.org/D13705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. Please address the inline comment. I think with that change we can hold off modifying libc++abi. Comment at: test/libcxx/test/config.py:444 @@ -442,1 +443,3 @@ +def configure_compile_flags_abi_version(self): +abi_version =

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. LGTM. We'll fix the libc++abi issue later. Repository: rL LLVM http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r250238 - Fix whitespace in doc

Author: ericwf Date: Tue Oct 13 17:22:42 2015 New Revision: 250238 URL: http://llvm.org/viewvc/llvm-project?rev=250238=rev Log: Fix whitespace in doc Modified: libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst Modified: libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst URL:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include jroelofs wrote: > EricWF wrote: > > Where does the `__GLIBC__` macro definition come from? I thought it

[PATCH] D13714: [libcxx] Use __config_site to configure the test suite features.

EricWF created this revision. EricWF added reviewers: mclow.lists, jroelofs, danalbert, eugenis, ed. EricWF added a subscriber: cfe-commits. This patch changes the tests to use the "__config_site" header if present instead of manually configuring for each option. This patch also removes the

Re: [PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

EricWF added a comment. @jroelofs +1. We are trying to make our test suite generic enough that other STL maintainers may use it and contribute to it. http://reviews.llvm.org/D14616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

EricWF added a comment. Those methods are currently unused but are you opposed to me adding them in this patch? They will be useful for compiling short tests to check for compiler features. http://reviews.llvm.org/D11333 ___ cfe-commits mailing

[libcxx] r246069 - [libcxx] Add special warning flag detection logic to compiler.py

Author: ericwf Date: Wed Aug 26 15:17:33 2015 New Revision: 246069 URL: http://llvm.org/viewvc/llvm-project?rev=246069view=rev Log: [libcxx] Add special warning flag detection logic to compiler.py Summary: Detecting `-Wno-warning` flags can be tricky with GCC (See

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. In http://reviews.llvm.org/D12247#233323, @davidxl wrote: We certainly need a fix without breaking ABI. Is there a ABI conformance test for libcxx? To actually answer @davidxl's question: No. libc++ does not have an ABI test suite of any sort.

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. In http://reviews.llvm.org/D12247#233323, @davidxl wrote: We certainly need a fix without breaking ABI. Is there a ABI conformance test for libcxx? Well this patch definitely breaks the ABI. This was my attempt at fixing the problem in `std::function` that might not

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

EricWF added a comment. In http://reviews.llvm.org/D12355#233477, @bkramer wrote: Won't this do the wrong thing for embedded '\0' in a std::string? std::string(hello\0world, 11).compare(hello) should not return 0. Woops. Yep that seems correct but it will sure hamper the possibility

[libcxx] r246070 - [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

Author: ericwf Date: Wed Aug 26 15:18:21 2015 New Revision: 246070 URL: http://llvm.org/viewvc/llvm-project?rev=246070view=rev Log: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation. Summary: On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

EricWF updated this revision to Diff 33235. EricWF added a comment. Address @mclow.lists note about consistency. http://reviews.llvm.org/D11553 Files: include/__functional_base include/__functional_base_03 include/functional

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

EricWF updated this revision to Diff 33236. EricWF added a comment. Remove unused CompileString functions. The reason they can't be used to implement `addWarningFlagIfSupported` is because we have to fuss with the flags before invoking the compiler . http://reviews.llvm.org/D11333 Files:

[PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch optimizes basic_string::compare to use strcmp when the default char_traits has been given. See PR19900 for more information. https://llvm.org/bugs/show_bug.cgi?id=19900

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

EricWF updated this revision to Diff 33179. EricWF added a comment. Remove all functions in the dylib and make them inline. http://reviews.llvm.org/D12354 Files: include/__debug include/algorithm include/regex src/debug.cpp test/libcxx/algorithms/debug_less.pass.cpp

[libcxx] r246022 - Remove XFAIL in test. The bug causing it has been fixed.

Author: ericwf Date: Wed Aug 26 02:03:43 2015 New Revision: 246022 URL: http://llvm.org/viewvc/llvm-project?rev=246022view=rev Log: Remove XFAIL in test. The bug causing it has been fixed. Modified:

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

EricWF updated this revision to Diff 33180. EricWF added a comment. Cleanup the diff and remove extra changes. http://reviews.llvm.org/D12354 Files: include/__debug include/algorithm test/libcxx/algorithms/debug_less.pass.cpp test/support/debug_mode.h Index: test/support/debug_mode.h

Re: [PATCH] D12299: [libcxx] ABI-Breaking Fix for ALL undefined behavior in list.

EricWF updated this revision to Diff 33219. EricWF added a comment. Address failing test that @awi pointed out. http://reviews.llvm.org/D12299 Files: include/list Index: include/list === --- include/list +++ include/list @@

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. I think I'm starting to understand but I think the correct fix for this would be to fix function so that: 1. It aligns its buffer by alignof(void*). 2. It doesn't stick over-aligned types in the small object buffer. Point two can probably be done without an ABI break,

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. In http://reviews.llvm.org/D12247#233595, @yiranwang wrote: In http://reviews.llvm.org/D12247#233349, @EricWF wrote: In http://reviews.llvm.org/D12247#233323, @davidxl wrote: We certainly need a fix without breaking ABI. Is there a ABI conformance test for

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. In http://reviews.llvm.org/D12247#233717, @yiranwang wrote: Hi Eric, Could you please explain a bit more what is broken specifically? As we can see, sizeof(), _Len, and _Align, and alignof() of aligned_storage are all not changed. That's correct. At the risk of

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. So this patch LGTM. Sorry for being slow to understand it. However I want to see two things before it lands. 1. I would like to see a test of some sort that the resulting type has the same size and alignment requirements it did before the change. I'm not sure what the

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. Thanks for doing all of this work. It's really appreciated. First, I don't really think we should have the notion of a minor ABI version. It will be hard enough to maintain 2 major versions and I don't understand what a minor ABI version buys us. In my opinion libc++

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. In http://reviews.llvm.org/D11740#234575, @eugenis wrote: Yes, not being able to use headers in the libcxx source tree is quite unpleasant. It can be fixed by providing a __config_version in libcxx/include with the default version values. Or, in the approach of

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. In http://reviews.llvm.org/D11740#234642, @eugenis wrote: OK. Then _LIBCPP_ABI_UNSTABLE won't bump the ABI version (as seen in library soname and header path)? Yeah. That was how I imagined it. http://reviews.llvm.org/D11740

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

EricWF updated this revision to Diff 33368. EricWF added a comment. Remove unnecessary call to `std::min`. http://reviews.llvm.org/D12355 Files: include/string Index: include/string === --- include/string +++ include/string @@

[libcxx] r246275 - Finally get the test suite passing in C++03!!

Author: ericwf Date: Fri Aug 28 00:46:17 2015 New Revision: 246275 URL: http://llvm.org/viewvc/llvm-project?rev=246275view=rev Log: Finally get the test suite passing in C++03!! After months of work there are only 4 tests still failing in C++03. This patch fixes those tests. All of the libc++

[libcxx] r246266 - [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

Author: ericwf Date: Thu Aug 27 22:02:37 2015 New Revision: 246266 URL: http://llvm.org/viewvc/llvm-project?rev=246266view=rev Log: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*) Summary: This patch optimizes basic_string::compare to use strcmp when the

[libcxx] r246270 - Fix bug in test_allocatorvoid that used the wrong value to represent object state

Author: ericwf Date: Fri Aug 28 00:00:25 2015 New Revision: 246270 URL: http://llvm.org/viewvc/llvm-project?rev=246270view=rev Log: Fix bug in test_allocatorvoid that used the wrong value to represent object state Modified: libcxx/trunk/test/support/test_allocator.h Modified:

[libcxx] r246272 - [libcxx] Constrain unique_ptr::operator=(unique_ptrTp, Dp) in C++03 mode

Author: ericwf Date: Fri Aug 28 00:07:06 2015 New Revision: 246272 URL: http://llvm.org/viewvc/llvm-project?rev=246272view=rev Log: [libcxx] Constrain unique_ptr::operator=(unique_ptrTp, Dp) in C++03 mode Summary: This patch properly constrains the converting assignment operator in C++03. It

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#235148, @jroelofs wrote: In http://reviews.llvm.org/D11963#234789, @EricWF wrote: Copy the headers to the build directory during every build instead of just during CMake configuration. Sounds like this would cause every build to

[libcxx] r246399 - Suppress clang warnings in some tests

Author: ericwf Date: Sun Aug 30 17:04:20 2015 New Revision: 246399 URL: http://llvm.org/viewvc/llvm-project?rev=246399view=rev Log: Suppress clang warnings in some tests Modified: libcxx/trunk/test/libcxx/double_include.sh.cpp libcxx/trunk/test/libcxx/test/config.py

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

EricWF added a comment. In http://reviews.llvm.org/D12512#236988, @majnemer wrote: > In http://reviews.llvm.org/D12512#236987, @EricWF wrote: > > > In http://reviews.llvm.org/D12512#236984, @majnemer wrote: > > > > > Wouldn't this change be problematic if you threw to code which was > > >

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. In http://reviews.llvm.org/D12247#231444, @yiranwang wrote: A test case is as following. It has to be build by GCC 4.9 -O3 (maybe or later), with latest libc++, and for AARCH64+ANDROID target. AARCH64 requires 128 bit alignment for aligned_storage and 64 bit

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. I think I've misunderstood this patch the whole time. I didn't understand that it was undefined to access the trailing padding of the storage type. Am I correct in saying that this patch won't change the actual values of `sizeof(aligned_storageN::type)` and

Re: [PATCH] D8178: [libcxx] Fix PR22806 - Tuple incorrectly selects copy/move constructor when storing nested tuple-like types.

EricWF added a comment. In http://reviews.llvm.org/D8178#236180, @EricWF wrote: > I think this patch is actually pretty close to correct but thinking about > tuple hurts my brain. > > @mclow.lists can you start reviewing this when you have time. @mclow.lists Nevermind I think I have a better

[PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

EricWF created this revision. EricWF added reviewers: mclow.lists, eugenis, ldionne. EricWF added a subscriber: cfe-commits. This patch fixes the following bugs: * PR23256 tuple is_constructible attempts tuple to A conversion: * Fix this by disabling the UTypes... overloads using the

Re: [PATCH] D9085: Fix tuple to A conversion in SFINAE for tuple(_Up...) constructor

EricWF added a comment. Another possible fix up for review as http://reviews.llvm.org/D12502. Repository: rL LLVM http://reviews.llvm.org/D9085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D8178: [libcxx] Fix PR22806 - Tuple incorrectly selects copy/move constructor when storing nested tuple-like types.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Abandoning for patch http://reviews.llvm.org/D12502. http://reviews.llvm.org/D8178 ___ cfe-commits mailing list

Re: [PATCH] D8178: [libcxx] Fix PR22806 - Tuple incorrectly selects copy/move constructor when storing nested tuple-like types.

EricWF abandoned this revision. EricWF added a comment. Actually abandoning. Sorry for the spam. http://reviews.llvm.org/D8178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#236376, @jroelofs wrote: > In http://reviews.llvm.org/D11963#236045, @EricWF wrote: > > > So that's not what happens but that's because libc++ builds using the > > headers in the source directory. During the build all of the macros in

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. FYI I'm focusing on getting http://reviews.llvm.org/D11963 in so that it stops blocking this patch. http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. FYI I'm focusing on getting http://reviews.llvm.org/D11963 in so that it stops blocking this patch. http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r246516 - Convert LIBCXXABI_BUILD_32_BITS to LLVM_BUILD_32_BITS.

Author: ericwf Date: Mon Aug 31 20:02:06 2015 New Revision: 246516 URL: http://llvm.org/viewvc/llvm-project?rev=246516=rev Log: Convert LIBCXXABI_BUILD_32_BITS to LLVM_BUILD_32_BITS. Modified: libcxxabi/trunk/test/CMakeLists.txt libcxxabi/trunk/test/lit.site.cfg.in Modified:

[PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, compnerd, majnemer. EricWF added a subscriber: cfe-commits. In 32 bit builds the __cxa_exception class has an alignment requirement greater than the maximal alignment supported by malloc. If this is the case we need to

Re: [PATCH] D12644: Using -isysroot on Apple platform

EricWF added a reviewer: danalbert. EricWF added a subscriber: danalbert. EricWF added a comment. @danalbert actually uses this option. I would like him to confirm this change. http://reviews.llvm.org/D12644 ___ cfe-commits mailing list

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM modulo handling C++03. Currently compiles w/ clang in C++03. Please either ensure your portions of the searchers also compile in C++03 and change the tests or #ifdef them out before

[libcxx] r246909 - Add temporary Makefile.sphinx build file to get libcxx.llvm.org/docs going

Author: ericwf Date: Sat Sep 5 00:12:04 2015 New Revision: 246909 URL: http://llvm.org/viewvc/llvm-project?rev=246909=rev Log: Add temporary Makefile.sphinx build file to get libcxx.llvm.org/docs going Added: libcxx/trunk/docs/Makefile.sphinx Added: libcxx/trunk/docs/Makefile.sphinx URL:

[PATCH] D12669: [libcxxabi] Fix alignment of pointers returned by fallback_malloc

EricWF created this revision. EricWF added reviewers: mclow.lists, compnerd, joerg, jroelofs. EricWF added a subscriber: cfe-commits. Currently the pointers returned by fallback_malloc do not have *ANY* alignment guarantees. This is caused by two different problems is `fallback_malloc.ipp`.

[libcxx] r246952 - Cleanup BuildingLibcxx.rst and remove TODO

Author: ericwf Date: Sun Sep 6 18:31:16 2015 New Revision: 246952 URL: http://llvm.org/viewvc/llvm-project?rev=246952=rev Log: Cleanup BuildingLibcxx.rst and remove TODO Modified: libcxx/trunk/docs/BuildingLibcxx.rst Modified: libcxx/trunk/docs/BuildingLibcxx.rst URL:

[libcxx] r246950 - Try to fix links for libcxx.llvm.org/docs again.

Author: ericwf Date: Sun Sep 6 18:09:54 2015 New Revision: 246950 URL: http://llvm.org/viewvc/llvm-project?rev=246950=rev Log: Try to fix links for libcxx.llvm.org/docs again. Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL:

<    1   2   3   4   5   6   7   8   9   10   >