[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added a comment. This will break LLDB, unless https://reviews.llvm.org/D54863 is applied. @shafik Could you please take a look on https://reviews.llvm.org/D54863 ? Repository: rC Clang https://reviews.llvm.org/D53655 ___ cfe-commits

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added a comment. > I see that now everything is reverted, the "good" things too (change to > indirectFieldDecl and a line split)? Yes, you are completely right, sorry for this mess. I just have updated so the good things remain. Repository: rC Clang https://reviews.llvm.org/D53655

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175091. martong marked an inline comment as done. martong added a comment. - Keep the good changes and use the name 'containsInVector' Repository: rC Clang https://reviews.llvm.org/D53655 Files: include/clang/AST/DeclContextInternals.h

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

martong added a comment. In D53818#1307321 , @a_sidorin wrote: > LGTM. Thank you for addressing my questions! Hi Alexei, Could you please also take a look on that patch which this one depends on? https://reviews.llvm.org/D53751 I think the changes of

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 174893. martong marked 4 inline comments as done. martong added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. - Minor style changes and rename a function Repository: rC Clang https://reviews.llvm.org/D53655 Files:

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added inline comments. Comment at: lib/AST/DeclBase.cpp:1469 assert(Pos != Map->end() && "no lookup entry for decl"); -if (Pos->second.getAsVector() || Pos->second.getAsDecl() == ND) +// Remove the decl only if it is contained. +if

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong updated this revision to Diff 174897. martong marked an inline comment as done. martong removed a reviewer: shafik. martong removed a subscriber: gamesh411. martong added a comment. Herald added a reviewer: shafik. - Better style without braces Repository: rC Clang

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong marked an inline comment as done. martong added inline comments. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Comment at: lib/AST/ASTImporter.cpp:7716 } } balazske wrote: > This can be simplified by removing brace

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong added a comment. Herald added a subscriber: gamesh411. That's a good point. I agree, we should check some bits (calling convention bits) but not all (e.g. noreturn bit). I am going to create another patch which replaces this. Repository: rC Clang https://reviews.llvm.org/D53699

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175482. martong marked 5 inline comments as done. martong added a comment. - Address several minor review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53655/new/ https://reviews.llvm.org/D53655 Files:

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong marked 20 inline comments as done. martong added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1169 +/// matches 'a'. +extern const internal::VariadicDynCastAllOfMatcher +indirectFieldDecl; aaron.ballman wrote: > Be sure to

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong updated this revision to Diff 175495. martong marked 5 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 Files:

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong marked 18 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:7605 + +ASTImporter::ASTImporter(ASTImporterLookupTable *LookupTable, + ASTContext , FileManager , a_sidorin wrote: > It's

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ExternalASTMerger.cpp:154 ToContainer->setHasExternalLexicalStorage(); - ToContainer->setMustBuildLookupTable(); +

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong marked 3 inline comments as done. martong added inline comments. Comment at: lib/AST/DeclBase.cpp:1469 assert(Pos != Map->end() && "no lookup entry for decl"); -if (Pos->second.getAsVector() || Pos->second.getAsDecl() == ND) +// Remove the decl

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

martong added inline comments. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Comment at: lib/AST/ASTImporter.cpp:2310 +D->getUnderlyingType(), FoundTypedef->getUnderlyingType())) { + QualType FromUT = D->getUnderlyingType(); +

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Gentle Ping. Repository: rC Clang https://reviews.llvm.org/D53708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175058. martong added a comment. - Revert "Minor style changes and rename a function" Repository: rC Clang https://reviews.llvm.org/D53655 Files: include/clang/AST/DeclContextInternals.h include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong added a comment. Constructs like `struct A { struct Foo *p; };` are very common in C projects. Since `Foo` as a forward decl cannot be found by normal lookup we need this patch in order to properly CTU analyze even a simple C project like `tmux`. Repository: rC Clang

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong added a subscriber: gamesh411. martong added a comment. @shafik , @gamesh411 I think when I used arcanist to update the patch it removed you as a reviewer and a subscriber. I am really sorry about this. Fortunately the Herald script added you guys back. And once you are here, this is a

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

martong added a comment. Herald added a subscriber: gamesh411. @shafik, I could run the libcxx tests on my Linux machine (Ubuntu 16.04) by installing libcxx: `sudo apt-get install libc++-dev`. From the logs of your build server seems like the crash happened with a `_gmodules` test.

[PATCH] D53702: [ASTImporter] Set redecl chain of functions before any other import

This revision was automatically updated to reflect the committed changes. Closed by commit rC347306: [ASTImporter] Set redecl chain of functions before any other import (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D53702?vs=171093=174763#toc

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

martong added a comment. I have reproduced the issue on MacOS, fixed it and updated the patch accordingly. Soon I will commit and will monitor if any build bots are being broken. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53697/new/

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

This revision was automatically updated to reflect the committed changes. Closed by commit rL347648: [ASTImporter] Typedef import brings in the complete type (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

This revision was automatically updated to reflect the committed changes. Closed by commit rL347564: [ASTImporter][Structural Eq] Check for isBeingDefined (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54898/new/ https://reviews.llvm.org/D54898 ___

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

martong marked an inline comment as done. martong added inline comments. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780 + typedefNameDecl(hasName("U"))); + ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType()); + shafik wrote: > As far as

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

martong added a comment. > I reverted this change because it breaks a bunch of lldb tests (on MacOS, and > probably on other platforms too). To be clear, part of the reason I'm > reacting strongly here is that this is not the first patch this has come up > on. I'm worried about the broader

[PATCH] D53702: [ASTImporter] Set redecl chain of functions before any other import

martong added a comment. > Did you ever resolve the issue of libcxx tests not running > https://reviews.llvm.org/D53697 Oh, by the way this change is completely independent from that other patch. Repository: rC Clang https://reviews.llvm.org/D53702

[PATCH] D53702: [ASTImporter] Set redecl chain of functions before any other import

martong added a comment. > Did you ever resolve the issue of libcxx tests not running > https://reviews.llvm.org/D53697 Hi @shafik , Sorry for the late reaction, I was on a two weeks long vacation recently. My priority is to make those libcxx tests pass, I did not forget. :) Repository: rC

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

martong added a subscriber: a_sidorin. martong added a comment. > I think these changes make sense at a high level but I am not sure about the > refactoring strategy. I am especially concerned we may end up in place where > all the effected users of the API don't get updated and we are stuck

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

martong updated this revision to Diff 175241. martong added a comment. - Get data of CXXRecordDecl only if set Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53697/new/ https://reviews.llvm.org/D53697 Files: lib/AST/ASTImporter.cpp

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

This revision was automatically updated to reflect the committed changes. Closed by commit rC350521: [CTU] Make loadExternalAST return with non nullptr on success (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D55280?vs=176779=180479#toc Repository:

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

martong accepted this revision. martong added a comment. Looks good to me (but xazax's comments are valid)! Thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56441/new/ https://reviews.llvm.org/D56441 ___

[PATCH] D56581: [ASTImporter] Set the described template if not set

martong created this revision. martong added reviewers: shafik, a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. During the addition of an injected class type to a record it may happen that a CXXRecordDecl in the redecl

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

martong added a comment. Just a quick note. We are pretty sure that `StructuralEquivalency` can have false positive results, i.e. it can report two decls as nonequivalent falsely. My understanding is that we should report an error only if we are absolutely certain that an error has happened,

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

martong marked 3 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1441 + To->setInit(ToInit); + if (From->isInitKnownICE()) { +EvaluatedStmt *Eval = To->ensureEvaluatedStmt(); a_sidorin wrote: > I see that this is

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

martong updated this revision to Diff 165039. martong marked an inline comment as done. martong added a comment. - Fix formatting and typo Repository: rC Clang https://reviews.llvm.org/D51597 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index:

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

This revision was automatically updated to reflect the committed changes. Closed by commit rL342384: [ASTImporter] Fix import of VarDecl init (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51597 Files:

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:3046 +if (!D->doesThisDeclarationHaveABody()) + return cast(const_cast(FoundByLookup)); +else { balazske wrote: > The `cast` should not be needed here (and is not done at

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

martong accepted this revision. martong added a comment. The updated version looks good to me! Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651 ___ cfe-commits mailing list

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. Shafik, I have realized what's the problem with the `ctu-main` test. When we import the body and set the new body to the existing FunctionDecl then the parameters are still the old parameters so the new body does not refer to the formal parameters! This way the

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183834. martong added a comment. I have created a separate patch for the test related refactor, this patch now depends on that patch and contains merely the visibility related change and their tests. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Currently `TestImportBase` is derived from `ParameterizedTestsFixture` which explicitly states that the

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183826. martong marked 5 inline comments as done. martong added a comment. - Remove dumpDeclContext() call - Remove superfluous else Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong marked an inline comment as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2954 +return Found->hasExternalFormalLinkage(); + else if (Importer.GetFromTU(Found) == From->getTranslationUnitDecl()) { +if (From->isInAnonymousNamespace())

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2154 +return NameOrErr.takeError(); } } a_sidorin wrote: > Should we write `else Name = *NameOrError`? Atm, we implement the simplest

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a comment. Ping @shafik @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59665/new/ https://reviews.llvm.org/D59665 ___ cfe-commits mailing list

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59845/new/ https://reviews.llvm.org/D59845 ___ cfe-commits mailing list

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1442328 , @shafik wrote: > @martong your idea does not work b/c default construction `DeclarationName()` > treats it the same as being empty. So `if (!Name)` is still `true`. And did you try moving the `push_back` to

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. Looks good for me now, but we should make a similar change in VisitRecordDecl too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59665/new/ https://reviews.llvm.org/D59665 ___ cfe-commits mailing list

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2463 if (!ConflictingDecls.empty()) { - Name = Importer.HandleNameConflict(Name, DC, IDNS, + Name = Importer.HandleNameConflict(SearchName, DC, IDNS,

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 192263. martong marked 2 inline comments as done. martong added a comment. - Add braces around else - Remove falsely duplicated push_back - Use Expected in HandleNameConflict Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked 5 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2260 ConflictingDecls.push_back(FoundDecl); } a_sidorin wrote: > Do we push the same decl twice? Uhh, thanks, that is rebase error I've

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1444673 , @teemperor wrote: > In D59485#1439628 , @martong wrote: > > > In D59485#1439570 , @martong wrote: > > > > > In D59485#1439390

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:590 + new RedirectingImporter(ToContext, ToFileManager, FromContext, + FromFileManager, MinimalImport, LookupTabl)); +}; teemperor

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1446764 , @a_sidorin wrote: > Hi Shafik, > Thank you for the explanation, it is much more clear to me now. But, as I > see, D59692 is going to discard the changes > this patch

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. In D59485#1446950 , @a_sidorin wrote: > Hello Raphael, > I think we should accept this change. I don't see an easy way to merge the > LLDB stuff into ASTImporter; also, this patch provides a good

[PATCH] D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL357402: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rC357394: [ASTImporter] Make ODR error handling configurable (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D58897?vs=192070=193086#toc Repository: rC Clang

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:1344 + + EXPECT_EQ(FromChooseExpr->isConditionTrue(), ToChooseExpr->isConditionTrue()); +} To compensate the skipping of the template test, perhaps we should have another

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function template specializations are not handled well

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a reviewer: martong. Ping. Please raise your objections if you have any until the 4th of March (that date we are going to commit if there are no objections). Also, please let us know if you find this deadline too strict. Repository: rC Clang CHANGES

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); +template static

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 188379. martong marked 4 inline comments as done. martong added a comment. - getDefinition -> getTemplateDefinition - Remove comments for braces, added FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of class template specializations are not handled

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

martong accepted this revision. martong added a reviewer: balazske. martong added a subscriber: balazske. martong added a comment. Shafik, this looks good to me, once teemperor's comments are addressed. Note, I added @balazske as a reviewer, he recently worked with importing the FileIDs, he may

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58502/new/ https://reviews.llvm.org/D58502

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rC355096: [CTU] Do not allow different CPP dialects in CTU (authored by martong, committed by ). Changed prior to commit:

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong updated this revision to Diff 189130. martong marked 4 inline comments as done. martong added a comment. - Add FindAndMapDefinition as member fun - Refactor CheckPreviousDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong marked 8 inline comments as done. martong added a comment. Alexei, thanks for the review! Comment at: lib/AST/ASTImporter.cpp:3002 + // Check if we have found an existing definition. Returns with that + // definition if yes, otherwise returns null.

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong updated this revision to Diff 189131. martong marked 2 inline comments as done. martong added a comment. - Fix some comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 Files: lib/AST/ASTImporter.cpp

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong added a comment. Alexei, thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function templates are not handled well currently. We want

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of classes and class templates are not handled

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

This revision was automatically updated to reflect the committed changes. Closed by commit rL355390: [ASTImporter] Fix redecl failures of Class and ClassTemplate (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58830: [ASTImporter] Import member expr with explicit template args

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Member expressions with explicit template arguments were not imported

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255 + // in the other unit it has none. + if (LangTo.CPlusPlus11 != LangFrom.CPlusPlus11 || + LangTo.CPlusPlus14 != LangFrom.CPlusPlus14 ||

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. In D57590#1411055 , @efriedma wrote: > I don't know anything about this particular patch, but you aren't allowed to > set deadlines like that; the patch review process requires that the patch is > actually reviewed. If you

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong added a comment. @shafik Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong marked an inline comment as done. martong added a comment. @shafik Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 ___ cfe-commits mailing list

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rC355593: [ASTImporter] Handle redecl chain of FunctionTemplateDecls (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D58494?vs=189665=189694#toc Repository: rC

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a reviewer: martong. Herald added a project: clang. Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected). Please see the "Stack" column above. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58830: [ASTImporter] Import member expr with explicit template args

This revision was automatically updated to reflect the committed changes. Closed by commit rL355596: [ASTImporter] Import member expr with explicit template args (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:5147 } +} else { // ODR violation. + // FIXME HandleNameConflict shafik wrote: > ODR violations are ill-formed no diagnostic required. So

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 189665. martong marked 6 inline comments as done. martong added a comment. - Add asserts Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 Files: lib/AST/ASTImporter.cpp

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4967 +template static auto getTemplateDefinition(T *D) -> T * { + auto *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); if (!ToTemplatedDef) shafik wrote: > shafik wrote: > > Can we

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58897/new/ https://reviews.llvm.org/D58897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.

martong added a reviewer: a_sidorin. martong added a comment. Herald added a reviewer: martong. Herald added a subscriber: jdoerfert. Herald added a project: clang. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55358/new/ https://reviews.llvm.org/D55358

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a subscriber: rnkovacs. > This patch is the next in the series of patches to finish the proper error > handling (i.e. using Error and Expected). Please see the "Stack" column > above. @balazske Or is it superseded by this one?

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 189830. martong edited the summary of this revision. martong added a comment. Herald added a project: clang. Rebase to master. There was a conflict in the tests, in ASTImporterTest.cpp. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong commandeered this revision. martong edited reviewers, added: a_sidorin; removed: martong. martong added a comment. This revision now requires review to proceed. Herald added subscribers: gamesh411, dkrupp. @a_sidorin Aleksei, If you don't mind, I am going to investigate this further with

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

martong accepted this revision. martong added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59595/new/ https://reviews.llvm.org/D59595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

martong added a comment. > We can't reliable import templates with the ASTImporter, so actually > reconstructing the template in the debug info AST and then importing it > doesn't work. Could you please elaborate how the import of templates fails in ASTImporter? Is it because the AST you

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL356455: [ASTImporter] Fix redecl failures of FunctionTemplateSpec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL356452: [ASTImporter] Fix redecl failures of ClassTemplateSpec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong updated this revision to Diff 191286. martong added a comment. - Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index:

<    1   2   3   4   5   6   7   8   9   10   >