Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

hans added a comment. Is this waiting for anything more now that http://reviews.llvm.org/D20346 has landed? http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans added a comment. Thanks for the review! In http://reviews.llvm.org/D20608#439480, @thakis wrote: > Do we have test coverage for `template class __declspec(dllexport) > codecvt;` somewhere already? Yes, that's covered by tests in CodeGenCXX/dllexport.cpp Comment at:

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans updated this revision to Diff 58461. hans added a comment. tweaks http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp

r270754 - Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

Author: hans Date: Wed May 25 15:49:14 2016 New Revision: 270754 URL: http://llvm.org/viewvc/llvm-project?rev=270754=rev Log: Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" It seems to have broken the sanitizer-windows

[PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans created this revision. hans added reviewers: rnk, thakis. hans added a subscriber: cfe-commits. This matches what MSVC does, and should make compiles faster by avoiding to unnecessarily emit a lot of code. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans updated this revision to Diff 58484. hans added a comment. Fix the "dllexport trumps" comment, and add a test. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7382 @@ +7381,3 @@ + if (A->getKind() == AttributeList::AT_DLLExport) { +// dllexport trumps dllexport here. +DLLImport = false; thakis wrote: > trumps _dllimport_ here > >

r270748 - clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

Author: hans Date: Wed May 25 15:16:43 2016 New Revision: 270748 URL: http://llvm.org/viewvc/llvm-project?rev=270748=rev Log: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811) This matches what MSVC does, and should make compiles faster by

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

This revision was automatically updated to reflect the committed changes. Closed by commit rL270748: clang-cl: Treat dllimport explicit template instantiation definitions as… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20608?vs=58484=58488#toc Repository: rL LLVM

r272702 - s/Intrin.h/intrin.h/, trying to fix the build after r272701

Author: hans Date: Tue Jun 14 15:14:24 2016 New Revision: 272702 URL: http://llvm.org/viewvc/llvm-project?rev=272702=rev Log: s/Intrin.h/intrin.h/, trying to fix the build after r272701 Modified: cfe/trunk/lib/Headers/CMakeLists.txt cfe/trunk/lib/Headers/intrin.h

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

SGTM, then :-) On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > I locally set up an SVN repo with a file called "File.txt" and then renamed > it with `svn mv` using a new svn client (1.8). > > Then I tried updating several local checkouts of my local repo with svn >

r272583 - clang-cl: Support -resource-dir option (PR28074)

Author: hans Date: Mon Jun 13 15:31:30 2016 New Revision: 272583 URL: http://llvm.org/viewvc/llvm-project?rev=272583=rev Log: clang-cl: Support -resource-dir option (PR28074) It's useful e.g. for distributed build systems. Modified: cfe/trunk/include/clang/Driver/Options.td

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm if it works :-) Repository: rL LLVM http://reviews.llvm.org/D20672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r270897 - Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

Author: hans Date: Thu May 26 14:42:56 2016 New Revision: 270897 URL: http://llvm.org/viewvc/llvm-project?rev=270897=rev Log: Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" Also make explicit instantiation decls not

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL273440: Add support for /Ob1 and -finline-hint-functions flags (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20647?vs=61418=61565#toc Repository: rL LLVM

r273440 - Add support for /Ob1 and -finline-hint-functions flags

Author: hans Date: Wed Jun 22 11:56:16 2016 New Revision: 273440 URL: http://llvm.org/viewvc/llvm-project?rev=273440=rev Log: Add support for /Ob1 and -finline-hint-functions flags Add support for /Ob1 (and equivalent -finline-hint-functions), which enable inlining only for functions marked

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

This revision was automatically updated to reflect the committed changes. Closed by commit rL273434: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490) (authored by hans). Changed prior to commit: http://reviews.llvm.org/D21566?vs=61560=61563#toc Repository: rL

r273434 - Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

Author: hans Date: Wed Jun 22 11:21:14 2016 New Revision: 273434 URL: http://llvm.org/viewvc/llvm-project?rev=273434=rev Log: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490) It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing silent

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

hans added a comment. Thanks for the review! Please take another look. Comment at: lib/CodeGen/CGCleanup.h:93 @@ -92,3 +92,3 @@ /// from this index onwards belong to this scope. -unsigned FixupDepth : 32 - 18 - NumCommonBits; // currently 12 +unsigned FixupDepth;

Re: [PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

hans updated this revision to Diff 61560. hans marked 3 inline comments as done. hans added a comment. Addressing comments. http://reviews.llvm.org/D21566 Files: lib/CodeGen/CGCleanup.h test/CodeGen/fixup-depth-overflow.c Index: test/CodeGen/fixup-depth-overflow.c

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

hans added inline comments. Comment at: test/Driver/cl-options.c:283 @@ -282,3 +282,2 @@ // RUN:/nologo \ -// RUN:/Ob1 \ // RUN:/openmp- \ You're removing it from the ignored flags here, but I don't see any code change or test for how clang-cl's

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

hans accepted this revision. hans added a comment. In http://reviews.llvm.org/D20647#463590, @Ilod wrote: > Fixed passing argument from clang driver to cc1. > Added driver tests. lgtm, thanks! http://reviews.llvm.org/D20647 ___ cfe-commits

[PATCH] D21566: Widen EHScope::ClenupBitFields::FixupDepth to avoid overflowing it (PR23490)

hans created this revision. hans added a reviewer: rjmccall. hans added a subscriber: cfe-commits. It currently only takes 2048 gotos to overflow the FixupDepth bitfield, causing silent miscompilation. Apparently some parser generators run into this (see PR). I don't know that that data

r257652 - Update cxx_dr_status.html after the 3.8 branch

Author: hans Date: Wed Jan 13 13:14:03 2016 New Revision: 257652 URL: http://llvm.org/viewvc/llvm-project?rev=257652=rev Log: Update cxx_dr_status.html after the 3.8 branch Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL:

Re: r257868 - PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin

Should this be merged to 3.8? On Thu, Jan 14, 2016 at 8:36 PM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Thu Jan 14 22:36:32 2016 > New Revision: 257868 > > URL: http://llvm.org/viewvc/llvm-project?rev=257868=rev > Log: > PR26111: segmentation

Re: r257710 - [Sema] Suppress diags in overload resolution.

Thanks! Richard, what say the code owner? On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV wrote: > FYI: This patch should to be merged into the clang 3.8.0 branch. > > Thank you! > George > > On Wed, Jan 13, 2016 at 3:36 PM, George Burgess IV via cfe-commits >

[libcxx] r257721 - Merging r257702:

Author: hans Date: Wed Jan 13 18:02:08 2016 New Revision: 257721 URL: http://llvm.org/viewvc/llvm-project?rev=257721=rev Log: Merging r257702: r257702 | marshall | 2016-01-13 15:05:15 -0800 (Wed, 13 Jan 2016) | 1 line

[libcxx] r257720 - Merging r257696:

Author: hans Date: Wed Jan 13 18:01:17 2016 New Revision: 257720 URL: http://llvm.org/viewvc/llvm-project?rev=257720=rev Log: Merging r257696: r257696 | marshall | 2016-01-13 14:52:36 -0800 (Wed, 13 Jan 2016) | 1 line Fix

[libcxx] r257716 - Merging r257682:

Author: hans Date: Wed Jan 13 17:53:40 2016 New Revision: 257716 URL: http://llvm.org/viewvc/llvm-project?rev=257716=rev Log: Merging r257682: r257682 | marshall | 2016-01-13 13:54:34 -0800 (Wed, 13 Jan 2016) | 1 line Fix

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

hans added a subscriber: hans. hans added a comment. I tried to printf debug with this patch: Index: lib/sanitizer_common/sanitizer_suppressions.cc === --- lib/sanitizer_common/sanitizer_suppressions.cc (revision 257931)

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260449 - Revert r260388 "[MS ABI] Never reference dllimport'd vtables"

Author: hans Date: Wed Feb 10 16:18:37 2016 New Revision: 260449 URL: http://llvm.org/viewvc/llvm-project?rev=260449=rev Log: Revert r260388 "[MS ABI] Never reference dllimport'd vtables" This caused the compiler to fail with "invalid linkage type for global declaration" (PR26569). Modified:

Re: [PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

Probably not (unless someone corrects me). In that case, it can wait for the next release. Thanks, Hans On Fri, Feb 5, 2016 at 11:02 AM, Aaron Ballman <aa...@aaronballman.com> wrote: > Is PR25804 a regression? > > ~Aaron > > On Fri, Feb 5, 2016 at 1:59 PM, Hans Wennborg v

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

It was requested that this be merged to 3.8 as it fixes PR25804. Manuel: does this look OK for the branch? Thanks, Hans On Fri, Feb 5, 2016 at 10:29 AM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Fri Feb 5 12:29:24 2016 > New Revision: 259898

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Merged in r259939. Cheers, Hans On Fri, Feb 5, 2016 at 2:06 PM, Ulrich Weigand wrote: > Hans, > > this is one more patch that should go into 3.8 -- it fixes miscompiles of > code using GCC-provided C++11 system headers like . > > With this patch, the test suite is now

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

Marshall: ping? On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote: > Marshall: ping? > > On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: >> On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: >>> On Tue, Jan 19, 2016 at 12:01

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

Marshall: ping? On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote: > I'm OK if Marshall is. > > Thanks, > Hans > > On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via > cfe-commits wrote: >> Hans, do you mind merging this to the 3.8

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

On Tue, Sep 8, 2015 at 1:06 AM, John McCall via cfe-commits wrote: > Author: rjmccall > Date: Tue Sep 8 03:05:57 2015 > New Revision: 246985 > > URL: http://llvm.org/viewvc/llvm-project?rev=246985=rev > Log: > Compute and preserve alignment more faithfully in

r260637 - UsersManual: update clang-cl commands

Author: hans Date: Thu Feb 11 19:01:37 2016 New Revision: 260637 URL: http://llvm.org/viewvc/llvm-project?rev=260637=rev Log: UsersManual: update clang-cl commands Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

I'm following the thread on r260235 to figure out what to merge in this series. On Thu, Feb 11, 2016 at 7:09 AM, Vasileios Kalintiris via cfe-commits wrote: > Hi Hans, > > Can we merge this on the release branch? It's a re-commit of D16613's patch > with the an

Re: r259183 - Add target triple to CodeGenOpenCL/pipe_types.cl test case

Sure, r259808. Thanks, Hans On Thu, Feb 4, 2016 at 10:13 AM, Ulrich Weigand wrote: > Hans, > > would it be OK to backport this test case fix to the 3.8 branch? > This is currently the only failing test on the branch for SystemZ. > > Thanks! > >>Author: uweigand

Re: Merge OpenCL 2.0 Pipe builtins (r258782) in 3.8

Sorry for the slow reply. I've replied on the r258782 thread. On Tue, Jan 26, 2016 at 10:29 AM, Anastasia Stulova wrote: > Could you please merge Clang commit r258782 into release 3.8. > > > > It adds Pipe BIFs to be used along with Pipe type committed earlier (in >

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Alexey: you're the owner of openmp in Clang. Can you comment on what should be merged here? On Tue, Jan 26, 2016 at 3:43 PM, Jack Howarth wrote: > Tested the attached patch which contains a back port of the net > changes from both r258307 and > > Author: abataev

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

I don't think we have a specific code owner for OpenCL in Clang, which means Richard is the owner. Richard, what do you think? On Wed, Jan 27, 2016 at 10:08 PM, xiuli pan wrote: > Hi hans, > > Request to merge it to release 38 > > It adds Pipe BIFs to be used along with

Re: [libcxx] r259046 - [libcxx] Work around for clang calling GAS after having already failed.

Yes, go ahead. Thanks, Hans On Thu, Jan 28, 2016 at 5:57 AM, Daniel Sanders wrote: > Hi Hans, > > Is it ok to merge this into 3.8? Eric Fiselier has already approved on the > review. > > From: cfe-commits

Re: [clang-tools-extra] r258924 - Add clang-tools-extra documentation to the CMake build.

On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Jan 27 05:37:08 2016 > New Revision: 258924 > > URL: http://llvm.org/viewvc/llvm-project?rev=258924=rev > Log: > Add clang-tools-extra documentation to the CMake

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

hans added a comment. Hi Stephan, I would rather see that we could get this right in the AST. The problem is that the Befriended::func() definition doesn't have dllexport attached: `-CXXMethodDecl 0x5ba1cf0 parent 0x5b4f288 prev 0x5b4f750 col:18 used func 'void (void)'

Re: [clang-tools-extra] r258926 - [clang-tidy] Fix documentation.

On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Jan 27 05:37:19 2016 > New Revision: 258926 > > URL: http://llvm.org/viewvc/llvm-project?rev=258926=rev > Log: > [clang-tidy] Fix documentation. > > Fixed broken

[clang-tools-extra] r258960 - docs/conf.py: update copyright year

Author: hans Date: Wed Jan 27 12:29:16 2016 New Revision: 258960 URL: http://llvm.org/viewvc/llvm-project?rev=258960=rev Log: docs/conf.py: update copyright year Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL:

Re: r257710 - [Sema] Suppress diags in overload resolution.

Thanks! r259412. On Mon, Feb 1, 2016 at 1:32 PM, Richard Smith wrote: > LGTM for 3.8. > > On Wed, Jan 13, 2016 at 4:03 PM, Hans Wennborg wrote: >> Thanks! Richard, what say the code owner? >> >> On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV >>

Re: r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Thanks! r259414. On Mon, Feb 1, 2016 at 1:36 PM, Richard Smith wrote: > LGTM for 3.8. > > On Thu, Jan 21, 2016 at 1:10 PM, Hans Wennborg wrote: >> Richard, it was suggested (in >> https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged >>

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Mon, Feb 1, 2016 at 1:53 PM, Richard Smith wrote: > On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg wrote: >> I don't think we have a specific code owner for OpenCL in Clang, which >> means Richard is the owner. >> >> Richard, what do you think? >

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

Marshall: ping? On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: > On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: >> On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote: >>> On 19 Jan 2016, at 01:50, Marshall Clow via

[libunwind] r259571 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:11:13 2016 New Revision: 259571 URL: http://llvm.org/viewvc/llvm-project?rev=259571=rev Log: Creating release candidate rc2 from release_380 branch Added: libunwind/tags/RELEASE_380/rc2/ - copied from r259570, libunwind/branches/release_38/

[libcxx] r259564 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:10:52 2016 New Revision: 259564 URL: http://llvm.org/viewvc/llvm-project?rev=259564=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxx/tags/RELEASE_380/rc2/ (props changed) - copied from r259563, libcxx/branches/release_38/

[libcxxabi] r259565 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:10:55 2016 New Revision: 259565 URL: http://llvm.org/viewvc/llvm-project?rev=259565=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc2/ (props changed) - copied from r259564,

Re: r259598 - Work around build failure due to GCC 4.8.1 bug. We don't completely understand

Yes! r259603. Cheers, Hans On Tue, Feb 2, 2016 at 3:17 PM, Richard Smith wrote: > Hans, this fixes a compile failure with one of our supported host > compilers (GCC 4.8.1). Can we get this patch into 3.8? > > On Tue, Feb 2, 2016 at 3:11 PM, Richard Smith via cfe-commits >

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

Yes, that seems like a good idea. Go ahead and merge (or let me know if you'd prefer me to do it). On Fri, Jan 29, 2016 at 3:14 PM, Alexey Samsonov wrote: > Hans, do you think it makes sense to merge this patch into 3.8? > > On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

On Fri, Jan 29, 2016 at 4:50 PM, Alexey Samsonov wrote: > > On Fri, Jan 29, 2016 at 3:16 PM, Hans Wennborg wrote: >> >> Yes, that seems like a good idea. Go ahead and merge (or let me know >> if you'd prefer me to do it). > > > I'd appreciate if you could

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Wed, Feb 3, 2016 at 1:00 PM, Richard Smith wrote: > On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova > wrote: >> >> I think the main reason is that we have committed pipe type before the >> release branch was taken. It appears to have no use

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

I'm OK if Marshall is. Thanks, Hans On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via cfe-commits wrote: > Hans, do you mind merging this to the 3.8 branch? > > Marshall, do you agree this is okay to take? > >> On 2016-Feb-03, at 11:30, Duncan P. N. Exon

Re: r259210 - Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

This broke tests: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/44018/steps/test_clang/logs/Clang-Unit%20%3A%3A%20ASTMatchers__Dynamic__DynamicASTMatchersTests__RegistryTest.Errors I've reverted it in r259218. Thanks, Hans On Fri, Jan 29, 2016 at 9:03 AM, Aaron Ballman via

r259218 - Revert r259210 "Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes."

Author: hans Date: Fri Jan 29 12:24:34 2016 New Revision: 259218 URL: http://llvm.org/viewvc/llvm-project?rev=259218=rev Log: Revert r259210 "Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to

Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

On Sat, Feb 20, 2016 at 6:29 AM, Hal Finkel wrote: > > > - Original Message - >> From: "Dimitry Andric via cfe-commits" >> To: "Hans Wennborg" >> Cc: "Roman Divacky" , "cfe-commits" >>

Re: r261717 - Default vaarg lowering should support indirect struct types.

On Wed, Feb 24, 2016 at 5:11 AM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits > wrote: >> Author: jyknight >> Date: Tue Feb 23 20:59:33 2016 >> New Revision: 261717 >> >> URL:

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

I'm sorry, but I had to revert this in order to revert r261634. r261657 On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Tue Feb 23 11:13:47 2016 > New Revision: 261657 > > URL:

r261670 - Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657

Author: hans Date: Tue Feb 23 13:10:16 2016 New Revision: 261670 URL: http://llvm.org/viewvc/llvm-project?rev=261670=rev Log: Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657 r261634 and r261633 seems to have caused PR26715. r261657 depends on

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

On Tue, Feb 23, 2016 at 11:15 AM, Hans Wennborg wrote: > I'm sorry, but I had to revert this in order to revert r261634. r261657 Meant to say the revert is in r261670. > > On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits > wrote: >>

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

On Tue, Feb 23, 2016 at 11:12 AM, Aaron Ballman wrote: > On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote: >> Hi Aaron, >> >> I'll let it sit in the tree for a bit, and will then merge it later today. > > Sounds great, thank you! r261684. >> Many

[libcxx] r261690 - Creating release candidate rc3 from release_380 branch

Author: hans Date: Tue Feb 23 15:40:01 2016 New Revision: 261690 URL: http://llvm.org/viewvc/llvm-project?rev=261690=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxx/tags/RELEASE_380/rc3/ (props changed) - copied from r261689, libcxx/branches/release_38/

[libunwind] r261697 - Creating release candidate rc3 from release_380 branch

Author: hans Date: Tue Feb 23 15:40:24 2016 New Revision: 261697 URL: http://llvm.org/viewvc/llvm-project?rev=261697=rev Log: Creating release candidate rc3 from release_380 branch Added: libunwind/tags/RELEASE_380/rc3/ - copied from r261696, libunwind/branches/release_38/

[libcxxabi] r261691 - Creating release candidate rc3 from release_380 branch

Author: hans Date: Tue Feb 23 15:40:04 2016 New Revision: 261691 URL: http://llvm.org/viewvc/llvm-project?rev=261691=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc3/ (props changed) - copied from r261690,

Re: [PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Very nice! I only have some style nits, really. Look forward to using this :-) Comment at: include/clang/Basic/DiagnosticDriverKinds.td:112 @@ +111,3 @@ +def

[clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

Author: hans Date: Mon Feb 29 15:17:39 2016 New Revision: 262257 URL: http://llvm.org/viewvc/llvm-project?rev=262257=rev Log: IdentifierNamingCheck.cpp: try to fix MSVC build It was failing to build with: clang-tidy\readability\IdentifierNamingCheck.cpp(640): error C2882: 'format' : illegal use

r261583 - Fix Visual Studio build after r261574

Author: hans Date: Mon Feb 22 16:21:58 2016 New Revision: 261583 URL: http://llvm.org/viewvc/llvm-project?rev=261583=rev Log: Fix Visual Studio build after r261574 Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified:

Re: [libcxxabi] r257896 - Revert r256322 (and follow-up 256323), the test it added does not pass on OS X.

Merged to 3.8 in r258186. (See discussion on the r256323 commit). On Fri, Jan 15, 2016 at 7:44 AM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Fri Jan 15 09:44:14 2016 > New Revision: 257896 > > URL: http://llvm.org/viewvc/llvm-project?rev=257896=rev >

[libcxxabi] r258186 - Merging r257896:

Author: hans Date: Tue Jan 19 15:06:49 2016 New Revision: 258186 URL: http://llvm.org/viewvc/llvm-project?rev=258186=rev Log: Merging r257896: r257896 | nico | 2016-01-15 07:44:14 -0800 (Fri, 15 Jan 2016) | 1 line Revert

Re: [libcxxabi] r256323 - Add new tests for throwing incomplete pointer types

Actually, I'll go ahead and merge Nico's revert to 3.8 for now to unbreak the build there, and then I'll be happy to merge fixes when you've looked into it. Sorry for the double messaging. On Tue, Jan 19, 2016 at 9:43 AM, Hans Wennborg wrote: > That sounds great. Thanks! > >

Re: [libcxxabi] r256323 - Add new tests for throwing incomplete pointer types

That sounds great. Thanks! On Tue, Jan 19, 2016 at 9:33 AM, Eric Fiselier wrote: > Hi Hans, > > Can I have today to work on this? If I can't come up with a fix we can > revert tommorow. > I'll ping you tommorow with the result. > > Does that work? > > /Eric > > On Tue, Jan 19, 2016

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

hans added a subscriber: dim. hans added a comment. +dim who said the locale tests were also failing for him on FreeBSD. Maybe this is relevant? http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

I'm fine with it. Alex, what do you think? On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman wrote: > Uncertain whether this meets the bar for inclusion in 3.8. > clang-modernize was moved into clang-tidy and from what I can tell, it > did not suffer from this crash. I

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

Thanks. Aaron, do you want to go ahead and merge this with utils/release/merge.sh? Or let me know if you'd prefer me to do the merge. On Thu, Jan 21, 2016 at 10:00 AM, Alexander Kornienko wrote: > I'm fine with including this to 3.8. BTW, I'm working on release notes. > > On

Re: r258394 - [OPENMP] Fix crash on reduction for complex variables.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Thu, Jan 21, 2016 at 4:35 AM, Alexey Bataev via cfe-commits

Re: r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Richard, it was suggested (in https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged to 3.8. I believe this falls under your ownership. On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Thu Jan 21 06:54:48

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Wed, Jan 20, 2016 at 4:29 AM, Alexey Bataev via cfe-commits

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

It seems Richard is out of office, but perhaps he can verify this later. Dimitry: go ahead and merge it (or let me know if you'd like me to). On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric wrote: > Hans, > > This change looks pretty trivial, and is required to not crash

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

Joerg, do you want to go ahead and merge this to 3.8 with utils/release/merge.sh? (Or let me know if you'd prefer me to do it.) On Sun, Jan 24, 2016 at 11:29 PM, Richard Smith wrote: > Approved for branch. > > On 23 Jan 2016 11:56 p.m., "Joerg Sonnenberger"

Re: [PATCH] D16511: [MSVC Compat] Only warn for unknown clang-cl arguments

hans added a subscriber: hans. hans added a comment. Maybe this behavior should be called out in the Command-Line Options section under clang-cl in docs/UsersManual.rst? http://reviews.llvm.org/D16511 ___ cfe-commits mailing list

[libcxxabi] r258235 - Creating release directory for release_380.

Author: hans Date: Tue Jan 19 17:41:04 2016 New Revision: 258235 URL: http://llvm.org/viewvc/llvm-project?rev=258235=rev Log: Creating release directory for release_380. Added: libcxxabi/tags/RELEASE_380/ ___ cfe-commits mailing list

[libcxx] r258233 - Creating release directory for release_380.

Author: hans Date: Tue Jan 19 17:40:59 2016 New Revision: 258233 URL: http://llvm.org/viewvc/llvm-project?rev=258233=rev Log: Creating release directory for release_380. Added: libcxx/tags/RELEASE_380/ ___ cfe-commits mailing list

[libcxx] r258234 - Creating release candidate rc1 from release_380 branch

Author: hans Date: Tue Jan 19 17:41:02 2016 New Revision: 258234 URL: http://llvm.org/viewvc/llvm-project?rev=258234=rev Log: Creating release candidate rc1 from release_380 branch Added: libcxx/tags/RELEASE_380/rc1/ (props changed) - copied from r258233, libcxx/branches/release_38/

Re: [Diffusion] rL257984: [Cygwin] Use -femulated-tls by default since r257718 introduced the new pass.

On Tue, Jan 19, 2016 at 3:43 PM, NAKAMURA Takumi wrote: > May I push it (llvm and clang) into release_38? > It depends on r257718. r257718 was committed after the branch. Are you suggesting we merge that too? This looks like a pretty significant change. Can't it wait until

[libcxxabi] r258236 - Creating release candidate rc1 from release_380 branch

Author: hans Date: Tue Jan 19 17:41:06 2016 New Revision: 258236 URL: http://llvm.org/viewvc/llvm-project?rev=258236=rev Log: Creating release candidate rc1 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc1/ (props changed) - copied from r258235,

[libunwind] r258248 - Creating release candidate rc1 from release_380 branch

Author: hans Date: Tue Jan 19 17:41:33 2016 New Revision: 258248 URL: http://llvm.org/viewvc/llvm-project?rev=258248=rev Log: Creating release candidate rc1 from release_380 branch Added: libunwind/tags/RELEASE_380/rc1/ - copied from r258247, libunwind/branches/release_38/

[libunwind] r258247 - Creating release directory for release_380.

Author: hans Date: Tue Jan 19 17:41:31 2016 New Revision: 258247 URL: http://llvm.org/viewvc/llvm-project?rev=258247=rev Log: Creating release directory for release_380. Added: libunwind/tags/RELEASE_380/ ___ cfe-commits mailing list

Re: [clang-tools-extra] r258327 - Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use

On Wed, Jan 20, 2016 at 11:00 AM, Jonathan Roelofs wrote: > > > On 1/20/16 11:53 AM, Dimitry Andric via cfe-commits wrote: >> >> Author: dim >> Date: Wed Jan 20 12:53:44 2016 >> New Revision: 258327 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=258327=rev >> Log:

Re: [libcxxabi] r258249 - Recommit r256322: Fix PR25898 - Check for incomplete pointers types in can_catch(...)

No problem. Please go ahead and merge with utils/release/merge.sh, or let me know if you'd prefer me to do it. On Tue, Jan 19, 2016 at 7:09 PM, Eric Fiselier wrote: > Hi Hans, > > Sorry to make this more complicated, but can you also include the follow-up > libc++abi commit

<    1   2   3   4   5   6   7   8   9   10   >