[clang-tools-extra] r275980 - [include-fixer] A refactoring of IncludeFixerContext.

Author: hokein Date: Tue Jul 19 09:49:04 2016 New Revision: 275980 URL: http://llvm.org/viewvc/llvm-project?rev=275980=rev Log: [include-fixer] A refactoring of IncludeFixerContext. Summary: No functional changes in this patch. It is a refactoring (pull out a structure representing the symbol

Re: [PATCH] D22510: [include-fixer] A refactoring of IncludeFixerContext.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275980: [include-fixer] A refactoring of IncludeFixerContext. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D22510?vs=64481=64502#toc Repository: rL LLVM

[clang-tools-extra] r276096 - [include-fixer] Tweak: remove unintended const.

Author: hokein Date: Wed Jul 20 04:00:22 2016 New Revision: 276096 URL: http://llvm.org/viewvc/llvm-project?rev=276096=rev Log: [include-fixer] Tweak: remove unintended const. Modified: clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp

[PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D22567 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

Re: [PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

hokein updated this revision to Diff 63796. hokein marked 6 inline comments as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D22299 Files: include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

Re: [PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

hokein marked an inline comment as done. Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252 @@ +251,3 @@ +// Only accept an unique header. +bool IsUniqueHeader = +std::adjacent_find(HeaderInfos.begin(), HeaderInfos.end(), You are right.

Re: [PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

hokein updated this revision to Diff 63799. hokein marked 2 inline comments as done. hokein added a comment. Add comments for std::equal. http://reviews.llvm.org/D22299 Files: include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h

Re: [PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

hokein added inline comments. Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252 @@ +251,3 @@ +assert(!HeaderInfos.empty()); +// Only accept an unique header. +bool IsUniqueHeader = std::equal( bkramer wrote: > In that case adjacent_find was the

Re: [PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

hokein updated this revision to Diff 63808. hokein marked an inline comment as done. hokein added a comment. Fix nits. http://reviews.llvm.org/D22299 Files: include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

[clang-tools-extra] r275781 - [include-fixer] Add an options allow moving the cursor to #include line in vim

Author: hokein Date: Mon Jul 18 05:04:45 2016 New Revision: 275781 URL: http://llvm.org/viewvc/llvm-project?rev=275781=rev Log: [include-fixer] Add an options allow moving the cursor to #include line in vim after inserting a missing header. Summary: A small improvement: Don't print newline

Re: [PATCH] D22367: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

hokein updated this revision to Diff 64104. hokein marked an inline comment as done. hokein added a comment. Add comment. https://reviews.llvm.org/D22367 Files: include-fixer/IncludeFixerContext.cpp unittests/include-fixer/IncludeFixerTest.cpp Index:

Re: [PATCH] D21470: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273849: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21470?vs=61092=61938#toc Repository: rL LLVM

[PATCH] D21747: [clang-tidy] Warning enum unused using declarations.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D21747 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-using-decls.cpp

[clang-tools-extra] r273849 - [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.

Author: hokein Date: Mon Jun 27 03:04:01 2016 New Revision: 273849 URL: http://llvm.org/viewvc/llvm-project?rev=273849=rev Log: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

[PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

hokein created this revision. hokein added a reviewer: alexfh. hokein added subscribers: cfe-commits, Eugene.Zelenko. Fix PR28350. http://reviews.llvm.org/D21833 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index:

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein updated this revision to Diff 62849. hokein marked 2 inline comments as done. hokein added a comment. Address Ben's comments. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/SymbolIndexManager.cpp

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein added a comment. In http://reviews.llvm.org/D21603#475011, @bkramer wrote: > In the future I'd prefer to have patches like this split up in a part that > refactors and a part that contains the actual change. Having that in one > patch makes it really hard to review. Acknowledged. I'm

[clang-tools-extra] r274848 - [include-fixer] Don't add qualifiers to symbols which have global scope operator.

Author: hokein Date: Fri Jul 8 09:28:43 2016 New Revision: 274848 URL: http://llvm.org/viewvc/llvm-project?rev=274848=rev Log: [include-fixer] Don't add qualifiers to symbols which have global scope operator. Reviewers: bkramer Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274848: [include-fixer] Don't add qualifiers to symbols which have global scope… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22127?vs=63221=63223#toc Repository: rL LLVM

[clang-tools-extra] r274845 - [include-fixer] Pull out Context implementation code to a cpp file.

Author: hokein Date: Fri Jul 8 08:11:38 2016 New Revision: 274845 URL: http://llvm.org/viewvc/llvm-project?rev=274845=rev Log: [include-fixer] Pull out Context implementation code to a cpp file. Added: clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp Modified:

Re: [PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

hokein updated this revision to Diff 63221. hokein added a comment. Rebase to master. http://reviews.llvm.org/D22127 Files: include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h unittests/include-fixer/IncludeFixerTest.cpp Index:

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

This revision was automatically updated to reflect the committed changes. Closed by commit rL274839: [clang-rename] fix typo in Python script for Vim integration (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22100?vs=63101=63203#toc Repository: rL LLVM

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D22100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22154: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. Although there is no guarantee of getOptions/getRawOptions receiving an absolute path, we try to make it if possible. So FileOptionProvider subclasses don't have to convert the path to an

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein added inline comments. Comment at: unittests/include-fixer/IncludeFixerTest.cpp:144 @@ -141,1 +143,3 @@ +runIncludeFixer("a::b::foo bar;\n", +/*FixNamespaceQualifiers=*/true, IncludePath)); djasper wrote: > I think

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein updated this revision to Diff 63043. hokein marked 3 inline comments as done. hokein added a comment. - Address Daniel's comments. - Add tests for nested classes. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

hokein added inline comments. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48 @@ +47,3 @@ + + // Assignement slicing: "a = b;" and "a = std::move(b);" variants. + const auto SlicesObjectInAssignment = Looks like you are missing some cases here,

[clang-tools-extra] r275051 - [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

Author: hokein Date: Mon Jul 11 02:47:04 2016 New Revision: 275051 URL: http://llvm.org/viewvc/llvm-project?rev=275051=rev Log: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions. Summary: Although there is no guarantee of getOptions/getRawOptions receiving an absolute

Re: [PATCH] D22154: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275051: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22154?vs=63282=63469#toc Repository: rL

[clang-tools-extra] r274832 - [include-fixer] Add missing namespace qualifiers after inserting a missing header.

Author: hokein Date: Fri Jul 8 04:10:29 2016 New Revision: 274832 URL: http://llvm.org/viewvc/llvm-project?rev=274832=rev Log: [include-fixer] Add missing namespace qualifiers after inserting a missing header. Summary: This is an initial version of fixing namespace issues by adding missing

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274832: [include-fixer] Add missing namespace qualifiers after inserting a missing… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21603?vs=63043=63189#toc Repository: rL

[PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D22127 Files: include-fixer/IncludeFixerContext.h unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

hokein added inline comments. Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87 @@ +86,3 @@ +// Capture the depth and types of indirections for the passed buffer. +while (true) { + if (BufferType->isPointerType()) { check whether `BufferType` is

Re: [PATCH] D23199: [include-fixer] Correct some header mappings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277811: [include-fixer] Correct some header mappings. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23199?vs=66926=66930#toc Repository: rL LLVM

[clang-tools-extra] r277811 - [include-fixer] Correct some header mappings.

Author: hokein Date: Fri Aug 5 06:54:34 2016 New Revision: 277811 URL: http://llvm.org/viewvc/llvm-project?rev=277811=rev Log: [include-fixer] Correct some header mappings. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D23199 Modified:

[PATCH] D23199: [include-fixer] Correct some header mappings.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D23199 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein updated this revision to Diff 67172. hokein added a comment. Add missing tests. https://reviews.llvm.org/D23266 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein updated this revision to Diff 67171. hokein added a comment. Remove unneeded header. https://reviews.llvm.org/D23266 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein updated this revision to Diff 67178. hokein marked 2 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D23266 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.cpp

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

hokein added inline comments. Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1 @@ +1,2 @@ +#include + Usually test should not use STL headers as it relies on the system headers. You don't have to use std::string to reproduce the

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein added a comment. > Can you add a lit test for this? We should've added that earlier :| I forgot to upload the test first time. But I have already uploaded it, see `multiple_fixes.cpp` Comment at: include-fixer/IncludeFixerContext.h:78 @@ -72,1 +77,3 @@ + /// \brief

[PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to include-fixer, include-fixer will apply all replacements to the first argument, which probably causes crashes.

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D22729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r278102 - [include-fixer] Support processing multiple files in one run.

Author: hokein Date: Tue Aug 9 03:26:19 2016 New Revision: 278102 URL: http://llvm.org/viewvc/llvm-project?rev=278102=rev Log: [include-fixer] Support processing multiple files in one run. Summary: Previously, if we pass multiple files or a file pattern (e.g. /path/to/*.cc) to include-fixer,

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278102: [include-fixer] Support processing multiple files in one run. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23266?vs=67294=67296#toc Repository: rL LLVM

Re: [PATCH] D23266: [include-fixer] Support processing multiple files in one run.

hokein updated this revision to Diff 67294. hokein added a comment. Update comments, don't mention absolute file path since this is no guarantee about that. https://reviews.llvm.org/D23266 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

hokein added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:66 @@ -66,1 +65,3 @@ + // Fixes grouped by file path. + std::map Fix; SmallVector Notes; Use llvm::StringMap here?

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) I think

Re: [PATCH] D23006: [clang-rename] add basic Emacs integration

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. lgtm with two nits. Comment at: clang-rename/tool/CMakeLists.txt:14 @@ +13,3 @@ + +install(PROGRAMS clang-rename.el + DESTINATION share/clang Also include

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

hokein added a comment. Seems that you only uploaded the diff part, I only see the updated part of your patch now, and can't see the whole patch now (The review page says "Context not available"), could you upload the whole patch again? Comment at:

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

hokein accepted this revision. hokein added a comment. Looks good now. Do you need I submit for you? https://reviews.llvm.org/D21992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r277142 - [ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument support in functionDecl.

s is not templateName patch. The templateName one is in r277155. > > > > On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer <benny@gmail.com> > > wrote: > >> > >> On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits > >> <cfe-commits@l

r277174 - Fix a typo in document.

Author: hokein Date: Fri Jul 29 12:30:13 2016 New Revision: 277174 URL: http://llvm.org/viewvc/llvm-project?rev=277174=rev Log: Fix a typo in document. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified:

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

hokein updated this revision to Diff 62354. hokein added a comment. enumType is already in ASTMatcher now. http://reviews.llvm.org/D21833 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-using-decls.cpp

r274217 - [ASTMatcher] Add a node matcher for EnumType.

Author: hokein Date: Thu Jun 30 02:50:01 2016 New Revision: 274217 URL: http://llvm.org/viewvc/llvm-project?rev=274217=rev Log: [ASTMatcher] Add a node matcher for EnumType. Reviewers: aaron.ballman Subscribers: cfe-commits, klimek Differential Revision: http://reviews.llvm.org/D21860

Re: [PATCH] D21860: [ASTMatcher] Add a node matcher for EnumType.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274217: [ASTMatcher] Add a node matcher for EnumType. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21860?vs=62277=62340#toc Repository: rL LLVM

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein updated this revision to Diff 62383. hokein marked 4 inline comments as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/SymbolIndexManager.cpp

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein updated this revision to Diff 62473. hokein marked 5 inline comments as done. hokein added a comment. Fix review comments. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/SymbolIndexManager.cpp

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

hokein added inline comments. Comment at: include-fixer/IncludeFixer.cpp:258 @@ +257,3 @@ + +// Query the symbol based on C++ name Lookup rules. +// Firstly, lookup the identifier with scoped namespace contexts; If fails, djasper wrote: > Could you add

[clang-tools-extra] r274496 - [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

Author: hokein Date: Mon Jul 4 07:01:56 2016 New Revision: 274496 URL: http://llvm.org/viewvc/llvm-project?rev=274496=rev Log: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check. Summary: Fix PR28350. Reviewers: alexfh Subscribers: aaron.ballman, Eugene.Zelenko,

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274496: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21833?vs=62354=62668#toc Repository: rL

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

hokein added a comment. In http://reviews.llvm.org/D21603#468717, @djasper wrote: > Sorry, I completely forgot about this. Will try to review today. Is this part > about the patch description accurate? Yes, the description is accurate. > Specifically, what needs to be implemented in vim to

[PATCH] D21860: [ASTMatcher] Add a node matcher for EnumType.

hokein created this revision. hokein added a reviewer: aaron.ballman. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D21860 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

hokein updated this revision to Diff 62278. hokein added a comment. Address review comments. http://reviews.llvm.org/D21833 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-using-decls.cpp

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

hokein marked an inline comment as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22 @@ +21,3 @@ +namespace { +// FIXME: Move this node matcher to ASTMatcher. +const internal::VariadicDynCastAllOfMatcher enumType; Done in D21860.

[PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D23544 Files: clang-tidy/readability/ImplicitBoolCastCheck.cpp clang-tidy/readability/ImplicitBoolCastCheck.h Index: clang-tidy/readability/ImplicitBoolCastCheck.h

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

hokein updated this revision to Diff 68154. hokein added a comment. Move ctor body to .cpp file. https://reviews.llvm.org/D23544 Files: clang-tidy/readability/ImplicitBoolCastCheck.cpp clang-tidy/readability/ImplicitBoolCastCheck.h Index: clang-tidy/readability/ImplicitBoolCastCheck.h

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278791: [clang-tidy] readability-implicit-bool-cast forgets to store its options. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23544?vs=68154=68158#toc Repository: rL

[clang-tools-extra] r278791 - [clang-tidy] readability-implicit-bool-cast forgets to store its options.

Author: hokein Date: Tue Aug 16 06:15:05 2016 New Revision: 278791 URL: http://llvm.org/viewvc/llvm-project?rev=278791=rev Log: [clang-tidy] readability-implicit-bool-cast forgets to store its options. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

[clang-tools-extra] r278922 - [include-fixer] Update -help message.

Author: hokein Date: Wed Aug 17 06:31:19 2016 New Revision: 278922 URL: http://llvm.org/viewvc/llvm-project?rev=278922=rev Log: [include-fixer] Update -help message. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp Modified:

[clang-tools-extra] r295048 - [clang-tidy] Improve diagnostic message for misc-definitions-in-header.

Author: hokein Date: Tue Feb 14 06:39:22 2017 New Revision: 295048 URL: http://llvm.org/viewvc/llvm-project?rev=295048=rev Log: [clang-tidy] Improve diagnostic message for misc-definitions-in-header. Summary: Users might get confused easily when they see the check's message on full template

[clang-tools-extra] r295178 - [clang-tidy] Ignore instantiated functions and static data members of classes in misc-definitions-in-headers.

Author: hokein Date: Wed Feb 15 08:10:50 2017 New Revision: 295178 URL: http://llvm.org/viewvc/llvm-project?rev=295178=rev Log: [clang-tidy] Ignore instantiated functions and static data members of classes in misc-definitions-in-headers. Reviewers: alexfh Reviewed By: alexfh Subscribers:

[clang-tools-extra] r292098 - [clang-move] Dump enum and type alias declarations.

Author: hokein Date: Mon Jan 16 03:34:07 2017 New Revision: 292098 URL: http://llvm.org/viewvc/llvm-project?rev=292098=rev Log: [clang-move] Dump enum and type alias declarations. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D28293 Modified:

[clang-tools-extra] r292215 - [clang-move] Handle helpers with forward declarations.

Author: hokein Date: Tue Jan 17 07:22:37 2017 New Revision: 292215 URL: http://llvm.org/viewvc/llvm-project?rev=292215=rev Log: [clang-move] Handle helpers with forward declarations. Reviewers: ioeric Reviewed By: ioeric Subscribers: cfe-commits Differential Revision:

[clang-tools-extra] r292207 - [clang-move] Ignore using decls which are defined in macros.

Author: hokein Date: Tue Jan 17 04:08:11 2017 New Revision: 292207 URL: http://llvm.org/viewvc/llvm-project?rev=292207=rev Log: [clang-move] Ignore using decls which are defined in macros. Summary: Also ignore helpers which are defined in macro. Currently clang-move doesn't handle macro well

[clang-tools-extra] r292218 - Remove dead code.

Author: hokein Date: Tue Jan 17 07:46:59 2017 New Revision: 292218 URL: http://llvm.org/viewvc/llvm-project?rev=292218=rev Log: Remove dead code. Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp URL:

[clang-tools-extra] r296337 - [clang-move] Extend clang-move to support moving global variable.

Author: hokein Date: Mon Feb 27 07:19:13 2017 New Revision: 296337 URL: http://llvm.org/viewvc/llvm-project?rev=296337=rev Log: [clang-move] Extend clang-move to support moving global variable. Summary: Also support dumping global variables. Reviewers: ioeric Reviewed By: ioeric Subscribers:

[clang-tools-extra] r296461 - [find-all-symbols] Implement operator== for SymbolAndSignals and SymbolInfo::Signals.

Author: hokein Date: Tue Feb 28 04:13:26 2017 New Revision: 296461 URL: http://llvm.org/viewvc/llvm-project?rev=296461=rev Log: [find-all-symbols] Implement operator== for SymbolAndSignals and SymbolInfo::Signals. Modified:

r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.

Author: hokein Date: Tue Feb 28 03:03:07 2017 New Revision: 296453 URL: http://llvm.org/viewvc/llvm-project?rev=296453=rev Log: [clang-format] Fix test failure caused by "rm" on some buildbots. The begining command "rm" will return 1 when there is not such file to delete. This patch is to

[clang-tools-extra] r296479 - [clang-tidy] Fix a false positive on modernize-use-nullptr check.

Author: hokein Date: Tue Feb 28 09:29:52 2017 New Revision: 296479 URL: http://llvm.org/viewvc/llvm-project?rev=296479=rev Log: [clang-tidy] Fix a false positive on modernize-use-nullptr check. Summary: The false positive happens on two neighbour CXXDefaultArgExpr AST nodes. like below: ```

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70363. hokein added a comment. Fix function name style. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

hokein added a comment. some initial comments. Comment at: change-namespace/CMakeLists.txt:9 @@ +8,3 @@ + LINK_LIBS + clangAST + clangBasic I think `clangASTMatchers` is needed here. Comment at: change-namespace/ChangeNamespace.cpp:21 @@

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein created this revision. hokein added a subscriber: cfe-commits. This patch introduces a new tool which moves a specific class definition from files (.h, .cc) to new files (.h, .cc), which mostly acts like "Extract class defintion". In the long term, this tool should be merged in to

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70362. hokein added a comment. Minor cleanup. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.cpp

[clang-tools-extra] r280359 - [include-fixer] Fix an undefined variable exception in vim script when there is

Author: hokein Date: Thu Sep 1 07:17:28 2016 New Revision: 280359 URL: http://llvm.org/viewvc/llvm-project?rev=280359=rev Log: [include-fixer] Fix an undefined variable exception in vim script when there is only one candidate header. Modified:

Re: [PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D24179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r280095 - [clang-tidy docs] Fix build errors on Sphinx 1.4.6

Author: hokein Date: Tue Aug 30 09:29:36 2016 New Revision: 280095 URL: http://llvm.org/viewvc/llvm-project?rev=280095=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.6 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-suspicious-string-compare.rst

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69679. hokein marked an inline comment as done. hokein added a comment. - Use empty string words. - rebase to master. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

Re: [PATCH] D24075: [include-fixer] Support finding headers for the symbol under cursor.

hokein added a comment. + Jens for reviewing emacs integration part. https://reviews.llvm.org/D24075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70538. hokein marked 19 inline comments as done. hokein added a comment. Herald added a subscriber: beanz. - Address review comments. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp

Re: [PATCH] D24075: [include-fixer] Support finding headers for the symbol under cursor.

hokein updated this revision to Diff 70545. hokein marked an inline comment as done. hokein updated the summary for this revision. hokein added a comment. bool => boolean https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:38 @@ +37,3 @@ + const clang::Module * /*Imported*/) override { +if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) { + if (IsAngled) {

Re: [PATCH] D24075: [include-fixer] Support finding headers for the symbol under cursor.

hokein marked an inline comment as done. Comment at: include-fixer/tool/clang-include-fixer.el:204 @@ -197,3 +203,3 @@ (message (concat "Calling the include fixer. " "This might take some seconds. Please wait.")) massberg wrote: > Is this message

Re: [PATCH] D24075: [include-fixer] Support finding headers for the symbol under cursor.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL280824: [include-fixer] Support finding headers for the symbol under cursor. (authored by hokein). Changed prior to commit:

[clang-tools-extra] r280824 - [include-fixer] Support finding headers for the symbol under cursor.

Author: hokein Date: Wed Sep 7 11:34:35 2016 New Revision: 280824 URL: http://llvm.org/viewvc/llvm-project?rev=280824=rev Log: [include-fixer] Support finding headers for the symbol under cursor. Summary: * Add a `query-symbol` option to query symbol without parsing the source file. * Update

Re: [PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein updated this revision to Diff 69994. hokein added a comment. Add editor scripts support. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-include-fixer.el

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69812. hokein marked 26 inline comments as done. hokein added a comment. Address aaron's comments. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein added a comment. wow, thanks for many detailed comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not contain "." prefix). "h,hh,hpp,hxx" by default. For + extension-less header files, using an empty string or

[PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/query_symbol.cpp Index:

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69839. hokein added a comment. Update HeaderFileExtensions doc for all documents. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-namespaces.rst

<    1   2   3   4   5   6   7   8   9   10   >