[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 311208. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 Files: clang/include/clang/Driver/Options.td

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311217. jansvoboda11 added a comment. Remove whitespace change, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files:

[PATCH] D84188: Port FileSystem options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84188/new/

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311198. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp Index:

[PATCH] D92857: [clang][cli] [clang][cli] Don't always emit -f[no-]legacy-pass-manager

jansvoboda11 updated this revision to Diff 311193. jansvoboda11 added a comment. Extract default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files:

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 updated this revision to Diff 311216. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93094/new/ https://reviews.llvm.org/D93094 Files: clang/include/clang/Driver/Options.td

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D84018 ___ cfe-commits

[PATCH] D93215: [clang][cli] Squash exception model in LangOptions into one member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG573255b47eb9: [clang][cli] Squash exception model in LangOptions into one member (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93216: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56c5548d7f07: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93214: [clang][cli] Create accessors for exception models in LangOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf24e58df7ddf: [clang][cli] Create accessors for exception models in LangOptions (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287 +static void +denormalizeString(SmallVectorImpl , const char *Spelling, + CompilerInvocation::StringAllocator SA, unsigned, T &) { dexonsmith wrote: >

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1); ASSERT_THAT(GeneratedArgs,

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 updated this revision to Diff 312785. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 Files: clang/include/clang/Driver/Options.td

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese, bader, ABataev. Herald added subscribers: Anastasia, ebevhan, yaxunl. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D84675: Streamline MarhsallingInfoFlag description

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/

[PATCH] D84675: [clang][cli] Streamline MarhsallingInfoFlag description

jansvoboda11 updated this revision to Diff 312790. jansvoboda11 added a comment. Rebase, remove `DefaultValue` to avoid confusion with `Default` used for `BoolOptionBase`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/

[PATCH] D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class

jansvoboda11 updated this revision to Diff 312761. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/ https://reviews.llvm.org/D84189 Files: clang/include/clang/Driver/Options.td

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Hi Kevin, sorry for the late response. I don't think adding new tests is necessary as long as the flag is used in existing ones. Comment at:

[PATCH] D82860: Port ObjCMTAction to new option parsing system

This revision was automatically updated to reflect the committed changes. Closed by commit rG09248a5d25bb: [clang][cli] Port ObjCMTAction to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304491. jansvoboda11 added a comment. Apply unique_ptr workaround for older Clang versions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files:

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304487. jansvoboda11 added a comment. Rebase on top of recent changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files:

[PATCH] D90507: Adding DWARF64 clang flag

jansvoboda11 added a comment. Hi @ayermolo, do you think this might be triggered by D82756 ? (my only upstream patch ATM) Comment at: clang/test/Driver/debug-options.c:377 // NO_DEBUG_UNUSED_TYPES:

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 added a comment. Thank you for the heads-up. It seems like Clang 5 didn't like the usage of `static constexpr` member via an instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860

[PATCH] D91368: Frontend: Split out addVFSOverlays from createVFSFromCompilerInvocation, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91368/new/ https://reviews.llvm.org/D91368 ___ cfe-commits mailing list

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

jansvoboda11 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91295/new/ https://reviews.llvm.org/D91295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91366/new/ https://reviews.llvm.org/D91366 ___ cfe-commits mailing list

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 added a comment. Getting rid of the duplication is definitely nice. I left one inline question about the terminology used. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal;

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91436/new/ https://reviews.llvm.org/D91436 ___ cfe-commits mailing list

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 305437. jansvoboda11 added a comment. Rebase and add documenting possible reference lifetime extension issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added a comment. Addressed review feedback. WDYT @Bigcheese? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH);

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D83071: Add support for options with two flags for controlling the same field.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3055c543f8: [clang][cli] Add support for options with two flags for controlling the same… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang. Herald added projects: clang, LLVM. jansvoboda11 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91861 Files: clang/include/clang/Driver/Options.td

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 306668. jansvoboda11 added a comment. Rebase, undo the move of options, introduce makeFlagToValueNormalizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files:

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this revision as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83697: Port Frontend option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83697: Port Frontend option flags to new option parsing system

jansvoboda11 updated this revision to Diff 306675. jansvoboda11 added a comment. Herald added a reviewer: sscalpone. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase, undo move of options, implement IsNegative. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:473 +MarshallingInfoFlag<"DependencyOutputOpts.OutputFormat", "DependencyOutputFormat::Make">, +Normalizer<"makeFlagToValueNormalizer(DependencyOutputFormat::NMake)">; def Mach :

[PATCH] D83315: Turn arcmt-* options into a single option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 updated this revision to Diff 306042. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 Files: clang/include/clang/Driver/Options.td

[PATCH] D83690: Port Migator option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83690/new/

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over the revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 updated this revision to Diff 306047. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 Files: clang/include/clang/Driver/Options.td

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83315: Turn arcmt-* options into a single option

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83315/new/

[PATCH] D83690: Port Migator option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e6fc2fa532c: [clang][cli] Port Migrator option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Herald added a subscriber: steakhal. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2be569870486: [clang][cli] Add ability to make fixups to CompilerInvocation after option… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e696d895bde: [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83406/new/

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 306035. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/

[PATCH] D83691: Port Comment option flags to new parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1702a297b8b: [clang][cli] Port Comment option flags to new parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 added a comment. Thanks. Committing this without the NFC change. Comment at: clang/include/clang/Driver/Options.td:407 + +def fparse_all_comments : Flag<["-"], "fparse-all-comments">, Group, Flags<[CC1Option]>, +

[PATCH] D83693: Port analyzer flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a0ea120e2a1: [clang][cli] Port analyzer flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. WDYT @Bigcheese? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 updated this revision to Diff 303828. jansvoboda11 added a comment. Rebase on top of D82756 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90957/new/ https://reviews.llvm.org/D90957 ___ cfe-commits mailing list

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks, `Jan Svoboda` and `jan_svob...@apple.com` is fine. Is it possible to add @dang as a co-author? `git log` says he uses `Daniel Grumberg` and `dany.grumb...@gmail.com`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. @dexonsmith, could you please commit this one for me? I don't have the rights to do so, as this is my first patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 added a comment. Thanks for the feedback. I left some comments inline and will update the patch accordingly. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3762-3764 +this->KEYPATH = MERGER(this->KEYPATH, DEFAULT_VALUE); \ +if

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 updated this revision to Diff 307028. jansvoboda11 added a comment. Add tests, fix condition in generator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91861/new/ https://reviews.llvm.org/D91861 Files:

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307034. jansvoboda11 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reduce template instantiations, remove names of unused parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307037. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files: clang/include/clang/Driver/Options.td

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 ___ cfe-commits mailing list

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks for the feedback. @Bigcheese do you have anything to add? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301564. jansvoboda11 added a comment. Herald added a subscriber: mgrang. Integrated code review suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks for the feedback Duncan. I don't think this patch introduces any changes the parser. We only change the way how `CodeGenOpts` and `LangOpts` get populated when using `DefaultAnyOf<[...]>`. I've added a test of `CompilerInvocation` that checks just that.

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. I've added tests for OptParserEmitter. Let me know if you had something more detailed in mind. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301913. jansvoboda11 added a comment. Herald added a subscriber: mgorny. Added LLVM unit tests, reverted back to `array_pod_sort`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 26. jansvoboda11 added a comment. Rebase onto master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

jansvoboda11 created this revision. jansvoboda11 added a reviewer: arphaman. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes an issue where large integer values were rejected as

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf111cf992df4: [clang][cli] Specify correct integer width for -fbuild-session-timestamp (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 added a comment. In D93701#2477239 , @jansvoboda11 wrote: > Another solution would be to create a "dummy" `DiagnosticsEngine` for the > `ParseDiagnosticArgs` calls, but I didn't find a way to do that. Something like

[PATCH] D94172: [clang][cli] NFC: Move marshalling macros closer together

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves marshalling macros closer together. In a future patch that starts reusing them,

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 314873. jansvoboda11 added a comment. Pass local variables to macros explicitly, rebase on top of prep patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. @thakis Thanks for the heads-up and sorry for the inconvenience. @rnk You're right. This patch accidentally changed `Group` to `Group` for `-g[no-]column-info`. In the linked build, this caused expansion of the driver flag `-gcolumn-info` to cc1 flag

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 updated this revision to Diff 314866. jansvoboda11 added a comment. Instead of making Diags optional everywhere, pass an ignoring Diags into ParseDiagnosticArgs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93701/new/

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314900. jansvoboda11 added a comment. Introduce `IsDiag` mixin, add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314907. jansvoboda11 added a comment. Use arrow instead of dot in keypath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT,

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 314877. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D94172: [clang][cli] NFC: Move marshalling macros closer together

jansvoboda11 updated this revision to Diff 314876. jansvoboda11 added a comment. Only more parseSimpleArgs closer to ParseDiagnosticArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94172/new/ https://reviews.llvm.org/D94172 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314887. jansvoboda11 added a comment. Rebase on top of prep patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3230ffa3ad: [clang][cli] Port DiagnosticOpts to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D95147: [clang][cli] Port visibility LangOptions to marshalling system

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces Clang-specific

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94679 Files:

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 updated this revision to Diff 316643. jansvoboda11 added a comment. Stop setting the default for LaxVectorConversions in CompilerInvocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D94682

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

jansvoboda11 added a comment. Thanks for taking a look! Committed with more detailed message. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146 - Opts.SSPBufferSize = - getLastArgIntValue(Args, OPT_stack_protector_buffer_size, 8, Diags); -

[PATCH] D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

<    1   2   3   4   5   6   7   8   9   10   >