[PATCH] D138234: [clang-format] Support new file formatting with vim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86278114085b: [clang-format] Support new file formatting with vim (authored by jsji). Changed prior to commit:

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji updated this revision to Diff 476905. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138234/new/ https://reviews.llvm.org/D138234 Files: clang/tools/clang-format/clang-format.py Index:

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji created this revision. jsji added reviewers: djasper, klimek. Herald added a project: All. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The vim Formatonsave integration is not working if we create a new file directly using

[PATCH] D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125386/new/ https://reviews.llvm.org/D125386 ___

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

jsji added a comment. @qiongsiwu1 Please also add reviewers from other targets. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

jsji added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:7 +// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=PPC,PPC64-PWR8 // RUN: %clang_cc1 -verify -triple powerpc64-unknown-aix -emit-llvm -o - %s | \ // RUN: FileCheck %s

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

jsji accepted this revision. jsji added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llvm.org/D120907 ___ cfe-commits mailing list

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:1332 +#ifdef _ARCH_PWR10 + return vec_extractm ((__vector unsigned int) __A); +#else Can we have some pwr10 tests to test all these P10 specific codegen? Repository: rG LLVM

[PATCH] D119309: [Driver][test] Clean up some AIX tests

jsji added subscribers: Xiangling_L, jasonliu, jsji. jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning up. BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji added a comment. In D118110#3269450 , @nemanjai wrote: > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for `long double`, but there should > be a way to set up lit to know

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Besides, would it be acceptable that we add a variable to cmake to determine > default long double semantics (like current GCC)? Yes, we can. But I think that can be in another patch, and we shouldn't rely on it -- as we shouldn't assume user will config/build

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Won't that end up producing a warning on ALL code built on any Linux distro > with a GCC toolchain older than 12.1? That would be terrible. Good point. Yes, so should be something like: IsDistroWithNewToolchain = ( Distro.IsRedhat() && Distro >= Distro::RHEL9 ||

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Would there be a way to query the GCC toolchain for what the default is for > `long double`? There would certainly be ways to query. But I don't think we should change the default *BASED* on the gcc toolchain installed. As you mentioned, `I would find it surprising

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. Can we just update `bool IEEELongDouble = false; ` to `bool IEEELongDouble = true;` in `clang/lib/Driver/ToolChains/Clang.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:76 + if (SupportIEEEFloat128(getDriver(), getTriple(), DriverArgs) && + !DriverArgs.hasArg(options::OPT_mabi_EQ)) +CC1Args.push_back("-mabi=ieeelongdouble"); What if we

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114569/new/ https://reviews.llvm.org/D114569

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Thanks, looks much better now. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir there is no `fmodule-format=obj` here, why are we failing here?

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added a comment. In D113451#3148815 , @kamaub wrote: > Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots > with this changeset > https://lab.llvm.org/buildbot/#/builders/93/builds/6031 >

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e2fd879e6f9: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD (authored by adalava, committed by jsji). Changed prior to commit: https://reviews.llvm.org/D113451?vs=385985=389001#toc

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added inline comments. Comment at: clang/test/CodeGen/ppc-mm-malloc-le.c:10 // RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm %s -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | FileCheck %s +// RUN: %clang -target

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140174 , @lkail wrote: > Is there any way to filter these tests out on AIX in `lit.local.cfg`? Agree, I would prefer we do something similar to

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140165 , @Jake-Egan wrote: > In D113049#3140160 , @jsji wrote: > >> Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? > > If 64-bit XCOFF object files will be

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for enabling this for FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113451/new/ https://reviews.llvm.org/D113451

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Please hold a few days to see whether there are inputs from other reviewers. Thanks. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji added inline comments. Comment at: clang/test/Driver/ppc-float-abi-warning.cpp:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang -### -x c++ -target powerpc64le-unknown-linux-gnu %s -mabi=ieeelongdouble + Can we add RUN line to test when we are

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin_printf, "__printfieee128"}, + {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"}, Why only these printf

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/Sema/SemaChecking.cpp:3382 +if (() != ::APFloat::PPCDoubleDouble()) + return Diag(TheCall->getBeginLoc(),

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42eea2b69bb9: [AIX] Enable int128 in 64 bit mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. In D111078#3065552 , @hubert.reinterpretcast wrote: > In D111078#3063245 , @lkail wrote: > >> This LGTM as the start point to support int128 on AIX. We might need more >> patches involving

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. ppc64-i128-abi.ll CHECK-P9 part depends on D94282 : [PowerPC] Support ppc-asm-full-reg-names for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 379485. jsji added a comment. Add AIX XCOFF triples to i128 tests, especially ppc64-i128-abi.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 Files:

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. Ping @hubert.reinterpretcast Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 ___ cfe-commits mailing list

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Can you please add a testcase that include `smmintrin.h` but use SSSE3? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111482/new/

[PATCH] D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75127bce6de7: [AIX][ZOS] Excluding merge-objc-interface.m from Tests (authored by qiongsiwu1, committed by jsji). Repository: rG LLVM Github

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Thanks for working on this. Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:161 // where th can be omitted when it is 0. dcbtst is the same. -

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 377283. jsji added a comment. Herald added a subscriber: kbarton. Address comments -- adding AIX triples to more existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: hubert.reinterpretcast wrote: > Confirming that this case matches GCC on AIX: > ``` > ld 4,8(3) > ld

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch remove the override in AIX target, so the int128 is enabled in

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c31969e8df2: [AIX] Dont pass namedsects in LTO mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji updated this revision to Diff 376595. jsji added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org/D110955 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index:

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added a subscriber: inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LTO don't need binder option , don't pass it in LTO mode. Repository: rG

[PATCH] D110671: [AIX] Enable PGO without LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e48951c736c: [AIX] Enable PGO without LTO (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110671: [AIX] Enable PGO without LTO

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added subscribers: wenlei, inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, we relied on LTO to merge the csects for profiling data/counter

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25c30324e953: [AIX] Change the linkage of profiling counter/data to be private (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji added a comment. @MaskRay Thank you so much for your review and discussion! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits mailing list

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji updated this revision to Diff 375716. jsji added a comment. Remove empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/test/Profile/cxx-templates.cpp

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji updated this revision to Diff 375709. jsji added a comment. Split the Driver changes to another patch, also fixed the duplicate code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files:

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 375688. jsji marked an inline comment as done. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files:

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > "as binder can NOT discard a subset of a csect."? Thanks, this does looks better! > The linker (binder) doesn't have to discard a subset of csect, but it should > ensure there are not two non-local symbols with the same name. > The latter is what I request. > Without

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > "as binder can NOT discard only part of a csect." this part caused confusion > to me... OK, yeah, csect is special to XCOFF, so this is not the same concept of sections in ELF. > I haven't verified but it is possible that PGO picks the first pair (zero > value) and

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. OK, I may not describe the example clearly. Let me use example code with offsets and llvm internal calculations as the example, so that you might be clearer. Let us say we have 2 objects , which both have weak function foo (and some non-weak functions). [2054] m

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. In D110422#3025133 , @MaskRay wrote: > The description isn't clear why the previous `weak` symbol usage does not > work. Have you verified that it does not work? Yes, we started with the `weak` symbols for `profc`/`profd` first,

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. @MaskRay Do you have further comments or alternative solutions? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. Using to `PrivateLinkage`, all the profc/profd for each weak symbol will be *local* to objects, and all kept in the csect, so we won't have problem. The downside is that we won't be able to discard the duplicated counters and profile data, but those can not be discarded

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. We have verified all the profile counters in SPEC , all are OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits mailing

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. In D110422#3021535 , @MaskRay wrote: > The description is still unclear. > > Say a.o has a weak `foo, __profc_foo, __profd_foo`, b.o has a weak `foo, > __profc_foo, __profd_foo`. > The linker picks the definitions from `a.o`. In

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. Pos_Rel __profc_weak_func notation is just the normal relocation to symbol __profc_weak_func. The relocation here is to calculate the relative pointer (offset) to __profc__weak_func from __profd__weak__func. In example above, the offsets value after binding will be the

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > In other binary formats the first weak definition is selected and other weak > definitions are discarded. > Do you mean that AIX ld doesn't pick the first weak definition? No. I think this is exactly what is causing problem here. eg: if we have two weak symbols

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374879. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374867. jsji added a comment. Restore the limitation of sample profiling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji created this revision. jsji added reviewers: PowerPC, Whitney, w2yehia, MaskRay. Herald added subscribers: wenlei, hiraditya, inglorion. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. On AIX, we relied on LTO

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. But please wait to see whether @aprantl has any comments. Thanks. Comment at: clang/test/Modules/ExtDebugInfo.cpp:27 +#line 50 using DebugCXX::Struct;

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration,

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration,

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060

[PATCH] D109255: [NFC][OpenMP] Use clang_cc1 to driver tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd364eccdd5a9: [NFC][OpenMP] Use clang_cc1 to driver tests (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. > I probably won't get to it today, but I can work on it later. Sure, take your time. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370663. jsji added a comment. use `_cc1` for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983052 , @ABataev wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. @ABataev Is this still OK for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370658. jsji added a comment. Use driver + -fsyntax-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. OK, I can

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983002 , @ABataev wrote: > I think we can use just `clang_cc1` here instead of `%clang -c` Good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370653. jsji added a comment. Use clang_cc1 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index:

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji created this revision. jsji added reviewers: jdenny, ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. jsji requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The test driver-fopenmp-extensions.c is failing on

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. In D109060#2976752 , @Jake-Egan wrote: > In D109060#2976745 , @jsji wrote: > >> For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add >> lit.local.cfg and add the

[PATCH] D109060: Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b'

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji accepted this revision as: jsji. jsji added a comment. LGTM, Thanks. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b"

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added a comment. Tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

jsji added a comment. > x64 debian > Clang.Driver::ppc-mprivileged-support-check.c The changed test is failing ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ https://reviews.llvm.org/D107461

[PATCH] D107077: [PowerPC] Fix return type of XL compat CAS

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107077/new/ https://reviews.llvm.org/D107077

[PATCH] D106920: [AIX] Update fetch_and_add type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbdf8e5b5aa: [AIX] Update fetch_and_add type (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106920: [AIX] Update fetch_and_add type

jsji updated this revision to Diff 362197. jsji edited the summary of this revision. jsji added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106920/new/ https://reviews.llvm.org/D106920 Files:

[PATCH] D106920: [AIX] Update fetch_and_add type

jsji created this revision. Herald added subscribers: steven.zhang, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that AIX kernerl are definiing int instead of unsing int for fectch_and_add. Legacy

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jsji added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:79 + set(LLVM_EXPORTED_SYMBOL_FILE) + set(USE_VERSION_SCRIPT TRUE) +endif() jsji wrote: > I think we should check LLVM_HAVE_LINK_VERSION_SCRIPT here, there are > platforms that does

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

jsji created this revision. jsji added reviewers: PowerPC, tstellar, MaskRay, hubert.reinterpretcast. Herald added a subscriber: mgorny. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some platform that might not have

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jsji added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:79 + set(LLVM_EXPORTED_SYMBOL_FILE) + set(USE_VERSION_SCRIPT TRUE) +endif() I think we should check LLVM_HAVE_LINK_VERSION_SCRIPT here, there are platforms that does NOT support

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. > that looks like a historical issue which exists for 13yrs Hmm... OK.. Let us leave it as it is for now. Thanks for the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji added a comment. Doesn't look like good enough to me, the code sequence generated is not clean enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344

  1   2   3   >