[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. Should we wait until the next OpenMP LLVM meeting to push this? Comment at: openmp/libomptarget/include/Ident.h:48-51 +auto removePath = [](const std::string &path) { +std::size_t pos = path.rfind('/'); +return path.substr(pos + 1);

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. Replace the OpenMP Runtime Library

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added a comment. This currently fails some Clang tests because of an error with how `size_t` is handled by Clang versus OMPKinds.def. The compiler will crash when generating code for a 32 bit device on a 64 bit host because Clang uses the `size_t` from the host while OMPKinds.def uses t

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. This stops it from crashing Clang, but I'm not sure if it's fixing the underlying problem. When I compile and run this program it crashes in libomptarget. If you get rid of the `float f[50]` in the struct it works as expected. `$ clang++ -fopenmp -fopenmp-targets=nvptx

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM then. Any clue what the cause of the other problem is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91370/new/ https://reviews.llvm.org

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392267 , @ABataev wrote: > In D91370#2392171 , @jhuber6 wrote: > >> LGTM then. >> >> Any clue what the cause of the other problem is? > > Could you try your test with the patch fr

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392313 , @ABataev wrote: > In D91370#2392310 , @jhuber6 wrote: > >> In D91370#2392267 , @ABataev wrote: >> >>> In D91370#2392171

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392319 , @ABataev wrote: > From libomptarget. It must be different. Could you copy it here? Yeah, I think there's some extra information looking at it again. Target CUDA RTL --> Start initializing CUDA Libomptarget

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > --- a/clang/lib/CodeG

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > --- a/clang/lib/CodeG

[PATCH] D91552: [OPENMP]Fix PR48076: mapping of data member pointer.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, fixed the problem on my machine and passes the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91552/new/ https://reviews.llvm

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 306210. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/capturing_i

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda8bec47ab8c: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging (authored by jhuber6). Changed prior to commit: https://reviews.l

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + sstefan1 wrote: > There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. > > Maybe j

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294798. jhuber6 added a comment. Herald added a subscriber: aaron.ballman. Reusing OMPBuilder from CGOpenMPRuntime. Altered the failing test case. This case failed when compiling for a 32 bit device on a 64 bit host. This case should be considered an error b

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294819. jhuber6 added a comment. Removed now unused function for generating convergent runtime functions. Updated Clang to print an error message if the user attempts to specify incompatible architectures due to a difference in pointer sizes. Repository:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295032. jhuber6 added a reviewer: erichkeane. jhuber6 added a comment. Adding test cases for incompatible architecture messages. Checking the architecture is done by checking all combinations of architectures. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 295120. jhuber6 added a comment. Adding check for Windows file path. Updating some files after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, clang. Herald added subscribers: cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. This patch adds an error to Clang that detects if Open

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295342. jhuber6 added a comment. Moving the Clang error checks into D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files: c

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295343. jhuber6 added a comment. Forgot to add one of the test changes from D88594 as it makes this one fail too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ http

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

This revision was automatically updated to reflect the committed changes. Closed by commit rG90eaedda9b8e: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D88430?vs=295343&id=295353#toc Repository

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 closed this revision. jhuber6 added a comment. Committed in rG9d2378b59150 , forgot to update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 295949. jhuber6 added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Adding an extra substitution in lit to solve the problem of automatically populating the test files with incompatible architectures. CHANGES SI

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 reopened this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Reopening for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___ cfe-commits mailing list

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296081. jhuber6 added a comment. Changed the lit substitution to be for fixing this problem specifically. It made the tests too unreadable and wasn't a good solution since it didn't detect 16 bit architectures anyway. Repository: rG LLVM Github Monorepo

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6). Repository: rG LLVM Github Monor

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296204. jhuber6 added a comment. Changing method of determining architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 Files: clang/include/clang/Basic/Diagnos

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: clang, OpenMP. Herald added subscribers: openmp-commits, cfe-commits, guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. This patch changes the CMake f

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315378 , @ye-luo wrote: > FindCUDA has been deprecated. > Please explore the following feature without directly calling FindCUDA. > https://gitlab.kitware.com/cmake/cmake/-/merge_requests/1856 Finding architectures usin

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315402 , @ye-luo wrote: > The link I posted indicated that independent feature is merged since 3.12. > Better to avoid deprecated stuff when introducing new cmake lines even though > some existing lines may still rely

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315451 , @ye-luo wrote: > I just realized that this patch affects clang and libomptarget. > I cannot comment on clang. Regarding libomptarget, Could you explain why the > detection is not put together with other cuda st

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315519 , @ye-luo wrote: > Probably not messing with `enable_language(CUDA)` at the moment, just add > `cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS)` to > `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 updated this revision to Diff 296577. jhuber6 added a comment. Removing redundant call to `find_package`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 Files: clang/CMakeLists.txt openmp/libom

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif() ye-luo wrote: > 1. Doesn't work right now. Missing comma ",${CMAKE_MATCH_1}"

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296748. jhuber6 added a comment. Removing the architecture detection from lit. Simply changing the tests to use specific architectures, in this case x86_64 and aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296778. jhuber6 added a comment. Changed method for comparing the architectures. Enum is local to the loop so it shouldn't pollute the namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https:

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296783. jhuber6 added a comment. Okay, I'll push it after this finishes its build and see if buildbot sends me angry emails again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 updated this revision to Diff 296792. jhuber6 added a comment. Implementing Ye's code. I changed it to putput the architecture as a dependency and then set the value where we define the default architecture. I did a full build from scratch using this and got the sm_70 libraries for my ma

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rGd564409946a5: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by… (authored by jhuber6). Herald added a subscriber: mgorny. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 closed this revision. jhuber6 added a comment. Screwed up and put the wrong revision in the commit message. Closed in rGd564409946a5a13cb6391fc0fec54dcbd6f6d249 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 reopened this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Closed accidentally, had the wrong revision link in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.ll

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297003. jhuber6 added a subscriber: ABataev. jhuber6 added a comment. Removing the _loc suffix. The Mapper API hasn't been officially released in Clang 11.x so we're still free to make changes. Currently working on augmenting the mapper API with variable dec

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 297008. jhuber6 added a comment. Updating tests after landing D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files: clang/l

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297297. jhuber6 added a comment. Fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/captur

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297661. jhuber6 added a subscriber: tianshilei1992. jhuber6 added a comment. Current build, fails `offloading/target_depend_nowait` for an unknown reason after calling cuStreamSynchronize in __tgt_target_teams_mapper_nowait. Repository: rG LLVM Github Mon

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2325934 , @grokos wrote: > In D87946#2325756 , @jhuber6 wrote: > >> Current build, fails `offloading/target_depend_nowait` for an unknown reason >> after calling cuStreamSynchroni

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594 c

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299081. jhuber6 added a comment. Checking tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 Files: clang/test/OpenMP/driver-openmp-target.c clang/test/Op

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rG24df30efda61: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https:

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. Initial version. This fails a few tests and needs additional test cases for the additional functionality as well as support inside the runtime library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://revie

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --chec

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299672. jhuber6 added a comment. Changing test to be similar to LLVM's method, checks the linker flags for 32-bit library and only if the target triple is one of the known 64-bit triples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. @daltenty Do you think this will fix the problem on AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 ___ cfe-commits mailing list cfe

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 added a comment. In D89696#2344753 , @daltenty wrote: > In D89696#2344508 , @jhuber6 wrote: > >> @daltenty Do you think this will fix the problem on AIX? > > It's not just AIX that will have this problem I s

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, daltenty. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299767. jhuber6 added a comment. Changing to just check if the target triple is of four known 64-bit architectures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904 Fil

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4a4ae97a7c: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https:

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 301167. jhuber6 added a comment. Updating after D90172 and D89802 landed. I don't see it failing the tests anymore but I'll look into it more. I should probably make a test for the source l

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. In D89802#2359504 , @tianshilei1992 wrote: > This patch caused segment fault in D90099 > where the map variable info pointer is `nullptr` but it is deferenced. Was it this one, or was it D90172

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds a module level metadata flag indicating that th

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 345557. jhuber6 edited the summary of this revision. jhuber6 added a comment. Splitting patches into D97680 and D102532 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions

jhuber6 updated this revision to Diff 346516. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixing Clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102784/new/ https://reviews.llvm.org/D10

[PATCH] D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2db182ff8d0c: [Diagnostics] Allow emitting analysis and missed remarks on functions (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D102784?vs=346516&id=346531#toc Repository:

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 347097. jhuber6 added a comment. Fixing nits and splitting command line removal to a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/lib/CodeG

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. jhuber6 added a project: clang. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. The changes introduced in D97

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The new device runtime uses an in

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jhuber6 added a comment. In D109997#3007216 , @jdoerfert wrote: > You checked that this works with the usage in the RT, right? Worked when I tested it. Want me to make a patch for it off of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGc30d7730ebde: [OpenMP] Change debugging symbol to weak_odr linkage (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109997/new/ https://

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, this passed the usual tests and I didn't see any leftover allocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https:/

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added a comment. In D110108#3010861 , @jdoerfert wrote: > The runtime code is missing, right? Yes, was going to make that a separate patch, also need to fix the LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); tianshilei1992 wrote: > Do we wan

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch adds a new RTL fun

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jhuber6 added a comment. In D110429#3024884 , @ronlieb wrote: > lld: error: undefined symbol: __kmpc_distribute_static_init_4 > referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) referenced by /tmp/private_m

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds OpenMP assumption attributes to call sites in a

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

jhuber6 updated this revision to Diff 375773. jhuber6 added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110655/new/ https://reviews.llvm.org/D110655 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGStmt.cpp clan

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd12502a3abae: [OpenMP] Apply OpenMP assumptions to applicable call sites (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Clang will create a global value put in constant memory

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10598 +CGM.getCXXABI().getMangleContext().mangleTypeName(VD->getType(), OS); +OS << "_" << VD->getName() << "_l" << Line; VarName = OS.str(); jdoerfert wrote: > What if

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 updated this revision to Diff 351012. jhuber6 added a comment. Changing to only mangle when using C++. It should be correct either way but is unnecessary with C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103995/new/ https://reviews.llv

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c32ffceedca: [OpenMP] Add type to firstprivate symbol for const firstprivate values (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

This revision was automatically updated to reflect the committed changes. Closed by commit rG68d133a3e8c9: [OpenMP] Simplify GPU memory globalization (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D97680?vs=347097&id=353650#toc Repository: rG LLVM Github Monorepo C

[PATCH] D102824: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03d7e61c87eb: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes (authored by jhuber6). Herald added subscribers: cfe-commits, ormris.

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc768aac2e4e: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102940/new/ htt

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 updated this revision to Diff 354324. jhuber6 added a comment. Addings tests and a module flag for openmp target devices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 Files: clang/lib/CodeGen

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:709 +getModule().addModuleFlag(llvm::Module::Max, "openmp-device", + LangOpts.OpenMP); + jdoerfert wrote: > Why do we need `OpenMPRuntime` in the condi

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 updated this revision to Diff 354368. jhuber6 added a comment. Removing runtime check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Ope

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. After D94315 we add

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

jhuber6 updated this revision to Diff 364844. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/parall

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Temporary files created by the offloadi

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6b50c2596: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ http

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#2937230 , @jdoerfert wrote: > Why the else? If this input isn't an OffloadingAction then it is a `.o` file which we already list as a temporary file. If it was an OffloadingAction then we have an extra device-specifi

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG01d59c0de822: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#2939365 , @yaxunl wrote: > This may break -save-temps since the input to clang-offload-bundler may not > be temporary files when -save-temps is enabled. > > I think clang-offload-bundler is not the right place to decid

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. This patch broke offloading on my machine. If I compile a basic offloading application I get an invalid device image. #include int main() { int isHost; #pragma omp target map(from:isHost) { isHost = omp_is_initial_device(); } return isHost; } Com

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950281 , @vzakhari wrote: > @jhuber6, thank you for reporting this. I do not have a properly setup CUDA > system currently. Can you please invoke `clang-offload-wrapper` with > `-save-temps` and send the temporary fi

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950515 , @vzakhari wrote: > In D99551#2950464 , @jhuber6 wrote: > >> In D99551#2950281 , @vzakhari wrote: >> >>> @jhuber6, thank you for r

<    1   2   3   4   5   6   7   8   9   10   >