[PATCH] D42887: [Driver] Add option to manually control discarding value names in LLVM IR.

bogner added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3269-3274 + const bool IsAssertBuild = #ifdef NDEBUG - CmdArgs.push_back("-disable-llvm-verifier"); - // Discard LLVM value names in -asserts builds. - CmdArgs.push_back("-discard-value-names"); +

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

bogner added a comment. The cmake and lit bits all look correct https://reviews.llvm.org/D50594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49771: CodeGen: use non-zero memset when possible for automatic variables

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Seems straightforward and correct to me. Comment at: lib/CodeGen/CGDecl.cpp:956-957 +class BytePattern { + uint8_t Val; + enum class ValueType { Specific, Any, None }

[PATCH] D62693: Support codesigning bundles and forcing

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Seems straightforward enough Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62693/new/ https://reviews.llvm.org/D62693

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. This seems reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94533/new/ https://reviews.llvm.org/D94533

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner updated this revision to Diff 556512. bogner added a comment. Rebased to fix conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner added a subscriber: Keenuts. bogner added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4146 if (Opts.HLSL) { -bool SupportedTarget = (T.getArch() == llvm::Triple::dxil || -T.getArch() == llvm::Triple::spirv) &&

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553964. bogner added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. +

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner updated this revision to Diff 555451. bogner added a comment. - Consolidate error messages - Error messages should start with a lower case letter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner updated this revision to Diff 556589. bogner added a comment. Herald added a subscriber: pmatos. - Check isSPIRVLogical rather than isSPIRV - Improve diagnostics given that HLSL can generate both DXIL and SPIR-V - Add tests for SPIR-V triples - Fix missing `REQUIRES:` in dxil triple tests

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe504194d51e1: [Driver][HLSL] Improve diagnostics for invalid shader model and stage (authored by bogner). Repository: rG LLVM Github Monorepo

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner added a comment. Ping. Please take another look when you get a chance, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 ___ cfe-commits mailing

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGef2b1700f464: [Sema][HLSL] Consolidate handling of HLSL attributes (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D158803?vs=554044=554379#toc Repository: rG LLVM Github

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:710-716 + "Shader model is required in target '%0' for DXIL generation">; +def err_drv_dxil_unsupported_shader_model : Error< + "Shader model '%0' in target '%1' is invalid for DXIL

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG12babb08189c: [clang-tidy] Disable implicit search for a compilation db in some tests (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158113: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5c8dea1e1d: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug) (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158113: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

bogner created this revision. bogner added a reviewer: beanz. Herald added a subscriber: mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds /Zi handling and explicitly ignores

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

bogner created this revision. bogner added reviewers: njames93, PiotrZSL, carlosgalvezp. Herald added subscribers: xazax.hun, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner created this revision. bogner added reviewers: beanz, python3kgae, bob80905, tex3d. Herald added subscribers: Anastasia, arphaman, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] bob80905 wrote: > I don't think we should expect this

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner added inline comments. Comment at: clang/test/SemaHLSL/entry_shader.hlsl:1 -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-entry foo -o - %s -DSHADER='"anyHit"' -verify +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner updated this revision to Diff 553588. bogner added a comment. Address feedback and simplify valid shader stage test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158820/new/ https://reviews.llvm.org/D158820 Files:

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43a9b92d79ab: [Sema][HLSL] Fix naming of anyhit/closesthit shaders (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 550224. bogner added a comment. Rebase on top of "Visibility" naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https://reviews.llvm.org/D157150 Files: clang/include/clang/Driver/Options.h

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4587522 , @awarzynski wrote: > This might cause some disruption to downstream consumers of this API and > Options.td. Hopefully, "update_options_td_flags.py" that you've included > should minimise that. I suggest

[PATCH] D157146: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce16c3cf30f5: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter (authored by bogner). Changed prior to commit:

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0db9dfb19329: [Driver] Update BoolOption to handle Visibility. NFC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe17667b33f1f: [Driver][DXC] Remove a bunch of options from DXC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158037/new/

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove

[PATCH] D157582: [Driver][DXC] Handle -Fo and -Fc flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb6fe61be3de: [Driver][DXC] Handle -Fo and -Fc flags (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D157582?vs=548879=550545#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4583904 , @awarzynski wrote: > This can be tweaked in `getOptionVisibilityMask` (extracted from this patch): > > llvm::opt::Visibility > Driver::getOptionVisibilityMask(bool UseDriverMode) const { > if

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 549853. bogner added a comment. Use "ClangOption" rather than "Default" in Options.td, as per the conversation in https://reviews.llvm.org/D157151 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

bogner added a comment. I can't speak to which flags should be present in flang-new or not, but in principle this looks great. You'll need to update the patch to use the "ClangOption" spelling rather than "Default" of course, as discussed in https://reviews.llvm.org/D157151

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 554044. bogner added a comment. - Now with more const - Added DiagnoseHLSLAttrStageMismatch and avoided using raw strings in diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner created this revision. bogner added reviewers: aaron.ballman, beanz. Herald added subscribers: Anastasia, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds more

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. +

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added subscribers: Anastasia, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553395. bogner added a comment. Broke out a couple of semi-unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files:

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. I'm not entirely convinced by the motivation (wouldn't it be better to just fix the tests?), but this seems like a perfectly reasonable flag to have. CHANGES SINCE LAST ACTION

[PATCH] D123907: [HLSL] Add shader attribute

bogner added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like I'm guessing you meant to

[PATCH] D124753: [HLSL] Set main as default entry.

bogner added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { typo, should be `CHECK-SAME` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128569: Start support for HLSL `RWBuffer`

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Fairly straightforward. LGTM with a couple of nits Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:48 + + // Complete an incomplete HLSL builtin type + void

[PATCH] D130017: [HLSL] Add RWBuffer default constructor

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Is it worth adding a test that calls this constructor / checks that we end up with a call to the builtin? Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:155 +

[PATCH] D131718: [HLSL] Add abs library function

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. LGTM. Make sure you update the description from saying that this doesn't handle half because of https://llvm.org/pr57100 to saying that it fixes the bug instead. Repository: rG LLVM

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Even without the tooling aspect the addition of the static asserts is a strict improvement. looks good, thanks! Comment at: clang/include/clang/Basic/HLSLRuntime.h:39 +

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/D138571

[PATCH] D142473: [UTC] Add --version argument

bogner added a comment. Multiple people had concerns with the added complexity of having to maintain historical versions of behaviour here (a concern which I share), and absolutely none of them accepted the revision or commented after the comment that you don’t think it’ll be too bad in

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

bogner created this revision. bogner added reviewers: beanz, kadircet, python3kgae, hans. Herald added subscribers: arphaman, hiraditya, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay. Herald added

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

bogner added inline comments. Comment at: clang/include/clang/Driver/Options.h:40 + Ignored = (1 << 18), + TargetSpecific = (1 << 19), }; bob80905 wrote: > Given that the id for these flags have changed, does it make sense to write a > test that makes sure

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eda85f047f: [OptTable] Make explicitly included options override excluded ones (authored by bogner). Repository: rG LLVM Github Monorepo

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

bogner created this revision. bogner added reviewers: Bigcheese, MaskRay. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. bogner requested review of this revision. Herald added subscribers:

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ef1718c4d4e: [Driver] Dont try to spell check unsupported options (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. Looking at https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, it seems a bit underspecified, but do we need to worry about differences between that spec and IEEE behaviour here? For example, it says there that `x<0, y=any -> NaN`, but

[PATCH] D157562: [Driver][DXC] Treat stdin as HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d459b71dc28: [Driver][DXC] Treat stdin as HLSL (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 549111. bogner added a comment. Resolve conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4577790 , @awarzynski wrote: > Hey @bogner , I've only skimmed through so far and it's looking great! That > Include/Exclude API was not fun to use. What you are proposing here takes > Options.td to a much a better

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4582109 , @awarzynski wrote: > I think that it would be good to replace `Default` with e.g. > > - `Clang`, or > - `ClangDriver`, or > - `ClangCompilerDriver`. > > Or, at least, to make the meaning of `Default` much

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner created this revision. bogner added reviewers: rnk, jansvoboda11, MaskRay. Herald added subscribers: jeroen.dobbelaere, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -g flag has

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner created this revision. bogner added a reviewer: MaskRay. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This updates the

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner created this revision. bogner added a reviewer: MaskRay. Herald added subscribers: pmatos, asb, ormris, kadircet, arphaman, steven_wu, hiraditya, sbc100, mcrosier. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson.

[PATCH] D157146: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter

bogner created this revision. bogner added a reviewer: MaskRay. Herald added a subscriber: mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the `hasFlag` check to account for an Option's

[PATCH] D157562: [Driver][DXC] Treat stdin as HLSL

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added subscribers: Anastasia, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 548832. bogner added a comment. Rebase/resolve conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/ https://reviews.llvm.org/D157149 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D157582: [Driver][DXC] Handle -Fo and -Fc flags

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added subscribers: Anastasia, hiraditya, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. In D156178#4530161 , @bogner wrote: > Looking at > https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, > it seems a bit underspecified, but do we need to worry about differences > between that

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 550125. bogner edited the summary of this revision. bogner added a comment. Rebase on top of "DefaultVis" naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https://reviews.llvm.org/D157150

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner added inline comments. Comment at: llvm/include/llvm/Option/OptParser.td:153 class Flags flags> { list Flags = flags; } +class Vis vis> { list Vis = vis; } class Group { OptionGroup Group = group; } phosek wrote: > Would it be possible to spell this out

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf58330cbe445: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially (authored by bogner). Changed prior to commit:

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner updated this revision to Diff 550055. bogner edited the summary of this revision. bogner added a comment. Update comment wording to be less ambiguous about flags vs visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157149/new/

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa16104e6da6f: [Option] Add Visibility field and clone the OptTable APIs to use it (authored by bogner). Repository: rG LLVM Github Monorepo