mgorny added a comment.
In https://reviews.llvm.org/D28213#665967, @dim wrote:
> I don't think FreeBSD has lock-free 64 bit atomic operations on 32-bit x86.
> IIRC we already had some trouble before with clang emitting libcalls to
> `__atomic_fetch_add_8` and friends, which then lead to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293632: [cmake] Hint find_package() to prefer LLVM installed
alongside clang (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29304?vs=86339=86421#toc
Repository:
rL LLVM
mgorny created this revision.
Herald added a subscriber: dberris.
Check whether strace is to be found in PATH, and control the strace_test
appropriately. This fixes a test failure when strace is not installed.
Repository:
rL LLVM
https://reviews.llvm.org/D29628
Files:
mgorny updated this revision to Diff 87134.
mgorny edited the summary of this revision.
mgorny added a comment.
Ok, this CUDA fix should be reasonable, i think. It simply assumes i586+ (i.e.
all inline atomics enabled) for CUDA target builds. I seriously doubt it's
technically possible that
mgorny added inline comments.
Comment at: lib/Basic/Targets.cpp:4244
+} else // allow locked atomics up to 4 bytes
+ MaxAtomicPromoteWidth = 32;
+ }
ahatanak wrote:
> mgorny wrote:
> > dim wrote:
> > > Are you purposefully not setting
mgorny added inline comments.
Comment at: lib/Basic/Targets.cpp:1808
+if (HostTriple.getArch() == llvm::Triple::x86)
+ HostTarget->setCPU("i586");
+
jlebar wrote:
> mgorny wrote:
> > jlebar wrote:
> > > Okay, is this still needed now?
> > Yes. I've
mgorny added a comment.
In https://reviews.llvm.org/D29542#667814, @joerg wrote:
> At this point, I don't think there is any use on pretending that
> i386-as-default makes sense. So I would request that the i386 case should be
> made explicit or just dropped, with a preference for the latter.
mgorny updated this revision to Diff 87311.
mgorny added a comment.
Removed the i386 branch. Now the i486+ are used unconditionally.
https://reviews.llvm.org/D29542
Files:
lib/Basic/Targets.cpp
test/CodeGen/atomic-ops.c
test/CodeGen/ms-volatile.c
test/CodeGenCXX/atomicinit.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294425: [test] Enable the strace_test only if strace is
installed (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29628?vs=87392=87603#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294431: [test] Fix hard_link_count test to account for fs
with dir nlink==1 (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29706?vs=87613=87618#toc
Repository:
rL LLVM
mgorny created this revision.
Filesystems are not required to maintain a hard link count consistent
with number of subdirectories. For example, on btrfs all directories
have nlink==1. Account for that in the test.
Repository:
rL LLVM
https://reviews.llvm.org/D29706
Files:
mgorny created this revision.
Herald added subscribers: dberris, aemerson.
Add an #if that excludes the newly added aeabi* tests on non-ARM
platforms. This is consistent with other ARM tests, and aims to make
running builtin tests easier. Lacking a proper infrastructure to run
tests selectively,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294438: [test] #ifdef new builtin tests for __arm__ platform
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29708?vs=87617=87629#toc
Repository:
rL LLVM
mgorny added a comment.
In https://reviews.llvm.org/D28213#666269, @dim wrote:
> > What's the value of `__atomic_always_lock_free(sizeof(long long), 0)` for
> > gcc and clang?
>
> For gcc, it is always 0, for clang (I tested 3.4.1 through 4.0.0) it is
> always 1. Maybe that was always
mgorny added a comment.
In https://reviews.llvm.org/D29542#666831, @jlebar wrote:
> > Could someone help me figure out what is the cause and correct solution to
> > that failure? @jlebar?
>
> You can see in NVPTXTargetInfo that we read properties from the host
> targetinfo so that we export
mgorny created this revision.
Herald added a subscriber: emaste.
Set the maximum width of atomic operations on x86-32 based on the target
CPU. The 64-bit inline atomics require cmpxchg8b which is an i586
instruction. Other inline atomics require cmpxchg which is an i486
instruction.
This fixes
mgorny added inline comments.
Comment at: lib/Basic/Targets.cpp:1808
+if (HostTriple.getArch() == llvm::Triple::x86)
+ HostTarget->setCPU("i586");
+
jlebar wrote:
> Okay, is this still needed now?
Yes. I've specifically tested with it commented out, and
mgorny created this revision.
Include a path hint for find_package() in ClangConfig.cmake to ensure
that CMake prefers LLVM installed alongside clang over the default
search path.
If two versions of LLVM are installed in the system, and one of them is
in PATH, CMake's find_package() magic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293052: [test] Port clang tests to canonicalized booleans
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28529?vs=83852=85736#toc
Repository:
rL LLVM
mgorny updated this revision to Diff 85875.
mgorny retitled this revision from "[Driver] Pass -lunwind when using libc++ +
compiler-rt on Linux" to "[Driver] Pass -lunwind along with compiler-rt when
necessary on Linux".
mgorny edited the summary of this revision.
mgorny added a comment.
Herald
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292729: [test] Fix page address logic in clear_cache_test
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28849?vs=85208=85248#toc
Repository:
rL LLVM
mgorny updated this revision to Diff 85208.
mgorny marked an inline comment as done.
mgorny added a comment.
Fixed the missing change. Also created a local variable to avoid calling the
sysconf three times.
https://reviews.llvm.org/D28849
Files:
test/builtins/Unit/clear_cache_test.c
mgorny created this revision.
Herald added a subscriber: dberris.
Make the use of #pragma redefine_extname and appropriate renames of
builtins conditional to using clang. GCC used not to support it outside
Solaris and currently seems to be very restrictive on applying it.
In other words, it does
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:3267
+ if (llvm::sys::fs::is_directory(CandidateLibPath))
+CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath));
+
Don't you also need rpath for it? Or is this purely for static
mgorny added inline comments.
Comment at: lib/Driver/ToolChain.cpp:327
+ llvm::sys::path::append(Path, "lib", OSLibName,
+ getArchName());
+ return Path.str();
I would suggest using arch type, to avoid e.g. i386/i486/i586 mess. It's
mgorny created this revision.
mgorny added a project: clang-tools-extra.
Prepend the clang library directory (determined using SHLIBDIR, alike
in clang) to the LD_LIBRARY_PATH to ensure that just-built clang
libraries will be used instead of a previous installed version.
When a stand-alone build
mgorny added inline comments.
Comment at: test/Driver/arch-specific-libdir.c:6
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: | FileCheck --check-prefix=CHECK-ARCHDIR %s
+//
Please be more specific in the tests, i.e. check if the
mgorny accepted this revision.
mgorny added a comment.
LGTM modulo the test match split. But please wait for someone who has been
longer here to confirm.
Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+//
+// CHECK-ARCHDIR:
mgorny added a comment.
Thanks. The -L tests look good, -rpath is not perfect but I don't think you can
improve it without additional changes to the Driver.
Comment at: test/Driver/arch-specific-libdir-rpath.c:6
+// -rpath only gets added during native compilation
+//
mgorny added inline comments.
Comment at: test/CodeGen/atomic-ops.c:1
-// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map
-triple=i686-apple-darwin9 | FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map
mgorny added a reviewer: doug.gregor.
mgorny added a subscriber: doug.gregor.
mgorny added a comment.
If I read the git correctly, the change that forbid defining builtins was
initially made in https://reviews.llvm.org/rL64639. @doug.gregor, any chance
you could help us over here? Is clang
mgorny created this revision.
mgorny added a project: clang-tools-extra.
Use the LLVM_UTILS_PROVIDED variable to determine whether test tool
dependencies should be exposed for clang-tools-extra tests. If clang is
being built stand-alone and LLVM test tools (FileCheck, count and not)
are
mgorny abandoned this revision.
mgorny added a comment.
I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I
don't really have time to look into it in more detail at the moment.
Repository:
rL LLVM
https://reviews.llvm.org/D28862
mgorny added a comment.
Le gentle ping.
https://reviews.llvm.org/D29542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
In https://reviews.llvm.org/D30025#678462, @theraven wrote:
> This code is working around something that's probably a clang bug. It would
> be better to fix the clang bug than add more complex workarounds.
Well, clang explicitly rejects those functions as errors, so I
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:3267
+ if (llvm::sys::fs::is_directory(CandidateLibPath))
+CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath));
+
pirama wrote:
> mgorny wrote:
> > Don't you also need rpath for it?
mgorny created this revision.
Herald added a subscriber: dberris.
Fix the logic used to calculate page address in clear_cache_test to use
the binary negation of 4095 rather than arithmetic. The latter gives
incorrect result since:
-4095 -> 0xf001
~4095 -> 0xf000
Alternatively, -4096
mgorny updated this revision to Diff 84947.
mgorny retitled this revision from "[compiler-rt] [test] Fix page address logic
in clear_cache_test to use binary negation" to "[compiler-rt] [test] Fix page
address logic in clear_cache_test".
mgorny edited the summary of this revision.
mgorny added a
mgorny added a comment.
Just to be clear, the values also differ per -O0 vs -O2. I'm not sure if we can
even reliably figure that out.
I've tried to work around the issue by building everything in 387 mode.
However, in that case muldc3_test has even larger mismatches and didn't really
want to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292257: [test] [builtins] Remove obsolete/UB tests in
__fixuns?fdi based (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28146?vs=82625=84737#toc
Repository:
rL LLVM
mgorny created this revision.
Herald added a subscriber: dberris.
Use approximate comparison between the result of __divsc3()
and the canonical value calculated, to allow the possible difference of
1 representable value resulting from optimization.
For example, the value of (0.01+j0.01)
mgorny added a comment.
Ping.
https://reviews.llvm.org/D26887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Second ping. @hfinkel, could you suggest me how to proceed with this?
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Ping.
https://reviews.llvm.org/D26764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Ping.
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288060: [Driver] Refactor distro detection & classification
as a separate API (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25949?vs=78462=79442#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288062: [Driver] Add unit tests for Distro detection
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25869?vs=78625=79444#toc
Repository:
rL LLVM
mgorny added a comment.
In https://reviews.llvm.org/D26764#606638, @beanz wrote:
> Looping in @eugenis, who added i686 support in r218761.
>
> eugenis, since i686 is identical to i386 generating it as a separate target
> is undesirable. Can you help advise as to how we can better meet your
mgorny added a comment.
In https://reviews.llvm.org/D25686#614420, @rengolin wrote:
> I think this patch should move to canonicalise the triple as per all the
> others, in the right place (vendor/environment).
>
> If you find `hardfloat` or on where the vendor should be, and there are no
>
mgorny created this revision.
mgorny added reviewers: chapuni, gribozavr, ddunbar, beanz.
mgorny added a subscriber: cfe-commits.
Extend the fix from https://reviews.llvm.org/rL286952 to unittests. The fix
added clang built
library directories (via llvm_shlib_dir) to LD_LIBRARY_PATH.
The
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289865: [test] Extend llvm_shlib_dir fix to unittests
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D27812?vs=81587=81635#toc
Repository:
rL LLVM
mgorny added a comment.
Thanks for the review. Committed now.
https://reviews.llvm.org/D26887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289436: [Driver] Fix finding multilib gcc install on Gentoo
(with gcc-config) (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26887?vs=78623=81086#toc
Repository:
rL LLVM
mgorny abandoned this revision.
mgorny added a comment.
I give up. I'm just going to complain to Gentoo ARM people a lot and maybe
they'll fix their triples.
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny added a comment.
Second ping.
https://reviews.llvm.org/D25314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added a reviewer: beanz.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Use the new llvm_canonicalize_cmake_booleans() function to canonicalize
booleans for lit tests. Replace the duplicate ENABLE_CLANG* variables
used to hold
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291495: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26900?vs=83527=83718#toc
Repository:
rL LLVM
mgorny added a comment.
As discussed on IRC, I will commit the unconditional versions for projects that
require the same version of LLVM (clang, lldb, lld) and the version with
fallback for others (runtimes).
https://reviews.llvm.org/D26900
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291477: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to
match builtin (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28213?vs=82791=83677#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292018: [cmake] Handle missing LIBUNWIND_* directories
gracefully (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25314?vs=73770=84455#toc
Repository:
rL LLVM
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.append(begin(ARMHFMuslTriples),
mgorny retitled this revision from "[Driver] Support "hardfloat" vendor triples
used by Gentoo" to "[Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi
triples".
mgorny updated the summary for this revision.
mgorny added a reviewer: atanasyan.
mgorny updated this revision to Diff 80118.
mgorny added inline comments.
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF:
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF:
mgorny added a comment.
How should I proceed, then? Was something along the lines of the earlier diff a
better idea?
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny added a comment.
In https://reviews.llvm.org/D28304#636669, @dvyukov wrote:
> User -march flag won't help as runtime is prebuilt.
I meant the flag used by the compiler vendor when compiler-rt is built.
> SCUDO is sse4.2, but tsan is sse3. Do you actually see any problems with
> sse3?
mgorny added reviewers: EricWF, mclow.lists, phosek, compnerd, Hahnfeld.
mgorny added a comment.
Little ping here. This is quite trivial, and since
https://reviews.llvm.org/D26894 has been committed already I'd like to start
adding changes like this one to all LLVM projects using llvm-config in
mgorny added a comment.
@cryptoad good to go then?
https://reviews.llvm.org/D28304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny retitled this revision from "[compiler-rt] [cmake] Disable appending
-msse* flags implicitly" to "[compiler-rt] [cmake] Disable appending -msse4.2
flag implicitly".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 83298.
https://reviews.llvm.org/D28304
mgorny added a comment.
Oh, sorry that I didn't check that. Then I guess it's good enough for me, we're
losing just few old Athlon 64 CPUs, I guess. I'll update the patch to remove
4.2 only.
https://reviews.llvm.org/D28304
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291259: [builtins] Implement __floattitf() & __floatuntitf()
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D27898?vs=82414=83385#toc
Repository:
rL LLVM
mgorny added a comment.
@compnerd, ping. Do you really think this is a real issue? As I said on the
other patch, the only case when compiler-rt would generate i686-suffixed
library is if the builder specifically used `-march=i686` for the compiler-rt
build, and in that case the i386 variant
mgorny added a comment.
In https://reviews.llvm.org/D26900#638328, @EricWF wrote:
> Is there a way to write this patch so that old `llvm-config`'s continue to
> work, at least for a little while until everybody upgrades?
Technically it's possible but I think it would add a lot of complexity.
mgorny created this revision.
mgorny added reviewers: rsmith, t.p.northover, hfinkel, EricWF.
mgorny added a subscriber: cfe-commits.
Correct the logic used to set `ATOMIC_*_LOCK_FREE` preprocessor macros not
to rely on the ABI alignment of types. Instead, just assume all those
types are aligned
mgorny created this revision.
mgorny added reviewers: ddunbar, sdmitrouk, dschuff.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, dberris.
Remove the failing tests for __fixunssfdi() and __fixunsdfdi() that
relied on undefined (and most likely obsolete in terms of
mgorny added a comment.
In https://reviews.llvm.org/D26796#632602, @compnerd wrote:
> This would need an upgrade path, since the output name can actually be
> different from the `AchTypeName` (e.g. i386 vs i686).
I was considering committing this alongside with the i686 removal, and assuming
mgorny created this revision.
mgorny added reviewers: mclow.lists, beanz, phosek, EricWF.
mgorny added a subscriber: cfe-commits.
Make LLVM_CMAKE_PATH a cache variable in order to support user
overrides. This is useful when building multiple multilib variants of
libunwind using CMake files from a
mgorny retitled this revision from "[cmake] Obtain LLVM_CMAKE_PATH from
llvm-config" to "[cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 83527.
mgorny added a comment.
Updated to support fallback to
mgorny added a comment.
Ping. @eugenis, do you consider it good to go then? Or do you want me to change
something specifically?
https://reviews.llvm.org/D26764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny added a comment.
Second ping.
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added reviewers: cryptoad, kcc, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Disable the code appending -msse3 and -msse4.2 flags implicitly when
the compiler supports them. The compiler support for those
mgorny added a comment.
In https://reviews.llvm.org/D28304#635620, @cryptoad wrote:
> Hey Michal,
> If I understand correctly, my next move is to move the CRC32 code into it's
> own file an only enable SSE 4.2 for this file?
Yes, like that. Have a SSE4.2 CRC32 function in a separate file,
mgorny requested a review of this revision.
mgorny added a comment.
@EricWF suggests that it'd be better to wait a while before depending on newer
llvm-config, so it'd probably be preferable to do this one instead first.
https://reviews.llvm.org/D28295
mgorny planned changes to this revision.
mgorny added a comment.
Since https://reviews.llvm.org/D26894 was accepted, I will be preparing a patch
using that instead.
https://reviews.llvm.org/D28295
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291217: [cmake] Disable appending -msse4.2 flag implicitly
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28304?vs=83298=83347#toc
Repository:
rL LLVM
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> mgorny wrote:
> > scanon wrote:
> > > Strictly speaking there's no need to adjust `a`
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> mgorny wrote:
> > scanon wrote:
> > > mgorny wrote:
> > > > scanon wrote:
> > > > >
mgorny added a comment.
I think the easiest solution would be for you to use a path related to clang
runtime directory, and install the runtimes there.
However, this would require rethinking the structure a bit to cover multilib,
different ABIs, maybe cross. We have a cheap hack for this in
mgorny updated this revision to Diff 82235.
mgorny marked an inline comment as done.
mgorny added a comment.
I think I've shifted all of `{`/`}` to be in line with keywords.
As for the splitting the code, you're probably right. However, I'd rather do
that in a separate patch (I'll add it to my
mgorny created this revision.
mgorny added reviewers: sdmitrouk, rengolin, zatrazz.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, aemerson.
Implement the missing __floattitf() and __floatuntitf() functions, to
convert 128-bit (unsigned) integers to quad-precision
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> Strictly speaking there's no need to adjust `a` here. If we rounded up into a
> new
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290422: [tests] Add missing "int_lib.h" includes and extend
guards (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28078?vs=82402=82407#toc
Repository:
rL LLVM
mgorny created this revision.
mgorny added reviewers: dschuff, kledzik, rengolin.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Fix missing "int_lib.h" includes in ARM negdf2vfp and subdf3vfp tests.
Additionally, extend the __arm__ guard to cover the builtin
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 82414.
mgorny added a comment.
Changed mantissa -> significand.
https://reviews.llvm.org/D27898
Files:
lib/builtins/CMakeLists.txt
lib/builtins/floattitf.c
lib/builtins/floatuntitf.c
mgorny added inline comments.
Comment at: lib/builtins/floatuntitf.c:73
+long_double_bits fb;
+fb.u.high.all = (du_int)(e + 16383) << 48/* exponent */
+ | ((a >> 64) & 0xLL); /* mantissa */
rengolin wrote:
>
mgorny added inline comments.
Comment at: lib/builtins/floatuntitf.c:73
+long_double_bits fb;
+fb.u.high.all = (du_int)(e + 16383) << 48/* exponent */
+ | ((a >> 64) & 0xLL); /* mantissa */
rengolin wrote:
>
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
Reopening since it has been reverted.
Repository:
rL LLVM
https://reviews.llvm.org/D28213
___
cfe-commits mailing list
mgorny added inline comments.
Comment at: cmake/config-ix.cmake:438-441
if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
+(COMPILER_RT_BUILD_SANITIZERS OR COMPILER_RT_BUILD_XRAY) AND
(OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR
(OS_NAME
mgorny added inline comments.
Comment at: test/sanitizer_common/CMakeLists.txt:7
set(SUPPORTED_TOOLS)
-if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID)
+if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND
+ COMPILER_RT_HAS_ASAN)
mgorny updated this revision to Diff 93347.
mgorny added a comment.
Needed to rebase again.
https://reviews.llvm.org/D25157
Files:
cmake/config-ix.cmake
include/CMakeLists.txt
lib/CMakeLists.txt
test/sanitizer_common/CMakeLists.txt
Index: test/sanitizer_common/CMakeLists.txt
mgorny updated this revision to Diff 93296.
mgorny added a comment.
Rebased. Ping. Now that we have lit tests for builtins, it would be really
useful for us to be able to build them without having to enable sanitizers.
https://reviews.llvm.org/D25157
Files:
cmake/config-ix.cmake
1 - 100 of 859 matches
Mail list logo
