[PATCH] D125860: [clang] Only use major version in resource dir

mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay. mgorny added a comment. Herald added subscribers: Michael137, StephenFan. To be honest, I've never seen much purpose in the x.y.z directory naming and I feel like it's making packaging unnecessarily more complex, at leas

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

mgorny added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if (!

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20132d8eaa68: Link libclangBasic against libatomic when necessary. (authored by thesamesam, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. Could you issue a warning though? It's really annoying when targets disappear like that and you have to guess which of the checks failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/ https://reviews.llvm.org/D1

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. I don't have a strong opinion. I'm happy as long as there is *anything* telling me "tests were disabled because ...". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/ https://reviews.llvm.org/D137669 _

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to som

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an argu

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM (without testing, just eyeball review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

mgorny accepted this revision as: mgorny. mgorny added a comment. I'd say this is fine to land as 16.x. I'll be doing another snapshot for Gentoo next weekend, so if it lands by then, we're going to do some crash testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny added a comment. Ah, I'm sorry for the delay. I have time right now, so I'll test and push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-co

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f94fe1c3c4: [clang][Driver] allow tilde in user config dir (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. In D137024#3931126 , @thetruestblue wrote: > This patch removes the logic that sets the binary tools dir using > llvm-config. We don't have llvmConfig.cmake in our toolchain or our build > tree and relied on llvm-config to > se

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Well, I'm certainly not opposed to making all the paths configurable. However, I'm not sure if having CMake file accessible one way or another wouldn't eventually be a necessity. For one thing, I would like to move more common code from standalone build codepaths of indi

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

mgorny resigned from this revision. mgorny added a reviewer: MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. I'm afraid this is above my skills. Maybe @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

mgorny added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT LLVM_E

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny created this revision. mgorny added reviewers: rupprecht, tstellar, MaskRay, thesamesam. Herald added a project: All. mgorny requested review of this revision. The LLVMTestingAnnotations library that is now used by unittests is not installed as part of LLVM. In order to make it possible to

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny added a comment. Thanks for the superfast review! I'll push it later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142449/new/ https://reviews.llvm.org/D142449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64: FAIL: Clang :: Driver/hip-device-libs.hip (9304 of 17486) TEST 'Clang

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f8b995b6362: [clang] Fix linking to LLVMTestingAnnotations in standalone build (authored by mgorny). Herald added a project: clang. Repository: r

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. In D140315#4077193 , @yaxunl wrote: > @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in > the failed test it was not true. `CMAKE_INSTALL_LIBDIR=lib64`, so I guess `_BASENAME` is that as well. Reposit

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. While the general direction seems sound, I suspect this may be a real PITA given that for us: -DCLANG_RESOURCE_DIR="../../../../lib/clang/${LLVM_MAJOR}" I'm going to try and see later throughout the week if it's possible to keep that working with this patch. Reposit

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added reviewers: MaskRay, thesamesam, tstellar. mgorny added a comment. Ok, this turned out to be surprisingly painless, at least within our packaging. However, I'd prefer if someone more experienced looked at the CMake changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

mgorny added a comment. In D141581#4072692 , @kwk wrote: > In D141581#4071617 , @thesamesam > wrote: > >> This is currently holding back further testing on our end which is >> concerning me a bit, especially as

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. This is the final version that was pushed, correct? (the commits don't link the revision) I've raised some concerns about the resulting API in https://reviews.llvm.org/D156270#4557902. I'd appreciate if you could take a look. Repository: rG LLVM Github Monorepo CHA

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I've tested right now (as of 3398744a6106c83993611bd3c5e79ec6b94417dc ) and all c

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. > Did Gentoo switch the default long double to IEEE 128-bit floating point? `LDBL_MANT_DIG` is 106, so I guess not yet on this system. > glibc provides 2 printf implementations on ppc64le (different symbols). The > headers control which implementation is used. Is that a

[PATCH] D155380: [clang] Fix delayed template parsing

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I can confirm that the tests pass for me with this applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/ https://reviews.ll

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. This change is causing test regressions on 32-bit architectures (I've reproduced with `-m32` on amd64 and in 32-bit nspawn container on arm64): FAIL: Clang-Unit :: Interpreter/./ClangReplInterpreterTests/1/13 (1 of 1584) TEST 'Clang-Unit :: Inter

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Changing the type from `unsigned long long` to `uintptr_t` fix the test for me. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:246 + EXPECT_FALSE(!Addr); + EXPECT_EQ((unsigned long long)&printf, Addr->getValue()); } Re

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I'm sorry, by "new" you mean the version with `uintptr_t` or the original as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

mgorny added a comment. From Gentoo perspective, correct is better, correct and matching GCC is the best (we support mixing compilers to some degree). I think it'd be best to wait for confirmation on GCC end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny created this revision. mgorny added reviewers: thesamesam, sammccall, thakis, MaskRay. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang-tool

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added a comment. @thesamesam, could you test it on PPC32, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:129 +#if defined(CLANGD_DECISION_FOREST) +# define DEFAULT_RANKING_MODEL DecisionForest sammccall wrote: > this approach feels a bit heavy on the preprocessor, especially for a h

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny abandoned this revision. mgorny added a comment. Closing in favor of D139107 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cf

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

mgorny added a comment. Thanks a lot for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139107/new/ https://reviews.llvm.org/D139107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138255/new/ https://reviews.llvm.org/D138255 ___

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55891/new/ https://reviews.llvm.org/D55891

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

mgorny created this revision. mgorny added reviewers: phosek, ldionne. Herald added subscribers: jfb, dexonsmith, christof, krytarowski, srhines. 996e62eef75 added Linux-specific dependent libraries to libunwind sources. As a result, building libunwind with modern LLD on *BSD started failing due

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

mgorny added a comment. I'll look into it a bit later. I've focused on libunwind since it's breaking NetBSD buildbot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70868/new/ https://reviews.llvm.org/D70868 ___ cfe-commits mailing list cfe

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rG35bc5276ca31: [libunwind] Emit dependent libraries only when detected by CMake (authored by mgorny). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Repository: rG LLVM Github

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, kcc, dvyukov. Herald added subscribers: llvm-commits, dberris. Herald added a project: LLVM. Use a new %run wrapper for ASAN/MSAN/TSAN tests that calls paxctl in order to disable ASLR on the test executables. This makes i

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny added a comment. In D70958#1769589 , @eugenis wrote: > I meant you could define this path in the common lit config as something like > "netbsd_noaslr_prefix" and then set up the %run substitution in > subdirectories. I take that you mean passing

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny updated this revision to Diff 232270. mgorny added a comment. Updated to pass the 'prefix' via `config` object from common, and to use full path for paxctl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70958/new/ https://reviews.llvm.org/D70958 Files: compiler-rt/test/asan/l

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c2b2b9e20ab: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Git

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, rsmith, compnerd, phosek. Disable the instantiation-depth-default.cpp test on NetBSD since it requires more stack space than we have by default on NetBSD. https://reviews.llvm.org/D71419 Files: clang/test/SemaTemplate/instanti

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

mgorny created this revision. mgorny added reviewers: krytarowski, rnk, samsonov, howard.hinnant. Herald added subscribers: llvm-commits, dberris. Herald added a project: LLVM. Introduce a new %paxctl_nomprotect substitution and call it on two builtin tests that do not work with MPROTECT on NetBSD

[PATCH] D71613: [cmake] Use 'llvm-config --components' to determine components

mgorny created this revision. mgorny added reviewers: dberris, justinkb. Herald added projects: LLVM, Sanitizers. Herald added subscribers: llvm-commits, Sanitizers. Use 'llvm-config --components' to determine available components rather than relying on '--libs' to fail for non-available. This sh

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems. Please see if D71613 fixes your proble

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

mgorny created this revision. mgorny added reviewers: arichardson, aaron.ballman, rsmith, compnerd. Use correct directory to put gen_ast_dump_json_test.py instead of LLVM_BINARY_DIR. This fixes attempting to write to /usr when building clang standalone. https://reviews.llvm.org/D71615 Files:

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

mgorny updated this revision to Diff 234351. mgorny edited the summary of this revision. mgorny added a comment. Switch to using `%run_nomprotect` instead of extra `%paxctl`. This should be more consistent and should avoid potential issues with `:` on Windows. CHANGES SINCE LAST ACTION https:

[PATCH] D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test

mgorny created this revision. mgorny added reviewers: krytarowski, m.ostapenko, eugenis. Herald added subscribers: llvm-commits, Sanitizers, dberris. Herald added projects: LLVM, Sanitizers. Add a missing %run substitution to fread_fwrite test. This fixes the test on NetBSD where %run disables AS

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG6207b060ad80: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP

mgorny created this revision. mgorny added reviewers: baloghadamsoftware, jdoerfert, ABataev. Herald added subscribers: lebedev.ri, guansong, rnkovacs. Herald added a reviewer: lebedev.ri. Use LLVM_LINK_COMPONENTS to link the FrontendOpenMP library instead of passing it explicitly to LINK_LIBS. T

[PATCH] D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test

This revision was automatically updated to reflect the committed changes. Closed by commit rG20345707b2c9: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71623/new/

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG190b9110c23c: [compiler-rt] [test] Disable MPROTECT on two builtin tests (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Monor

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well? Comment at: clang/docs/CMakeList

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Well, it looks correct to me. Not sure if it's the best approach but it can be refined in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT

This revision was automatically updated to reflect the committed changes. Closed by commit rG3215f7c7a81f: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Git

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

mgorny added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:28 +foreach(lib ${interface}) + string(REGEX MATCH "^clang" is_clang_lib ${lib}) + if (NOT is_clang_lib) Any reason not to use `if(${lib} MATCHES ...)`? https://cmake.

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lib/Driver/ToolChains/Gnu.cpp:2284 +// Test the path based on the version in /etc/env.d/gcc/config-{tuple}. +GentooScanPaths.push_ba

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Thanks. Besides that one tiny nit, looks good at a first glance. I'll test it tomorrow or the next day (but only for the most basic use, sorry). However, I do not feel confident enough with Clang code to ack change this large on my own. So let's wait for @chandlerc to ta

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. If that's not a problem, then the more tests, the merrier ;-). Preferably something specific to crossdev would be helpful, given this is a new use case, and/or something that would actually have directory mismatches with CURRENT entry name (i.e. that wouldn't have worked

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, I've tried it on top of clang-6.0.0 and I get the following test failures: Failing Tests (8): Clang :: Driver/android-ndk-standalone.cpp Clang :: Driver/constructors.c Clang :: Driver/cuda-detect.cu Clang :: Driver/env.c Clang :: Driver/

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, that's a problem. I think we really ought to consider all possibilites of sysroot first, and either do not fall back to main system at all or do that only if sysroot doesn't have any install at all. Basically, it is important that we don't break non-Gentoo sysroots,

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. To be honest, I don't really know. But since we're not installing it straight to `/usr`, I suppose that's not a problem we need to solve right now. However, they do work with clang installed in `/usr/lib/llvm/*/bin`, and this patch must not regress that. So if your `/usr

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Well, it's better: Failing Tests (1): Clang :: Driver/linux-header-search.cpp It is apparently the new test failing: + /var/tmp/portage/sys-devel/clang-6.0.0-r1/work/x/y/cfe-6.0.0.src-abi_x86_32.x86/bin/clang -no-canonical-prefixes /var/tmp/portage/sys-devel

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. I'm sorry, I see the problem now — the diff generated by Phabricator does not include the empty files x_x (seriously, this thing keeps surprising me in how broken it could be). I'm going to try again with correct file set tonight or tomorrow. If you could send the comple

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Works fine, thanks a lot! Note that I haven't tested crossdev or anything special, just regular multilib. Repository: rC Clang https://reviews.llvm.org/D45233 __

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. To be honest, I find those '(deprecated)' confusing — the user may mistakenly assume that it's about all values rather than the alias. Comment at: docs/CommandGuide/clang.rst:105 + + Supported options for the C language are: + s/options

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

mgorny created this revision. mgorny added reviewers: simark, ilya-biryukov. Herald added a subscriber: ioeric. Explicitly include and build lib/Testing/Support from LLVM sources when doing a stand-alone build. This is necessary since clangd tests started to depend on LLVMTestingSupport library wh

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. Well, my idea was to list the standards one per line (like on GCC manpage), and then the '(deprecated)' comments would probably stand out enough to apply to a single line. Also, FWICS the gcc manpage simply lists which aliases are deprecated in the description text. But

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. I think you'd want a definition list instead then. But I haven't tested if they can be nested inside option lists. Repository: rC Clang https://reviews.llvm.org/D45406 _

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

mgorny added a comment. I've based this change on an earlier fix to lldb when that project started using LLVMTestingSupport. That change in turn was based on how we handle gtest across the projects. As for gtest, I think installing was not considered as an option since different projects may b

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329594: [cmake] Include LLVMTestingSupport when doing stand-alone build (authored by mgorny, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45409 Files: unittests/CMakeLists.txt I

[PATCH] D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL329594: [cmake] Include LLVMTestingSupport when doing stand-alone build (authored by mgorny, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. The diffs aren't very useful since I had to add a class for each test unit and so everything needed reindenting. You can take my word that changes boil down to: - adding `unittest` import, - adding class for each test unit and converting the functions into methods (exce

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. Before: == FAIL: tests.cindex.test_code_completion.test_code_complete_availability -- Traceback (most recent call last): File

[PATCH] D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions

mgorny created this revision. The bump of default _MSC_VER which occurred in r315107 has caused the '__declspec(thread)' TLSKind to change from STATIC to DYNAMIC. Update the clang python binding tests accordingly. Test both for behavior with old and new -fms-compatibility-version. Repository:

[PATCH] D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions

mgorny added a comment. @frutiger, do you maybe happen to have fixes for the two other test failures? Maybe I'm tracking them down unnecessarily ;-). Repository: rL LLVM https://reviews.llvm.org/D39804 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D39810: [clang] [python] [tests] Disable the broken unique-external linkage test

mgorny created this revision. Starting with https://reviews.llvm.org/rL314037, anonymous namespaces no longer give unique-external linkage to variables. As a result, the relevant test no longer works correctly. Comment it out until a replacement expression is found. Repository: rL LLVM https

[PATCH] D39810: [clang] [python] [tests] Disable the broken unique-external linkage test

mgorny abandoned this revision. mgorny added a comment. Duplicate of https://reviews.llvm.org/D39161. Repository: rL LLVM https://reviews.llvm.org/D39810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions

mgorny added a comment. I see that you haven't more luck than I did finding a better solution. How about the code completion failure? I suppose I still have to figure that one out on my own ;-). I can commit this one myself, I have it ready for commit already. Repository: rL LLVM https://r

[PATCH] D39838: [clang] [python] [tests] Update priority values in code completion test

mgorny created this revision. The priority for destructors and operators was reduced in https://reviews.llvm.org/rL314019. Adjust the values used in the test appropriately to fix the test failure. Repository: rL LLVM https://reviews.llvm.org/D39838 Files: bindings/python/tests/cindex/test

[PATCH] D39838: [clang] [python] [tests] Update priority values in code completion test

mgorny added a comment. In https://reviews.llvm.org/D39838#920399, @ilya-biryukov wrote: > LGTM. > > Can we run those tests as part of `check-all` cmake target or setup a > buildbot that runs those? Seems surprising it went unnoticed for so long. I was thinking of that but I think it'd be nice

[PATCH] D39838: [clang] [python] [tests] Update priority values in code completion test

This revision was automatically updated to reflect the committed changes. Closed by commit rL317828: [python] [tests] Update priority values in code completion test (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D39838?vs=17&id=122304#toc Repository: rL LLVM htt

[PATCH] D39161: [bindings] remove unique_external test failure

mgorny added reviewers: jbcoe, aaron.ballman. mgorny added a comment. Let's try some more reviewers. https://reviews.llvm.org/D39161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. Thanks. I'll update it to incorporate the lately committed test fixes, and push it later today. Repository: rL LLVM https://reviews.llvm.org/D39763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D39161: [bindings] remove unique_external test failure

mgorny added a comment. I've rewritten the tests to use `unittest`, so this patch needs to be updated now. However, you may want to wait a while since @compnerd promised to look at it and he might have a way to get `uniqueExternal()` linkage. https://reviews.llvm.org/D39161

[PATCH] D39810: [python] [tests] Fix test_linkage for unique external linkage

mgorny updated this revision to Diff 122575. mgorny retitled this revision from "[clang] [python] [tests] Disable the broken unique-external linkage test" to "[python] [tests] Fix test_linkage for unique external linkage". mgorny edited the summary of this revision. mgorny added reviewers: jbcoe,

[PATCH] D39810: [python] [tests] Fix test_linkage for unique external linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rL317986: [python] [tests] Fix test_linkage for unique external linkage (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D39810?vs=122575&id=122590#toc Repository: rL LLVM https

[PATCH] D39842: Allow to store precompiled preambles in memory.

mgorny added a comment. Please revert this commit. You've just broken all the stand-alone builds of clang. Comment at: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp:27 #include "llvm/ADT/StringSet.h" +#include "llvm/Config/config.h" #include "llvm/Support/CrashRecoveryConte

[PATCH] D40142: [cmake] Use llvm-lit directory when provided for stand-alone build

mgorny created this revision. After the recent lit test changes, clang attempts to run its tests via llvm-lit by default. However, the llvm-lit binary is not present when performing stand-alone build resulting in a failure out of the box. To solve that, add the llvm-lit directory to CMake when pe

[PATCH] D40142: [cmake] Use llvm-lit directory when provided for stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL318562: [cmake] Use llvm-lit directory when provided for stand-alone build (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D40142?vs=123219&id=123419#toc Repository: rL LLVM

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

mgorny added a comment. To be honest, as I said before, I'm entirely confused by the logic there, with all the prepending, appending and shuffling around. But if you believe it gives the correct result, I'm all for it. However, if that wouldn't be too much of a hassle, would you mind also renam

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

mgorny added a comment. Or even more abstract (if we assume we don't have to check for presence of `llvm_tools_dir`): path_vars = ['clang_tools_dir', 'llvm_tools_dir'] paths = [getattr(self.config, k) for k in path_vars if hasattr(self.config, k)] (untested) https://reviews.llvm.org/D402

<    2   3   4   5   6   7   8   9   >