[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353990: [HWASAN] Updated HWASAN design document to better portray the chance of missing… (authored by hctim, committed by ). Changed prior to commit:

[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

hctim created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provided rule of thumb percentage chances of miss for 4 and 8 bit tag sizes. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58195 Files:

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199632. hctim marked 2 inline comments as done. hctim added a comment. In D61923#1502988 , @cryptoad wrote: > Is the question why do Scudo has its own as opposed to rely on platform > specific ones? Yes, I have

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1503272 , @jfb wrote: > Have you asked on libcxx-dev whether a stand-alone base is something of > interest to them? No, but I will follow up on that. > Kinda... but your answer really sounds like this is a Google-only

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200094. hctim added a comment. Merged in master after fixing up some buildbots with the previous patches. Also have pinged libcxx-dev :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this broke an autoconf bot . Have submitted rL362149 , which should hopefully fix the issue. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this also broke an armv8 bot, due to a maximum number of threads issue. Have filed rL362163 to attempt to fix. If that doesn't work, I'll just disable the test for armv8. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202275. hctim added a comment. Merged with tip-of-tree in preparation for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runtime/CMakeLists.txt

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

This revision was automatically updated to reflect the committed changes. Closed by commit rL362138: [GWP-ASan] Mutex implementation [2]. (authored by hctim, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D61923?vs=202275=202276#toc

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > hctim wrote: > > morehouse wrote: > > > Can we just link with gtest_main instead of having this? > > Unfortunately not easily.

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202237. hctim marked 7 inline comments as done. hctim added a comment. - Updated from Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files:

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > Can we just link with gtest_main instead of having this? Unfortunately not easily. `generate_compiler_rt_tests` builds each

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202078. hctim marked 21 inline comments as done. hctim added a comment. - Apologies about the delay on this. Updated with Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1495428 , @gribozavr wrote: > What does GWP stand for? Google Wide Profiling . We use the name GWP-ASan, even though it's "technically

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim updated this revision to Diff 199083. hctim marked an inline comment as done. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Updated tests to use unittests rather than expose a public interface and exercise that. Minor perf improvements to

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1502266 , @jfb wrote: > Hello I'm here to bikeshed, and this is a terrible name for an LLVM project. > Or super appropriate because LLVM itself is a terrible name? In any case, > backronym it to something else, or rename

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199541. hctim marked 10 inline comments as done. hctim added a comment. Herald added subscribers: cfe-commits, srhines. Herald added a reviewer: jfb. Herald added a project: clang. - Working copy of mutex. - >>! In D61923#1502245

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1502245 , @jfb wrote: > Seems a shame to duplicate mutex again... Why can't use use the STL's version > again? It doesn't allocate. We can't use `std::mutex` as we must be C-compatible (and can't make the strong

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/platform_specific/mutex_posix.cpp:43 + +Mutex::Mutex() : PImpl(new Impl) {} +Mutex::~Mutex() { delete PImpl; } eugenis wrote: > This is a dependency on libc++ / libstdc++. > > I'm not sure about

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200760. hctim marked 2 inline comments as done. hctim added a comment. - Ifdef-d headers into mutex.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files:

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200600. hctim added a comment. Changed GWP-ASan to use platform specific mutexes. For now, we only target Android and Linux, and subsequently only need the pthread_mutex variant for POSIX. Kept around the mutex unittests as it's an easy assertion that the

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200604. hctim marked an inline comment as done. hctim added a comment. - Updated to use pointer-to-impl to abstract implementation behaviour away from header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim abandoned this revision. hctim added a comment. Abandoned as this was merged in small chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60593/new/ https://reviews.llvm.org/D60593 ___

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hctim added a comment. This change broke the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37446 Reverted in `b19d87b16f81e7c0a22a0a103c867c1b844eb8bc` TEST 'Clang-Unit :: Frontend/./FrontendTests/PCHPreambleTest.ParseWithBom'

[PATCH] D75057: Syndicate, test and fix base64 implementation

hctim added a comment. Looks like this change broke the UBSan build bots: FAIL: LLVM-Unit :: Support/./SupportTests/Base64Test.Base64 (3484 of 36324) TEST 'LLVM-Unit :: Support/./SupportTests/Base64Test.Base64' FAILED Note: Google Test filter =

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

hctim added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. For tracking purposes. The ASan leaks have been worked around in two separate patches in order to make the bots green again: - c38e42527b21acee8d01a016d5bfa2fb83202e29 -

[PATCH] D49793: [AArch64] - return address signing

hctim added a comment. Herald added a project: LLVM. This change broke the sanitizer buildbots. Please see here for more information:

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hctim added a comment. This change broke the sanitizer buildbots and was reverted here . Please see here for more information:

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. In D69825#1831691 , @plotfi wrote: > In the meantime I could -fno-integrated-cc1 the driver.c InterfaceStubs > tests to quite the bots if that is what people want (and file a bug on > bugzilla). Yes, please. A temporary

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Not a known issue - no, but MSan doesn't play nice with uninistrumented libraries (including things like libcxx) - and so it can be tricky to ensure your build is properly sanitized, which is why I'd recommend the build script :). Repository: rG LLVM Github Monorepo

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Looks like this patch broke the MSan buildbots, PTAL (repro instructions https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/46239/steps/check-clang%20msan/logs/stdio FAIL: Clang ::

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

hctim added a comment. Hi folks, looks like this patch broke `check-clang` under ASan/MSan, would you mind taking a look? Thanks. FAIL: Clang :: Driver/darwin-dsymutil.c (6208 of 24675) TEST 'Clang :: Driver/darwin-dsymutil.c' FAILED Script: --

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim added a comment. So - the `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` flag is a property of the build system and not that of the compiler. There are some places (android) where enabling `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` globally changes the behaviour of large amounts of libraries

[PATCH] D83369: hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83369/new/ https://reviews.llvm.org/D83369

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2147608 , @dokyungs wrote: > Builtin libfunc optimizations may transform memcmp and strcmp-like functions. > To disable such optimizations, -fno-builtin= flag was additionally added in > compiling new test cases. FWIW,

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2148180 , @morehouse wrote: > In D83494#2148164 , @dokyungs wrote: > > > Right. Apparently with `-O2` many calls to `memcmp`-like functions are > > removed. I just wondered,

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:242 +bool SanitizerArgs::needsFuzzerInterceptors() const { + return needsFuzzer() && !needsAsanRt() && !needsHwasanRt() && + !needsTsanRt() && !needsMsanRt(); HWASan doesn't

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim accepted this revision. hctim marked an inline comment as done. hctim added a comment. LGTM Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:52 +// NOLINTNEXTLINE +void __sanitizer_weak_hook_memcmp(void *, const void *, const void *, size_t, +

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim updated this revision to Diff 274656. hctim added a comment. Changed the filename and fixed up the inverted test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 Files:

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim created this revision. hctim added reviewers: morehouse, Dor1s. Herald added a project: clang. Herald added a subscriber: cfe-commits. Probably a useful feature for checking whether a file was built with -fsanitize=fuzzer or -fsanitize=fuzzer-no-link. N.B. __has_feature(fuzzing_coverage)

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2105036 , @arsenm wrote: > Is the fallback not working correctly in this case for some reason? I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, and that was changed in D78465

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim abandoned this revision. hctim added a comment. Abandoning - fixing the underlying issue at D82615 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim created this revision. hctim added reviewers: pcc, ostannard. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kristof.beyls, rovka. Herald added projects: clang, Sanitizers, LLVM. HWASan globals instruction selection lowering hasn't been implemented in GlobalISel or

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2109920 , @eugenis wrote: > I'm OK with this as a workaround, but it would be more natural to detect the > unsupported IR pattern in globalisel and fall back instead of disabling it > entirely. Is it difficult to do for

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2110010 , @arsenm wrote: > I don't follow. It no longer falls back, so what is the problem? HWASan-globals end up with an address that's outside of the code model (due to the tag), so the normal instruction sequence of

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM w/ nit Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091 + if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) { +CmdArgs.push_back("-fno-builtin-memcmp");

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1092 + // libFuzzer wants to intercept calls to certain library functions, so the + // following -fno-builtin-* flags disable implicit builtin knowledge about + // those functions. Other sanitizers

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM - I'm assuming this doesn't regress performance because there's no latency of the additional store due to its locality? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90424/new/ https://reviews.llvm.org/D90424 ___

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim created this revision. hctim added reviewers: cryptoad, pcc. Herald added subscribers: phosek, mgorny. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch moves -fsanitize=scudo to link the

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345939. hctim added a comment. Add arm32 to supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345906. hctim marked 2 inline comments as done. hctim added a comment. Address Kostya's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files:

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added a comment. In D102543#2763749 , @cryptoad wrote: > I think one of the remaining things to address is the supported architectures: > > set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345977. hctim added a comment. Let's submit the "adding archs" part of the patch first, then land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files:

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG694d8cbe: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests. (authored by hctim). Changed prior to commit: https://reviews.llvm.org/D102543?vs=347814=348011#toc Repository: rG LLVM

[PATCH] D103218: [Fuchsia][CMake] Add missing include path.

hctim added a comment. Thanks for the keen eye on the Fuchsia bots, I didn't see this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103218/new/ https://reviews.llvm.org/D103218 ___ cfe-commits mailing

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. In D102543#2783516 , @cryptoad wrote: > I saw some bots failure for preinit.c: > > FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) > TEST 'ScudoStandalone-i386 :: preinit.c' FAILED >

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 348116. hctim added a comment. Move lit tests behind the cmake guard: "if(COMPILER_RT_INCLUDE_TESTS AND COMPILER_RT_HAS_SCUDO_STANDALONE)" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 347814. hctim marked an inline comment as done. hctim added a comment. Address Vitaly's suggestions, make some slight changes so that cross-compilation and running under QEMU doesn't require staging the runtimes in the host compiler. Repository: rG LLVM

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC +

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

hctim added a comment. Hi, looks like this change caused a regression on the sanitizer buildbots (https://lab.llvm.org/buildbot/#/builders/169/builds/1290/steps/25/logs/stdio). Error copied below for your convenience. Can be repro'd using the bot instructions at

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

hctim added a comment. In D96120#2615085 , @russell.gallop wrote: > In D96120#2597877 , @kcc wrote: > >> I am afraid we will have to delete the older (non-standalone) variant >> entirely. >> (And the sooner the

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

hctim added a comment. Hello, it looks like this change broke the MSan and ASan buildbots. http://lab.llvm.org:8011/#/builders/5/builds/5327 FAIL: LLVM :: CodeGen/AMDGPU/GlobalISel/readcyclecounter.ll (39307 of 74613) TEST 'LLVM ::

[PATCH] D106908: Improve UBSan documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG65e9d7efb090: Improve UBSan documentation (authored by hctim). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 413625. hctim marked an inline comment as done. hctim added a comment. Herald added a project: All. Rebase onto D119384 , removing all the llvm and lld-specific parts. This patch now only contains the clang-specific bits.

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 419874. hctim marked an inline comment as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 7 inline comments as done. hctim added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/test/Lexer/has_feature_memtag_stack.cpp:2 +// RUN: %clang_cc1 -E -fsanitize=memtag-stack %s -o - | FileCheck --check-prefix=CHECK-MEMTAG %s +// RUN:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added a comment. In D118948#3427344 , @tschuett wrote: > Is `-fsanitize=memtag-heap` Android specific or target independent? It passes > Android flags to the linker?!? The frontend flag should be

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 420274. hctim marked 2 inline comments as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/Driver/memtag-ld.c:36 + +// CHECK-ASYNC: ld{{.*}} "-memtag-mode=async" +// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode= MaskRay wrote: > This will be easier

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3295321 , @MaskRay wrote: > I haven't investigated the use case yet, just commented a few things. Please > split the patch into 3: > > - BinaryFormat/ELF.h (see an inline comment) > - lld/ELF > - clang Can you clarify

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405842. hctim added a comment. (forgot to add REQUIRES: aarch64 to the lld test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, dang, arichardson, emaste. Herald added a reviewer: MaskRay. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405839. hctim marked an inline comment as done. hctim added a comment. Address Ray's comments, and made it so that stack MTE doesn't imply heap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 9 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536 +enum { + NT_TYPE_IDENT = 1, + NT_TYPE_KUSER = 3, MaskRay wrote: > If Android wants to define notes, can it use a namespace

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, hiraditya. Herald added a reviewer: aaron.ballman. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers,

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim planned changes to this revision. hctim marked 8 inline comments as done. hctim added a comment. Pushed the [1/3] ELF note parsing over to D119381 . Will leave this review for the clang-side changes, and send a new patch for the LLD changes. All of your

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3428157 , @MaskRay wrote: > Since this driver option has no-op for glibc/musl/other ELF OS, by convention > it should report an `err_drv_unsupported_opt_for_target` error. > This allows configure-time detection. Done.

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 420590. hctim added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa1490513f1: [MTE] Add -fsanitize=memtag* and friends. (authored by hctim). Changed prior to commit:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421593. hctim marked an inline comment as done. hctim added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421581. hctim added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Over to @eugenis for any final touches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Thanks, I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim created this revision. hctim added reviewers: echristo, cmtice. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An upcoming patch will extend llvm-symbolizer to provide the source line information

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. section : increase in bytes for clang built with full debuginfo : %% of total binary size .debug_loclists 317782 0.0250% .debug_abbrev 88590 0.0070% .debug_info 100708340.7929% .debug_rnglists

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3454354 , @dblaikie wrote: > This seems like it would significantly introduce debug info size for at least > some kinds of code - have you done any size measurements of this change? With

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. I just did an experiment with the following patch that punts everything to `const char*` types to try and get better folding onto a single type: The change didn't make a significant difference, with the clang binary size of 1263433512 (126384B reduction, or 1.224% ->

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. 1263559896 (new) - 1248280328 (old) = 15279568 B (1.22% increase). Seems more reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 424055. hctim added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Patch update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3462551 , @dblaikie wrote: > What's the DW_AT_type referring to? (why is there a type called ".str"?) > > For your particular purposes, it seems like the name/type/linkage name could > all be omitted & that might be OK,

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Confirmed again with `-DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On`: 1510883864 (new) - 1510881800 (old) = 2064 bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Yeah, as I drove away from my desk I realized my mistake. Will get new accurate numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 425379. hctim added a comment. Wrong base, updating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. > summary of DWARF: > & how many of these descriptions get added to the debug info? afaict, there is now: 1x .debug_addr entry for each string 1x. debug_info DW_TAG_variable for each string 1x. DW_TAG_array_type + DW_TAG_subrange_type for each unique sizeof(string) i

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added a comment. Sorry for the large patch. Honestly, looks bigger than it is due to 1-line changes in many files + many-line changes in stuff that was pretty much moved around. I didn't see a great way to split this up except for sharding out the GlobalValue changes + IR + bitcode

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/CodeGen/debug-info-variables.c:1 +// RUN: %clang_cc1 %s -debug-info-kind=standalone -S -emit-llvm -o - | FileCheck %s + dblaikie wrote: > Presumably named variables are

  1   2   3   >