[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 431810. hctim added a comment. Remove extra creation path, turns out it's a duplicate of elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: clang/lib/C

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added a comment. (friendly ping) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 433889. hctim marked an inline comment as done. hctim added a comment. Add round-trip tests, fork out the clang and langref changes for further commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added a comment. Also, the bitset now doesn't have positive-inclusions for ASan/HWASan, and no mention of MTE yet (which will come later). Sanitizers are applied to all GVs implicitly, so we only need to carry around the exclude masks. Added a comment to the struct that clarifies this.

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim created this revision. hctim added reviewers: vitalybuka, kstoimenov. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds generation of sanitizer metadata attributes (which were added in

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); kstoimenov wrote: > Would it mak

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 434145. hctim marked 2 inline comments as done. hctim added a comment. Herald added subscribers: llvm-commits, ormris, jdoerfert, steven_wu, hiraditya. Herald added a project: LLVM. Add TODO() comments from Kirill's notes. Repository: rG LLVM Github Monorepo

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim marked 7 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:429 + // Extra sanitizer attributes that are used for global variables (GV's). + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, --

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 434228. hctim marked 4 inline comments as done. hctim added a comment. Update from Vitaly's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/incl

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 434546. hctim added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CodeGenModule.cpp cl

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 434618. hctim marked 5 inline comments as done. hctim added a comment. Update w/ Vitaly's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/includ

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:181 #define GET_ATTR_NAMES #define ATTRIBUTE_ENUM(ENUM_NAME, DISPLAY_NAME) \ kw_##DISPLAY_NAME, vitalybuka wrote: > Have you considered in Attributes.inc ? > > /// Can be used as

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim created this revision. hctim added a reviewer: eugenis. Herald added a reviewer: aaron.ballman. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds the -fsanitize plumbing for memtag-globals

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim added a comment. We already have `-fsanitize=memtag` that implies `-fsanitize=memtag-heap` and `-fsanitize=memtag-stack`. It makes the most sense IMHO in the world where we want heap MTE. `-fsanitize=memtag-heap` is the most reasonable instead of `-fsanitize-memtag-heap`, as "do i need `

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim marked 5 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:397 + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, + // GV's with __attribute__((no_sanitize("address"))). vitalybuka wrote

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 435219. hctim marked 5 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/include/llvm/AsmParser/LLPa

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSanitizeL.containsLocation(EnabledAsanMas

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435257. hctim marked 3 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/SanitizerMetad

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 10 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSanitizeL.containsLocation(EnabledAsanMa

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435667. hctim marked 3 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.c

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435669. hctim added a comment. Remove two unnecessary braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/C

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435671. hctim added a comment. And some small diff-reducing touch ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp cla

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

hctim added a comment. Hi folks, I found an issue with building Android using this patch. I've reduced it down to the following problem where the evaluation of the `std::visit` is believed to be non-exhaustive, but it seems like it is? Would you mind taking a look? Admittedly, my knowledge in

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab1a5991fe76: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. Thanks for the detailed information folks. I'll probably fix it up and re-submit next week (after the US holidays) given that the blast radius seems to be bigger than I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477600. hctim added a comment. Use new MemtagABI section types, now that it's merged upstream: https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 477620. hctim marked 2 inline comments as done. hctim added a comment. Move isMemtag below assert(Sym) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/te

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 478367. hctim marked an inline comment as done. hctim added a comment. Update comment for .memtag globals when generating object files on non-MTE-globals supported architectures, and move said comment from an assert to a fatal error. Repository: rG LLVM Gi

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); fmayer wrote: > Is the story here that

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850defb86164: Add assembler plumbing for sanitize_memtag (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 479452. hctim marked 2 inline comments as done. hctim added a comment. Rebase now that the parent is submitted, clean up an old comment. New commit message also incoming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:657 +// Tagged global variables shouldn't be merged, as they are assigned unique +// memory tags at runtime. +if (GV.isTagged()) eugenis wrote: > This comment is not convincing.

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 479693. hctim added a comment. Lots of places in scudo_standalone depend on GWP-ASan, and it seems far more reasonable to make COMPILER_RT_HAS_GWP_ASAN mean "is GWP-ASan actually going to be built", rather than checking three variables in all the places. Give

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc414bbefe45a: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D75057: Syndicate, test and fix base64 implementation

hctim added a comment. Looks like this change broke the UBSan build bots: FAIL: LLVM-Unit :: Support/./SupportTests/Base64Test.Base64 (3484 of 36324) TEST 'LLVM-Unit :: Support/./SupportTests/Base64Test.Base64' FAILED Note: Google Test filter = Bas

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hctim added a comment. This change broke the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37446 Reverted in `b19d87b16f81e7c0a22a0a103c867c1b844eb8bc` TEST 'Clang-Unit :: Frontend/./FrontendTests/PCHPreambleTest.ParseWithBom'

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

hctim added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and th

[PATCH] D49793: [AArch64] - return address signing

hctim added a comment. Herald added a project: LLVM. This change broke the sanitizer buildbots. Please see here for more information: /b/sanitizer-x86_64-linux/build/llvm-pr

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hctim added a comment. This change broke the sanitizer buildbots and was reverted here . Please see here for more information: /b/sanitizer-x86_64-li

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. In D69825#1831691 , @plotfi wrote: > In the meantime I could -fno-integrated-cc1 the driver.c InterfaceStubs > tests to quite the bots if that is what people want (and file a bug on > bugzilla). Yes, please. A temporary workarou

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hctim added a comment. For tracking purposes. The ASan leaks have been worked around in two separate patches in order to make the bots green again: - c38e42527b21acee8d01a016d5bfa2fb83202e29 - e174da447c180b586719cb28f7bd556

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

hctim added a comment. Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126

[PATCH] D146987: [Assignment Tracking] Enable by default

hctim added a comment. Hey, found another error that looks to be different from @maskray's revert. $ bin/clang -c -O2 -g -ftrivial-auto-var-init=zero /tmp/repro.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim added a comment. Herald added subscribers: Enna1, abrachet, MaskRay. Herald added a project: All. Partially merged (making -fsanitize=scudo use scudo_standalone) merged in D138157 . Will probably re-use this in a bit to add the dangling scudo tests to scud

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 413625. hctim marked an inline comment as done. hctim added a comment. Herald added a project: All. Rebase onto D119384 , removing all the llvm and lld-specific parts. This patch now only contains the clang-specific bits. Rep

<    1   2   3