[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

This revision was automatically updated to reflect the committed changes. Closed by commit rL310616: Place implictly declared functions at block scope (authored by chill). Changed prior to commit: https://reviews.llvm.org/D33676?vs=109366=110587#toc Repository: rL LLVM

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseStmt.cpp:843-845 + return ParseCompoundStatement(isStmtExpr, +Scope::DeclScope | Scope::CompoundStmtScope); } rsmith wrote: > This seems to miss quite a lot of places that

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 106056. chill added a comment. Herald added a subscriber: eraman. Set the compound statement flag on all compound statement scopes (previous version used to set the flag on just enough scopes as to be sufficient for the purpose of inserting C90 implicit

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 109366. chill added a comment. Updated with only whitespace changes after formating each changed line with clang-format. https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseCXXInlineMethods.cpp lib/Parse/ParseDecl.cpp

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Thanks for the review, I'll wait a few days. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping? https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added a subscriber: cfe-commits. chill added a comment. This issue https://bugs.llvm.org//show_bug.cgi?id=2266 does not appear to trigger anymore, with this patch applied. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. In https://reviews.llvm.org/D33676#767746, @rogfer01 wrote: > I understand that the scope `S` in this case is a (function) prototype scope > so it would not be the innermost block scope, would it? That said, GCC does > not accept `p_ok` above so probably this behaviour

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 101522. chill added a comment. Update 1 notes. The scopes for compound statements are explicitly marked as such, so then `Sema::ImplicitylDefineFunction` can ascend to the nearest enclosing scope. The function scopes (ones with `Scope:FnScope`) do not

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: test/Sema/implicit-decl.c:12 int32_t compCount = 0; - if (_CFCalendarDecomposeAbsoluteTimeV(compDesc, vector, compCount)) { // expected-note {{previous implicit declaration is here}} \ - expected-error {{implicit

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 102802. chill added a comment. Update 2: added a testcase involving expression statements https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/SemaDecl.cpp test/Sema/implicit-decl-c90.c

[PATCH] D38628: Remove unneeded typename from test

chill added a comment. FYI, there is a similar issue in `test/std/utilities/variant/variant.helpers/variant_alternative.fail.cpp` added by the same commit git hash: a12318f5ae0aae44eb17f376d3598717b45f7a5f "Added failing tests for index out of range for tuple_element> and

[PATCH] D46439: Fix incorrect packed aligned structure layout

chill created this revision. chill added reviewers: rsmith, aaron.ballman. Executing the following program #include #include struct S { char x; int y; } __attribute__((packed, aligned(8))); struct alignas(8) T { char x; int y; } __attribute__((packed));

[PATCH] D46439: Fix incorrect packed aligned structure layout

chill marked an inline comment as done. chill added a comment. Update: updated comment, added a test. Comment at: lib/Sema/SemaDecl.cpp:15651 } } else { ObjCIvarDecl **ClsFields = rsmith wrote: > Do we need to do any attribute processing in this

[PATCH] D46439: Fix incorrect packed aligned structure layout

chill updated this revision to Diff 145687. https://reviews.llvm.org/D46439 Files: lib/Sema/SemaDecl.cpp test/Layout/itanium-pack-and-align.cpp Index: test/Layout/itanium-pack-and-align.cpp === --- /dev/null +++

[PATCH] D46439: Fix incorrect packed aligned structure layout

chill added a comment. Ping? https://reviews.llvm.org/D46439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

This revision was automatically updated to reflect the committed changes. Closed by commit rC332843: [Sema] Fix incorrect packed aligned structure layout (authored by chill, committed by ). Changed prior to commit: https://reviews.llvm.org/D46439?vs=145687=147781#toc Repository: rC Clang

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

chill added a comment. Thanks a lot! https://reviews.llvm.org/D46439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill updated this revision to Diff 149252. chill added a comment. Update: - similar changes needed for AArch64 - added/updated tests https://reviews.llvm.org/D46013 Files: include/clang/AST/ASTContext.h include/clang/AST/RecordLayout.h lib/AST/ASTContext.cpp lib/AST/RecordLayout.cpp

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill updated this revision to Diff 149536. chill added a comment. Update: - fix only APCS, don't touch other ABIs - misc other https://reviews.llvm.org/D46013 Files: include/clang/AST/ASTContext.h include/clang/AST/RecordLayout.h lib/AST/ASTContext.cpp lib/AST/RecordLayout.cpp

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill marked 2 inline comments as done. chill added a comment. In https://reviews.llvm.org/D46013#1118014, @efriedma wrote: > I'm not sure Apple will want to mess with their ABI like this... adding some > reviewers. Fair enough, I'd rather not touch it :) https://reviews.llvm.org/D46013

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill updated this revision to Diff 150148. chill added a comment. Update: refactor a bit to not impose size overhead on targets, which don't use natural alignment. https://reviews.llvm.org/D46013 Files: include/clang/AST/ASTContext.h include/clang/AST/RecordLayout.h

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill updated this revision to Diff 152679. chill added a comment. Update: use "unadjusted alignment" instead of "natural alignment", rename things accordingly. https://reviews.llvm.org/D46013 Files: include/clang/AST/ASTContext.h include/clang/AST/RecordLayout.h lib/AST/ASTContext.cpp

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:5055 + Alignment = getContext().getTypeNaturalAlign(Ty); + Alignment = std::min(std::max(Alignment, 64u), 128u); +} else { t.p.northover wrote: > I think the max/min logic is more

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. In https://reviews.llvm.org/D46013#1140336, @t.p.northover wrote: > I'm fine with the ABI changes, but I'm not very convinced by the > "NaturalAlignment" name. I'd rather not put target names in API functions. The meaning of that field is pretty target independent

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. In https://reviews.llvm.org/D46013#1084440, @efriedma wrote: > I'd like to see some tests for __attribute((packed)). Thanks, indeed it does not work correctly on packed structures. Back to the drawing board ... Repository: rC Clang https://reviews.llvm.org/D46013

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill created this revision. chill added reviewers: dblaikie, keith.walker.arm. Herald added subscribers: JDevlieghere, aprantl. This is the `clang` counterpart to https://reviews.llvm.org/D42734 This patch: - fixed an incorrect sign-extension of unsigned values, when emitting debug info

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132587. chill added a comment. Changes, relative to the previous revision: - a few tweaks to the tests https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeGenCXX/debug-info-enum-class.cpp

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill marked 3 inline comments as done. chill added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, dblaikie wrote: > Could

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132414. chill added a comment. Minor update, the parameter to `createEnumerator` is `IsUnsigned` now (instead of `IsSigned`), changed caller. https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132822. chill added a comment. Changes since last revision: - Add/update test to check that each enumerator belongs to the right enumeration https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

This revision was automatically updated to reflect the committed changes. Closed by commit rL324490: [DebugInfo] Improvements to representation of enumeration types (PR36168) (authored by chill, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

This revision was automatically updated to reflect the committed changes. Closed by commit rC324490: [DebugInfo] Improvements to representation of enumeration types (PR36168) (authored by chill, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42736 Files:

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rC338279: [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments (authored by chill, committed by ). Repository: rC Clang https://reviews.llvm.org/D46013 Files:

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill updated this revision to Diff 157662. chill added a comment. Fixed to properly examine the canonical type when getting it's unadjusted alignment. https://reviews.llvm.org/D46013 Files: include/clang/AST/ASTContext.h include/clang/AST/RecordLayout.h lib/AST/ASTContext.cpp

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill marked an inline comment as done. chill added a comment. Thanks for pointing this! https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Please, wait a couple of days before committing to give a chance to someone else to weigh in. Repository: rC Clang https://reviews.llvm.org/D48916

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

chill added inline comments. Comment at: test/CodeGen/clang-sections-attribute.c:1 +// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s + Isn't it possible for the test to fail if the Arm target is not configured? Repository: rC Clang

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill created this revision. chill added reviewers: john.brawn, olista01, eli.friedman, rengolin. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. The "Procedure Call Procedure Call Standard for the ARM® Architecture"

[PATCH] D64410: [WIP] Intrinsics side effects

chill created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. Change-Id: I49f5612ce6899004fa84b9a83c34dcd2d9af8224 Consistent types and naming for AArch64 target features (NFC) Change-Id:

[PATCH] D64410: [WIP] Intrinsics side effects

chill abandoned this revision. chill added a comment. I fail at arcanist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64410/new/ https://reviews.llvm.org/D64410 ___ cfe-commits mailing list

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. Going to commit as obvious. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64415/new/ https://reviews.llvm.org/D64415 ___ cfe-commits

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chill added a comment. Herald added a project: LLVM. Shouldn't we disable `OPT_ffine_grained_bitfield_accesses` only if TSAN is active? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36562/new/ https://reviews.llvm.org/D36562

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chill added a comment. In D36562#1641930 , @wmi wrote: > In D36562#1639441 , @chill wrote: > > > Shouldn't we disable `OPT_ffine_grained_bitfield_accesses` only if TSAN is > > active? > > > I don't remember why it

[PATCH] D67542: Fix depfile name construction

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67542/new/ https://reviews.llvm.org/D67542 ___ cfe-commits mailing list

[PATCH] D67542: Fix depfile name construction

chill added a reviewer: chill. chill added inline comments. Comment at: clang/test/Driver/metadata-with-dots.c:2 +// RUN: mkdir -p out.dir +// RUN: cat %s > out.dir/test.c +// RUN: %clang -E -MMD %s -o out.dir/test Is this going to ruin on Windows ?

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 212332. chill added a comment. Rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill added a comment. If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 ___ cfe-commits

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

This revision was automatically updated to reflect the committed changes. Closed by commit rL367428: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill, committed by ). Changed prior to commit: https://reviews.llvm.org/D64416?vs=212332=212559#toc Repository:

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill reopened this revision. chill added a comment. This revision is now accepted and ready to land. I reverted the patch, have to rework `tcancel`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 210768. chill added a comment. This revision is now accepted and ready to land. Changed `tcancel` implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files:

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366315: [AArch64] Consistent types and naming for AArch64 target features (NFC) (authored by chill, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366322: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D64415: Consistent types and naming for AArch64 target features (NFC)

chill updated this revision to Diff 210286. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64415/new/ https://reviews.llvm.org/D64415 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h Index: clang/lib/Basic/Targets/AArch64.h

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 211140. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D68711: Implement target(branch-protection) attribute for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa6d48fa70eb: Implement target(branch-protection) attribute for AArch64 (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

chill added a comment. I'm a bit unsure how much we're willing to pollute the namespace: in this particular case looking at the four `__bitcast_*` functions. I appreciate that getting rid of them would require emitting LLVM IR bitcasts, so a bit more effort compared to the macro approach.

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

chill added a comment. I hope I will be able to pick this up in the following weeks and land patches a couple of weeks later. Sorry for the delay, but priorities shift all the time ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62394/new/ https://reviews.llvm.org/D62394

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added a comment. TBH, I quite dislike the creeping abuse of `SubtargetFeature`s as code generation options. cf. Target.td:1477 //===--===// // SubtargetFeature - A characteristic of the chip set. // IMHO, since

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:902 + std::vector = getTargetOpts().Features; + std::string SearchFeature = "+reserve-" + RegName.str(); + for (std::string : Features) { SjoerdMeijer wrote: > I was pointed at

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added a comment. In D68862#1708079 , @carwil wrote: > > IMHO, since reserved registes are per-function, this strongly suggests > > implementation as function attribute(s), rather than subtarget features > > (also for the pre-existing r9). > > What

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added a comment. That said, my comments are not of the "over my dead body" kind ;) Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } I would

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:200 +if (!F.hasFnAttribute("branch-target-enforcement")) + return false; +Attribute A = F.getFnAttribute("branch-target-enforcement"); chill wrote: >

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Please, wait a couple of days before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/ https://reviews.llvm.org/D74966

[PATCH] D72762: [ARM][TargetParser] Improve handling of dependencies between target features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3627c91ead93: [ARM][TargetParser] Improve handling of dependencies between target features (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D73459: [ARM] Add documentation for -march= and -mfpu= command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGac2153546074: [ARM] Add documentation for -march= and -mfpu= command line options (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D72633: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rGda3f2b414ace: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D71843: [ARM][MVE] MVE-I should not be disabled by -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rG173b711e83d7: [ARM][MVE] MVE-I should not be disabled by -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5151 + return Address; +} +llvm::Function *F = Can drop the extra braces here. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5156 +llvm::CallInst *Call =

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

chill added a comment. In D75044#1966997 , @chill wrote: > Needs a test in `clang/test` that `__builtin_extract_return_address` is > translated to `llvm.extractreturnaddress`. Nevermind, I'm blind. CHANGES SINCE LAST ACTION

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

chill added a comment. Needs a test in `clang/test` that `__builtin_extract_return_address` is translated to `llvm.extractreturnaddress`. What if LLVM IR contains a call to `llvm.extractreturnaddress`, but the target is not AArch64? Comment at:

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5149-5152 + if (BPI.BranchTargetEnforcement) +Fn->addFnAttr("branch-target-enforcement", "true"); + else +Fn->addFnAttr("branch-target-enforcement", "false");

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, conditional on the dependent patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77134/new/ https://reviews.llvm.org/D77134

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

chill added a reviewer: efriedma. chill added a subscriber: efriedma. chill added a comment. Following @efriedma comment here http://lists.llvm.org/pipermail/cfe-dev/2020-March/065017.html LGTM. Comment at: clang/include/clang/Basic/TargetInfo.h:18 #include

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } danielkiss wrote: > chill wrote: > > I would really prefer to not set

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 3 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 2 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; }

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 4 inline comments as done. chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + snidertm wrote: > Just curious … Does the LLVM backend have a way

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill added a comment. In D71129#1956137 , @snidertm wrote: > Have you already committed support for CMSE attributes to the LLVM backend? > Or is that on the way? The last two CMSE patches are under review: https://reviews.llvm.org/D76518 Repository:

[PATCH] D77270: Fix the check for regparm in FunctionType::ExtInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG334ac8105401: Fix the check for regparm in FunctionType::ExtInfo (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D76369: [CMSE] Clear padding bits of struct/unions/fp16 passed by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG102b4105e3fd: [CMSE] Clear padding bits of struct/unions/fp16 passed by value (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D78129: Add Marvell ThunderX3T110 support

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in { def PACIAZ : SystemNoOperands<0b000,

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I see. I can also count (`grep -rn '#include.*https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I'm sorry, I don't understand the issue. Certainly it's the compiler (driver) responsibility to setup include paths according to the selected target. How do you trigger a problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75109: Apply function attributes through array declarators

This revision was automatically updated to reflect the committed changes. Closed by commit rG6081ccf4a3b6: Apply function attributes through array declarators (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG080d046c91d2: [ARM][CMSE] Implement CMSE attributes (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. LGTM, as soon as D85649 is accepted (so they stay in sync). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 ___ cfe-commits mailing list

  1   2   >