[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1954 + // than 23760. + // It might be nice to use AArch64::MOVi32imm here, which would get + // expanded in PreSched2

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 345949. nickdesaulniers added a comment. - braces, typo fix, add comment about additional approaches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine to me; the only reference in all of Android that looks problematic might be building libaom for windows:

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. LGTM but please review the linter warnings. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); did you mean to drop support for

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 345587. nickdesaulniers added a comment. Herald added a subscriber: dang. - support up to +/- 4096 non-multiples of 8. We could get crazy with psuedo instructions and register scavenging, but this is really overkill; the very first case of positive

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +.addImm(Options.StackProtectorGuardOffset >> 3); + else dmgreen wrote: > nickdesaulniers wrote: > > dmgreen wrote: >

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. In D100919#2750125 , @dmgreen wrote: > It's worth adding -verify-machineinstrs to the tests, to check the code > passes the internal checks. Done. Comment at:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 344549. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder USE/DEF, add -verify-machineinstrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaefbfbcbd776: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion (authored by nickdesaulniers). Repository: rG LLVM

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342921. nickdesaulniers added a comment. - prefer addDef, explicit register kills Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:20 +; RUN: --stack-protector-guard-offset=-1 -o - | \ +; RUN: FileCheck --check-prefix=CHECK

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342905. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

nickdesaulniers added a comment. I didn't see any instances in quick testing on the Linux kernel: x86_64 defconfig, aarch64 defconfig, arm defconfig, x86_64 allmodconfig. So I guess that's a good thing (for Linux)! Comment at: clang/lib/Sema/SemaExpr.cpp:10723-10733 +

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

nickdesaulniers added a comment. In D98798#2734598 , @xbolva00 wrote: > Maybe Nick could try this patch with linux kernel? Yes! Thank you of thinking of me for this; we're currently sorting issues identified by this warning (as implemented today, for

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 7 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 342475. nickdesaulniers added a comment. - "expected one of: ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +"invalid value '%1' in '%0', value must be 'none' or a

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. In D101387#2731436 , @awarzynski wrote: > In D101387#2730043 , > @nickdesaulniers wrote: > >> @FarisRehman when I run `llvm-lit -vv >> flang/test/Driver/fixed-line-length.f90`

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 342470. nickdesaulniers added a comment. - trim diag as per @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. In D100581#2730760 , @mbenfield wrote: > In D100581#2730557 , > @nickdesaulniers wrote: > >> I see lots of instances from the kernel that look like this when reduced: > > > >>

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. Testing Diff 342071 on the mainline Linux kernel, just building x86_64 defconfig triggers 19 instances of this warning; all look legit. ;) In D100581#2730708 , @dblaikie wrote: > In D100581#2730557

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. The additions of `-Wno-unused-but-set-variable` to: - clang/test/SemaObjC/foreach.m - clang/test/SemaCXX/sizeless-1.cpp - clang/test/SemaCXX/shift.cpp - clang/test/SemaCXX/goto.cpp - clang/test/Sema/vector-gcc-compat.cpp - clang/test/Sema/vector-gcc-compat.c -

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I see lots of instances from the kernel that look like this when reduced: $ cat foo.c int page; int put_page_testzero(int); void foo (void) { int zeroed; zeroed = put_page_testzero(page); ((void)(sizeof(( long)(!zeroed; } $ clang -c

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:876 UnusedLocalTypedef, UnusedValue, UnusedVariable, -UnusedPropertyIvar]>, +UnusedButSetVariable,

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. @FarisRehman when I run `llvm-lit -vv flang/test/Driver/fixed-line-length.f90` I see: UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) This is with `-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt;flang"` used, and a `flang` binary produced. Does

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Ready for rereview. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">;

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341742. nickdesaulniers added a comment. - remove extra whitespace, use xbolva00's sugguestion text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; xbolva00 wrote: > invalid value '%1' in '%0',

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. While I appreciate the flexibility afforded by %select; I find the suggestions unreadable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341711. nickdesaulniers added a comment. - fix flang diag placeholders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101387: remove single quotes around sugguestion diagnostic

nickdesaulniers updated this revision to Diff 341709. nickdesaulniers added a comment. - rework diags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I'm happy to retest with a few Linux kernel builds...tomorrow! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. In D100581#2723789 , @mbenfield wrote: > But gcc's behavior is to not trigger here so maybe following it is best. Perhaps file a bug against GCC to find whether that was intentional or a bug? Repository: rG LLVM

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. Huh, maybe not: https://godbolt.org/z/PnE1fMGWo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits mailing list

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I think this is triggering some false positives in builds of the Linux kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340932. nickdesaulniers added a comment. - rebase on D101387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340931. nickdesaulniers added a comment. - rebase on D101387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files:

[PATCH] D101387: remove single quotes around sugguestion diagnostic

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, MaskRay, DavidSpickett. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clutters the sugguestion. Repository: rG LLVM Github

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:59 +// INVALID-VALUE-AARCH64: error: invalid value 'tls' in 'mstack-protector-guard=','valid arguments to

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers added a comment. In D101327#2718989 , @DavidSpickett wrote: > So if kernel builds are using a small subset of registers, just check for > those. The kernel uses just one for aarch64. It looks like GCC just feeds through whatever is

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340915. nickdesaulniers added a comment. - prefer vanilla array + llvm::find Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) DavidSpickett wrote: > nickdesaulniers

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340905. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - prefer err_drv_invalid_value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D101325: [CodeGenOptions] make StackProtectorGuardOffset signed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea8416bf4df4: [CodeGenOptions] make StackProtectorGuardOffset signed (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340662. nickdesaulniers added a comment. - remove comment about string case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files:

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers created this revision. nickdesaulniers added reviewers: echristo, jyknight, rsmith. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In order to support arbitrary

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) nickdesaulniers wrote: > nickdesaulniers

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340652. nickdesaulniers added a comment. This revision is now accepted and ready to land. - add support for NPOT and negative offsets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D101325: [CodeGenOptions] make StackProtectorGuardOffset signed

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, craig.topper, MaskRay, LemonBoy. Herald added subscribers: jansvoboda11, dexonsmith, dang, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) nickdesaulniers wrote: > nickdesaulniers

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added subscribers: jyknight, echristo. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion)

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3114 if (Arg *A = Args.getLastArg(options::OPT_mstack_protector_guard_offset_EQ)) { StringRef Value = A->getValue(); nickdesaulniers wrote: > TODO: GCC treats

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340212. nickdesaulniers added a comment. This revision is now accepted and ready to land. - combine tests, clean up Clang drivers slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg-nonzero-offset.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc %s --stack-protector-guard=sysreg \ This can be

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340192. nickdesaulniers added a comment. This revision is now accepted and ready to land. - fix 32b ARM triple, add test for non-zero offset, actually load ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Herald added a subscriber: tmatheson. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3104 << A->getAsString(Args) << TripleStr; -if (Value != "tls" && Value != "global") { +if (Value != "tls" && Value != "global" &&

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Nice idea to create `Function::createWithDefaultAttr` then reuse for multiple purposes! Comment at: llvm/lib/IR/Function.cpp:333 Function

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Pretty sure I need to do something with non-zero values of `-mstack-protector-guard-offset=0`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) TODO: can we re-use

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. I still have some todos that I will get to tomorrow, but posting this early for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, efriedma, MaskRay. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, +

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. In D100251#2684083 , @MaskRay wrote: > In D100251#2684074 , > @nickdesaulniers wrote: > >>> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >>> while >>>

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. > -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame > while > -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address > produces .eh_frame. Does this patch change that behavior? Repository: rG LLVM Github Monorepo

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

nickdesaulniers added a comment. > Let's first give users tools to weed out the cases where the pointer > passed into function's argument is underaligned. Isn't there already `-Walign-mismatch` in clang? We definitely have 1 unresolved case of that affecting the Linux kernel ATM:

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

nickdesaulniers accepted this revision. nickdesaulniers added a comment. I don't foresee this affecting Linux kernel builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2662990 , @jcai19 wrote: > We can probably remove the -fno-integraetd-as case. Or split it out into a separate test file with `// REQUIRES: linux`. Either actually is fine by me. Repository: rG LLVM Github

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. ah, sorry, I think we're missing a `// REQUIRES: linux` in the newly added test? I've pushed a revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added inline comments. Comment at: clang/test/Driver/as-version.s:9 +// RUN: | FileCheck --check-prefix=GAS %s +// GAS: GNU assembler What happens if we run this on windows (where I suspect that GAS isn't available)? Perhaps a `CHECK-NOT:

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2657509 , @MaskRay wrote: > gcc does not understand options in `-Wa,` so `-Wa,--version` needs to be used > this way: `gcc -Wa,--version -c -x assembler /dev/null -o /dev/null` > The verbose syntax makes it not

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's drop the Android part, too? Update the description (commit message), too? I checked our oldest supported kernel version, and we don't use `-B` either:

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added a comment. Thanks for the patch! It is a much needed clarification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 ___ cfe-commits mailing

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

nickdesaulniers added a comment. I tested this on some wacko LTO kernel build failure (https://github.com/ClangBuiltLinux/linux/issues/1269). The error message went from: > :0: error: __ia32_compat_sys_sysctl changed binding to STB_GLOBAL To: unimplemented UNREACHABLE executed at

[PATCH] D88631: [X86] Support customizing stack protector guard

nickdesaulniers added a comment. Herald added a subscriber: jansvoboda11. Looks like there's also a `-mstack-protector-guard-symbol=` which Linux kernel developers are looking to use for 32b X86 kernels: https://bugs.llvm.org/show_bug.cgi?id=49209. Repository: rG LLVM Github Monorepo

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa680bc3a31d3: [clang][Arm] Fix handling of -Wa,-implicit-it= (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. Thanks for the review (here and D96304 )! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:26 +/// assembler flag appearing last (latter wins). +// RUN: %clang -target arm-linux-gnueabi -### -mimplicit-it=never -Wa,-mimplicit-it=always %S/Inputs/wildcard1.c 2>&1 |

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers updated this revision to Diff 322807. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder test checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers updated this revision to Diff 322439. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - address code review comments, add moar tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers created this revision. nickdesaulniers added reviewers: DavidSpickett, ostannard. Herald added a subscriber: danielkiss. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similiar to D95872

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great. Thanks again David. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95872/new/ https://reviews.llvm.org/D95872

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV8

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers added a comment. Wow, thank you so much for the work that went into this patch! Very thorough tests. Just minor questions about yet more test cases. Patch LGTM. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both.

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5179 if (RecordDecl *OwningClass = dyn_cast(Owner)) { -Anon = FieldDecl::Create( -Context, OwningClass, DS.getBeginLoc(), Record->getLocation(), -/*IdentifierInfo=*/nullptr,

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, aaron.ballman. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When declaring an anonymous struct with `const` or `volatile` qualifiers, ensure

[PATCH] D94442: clang: Always pass PowerPC endian information to GNU as

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a23fbd28c75: clang: Always pass PowerPC endian information to GNU as (authored by nathanchance, committed by nickdesaulniers). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

nickdesaulniers added a comment. Much thanks for the patch! Comment at: clang/test/Driver/sigpipe-handling.c:2 +// REQUIRES: shell +// RUN: %clang -E -fno-integrated-cc1 %s | tee /dev/null | head -n1 | FileCheck %s + Looks like clang -E

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

nickdesaulniers added a comment. Compiler crash reported in: https://bugs.llvm.org/show_bug.cgi?id=48695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78105/new/ https://reviews.llvm.org/D78105 ___

[PATCH] D68410: [AttrDocs] document always_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGe75fec2b238f: [AttrDocs] document always_inline (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 melver wrote: > nickdesaulniers wrote: > > Do we

<    5   6   7   8   9   10   11   12   13   14   >