[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88662. pirama added a comment. Changed the name of the utility that builds the arch-specific directory. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88663. pirama added a comment. Use getArchTypeName() instead of getArchName(). https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added a comment. In https://reviews.llvm.org/D30015#678243, @Hahnfeld wrote: > Why is this only for OpenMP? I imagine this should be done for **all** > runtime libraries The other runtime libraries have the arch included in the library's name and the driver links the correct file.

[PATCH] D30015: Add arch-specific directory to search path

pirama added a comment. I believe I've addressed all open issues, but this patch has changed a lot since Dan marked it accepted. @Hahnfeld or @mgorny: Can one of you give a LGTM if you are satisfied? https://reviews.llvm.org/D30015 ___

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

pirama added inline comments. Comment at: lib/Driver/Tools.cpp:8683 if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) -addOpenMPRuntime(CmdArgs, getToolChain(), Args); +addOpenMPRuntime(CmdArgs, getToolChain(), Args, JA);

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88799. pirama added a comment. Stricter tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// pirama wrote: > I feel this test is fragile. Any idea how to further restrict and require > that

[PATCH] D30015: Add arch-specific directory to search path

pirama added a reviewer: rnk. pirama added a subscriber: rnk. pirama added a comment. @rnk: This patch was to address discussion in http://lists.llvm.org/pipermail/openmp-dev/2017-February/001659.html but now also addresses http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html. Can

[PATCH] D30015: Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:18 +// +// CHECK-ARCHDIR: -L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath" {{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux +// CHECK-NO-ARCHDIR-NOT:

[PATCH] D30015: Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:18 +// +// CHECK-ARCHDIR: -L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath" {{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux +// CHECK-NO-ARCHDIR-NOT:

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added a subscriber: openmp-commits. pirama marked an inline comment as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:3267 + if (llvm::sys::fs::is_directory(CandidateLibPath)) +CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath)); +

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added a comment. I am fine to do this more generally, but not sure of the scope. Should this be always added or only if a runtime (sanitizer or openmp or xray) is requested? https://reviews.llvm.org/D30015 ___ cfe-commits mailing list

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88768. pirama added a comment. - Arch-subdir is now always added to -L - It is added to -rpath during native compilation. - Tests have been updated https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// I feel this test is fragile. Any idea how to further restrict and require that the default target

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88864. pirama added a comment. Fix typo. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 88865. pirama marked an inline comment as done. pirama added a comment. Add arch name to -rpath test. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama added a comment. In https://reviews.llvm.org/D30920#700741, @mehdi_amini wrote: > In https://reviews.llvm.org/D30920#700574, @hfinkel wrote: > > > In https://reviews.llvm.org/D30920#700557, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D30920#700433, @tejohnson wrote: > > > >

[PATCH] D30947: [Driver] Fix arch-specific-libdir-rpath.c

pirama created this revision. Fix the test by adding missing -target flags with a 'linux' triple. https://reviews.llvm.org/D30947 Files: test/Driver/arch-specific-libdir-rpath.c Index: test/Driver/arch-specific-libdir-rpath.c

[PATCH] D30947: [Driver] Fix arch-specific-libdir-rpath.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL297754: [Driver] Fix arch-specific-libdir-rpath.c (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D30947?vs=91746=91747#toc Repository: rL LLVM

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

pirama added inline comments. Comment at: lib/Driver/ToolChain.cpp:652 +// libc++ may be installed per arch. +addArchSpecificRPath(*this, Args, CmdArgs); break; `addArchSpecificRPath` is a static function in Tools.cpp and isn't visible here.

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 90532. pirama edited the summary of this revision. pirama added a comment. Fixed comment in test and added a test for -fsanitize=address without -shared-libasan. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h

[PATCH] D30015: Add arch-specific directory to search path

pirama added a comment. Committed. Thanks for the reviews! Repository: rL LLVM https://reviews.llvm.org/D30015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30015: Add arch-specific directory to search path

pirama marked an inline comment as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:2007-2009 + // In the cross-compilation case, arch-specific library path is likely + // unavailable at runtime. + if (TC.isCrossCompiling()) return; rnk

[PATCH] D30015: Add arch-specific directory to search path

This revision was automatically updated to reflect the committed changes. Closed by commit rL296927: Add arch-specific directory to search path (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D30015?vs=90532=90545#toc Repository: rL LLVM

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91633. pirama added a comment. - Rebase - Added command line flag and updated tests. https://reviews.llvm.org/D30700 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c test/Driver/arch-specific-libdir.c test/lit.cfg

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

pirama added inline comments. Comment at: lib/Driver/ToolChain.cpp:652 +// libc++ may be installed per arch. +addArchSpecificRPath(*this, Args, CmdArgs); break; Hahnfeld wrote: > pirama wrote: > > `addArchSpecificRPath` is a static function in

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama created this revision. Herald added a subscriber: mehdi_amini. Address PR32155: Skip passing -Os and -Oz to the Gold plugin using -plugin-opt. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91635. pirama added a comment. *Actually* add the command line flags. https://reviews.llvm.org/D30700 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama marked 3 inline comments as done. pirama added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:369 if (A->getOption().matches(options::OPT_O4) || -A->getOption().matches(options::OPT_Ofast)) +

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91671. pirama added a comment. Address review comments https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ===

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91743. pirama added a comment. Update commit message https://reviews.llvm.org/D30700 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c test/Driver/arch-specific-libdir.c

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91738. pirama added a comment. Explicitly pass -O2 instead of relying on the default opt level. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c

[PATCH] D30700: [Driver] Add flag to request arch-specific-subdir in -rpath

This revision was automatically updated to reflect the committed changes. Closed by commit rL297751: [Driver] Add flag to request arch-specific-subdir in -rpath (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D30700?vs=91743=91744#toc Repository: rL LLVM

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama created this revision. This patch unconditionally adds -rpath of the arch-specific subdirectory in resource directory (instead of doing so only during native compilation). This patch also re-enables test arch-specific-libdir.c which was silently unsupported because of the REQUIRES tag

[PATCH] D30015: Add arch-specific directory to search path

pirama marked 2 inline comments as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:289 + CmdArgs.push_back("-rpath"); + CmdArgs.push_back(Args.MakeArgString(CandidateRPath.c_str())); +} rnk wrote: > We shouldn't add rpath to

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 90373. pirama added a comment. Add -rpath only when a runtime is included as a shared library. And, cleanup tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama added a comment. In https://reviews.llvm.org/D30700#694511, @rnk wrote: > I was thinking `-f[no-]compiler-rt-rpath` or something, but openmp is not > part of compiler-rt. Name recommendations welcome. \ Maybe `-f[no-]rtlib-add-rpath`? > We might also want to reconsider the default

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama added a comment. From the discussion, it seems it is theoretically feasible to make optimization for speed a function-level attribute as well. After looking at the PassMangerBuilder for this bug, I think that'll make the optimization passes cleaner by keeping the passes and their

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

pirama added inline comments. Comment at: cmake/caches/Android-stage2.cmake:37 + set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "") + set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") +

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

pirama added inline comments. Comment at: cmake/caches/Android-stage2.cmake:27 + set(RUNTIMES_${target}-linux-android_CMAKE_ASM_FLAGS ${ANDROID_${target}_C_FLAGS} CACHE PATH "") + set(RUNTIMES_${target}-linux-android_CMAKE_BUILD_TYPE RELEASE CACHE STRING "") +

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. In https://reviews.llvm.org/D37302#871794, @joerg wrote: > So what about targets that don't support subnormals? I'm moderately sure ARM > falls into this category given the right phase of the moon. Clang defines `__FLT_HAS_DENORM__` and friends unconditionally, so I

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. Ping https://reviews.llvm.org/D37302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. @bruno Any suggestion on how to update test/Headers/float-darwin,c* so make it check the include_next? I am unable to find the darwin-specific float.h inside an XCode installation directory. - Oops, my earlier comment had the wrong test name

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. Ping... https://reviews.llvm.org/D37302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama updated this revision to Diff 124410. pirama added a comment. Address review comments. https://reviews.llvm.org/D40476 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/as-mcpu.c Index: test/Driver/as-mcpu.c === ---

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama updated this revision to Diff 124417. pirama added a comment. Normalize falkor and saphira as well. https://reviews.llvm.org/D40476 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/as-mcpu.c Index: test/Driver/as-mcpu.c

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama updated this revision to Diff 124415. pirama added a comment. Sink 'Arg *' declaration. https://reviews.llvm.org/D40476 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/as-mcpu.c Index: test/Driver/as-mcpu.c === ---

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rL319077: Switch CPU names not recognized by GNU assembler (authored by pirama). Repository: rL LLVM https://reviews.llvm.org/D40476 Files: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 124313. pirama added a comment. - Switch kryo to use -mcpu=cortex-a57 when invoking the assembler https://reviews.llvm.org/D37302 Files: lib/Driver/ToolChains/Gnu.cpp lib/Headers/float.h test/Driver/as-mcpu.c test/Headers/float.c Index:

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama updated this revision to Diff 124318. pirama added a comment. Few refactorings. https://reviews.llvm.org/D40476 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/as-mcpu.c Index: test/Driver/as-mcpu.c === --- /dev/null

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 124315. pirama added a comment. Actually revert https://reviews.llvm.org/D37302 Files: lib/Headers/float.h test/Headers/float.c Index: test/Headers/float.c === --- test/Headers/float.c

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 124314. pirama added a comment. Revert to previous patch after accidental update https://reviews.llvm.org/D37302 Files: lib/Driver/ToolChains/Gnu.cpp lib/Headers/float.h test/Driver/as-mcpu.c test/Headers/float.c Index: test/Headers/float.c

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

pirama created this revision. Using -no-integrated-as causes -mcpu=kryo to fail since GNU assembler doesn't recognize kryo. Cortex-a57 is the closest CPU to kryo that the assembler does recognize. So we should switch the assembler to use that instead. https://reviews.llvm.org/D40476 Files:

[PATCH] D48749: [Win32] Overload ==, != for locale_t and long long

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX336141: [Win32] Overload ==, != for locale_t and long long (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D48749?vs=153411=153778#toc Repository: rCXX

[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation

pirama added a comment. In https://reviews.llvm.org/D50199#1186164, @rnk wrote: > Does this do anything other than -DUNICODE? Maybe just translate it at the > driver level and skip the -cc1 flag? It seems odd to include predefined macros at the driver, which AFAIK is just a bridge to the

[PATCH] D50112: [Android] Increase default new alignment for Android

pirama created this revision. pirama added a reviewer: rsmith. Android's memory allocators also guarantee 8-byte alignment for 32-bit architectures and 16-byte alignment for 64-bit. Repository: rC Clang https://reviews.llvm.org/D50112 Files: lib/Basic/TargetInfo.cpp

[PATCH] D50112: [Android] Increase default new alignment for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC338603: [Android] Increase default new alignment for Android (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D50112?vs=158402=158574#toc Repository: rC Clang

[PATCH] D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis

pirama added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10411 +->getAs(); + if (!ResultBT || !(RBT && RBT->isFloatingPoint())) return; + Add a comment explaining this conditional as well? > Return if source and target

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

This revision was automatically updated to reflect the committed changes. Closed by commit rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D37302?vs=159330=159778#toc Repository: rC Clang

[PATCH] D50359: Add a new library, libclang-cxx

pirama created this revision. Herald added a subscriber: mgorny. The current libclang.so exports only the symbols required for the stable C api. This is opposed to libLLVM.so, which exports all the symbols from the LLVM libraries, including those from the C++ API. This patch adds

[PATCH] D50359: Add a new library, libclang-cxx

pirama added a comment. This implements the new library proposed in http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html. Repository: rC Clang https://reviews.llvm.org/D50359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

pirama created this revision. pirama added reviewers: rsmith, srhines. Android uses jemalloc allocator, which returns 8-byte-aligned pointers for allocations smaller than 8 bytes for 64-bit architectures. Set NewAlign conservatively to 8 bytes. Repository: rC Clang

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama added a comment. Sorry this fell of my radar. I've rebased the patch. Since this has been inactive for a while, lets wait for a couple of days to see if there are any other comments. If there are no objections, I'll submit this on Wednesday. Repository: rC Clang

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 159330. pirama added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D37302 Files: lib/Headers/float.h test/Headers/float.c Index: test/Headers/float.c === ---

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

pirama abandoned this revision. pirama added a comment. Thanks for the clarification Richard and Eli. I agree that leaving the status quo will match the intent of the macro. I'll abandon this. Repository: rC Clang https://reviews.llvm.org/D50683

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama created this revision. pirama added reviewers: srhines, enh. Android's libm does not set errno. Repository: rC Clang https://reviews.llvm.org/D51068 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/fast-math.c Index: test/Driver/fast-math.c

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} I tried to be defensive here in case the default changes in the future. I can simplify to just return true here if

[PATCH] D51068: [Android] Default to -fno-math-errno

This revision was automatically updated to reflect the committed changes. Closed by commit rL340424: [Android] Default to -fno-math-errno (authored by pirama, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51068 Files:

[PATCH] D48743: Make pthread's __libcpp_get_tls declaration consistent

pirama added a comment. Ping... Repository: rCXX libc++ https://reviews.llvm.org/D48743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors

pirama added a comment. Ping... Repository: rCXXA libc++abi https://reviews.llvm.org/D48742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44852: [CodeGen] Mark fma as const for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL328552: [CodeGen] Mark fma as const for Android (authored by pirama, committed by ). Repository: rL LLVM https://reviews.llvm.org/D44852 Files: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama added a comment. Thanks for the reviews! Repository: rL LLVM https://reviews.llvm.org/D44852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama updated this revision to Diff 139798. pirama added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D44852 Files: lib/Sema/SemaDecl.cpp test/CodeGen/math-builtins.c Index: test/CodeGen/math-builtins.c

[PATCH] D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests

pirama added a comment. Hi Petr, thanks for the fix (I dropped the ball on this one :( ). Instead of duplicating the checks, does it make sense to fold check into addArchSpecificRPath and rename it to 'addArchSpecificRPathIfRequested' or something similar? Repository: rC Clang

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama created this revision. pirama added reviewers: spatel, efriedma, srhines, chh, enh. Herald added a subscriber: cfe-commits. r318093 sets fma, fmaf, fmal as const for Gnu and MSVC. Android also does not set errno for these functions. So mark these const for Android. Repository: rC

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 139667. pirama added a comment. - [CodeGen] Mark fma as const for Android Repository: rC Clang https://reviews.llvm.org/D37302 Files: lib/Headers/float.h lib/Sema/SemaDecl.cpp test/CodeGen/math-builtins.c test/Headers/float.c Index:

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 139670. pirama added a comment. Remove unexpected change from another patch. Repository: rC Clang https://reviews.llvm.org/D37302 Files: lib/Headers/float.h test/Headers/float.c Index: test/Headers/float.c

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

pirama updated this revision to Diff 139666. pirama added a comment. - [CodeGen] Mark fma as const for Android Repository: rC Clang https://reviews.llvm.org/D37302 Files: lib/Headers/float.h lib/Sema/SemaDecl.cpp test/CodeGen/math-builtins.c test/Headers/float.c Index:

[PATCH] D48731: Configure ELAST for MinGW

pirama created this revision. pirama added reviewers: compnerd, srhines, danalbert, mstorsjo. Herald added subscribers: cfe-commits, ldionne, christof. Use _LIBCPP_MSVCRT_LIKE while configuring ELAST, so MinGW gets the same configuration as MSVC. Repository: rCXX libc++

[PATCH] D48749: [Win32] Overload ==, != for locale_t and long long

pirama created this revision. pirama added reviewers: mstorsjo, EricWF, srhines, danalbert. Herald added subscribers: ldionne, christof. _is_chartype_l (needed for isxdigit_l) in MinGW compares locale_t and NULL. NULL is 'long long' for 64-bit, and this results in ambiguous overloads when

[PATCH] D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors

pirama created this revision. pirama added reviewers: EricWF, srhines, danalbert. Herald added subscribers: ldionne, christof. This function is passed as the __at_exit parameter to __libcpp_tls_create. This parameter is marked with the _LIBCPP_TLS_DESTRUCTOR_CC attribute. The macro is empty for

[PATCH] D48743: Make pthread's __libcpp_get_tls declaration consistent

pirama created this revision. pirama added reviewers: EricWF, srhines, danalbert. Herald added subscribers: ldionne, christof. Add the _LIBCPP_TLS_DESTRUCTOR_CC attribute to the __at_exit parameter for the pthread definition of __libcpp_get_tls. This makes it consistent with the rest (the

[PATCH] D48731: Configure ELAST for MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX335916: Configure ELAST for MinGW (authored by pirama, committed by ). Changed prior to commit: https://reviews.llvm.org/D48731?vs=153352=153381#toc Repository: rCXX libc++

[PATCH] D53850: Declares __cpu_model as hidden symbol

pirama edited reviewers, added: echristo, craig.topper; removed: pirama. pirama added subscribers: srhines, pirama, cfe-commits. pirama added a comment. Adding reviewers suggested by 'arc cover'. https://reviews.llvm.org/D53850 ___ cfe-commits

[PATCH] D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors

pirama abandoned this revision. pirama added a comment. Herald added subscribers: libcxx-commits, jfb. This file is not built for WIN32. Repository: rCXXA libc++abi https://reviews.llvm.org/D48742 ___ cfe-commits mailing list

[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32

pirama updated this revision to Diff 166527. pirama added a comment. Simplify patch. Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 Files: src/private_typeinfo.cpp Index: src/private_typeinfo.cpp === ---

[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32

This revision was automatically updated to reflect the committed changes. Closed by commit rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32 (authored by pirama, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32

pirama created this revision. pirama added reviewers: EricWF, srhines, mstorsjo. Herald added subscribers: libcxx-commits, ldionne, christof. Mark it as unused to avoid -Wunused-parameter. Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 Files: src/private_typeinfo.cpp Index:

[PATCH] D50359: Add a new library, libclang-cxx

pirama added a comment. As I mentioned in the discussion, we decided to carry build rules for the proposed library in downstream. I've updated this to make it more general, and will leave it open in case there's more interest to revive it in the future. Repository: rC Clang

[PATCH] D50359: Add a new library, libclang-cxx

pirama updated this revision to Diff 165118. pirama added a comment. Herald added a subscriber: fedor.sergeev. Add empty source file to silence CMake warning. Support more platforms, similar to libLLVM.so Repository: rC Clang https://reviews.llvm.org/D50359 Files: CMakeLists.txt

[PATCH] D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++.

pirama added inline comments. Comment at: test/Driver/nostdlibxx.cpp:14 +// RUN: %clangxx -target i686-pc-linux-gnu -### \ +// RUN: -nostdlib++ -stdlib=libc++ -lstdc++%s 2> %t +// RUN: FileCheck --check-prefix=CHECK-RESERVED-LIB-REWRITE < %t %s Missing space

[PATCH] D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++.

pirama accepted this revision. pirama added inline comments. This revision is now accepted and ready to land. Comment at: test/Driver/nostdlibxx.cpp:14 +// RUN: %clangxx -target i686-pc-linux-gnu -### \ +// RUN: -nostdlib++ -stdlib=libc++ -lstdc++%s 2> %t +// RUN: FileCheck

[PATCH] D53343: [Driver] Default Android toolchains to noexecstack.

pirama accepted this revision. pirama added inline comments. This revision is now accepted and ready to land. Herald added a project: clang. Comment at: include/clang/Driver/ToolChain.h:393 + /// Test whether this toolchaind defaults to non-executable stacks. + virtual bool

[PATCH] D63889: Check possible warnings on global initializers for reachability

pirama added inline comments. Comment at: clang/include/clang/Sema/AnalysisBasedWarnings.h:111 +void emitPossiblyUnreachableDiags(Sema , AnalysisDeclContext , +SmallVector PossiblyUnreachableDiags); + Fix indentation. Comment at:

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 218959. pirama added a comment. Herald added a subscriber: emaste. Supported this flag for NetBSD and FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 219004. pirama added a comment. Change parameter name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200 Files: clang/include/clang/Driver/Options.td

[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

pirama added a comment. Does this regress from existing behavior for unused arguments? Currently, `-static-libstdc++ -nostdlib` issues an unused argument warning for `-static-libstdc++`, while AFAICT `-static=c++stdlib -nostdlib` doesn't. I'm not exactly sure how/where to issue this warning,

[PATCH] D67200: Add -static-openmp driver option

pirama added a comment. In D67200#1660147 , @srhines wrote: > Looks really nice. I am sure the NDK developers will be happy to see support > for static OpenMP. Do you want to add the public NDK github issue link in the > commit message? Done. In

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 219182. pirama added a comment. Herald added a subscriber: ychen. Mention NDK issue https://github.com/android-ndk/ndk/issues/1028. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/

[PATCH] D67200: Add -static-openmp driver option

pirama added a comment. I'll update this review addressing @Joerg's reply to cfe-commits: > Needs testing for the -static interaction? Thanks @srhines for pointing me to it - I'd only subscribed to cfe-dev and not cfe-commits so I'd missed it.. Repository: rG LLVM Github Monorepo CHANGES

  1   2   >