[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro added a comment. Could someone please commit this for me? I've no commit access. Thanks. https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro added a comment. It's been another two weeks, so: could someone please commit this for me? Thanks. https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684 if (AddExportDynamic) -CmdArgs.push_back("-export-dynamic"); +CmdArgs.push_back("--export-dynamic"); alekseyshl wrote: > If it does not exist on Solaris, why change it

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I forgot: this patch is on top of https://reviews.llvm.org/D35755. Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, I see several instances of this warning: clang-6.0: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Since Solaris 10,

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I ran into a few instances of In file included from

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When looking at lib/Basic/Targets/OSTargets.h, I noticed that _REENTRANT is defined unconditionally on Solaris, unlike all other targets and what either Studio cc (only define it with -mt) or gcc

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. In https://reviews.llvm.org/D41240#955391, @rsmith wrote: > Mechanically, the code change looks fine, but I can't comment on whether this > is a correct change for Solaris, or whether the type provided by `__float128` > would use the right floating-point representation. You

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro updated this revision to Diff 127348. ro added a comment. Enables test/CodeGenCXX/float128-declarations.cpp on Solaris/x86, too. Repository: rC Clang https://reviews.llvm.org/D41240 Files: lib/Basic/Targets/OSTargets.h test/CodeGenCXX/float128-declarations.cpp Index:

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528 StringRef Sanitizer) { + // Solaris ld doesn't need this. Inhibit use of non-existant + // --export-dynamic. alekseyshl wrote: > Can you

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro updated this revision to Diff 127499. ro marked an inline comment as done. ro added a comment. Reworded comment. Repository: rC Clang https://reviews.llvm.org/D40903 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro marked an inline comment as done. ro added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528 StringRef Sanitizer) { + // Solaris ld doesn't need this. Inhibit use of non-existant + // --export-dynamic.

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added a comment. There are two issues before the patch can be commited: - It depends on https://reviews.llvm.org/D35755 which needs minor changes. - I'm currently working with an experimental version of Solaris ld that *does* support generation of __start___sancov_guards etc. labels. This

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. What's the status here? This patch is required for my WIP sanitizers-on-Solaris work. https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. In https://reviews.llvm.org/D35755#931120, @krytarowski wrote: > Do we still target Oracle Solaris or SmartOS? Just wondering and noted the > domain change in e-mail. Both, I'd say ;-) They still have much common heritage and the vast majority of linker/toolchain work on

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro created this revision. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, lit complains llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS' The following patch avoids this: Solaris uses

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro added a comment. Thanks. Could someone please commit it for me? https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro created this revision. ro added a project: Sanitizers. Herald added subscribers: fedor.sergeev, jyknight. This patch (on top of https://reviews.llvm.org/D35755) provides the clang side necessary to enable the Solaris port of the sanitizers implemented by https://reviews.llvm.org/D40898,

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

This revision was automatically updated to reflect the committed changes. Closed by commit rC332343: [Solaris] Only define _REENTRANT if -pthread (authored by ro, committed by ). Repository: rC Clang https://reviews.llvm.org/D41241 Files: lib/Basic/Targets/OSTargets.h Index:

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro added a comment. Thanks for the quick review. Could you commit the base patch (which had been approved some time ago) and this one? Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro added a comment. Excellent, thanks a lot. Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I believe there's nothing more left for me here. Is the patch ok now? Thanks. Rainer Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^2 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro created this revision. ro added reviewers: fedor.sergeev, tstellar, jyknight. This patch is meant to address the last outstanding review comment on the already approved (but not yet commited) https://reviews.llvm.org/D35755, namely making the handling of the RHEL devtoolsets Linux-specific.

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. Thanks. Could you please commit this for me? Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added a comment. Could anyone please commit this for me? Thanks. Rainer Repository: rC Clang https://reviews.llvm.org/D40903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. Could anyone please commit this for me? Thanks. Rainer Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping^2 Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^4 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added a comment. In https://reviews.llvm.org/D40903#998474, @alekseyshl wrote: > Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add > test cases for Solaris to test/Driver/sanitizer-ld.c too. Sorry about that! I certainly will, but it'll be some time because I'm

[PATCH] D48423: [liblang] Remove DOS line endings in libclang.exports

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. libclang.so fails to link on Solaris: Undefined first referenced symbol in file clang_getCompletionFixIt

[PATCH] D48423: [liblang] Remove DOS line endings in libclang.exports

This revision was automatically updated to reflect the committed changes. Closed by commit rC335234: [liblang] Remove DOS line endings in libclang.exports (authored by ro, committed by ). Repository: rC Clang https://reviews.llvm.org/D48423 Files: tools/libclang/libclang.exports Index:

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL330572: [Solaris] __float128 is supported on Solaris/x86 (authored by ro, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a reviewer: fedor.sergeev. ro added a comment. ping^5 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

ro added a reviewer: mgorny. ro added a comment. Ping? Who's an appropriate reviewer here? `CODE_OWNERS.TXT` doesn't list anyone. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/ https://reviews.llvm.org/D60046

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

ro created this revision. ro added a reviewer: rsmith. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny, jyknight. Running `make check-all` fails on Solaris 11/SPARC since the clang python tests FAIL:

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

ro added a comment. In D60046#1458399 , @mgorny wrote: > Thanks, looks good. Do you have commit access or do you need me to commit it > for you? I do have commit access, so I'll do it myself. Thanks. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

This revision was automatically updated to reflect the committed changes. Closed by commit rC357917: [python, tests] Disable Clang Python tests on SPARC (authored by ro, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

ro updated this revision to Diff 194144. ro added a comment. Skip SPARC like other targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/ https://reviews.llvm.org/D60046 Files: bindings/python/tests/CMakeLists.txt Index:

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

ro added a comment. In D60046#1456034 , @mgorny wrote: > Just add it to the regex above. Done now. Initially I tried to check if it's also the ffi issue, until I noticed that some targets were skipped there for different reasons. I cannot check

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro created this revision. ro added reviewers: rsmith, fedor.sergeev. Herald added a subscriber: jyknight. Herald added a project: clang. `Clang :: Sema/wchar.c` has long been failing on Solaris: error: 'error' diagnostics expected but not seen: File

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro added a comment. Ping? This has been a week, too. According to gcc/config headers, there are quite a number of targets with long int for wchar_t/wint_t, so there should be some generic way to handle the Clang :: Sema/format-strings.c failure. Suggestions? Repository: rC Clang CHANGES

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro added a comment. In D62944#1542217 , @efriedma wrote: > For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && > !defined(__LP64__)`, but I don't think the alternative is better. We could > restrict the test so it doesn't run

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro updated this revision to Diff 205012. ro added a comment. Herald added a subscriber: krytarowski. Adapt `Sema/format-strings.c`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 Files: lib/Basic/Targets/OSTargets.h

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL363612: Clang :: Sema/wchar.c has long been failing on Solaris: (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. `Clang :: Driver/cl-response-file.c` currently FAILs on Solaris: Command Output (stderr): -- /vol/llvm/src/clang/dist/test/Driver/cl-response-file.c:10:11: error:

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL363985: [test][Driver] Fix Clang :: Driver/cl-response-file.c (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

ro added a comment. In D63678#1554508 , @rnk wrote: > I would almost prefer to XFAIL this on Solaris, I feel like the intent is > clearer with echo. Please have a look at what the autoconf manual has to say on echo vs. printf:

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro created this revision. ro added a reviewer: alekseyshl. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. As explained in https://reviews.llvm.org/D63601, there's no point using `clang_rt.sancov_{begin,end}` on Solaris any longer. This companion patch to the above

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro added a comment. Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63602/new/ https://reviews.llvm.org/D63602

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro added a comment. Ping? It's been a week and I've since been informed that without it Solaris/SPARC compilation is broken since the `sancov_*` archives don't exit (compiler-rt isn't built on sparc). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63602/new/

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith. ro added a project: clang. `make check-all` currently fails on `x86_64-pc-solaris2.11` when building with GCC 9: Undefined first referenced symbol in file

[PATCH] D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC

ro created this revision. ro added reviewers: venkatra, fedor.sergeev. Herald added subscribers: jrtc27, jyknight. Herald added a project: clang. `Clang :: Headers/max_align.c` currently FAILs on 64-bit SPARC: error: 'error' diagnostics seen but not expected: File

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro created this revision. ro added a reviewer: kcc. ro added a project: Sanitizers. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. `UBSan-Standalone-x86_64 :: TestCases/TypeCheck/Function/function.cpp` currently FAILs on Solaris/x86_64: clang-9: error: unsupported

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith. Herald added subscribers: dexonsmith, mehdi_amini, jyknight. Herald added a project: clang. Starting with Solaris 11.4 (which is now the required minimal version), Solaris does support `__cxa_atexit`. This patch reflects that.

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith, theraven. Herald added subscribers: jrtc27, jyknight. Herald added a project: clang. I noticed that clang currenly passes `--dynamic-linker` to `ld`. This has been the case since Solaris 11 support was added initially back in

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1578245 , @MaskRay wrote: > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > for C++ only, while clang has long been doing it for all languages > > Can you explain more about the hack >

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1579850 , @MaskRay wrote: > > Honestly I find such enforced C/C++ difference very unfortunate... e.g. > > if (Opts.CPlusPlus) > Builder.defineMacro("_GNU_SOURCE"); You may not like them, but there are plenty of

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro added a comment. In D63602#1574337 , @vitalybuka wrote: > In D63602#1570884 , @ro wrote: > > > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > > remained unreviewed for two weeks. >

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL365396: [Sanitizers] Dont use clang_rt.sancov_{begin,end} on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added reviewers: mehdi_amini, rnk. ro added a comment. Ping? It's been a week and it would be good to get this patch and its companion into LLVM 9: it unbreaks `make check-all` with gcc 9 and restores g++ compatibility. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith, mehdi_amini, rnk. Herald added subscribers: kadircet, jrtc27, ilya-biryukov, mgorny, jyknight. Herald added a project: clang. `Builtins-*-sunos :: compiler_rt_logbf_test.c` currently FAILs on Solaris, both SPARC and x86, 32 and

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL366202: [Driver] Dont pass --dynamic-linker to ld on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > ro wrote: > > rnk wrote: > > > Is it feasible to make this an `enum class`? I'm worried about namespace > >

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added a comment. I've now submitted the lldb patch to reflect the `LangStandard.h` move. It turns out the part of isl (included in polly) that uses `InputKind::C` isn't even compiled inside the llvm tree. Nonetheless, I've submitted a patch upstream

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. In D64793#1613063 , @rnk wrote: > lgtm > > If I interpret @jyknight correctly, having failed to dissuade you, he doesn't > feel strongly enough about this to block it, he just wants to reduce legacy > when feasible. Fully

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 213243. ro marked 2 inline comments as done. ro added a comment. - Restrict enum class Languge to uint8_t to save space. - Filter patch through clang-format-diff.py Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367305: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro updated this revision to Diff 212393. ro added a comment. Test i386--solaris instead of x86_64--solaris twice. Retested on x86_64-pc-solaris2.11. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 Files:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL367351: [Driver] Support -fsanitize=function on Solaris/x86 (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. In D64488#1606716 , @krytarowski wrote: > Something is broken between reviews. and my mailbox as I am not receiving any > e-mails so pinging does not make any effect... no LLVM admin replied to my > questions on this to validate

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro created this revision. ro added reviewers: rsmith, rnk. Herald added subscribers: fedor.sergeev, Anastasia, mgorny, jyknight. Herald added a reviewer: bollu. Herald added a project: clang. This patch is a prerequisite for using `LangStandard` from `Driver` in https://reviews.llvm.org/D64793.

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro updated this revision to Diff 212763. ro marked 2 inline comments as done. ro added a comment. Updated patch to make use of the move to `Basic`. Tested on top of that one on `x86_64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and `x86_64-pc-linux-gnu`.

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro marked 5 inline comments as done. ro added a comment. In D64793#1604877 , @jyknight wrote: > > I fear it is necessary: at least it matches documented behaviour of both > > the Sun/Oracle Studio compilers and gcc. > > I will defer to your opinion here.

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 212992. ro marked an inline comment as done. ro added a comment. Change Language to enum class. Tested as before. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/ https://reviews.llvm.org/D65562 Files:

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro marked 2 inline comments as done. ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > Is it feasible to make this an `enum class`? I'm worried about

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro updated this revision to Diff 212993. ro added a comment. Account for enum class Language change in D65562 . Tested as before. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/ https://reviews.llvm.org/D64793 Files:

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. Ping^2? It's been two weeks now. Who can decide if the LangStandards code can be used from lib/Frontend as is or needs to be moved elsewhere (lib/Basic?) for use by driver code? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. Ping^3? Three weeks and counting... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rL367864: Move LangStandard*, InputKind::Language to Basic (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367866: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. Ping^2? Two weeks now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC

ro added a comment. Ping^2? It's been two weeks now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64487/new/ https://reviews.llvm.org/D64487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. Ping? It's been a week now and this is a correctness issue on Solaris, not just a single failing test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/ https://reviews.llvm.org/D64793

[PATCH] D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da6eea07cde: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC (authored by ro). Changed prior to commit: https://reviews.llvm.org/D64487?vs=208946=211316#toc Repository: rG LLVM

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro marked an inline comment as done. ro added a comment. In D64793#1597550 , @jyknight wrote: > Is this really necessary? Users don't typically pass -std= to the driver for > linking anyways (what do you even pass if you've compiled both C and C++ >

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL366305: [Driver] Enable __cxa_atexit on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1588154 , @rnk wrote: > > To avoid a similar inconsistence with host compilers that don't predefine > > _FILE_OFFSET_BITS=64 > > (e.g. clang < 9, gcc < 9), this needs a compantion patch to be submitted > > shortly. > > I'm

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1589174 , @MaskRay wrote: > >> Even if it were, this would only affect future releases. The user experience >> of "you need to upgrade to Solaris 11.x" or install update y to get this" >> seems pretty dismal to me.

[PATCH] D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC

ro added a reviewer: jyknight. ro added a comment. Ping? It's been a week. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64487/new/ https://reviews.llvm.org/D64487 ___ cfe-commits mailing list

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a reviewer: krytarowski. ro added a comment. Ping? It's been a week. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 ___ cfe-commits mailing list

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

ro added reviewers: mehdi_amini, rnk. ro added a comment. Ping? It's been a week and the patch seems completely in line with other ELF targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64491/new/ https://reviews.llvm.org/D64491

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

ro added reviewers: mehdi_amini, rnk. ro added a comment. Ping? It's been a ween and unless someone comes up with a good explanation why the default interpreter must be specified instead of letting ld figure it out, this seems pretty obvious. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > ro wrote: > > > > efriedma wrote: > > > > > This probably

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247786 , @efriedma wrote: > > For compiler-rt, the XFAILs should probably reflect whatever config the bot > is running. (Alternatively, you could use UNSUPPORTED, but that doesn't seem > warranted here.) That's been

  1   2   3   >