[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added a comment. I would be more comfortable with exposing something like `clang_CXXRecord_hasAnyNonDeletedDefaultConstructor`. It's better than the confusing `clang_CXXRecord_needsImplicitDefaultConstructor` but it would still be different from the usual type traits in a subtle way

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

royjacobson added a comment. Thanks for working on it! It looks really good. Please remember to update the feature test macro (__cpp_aggregate_paren_init). Also, I think there's no test coverage for the ASTReader/Writer changes? I would like to see some as well. Comment at:

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

royjacobson added inline comments. Comment at: clang/test/SemaCXX/P0960R3.cpp:54 +} + +void foo() { Could you add test that this works with variadic templates? Something like ``` template T construct(Args... args) { return T(args...); } ``` Similar to the int

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. friendly ping @njames93 FWIW I ran this over the LLVM codebase and have seen no crashes or false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 __

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. LGTM, thanks for picking it up! I wonder how much effect this has on compilation times given that `SubsumptionCache` caches subsumption by the `Decl *` pair... One Q - do you think

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. LGTM, thank you for this patch! I'll wait until Monday to let others have a look and then we can backport, I think it's useful and it's small enough to not be a problem. Could you ad

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson updated this revision to Diff 452447. royjacobson added a comment. Update to handle some edge cases better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ https://reviews.llvm.org/D131541 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson updated this revision to Diff 452448. royjacobson added a comment. Add another test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ https://reviews.llvm.org/D131541 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson added reviewers: erichkeane, hubert.reinterpretcast, shafik. royjacobson added a comment. Updated the patch and added more test coverage. I still don't diagnose the dependent friend case, but I didn't see how to do it easily. Comment at: clang/lib/Sema/SemaDecl.cp

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f0f7e64600: __has_trivial_copy should map to __is_trivially_copyable (authored by zahen, committed by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

royjacobson added a comment. Added a backport request here - https://github.com/llvm/llvm-project/issues/57140 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131730/new/ https://reviews.llvm.org/D131730

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. Some documentation/test nits, and one question, but otherwise LGTM. Could you fix the merge conflict? It would be nice to see pre-commit CI results. Given the complexity of the techni

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

This revision was automatically updated to reflect the committed changes. Closed by commit rG68786f063275: [Sema] Fix friend destructor declarations after D130936 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ h

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

royjacobson added a comment. Stopping by - I assume this targets Clang 16 now, so the abi compat level should be adjusted to 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 __

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 453411. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp cla

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:494-497 +- Implemented "Conditionally Trivial Special Member Functions" (`P0848 `_). + Note: The handling of deleted functions is not yet compliant, as Clang + does not implem

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 453712. royjacobson added a comment. Add disclaimer to cxx_status about the standing DRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Rele

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:494-497 +- Implemented "Conditionally Trivial Special Member Functions" (`P0848 `_). + Note: The handling of deleted functions is not yet compliant, as Clang + does not implem

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454338. royjacobson added a comment. Address Aaron's comments, add the consteval test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Release

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked 11 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defin

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Build

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454567. royjacobson added a comment. Remove the __cpp_concepts version bump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Build

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454577. royjacobson added a comment. Clarify ambiguous doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/D

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454913. royjacobson added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG717161509914: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions) (authored by royjacobson). Repository: rG LLVM Github Monor

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

royjacobson added a comment. I looked at this a bit about a week ago and got it down to 3-4 tests failing, but I'm not sure how much time I'll have to continue working on it. If one of you wants to take over I'll be happy to send you what I've currently got. @erichkeane @ilya-biryukov Also, do

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 455686. royjacobson added a comment. Default constructors can be template functions. Update patch to handle them correctly, and add asserts to LookupSpecialMember that can catch similar problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added a comment. I added handling of FunctionTemplateDecls in SemaDecl because they can be default constructors. This caused errors with std::pair for example - it has two enable_ifs constructors to control explicit/implicit construction. I will try committing again if the pre-commi

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 455689. royjacobson added a comment. Rename file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 455696. royjacobson added a comment. We call LookupSpecialMember before we compute eligibility, so the assert fails. Remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llv

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 455721. royjacobson added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1c960fc6dc2: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions) (authored by royjacobson). Repository: rG LLVM Github Monor

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 461026. royjacobson added a comment. Added tests for 'this' lambda captures and for the pre-cxx2b compatability warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement suggested fix for DR2628. Coulnd't update the DR docs because there hasn't been a new DRs index, but the

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson updated this revision to Diff 461351. royjacobson edited the summary of this revision. royjacobson added a comment. Add release note, slightly nicer test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134145/new/ https://reviews.llvm.org

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson added inline comments. Comment at: clang/test/CXX/drs/dr26xx.cpp:12 +void f() { + foo fooable; // expected-error {{call to deleted}} +} erichkeane wrote: > That does look much nicer, thanks! I qualified it with DR2628 because the DR tests can get p

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson updated this revision to Diff 461352. royjacobson added a comment. rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134145/new/ https://reviews.llvm.org/D134145 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemp

[PATCH] D134145: [Clang] Implement fix for DR2628

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG368b6832de33: [Clang] Implement fix for DR2628 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Does anyone feel comfortable with looking at the CodeGen tests? They're checking that we aren't passing a `this` argument. @erichkeane @shafik @lichray Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https:/

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks everyone! So if no one else has comments I'm planning to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 _

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : Error< + "a static lambda cannot have any captures

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : Error< + "a static lambda cannot have any captures

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 462437. royjacobson added a comment. Apply suggestions from Aaron and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 462438. royjacobson marked 8 inline comments as done. royjacobson added a comment. Small doc change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson marked an inline comment as not done. royjacobson added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1037-1041 +def err_static_mutable_lambda : Error< + "lambda cannot be both mutable and static">; +def err_static_lambda_captures : E

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 462667. royjacobson marked 7 inline comments as done. royjacobson added a comment. Apply small suggestions by Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson planned changes to this revision. royjacobson added a comment. I think I didn't get the overload resolution changes quite right, so this will probably change a bit. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:698 Builder.defineMacro("__cpp_multidimensi

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463346. royjacobson added a comment. - Fix overload resolution and apply it retroactively - Allow static lambdas and static operator() as extensions - Define the feature macros in earlier versions and fix the tests Repository: rG LLVM Github Monorepo

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. GCC have implemented this yesterday , and they also apply the overload resolution change retroactively. So I've done it as well and downgraded the errors to ExtWarns. I'm not su

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson created this revision. royjacobson added a reviewer: shafik. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a null dereference in some diagnostic issuing code. Closes https://gith

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463920. royjacobson added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463926. royjacobson added a comment. Rebase (main was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson updated this revision to Diff 463929. royjacobson added a comment. Rebase on main (build was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 Files: clang/lib/Sema/SemaInit.cpp clan

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson created this revision. royjacobson added a reviewer: cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Define the feature test macro for named character escapes. I assume this was

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 463978. royjacobson marked 7 inline comments as done. royjacobson added a comment. Address CR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: cl

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. In D133659#3824472 , @aaron.ballman wrote: > Double-checking my understanding of the overload resolution changes: we added > a new conversion sequence, but we don't expect that conversion sequence to > cause a change in ove

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks for the patient review and the discussion! @aaron.ballman @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___ cfe-

[PATCH] D133659: [Clang] P1169R4: static operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6523814c4e38: [Clang] P1169R4: static operator() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.o

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson updated this revision to Diff 464007. royjacobson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Lexer/cx

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson updated this revision to Diff 464172. royjacobson added a comment. Slightly modify the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 Files: clang/lib/Sema/SemaInit.cpp clang/test/Se

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/SemaCXX/specialization-diagnose-crash.cpp:2 +// RUN: %clang_cc1 -fsyntax-only %s -verify +// expected-no-diagnostics +// This is a reduction of GH57370 and GH58028, originally

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked an inline comment as done. Closed by commit rG9706bb3165f5: [Clang] Fix variant crashes from GH58028, GH57370 (authored by royjacobson). Repository:

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson updated this revision to Diff 464174. royjacobson added a comment. Remove literal suffix in accordance with the rest of the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson added a comment. In D134898#3825255 , @cor3ntin wrote: > Thanks for catching that, I missed there was a feature test macro for it. > It doesn't really make sense for it to be a feature test macro (given WG21's > current policies) so I'll make

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1bb8cd4254: [Clang] define __cpp_named_character_escapes (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson reopened this revision. royjacobson added a comment. This revision is now accepted and ready to land. Apparently some of the workers crashed with the test - https://lab.llvm.org/buildbot/#/builders/216/builds/10556, but I couldn't reproduce this locally. @shafik any idea why the diag

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson added a comment. In D134885#3827383 , @erichkeane wrote: > In D134885#3826335 , @royjacobson > wrote: > >> Apparently some of the workers crashed with the test - >> https://lab.llvm.org/buildbot/#/b

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson added a comment. In D134885#3827479 , @shafik wrote: > In D134885#3826335 , @royjacobson > wrote: > >> Apparently some of the workers crashed with the test - >> https://lab.llvm.org/buildbot/#/builde

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

royjacobson updated this revision to Diff 464309. royjacobson added a comment. Lock the test to standard version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https://reviews.llvm.org/D134885 Files: clang/lib/Sema/SemaInit.cpp clan

[PATCH] D134885: [Clang] Fix variant crashes from GH58028, GH57370

This revision was automatically updated to reflect the committed changes. Closed by commit rG9415aad6a40f: [Clang] Fix variant crashes from GH58028, GH57370 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134885/new/ https:/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

royjacobson added a comment. Is there consensus that applying this DR resolution is distruptive enough that it's actually an issue? If clang-abi-compat is not a good way to offer backwards compatibility in this case, maybe we should just leave it be. FWIW, I worry that applying it according to

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

royjacobson added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson created this revision. royjacobson added reviewers: njames93, ymandel, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson marked 2 inline comments as done. royjacobson added a comment. In D135404#3842156 , @njames93 wrote: > Why limit this to just the value type traits, makes sense to also support > type type traits. I'd love to, but I can't match against the `

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 466285. royjacobson added a comment. Addrees CR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files: clang-tools-extra/clang-tidy/modernize/CMakeList

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

royjacobson added a comment. Should cxx_status.html be updated as well? It's listed there as a C++2b paper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 ___

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

royjacobson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1476 is false. Note this trait will also return false when the initialization of ``T`` from ``U`` is ill-formed. +* ``__reference_constructs_from_temporary(T, U)`` (C++) We sho

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

royjacobson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1476 is false. Note this trait will also return false when the initialization of ``T`` from ``U`` is ill-formed. +* ``__reference_constructs_from_temporary(T, U)`` (C++) royjac

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > aaron.ballman wr

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > royjacobson wr

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > royjacobson wr

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

royjacobson added a comment. This seems to be stuck with no reviewers, is there any way to help here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 ___ cfe-co

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://github.com/llvm/llvm-project/issues/59624, we sometimes mark implicitly deleted special member

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

royjacobson added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? Is there a standard wording around it? Unfortunately, only a standard wording i

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson updated this revision to Diff 486105. royjacobson edited the summary of this revision. royjacobson added a comment. Rebase + remove extra class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://reviews.llvm.org/D140664

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson updated this revision to Diff 486347. royjacobson added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://reviews.llvm.org/D140664 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5dd37ac139a: [Sema] Don't mark deleted special member functions as non-trivial (authored by royjacobson). Repository: rG LLVM Github Monorepo CH

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson reopened this revision. royjacobson added a comment. This revision is now accepted and ready to land. So, I had a quick look at this. Turns out this fix changed the argument passing ABI for those classes on the Sony PS4. This is probably not acceptable :) Putting this behind an ABI c

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 472660. royjacobson marked 4 inline comments as done. royjacobson added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files: clan

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. In D135404#3899904 , @njames93 wrote: > I'd also suggest using the `IgnoreUnlessSpelledInSource` traversal kind here. > Given that most of the time these will be instantiated we don't want to warn > and emit a fix for each i

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson abandoned this revision. royjacobson added a comment. Closing in favor of the much more mature D137302 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404

[PATCH] D136554: Implement CWG2631

royjacobson added a comment. In D136554#3907661 , @cor3ntin wrote: > I pushed a tentative fix for the bot failure, > alas I'm completely unable to reproduce the issue locally, even > though it does not appear to be architecture dependant afaict. It seems

[PATCH] D137458: [clang] Add __decay as a builtin template

royjacobson added a comment. I worry about this mangling issue https://github.com/llvm/llvm-project/issues/54993. For std::make_index_sequence that wasn't that big of a deal, since nobody really uses that as return type of (template) functions, but my guess is that enough people do things like

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 492516. royjacobson added a comment. - Address comments from Erich and Emilia - Validate that the rst actually builds an html file - Fix some missing backticks and underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. Thanks Erich and Emilia! The html file is attached here, I think it's probably easier to proof read that way. (Took me a bit to figure out the CMake magic...) F26271094: ReleaseNotes.html Repository: rG LLVM Github Monorepo

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. In D142578#4087974 , @tschuett wrote: > I am not the only one who has a different background. If the introduction > says this is the introduction of the release notes, I am not super motivated > to read on. I would prefer to

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493008. royjacobson added a comment. - Remove redundant paragraph from the intro - Remove outdated bug fix bullet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

<    1   2   3   4   >