nruslan created this revision.
nruslan added a reviewer: clang.
Herald added a subscriber: cfe-commits.
Adds support for this flag. There is also another piece for llvm (separate
review). More info: https://bugs.llvm.org/show_bug.cgi?id=36221
Repository:
rC Clang
nruslan added a comment.
@hans: One real-world example is when it is used to compile UEFI code using
PE/COFF targets natively. Obviously, UEFI uses ABI which is basically almost
the same as MS ABI, except that chkstk is not used. It mostly works (I actually
was able to get it running) except
nruslan added a comment.
@craig.topper, @MatzeB, @hans: Can someone take a look at this change?
Repository:
rC Clang
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nruslan added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4038
+ if (Args.hasArg(options::OPT_mno_stack_arg_probe))
+CmdArgs.push_back("-mno-stack-arg-probe");
+
hans wrote:
> I think you can just do
>
> ```
> Args.AddLastArg(CmdArgs,
nruslan updated this revision to Diff 134377.
nruslan marked 3 inline comments as done.
nruslan added a comment.
Added mstack-arg-probe, tests, and changes related to other comments of the
reviewers
https://reviews.llvm.org/D43108
Files:
docs/ClangCommandLineReference.rst
nruslan added a comment.
@hans: I responded to the comments and also updated diff for clang with new
changes.
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nruslan added a comment.
@hans, @craig.topper, @MatzeB: Can someone commit
https://reviews.llvm.org/D43108 (this) and https://reviews.llvm.org/D43107 on
my behalf? I do not think, I have commit access.
https://reviews.llvm.org/D43108
___
nruslan added a comment.
@aemerson : I am not 100% sure, but I think you are talking about different
flag. This commit is for supporting a flag to disable stack probes (identical
flag can be found in MinGW), it basically only applies to PE/COFF (Windows)
targets. It can be useful to compile
nruslan added a comment.
@aemerson : yes, it is just part of MS ABI
Repository:
rC Clang
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nruslan added inline comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
hans wrote:
> This file is automatically generated based on the options .td files, so no
> need to update it
nruslan updated this revision to Diff 169224.
nruslan marked 3 inline comments as done.
nruslan added a comment.
@hans , @craig.topper : Updated the patch with all requested changes
https://reviews.llvm.org/D53102
Files:
include/clang/Driver/Options.td
nruslan added a comment.
@hans, @craig.topper : If everything is fine, can someone check in the clang
and llvm patches on my behalf? I do not have commit access.
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
nruslan added a comment.
In https://reviews.llvm.org/D53102#1268364, @kristina wrote:
> By the way, out of curiosity is this for anything specific (alternative libc
> or some user-mode-scheduling implementation)? Not nitpicking, just curious
> since it's an interesting topic in general and
nruslan added a comment.
@kristina : Thank you very much for taking care of the patchsets!
Repository:
rC Clang
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nruslan added a comment.
In https://reviews.llvm.org/D53102#1268272, @kristina wrote:
> If the author doesn't mind I can just apply the style fix after patching and
> then rebuild and run all the relevant tests (or would you prefer to do
> that?). Seems easier than a new revision for an
nruslan created this revision.
nruslan added reviewers: hans, craig.topper.
Herald added a subscriber: cfe-commits.
Allows to disable direct TLS segment access (%fs or %gs). GCC supports a
similar flag, it can be useful in some circumstances, e.g. when a thread
context block needs to be updated
16 matches
Mail list logo
