[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir created this revision. schittir added reviewers: erichkeane, saar.raz. schittir added a project: clang. schittir requested review of this revision. Herald added a subscriber: cfe-commits. Klocwork static code analysis exposed this bug: Pointer 'Constraint' returned from call to

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir marked an inline comment as done. schittir added a comment. In D108481#2960875 , @aaron.ballman wrote: > LGTM, thanks for the cleanup! Do you need someone to commit on your behalf? > If so, what name and email address would you like me to use

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir updated this revision to Diff 368183. schittir added a comment. 1. Removed the useless assert on TC. 2. Retained the change from `cast_or_null` to `cast` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108481/new/ https://reviews.llvm.org/D108481 Files:

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane. schittir added a project: clang. schittir requested review of this revision. Herald added a subscriber: cfe-commits. Avoid nullptr dereferencing of 'Constraint'; NFC Klocwork static code analysis exposed this

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir added a comment. In D108712#2965433 , @aaron.ballman wrote: > LGTM! There is no way for this to be null because `emitRethrow()` is what > should be called in that case. > > I'll land this on your behalf sometime shortly (perhaps as late as

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir created this revision. Herald added subscribers: jeroen.dobbelaere, kosarev. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 32bit mode, attaching TBAA metadata to the store following the call to inline assembler

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir updated this revision to Diff 392840. schittir added a subscriber: mikerice. schittir added a comment. Add test case Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir added a comment. In D115320#3178682 , @jeroen.dobbelaere wrote: > Do you have a testcase ? Thank you for the review. Please take a look at the new diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393948. schittir added a comment. Fix test format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393945. schittir added a comment. Changing test's CHECK lines CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 394173. schittir added a comment. Rebasing patch to see if the test failure will go away. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 394176. schittir added a comment. Change CHECK-LABEL to STORE-LINE-LABEL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir added a comment. https://reviews.llvm.org/harbormaster/unit/view/1536685/ Test failure seems unrelated to this patch. Unable to reproduce locally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir added a comment. In D115320#3195090 , @DavidSpickett wrote: > I've gone ahead and added the REQUIRES myself. Thank you, David! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393642. schittir marked an inline comment as done. schittir added a comment. 1. Removed returnNullTBAA() method 2. Add NO-TBAA check-prefix to the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393381. schittir added a comment. Updated test per Jeroen's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir added a comment. In D115320#3182581 , @jeroen.dobbelaere wrote: > When I try out the example on llvm-13, I get a 'omnipotent char' tbaa > description. That should be ok in general. When I replace the 'float > _Complex' with 'double', I do get

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a297fb9e: Avoid setting tbaa on the store of return type of call to inline assembler. (authored by schittir). Repository: rG LLVM Github

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcc7c5614cd: [NFC] Initialize member pointer and avoid potential null dereference (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

schittir added a comment. Thank you for the reviews, Aaron and Aaron! All tests pass. Landing the patch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158775/new/ https://reviews.llvm.org/D158775

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc. Herald added projects: clang, LLVM.

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 552243. schittir added a comment. Fix errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/Interpreter/Value.cpp

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @jplehr @michaelplatings @MitalAshok @tahonermann - sorry this one slipped through the cracks. I fixed the errors now. Thank you for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir marked 2 inline comments as done. schittir added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir updated this revision to Diff 552380. schittir added a comment. Remove unnecessary initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 Files: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp Index:

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir marked an inline comment as done. schittir added a comment. Thank you for the review, @aaron.ballman and @tahonermann Investigating the build failure... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir abandoned this revision. schittir added a comment. In D158488#4607754 , @Manna wrote: > This has already been addressed by https://reviews.llvm.org/D157989 Thank you for letting me know. Abandoning this change. CHANGES SINCE LAST ACTION

[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad89131e0de: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5824-5828 // Handle default initialization. if (Kind.getKind() == InitializationKind::IK_Default) { TryDefaultInitialization(S, Entity, Kind, *this); return; } tahonermann

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 479731. schittir added a comment. Add assert instead of multiple checks in if conditions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481974. schittir marked an inline comment as done. schittir added a comment. Fixed typo. Sorry! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481989. schittir added a comment. Fix typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index: clang/lib/Sema/SemaInit.cpp

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481732. schittir added a comment. Add `(Initializer && ` and assert to else branch per Tom's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. Comment at: clang/lib/Sema/SemaInit.cpp:5947 if (TryOCLZeroOpaqueTypeInitialization(S, *this, DestType, Initializer)) return; #1/5 Coverity reported explicit null dereference of 'Initializer' Comment

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. In D139148#3969383 , @tahonermann wrote: > When committing changes to address Coverity reported issues, I think it would > be useful to include the Coverity analysis in the commit message. A textual > representation can be

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 480217. schittir added a comment. Move the assert to after the branches that handle the cases where Initializer may be null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. > Perhaps the` assert` should be added after line 5926 above. Done. > I think the checks for `Initializer` being non-null following the addition of > an `assert` should be removed. I don't see any after this point. CHANGES SINCE LAST ACTION

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481475. schittir edited the summary of this revision. schittir added a comment. Add assert at the beginning of blocks pointed out by Coverity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir created this revision. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding nullptr check for 'Initializer' Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139148 Files:

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. In D139148#3965404 , @shafik wrote: > This looks like the correct thing to do but I see further down there are also > unconditional uses of `Initializer` that should also be guarded with a check. > It would be good to fix

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 479541. schittir added a comment. Add more nullptr checks per Shafik's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index: clang/lib/Sema/SemaInit.cpp

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507964. schittir added a comment. Changed CodeObjectVersion default to COV_None CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index:

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220697 , @jrtc27 wrote: > None of the other fields are initialised, so blindly initialising it alone to > 0 here seems highly suspect. What's the actual case in which it's used whilst > uninitialised? Coverity

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508221. schittir added a comment. Deleting the member PolicyBitMask CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220717 , @jrtc27 wrote: > The field should just be deleted. D126742 > added it without any uses, and I don't know what the original intent was. > Maybe it was used before the

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir created this revision. schittir added reviewers: tahonermann, shafik, aaron.ballman. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir created this revision. schittir added reviewers: tahonermann, shafik. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by Coverity static analysis tool. Repository: rG LLVM Github

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507425. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index: clang/include/clang/Basic/TargetOptions.h

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:91 /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4;

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9972c9a89347: [NFC] Remove unused member variable `PolicyBitMask` in SemaRecord (authored by schittir). Repository: rG LLVM Github Monorepo

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added a comment. Thank you, @aaron.ballman and @tahonermann for your comments! This was committed to https://github.com/llvm/llvm-project.git with hash 6f2a865d2f6bc426a61939a0a1acfcb25d5c1a18 CHANGES SINCE LAST

[PATCH] D152689: [NFC] Remove dead conditionals

schittir updated this revision to Diff 530702. schittir added a comment. Fix clang-format issue in SemaOverload.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaOverload.cpp

[PATCH] D152689: [NFC] Remove dead conditionals

schittir added a comment. Thank you for the review, @aaron.ballman and @rjmccall The latest patch fixes clang-format issue causing build failure. Could you please take a look at this again? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 538851. schittir marked an inline comment as done. schittir added a comment. Fix format per comments - indent class members and avoid indenting the class definition line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG472232a80d03: [NFC] Fix potential dereferencing of nullptr (authored by schittir). Herald added a subscriber: wangpc. Changed prior to commit: https://reviews.llvm.org/D139148?vs=481989=539705#toc

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9877eca408e: [NFC] Initialize class member pointers to nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. Landing this one fell through the cracks, hence the delay between accepting and committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir closed this revision. schittir added a comment. In D153589#4493187 , @HazardyKnusperkeks wrote: > Can you mark this change as closed? > If you'd put "Differential Revision: https://reviews.llvm.org/D153589; in > your commit message this would

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 542333. schittir added a comment. Please consider these changes for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h

[PATCH] D155774: [NFC] Remove needless nullchecks.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir created this revision. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155776 Files:

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added a comment. Thank you all for reviewing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir added a comment. Thank you for reviewing. This patch is now landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153926/new/ https://reviews.llvm.org/D153926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152689: [NFC] Remove dead conditionals

schittir created this revision. schittir added reviewers: tahonermann, aaron.ballman, erichkeane. Herald added a subscriber: hiraditya. Herald added a project: All. schittir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @tahonermann Thank you for considering this thoroughly. This patch is now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776

[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac137acefc0: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added a project: All. schittir requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D156261: [NFC] Cast unchecked return values to void.

schittir created this revision. schittir added reviewers: tahonermann, aaron.ballman. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir updated this revision to Diff 545410. schittir added a comment. Remove changes in CGObjCMac.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 Files: clang/lib/AST/ItaniumMangle.cpp clang/lib/Sema/SemaCodeComplete.cpp Index:

[PATCH] D156261: [NFC] Cast unchecked return values to void.

schittir added a comment. In D156261#4535220 , @aaron.ballman wrote: > I think the cast to void is unneeded in these cases. We typically add a cast > to void when the function exists to compute a result but also has side > effects. e.g., you typically

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. Thank you for the review, @aaron.ballman and @efriedma Do you recommend any changes here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in my local testing. Restarting build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 ___

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4544804 , @aaron.ballman wrote: > LGTM! Are you planning to work on the ObjC issues separately? (Not suggesting > you have to! But if you don't intend to, can you file an issue in GitHub so > we don't lose track of

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4545581 , @schittir wrote: > Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in > my local testing. Restarting build. The build is now green. Landing the patch. CHANGES SINCE LAST ACTION

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG235390d930be: [NFC] Avoid potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/

[PATCH] D155774: [NFC] Remove needless nullchecks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ce662c5d596: [NFC] Remove needless nullchecks. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt,

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 533386. schittir marked 3 inline comments as done. schittir added a comment. Changes to address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Sema/SemaExprObjC.cpp

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added a comment. Thank you @aaron.ballman and @Fznamznon for reviewing! I landed this patch with commit d2fafa79ef08f9ef9cd0108a6caa7fc61a31bdeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2fafa79ef08: [NFC] Fix potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533794. schittir added a comment. Address comment- Use default member initialization instead of initializing in a constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files:

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:58 /// used as arguments will necessarily be available at construction time. - LazyRuntimeFunction() - : CGM(nullptr), FunctionName(nullptr), Function(nullptr) {} + LazyRuntimeFunction() {}

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir marked an inline comment as done. schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() &&

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added subscribers: cfe-commits, steakhal, martong. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan,

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 533798. schittir added a comment. Make the constructor default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCGNU.cpp

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 535466. schittir added a comment. Not sure what clang-format wants. I hope it likes this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153926/new/ https://reviews.llvm.org/D153926 Files: clang/include/clang/AST/RawCommentList.h

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 535459. schittir added a comment. Hope clang-format likes this patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace getAs with castAs and add assert if needed.

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 532528. schittir added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExprObjC.cpp clang/lib/Sema/SemaObjCProperty.cpp

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir created this revision. schittir added reviewers: erichkeane, aaron.ballman, tahonermann, shafik. Herald added subscribers: cfe-commits, steakhal, martong. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks,

[PATCH] D152689: [NFC] Remove dead conditionals

schittir added a comment. Patch landed with commit id 0e444c57c85853c86e4f4c94d9a51fb459fd9922 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir updated this revision to Diff 531824. schittir marked an inline comment as done. schittir added a comment. Fix the assert causing build failure and address another review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152977/new/ https://reviews.llvm.org/D152977

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:461 +assert(NamedCtx, "NamedCtx cannot be null"); + aaron.ballman wrote: > This doesn't build. ;-) Thanks for the catch. Something was wrong with my workspace build setup,

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || -

  1   2   >