[PATCH] D19701: [libcxx] [test] Remove more names of unreferenced parameters.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Remove more names of unreferenced parameters. Fixes MSVC "warning C4100: unreferenced formal parameter". http://reviews.llvm.org/D19701 Files: test/std/inpu

[PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix get_temp_file_name() to compile for Windows. It was including but attempting to use GetTempPath() and GetTempFileName(), which are provided by . Instead

RE: [PATCH] D19700: [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

[Eric Fiselier] > Well arguable it should be `no return` or even better it should > have an "= delete" so it's diagnosed even if it's not called. > For now this works though. Agreed - I just wasn't sure what this code was trying to do, and I figured it should be consistent. I'm trying to keep my

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT added a comment. Are there any issues with these changes? I tried to follow the existing practice for void-casting, including the comment (although the comments varied). http://reviews.llvm.org/D19625 ___ cfe-commits mailing list cfe-commi

RE: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

[David Majnemer] > Er, I don't think mingw provides _mktemp_s. Yeah, I don't know what needs to be done for MinGW. (I avoided using _mktemp for MSVC because I knew it would complain about "security".) I am pretty sure that this code was already broken for MinGW - I grepped and found no inclusio

RE: [PATCH] D19622: [libc++] Implement the member functions of a local struct.

[Sebastian Redl] > I rail against this warning here: > http://stackoverflow.com/questions/18979503/why-locally-defined-struct-in-function-need-assignment-operator-copy-construct/18979812#18979812 > It's not just that the warning is silly, it's also a level 1 warning, which > is extra-silly. (MSVC'

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

STL_MSFT added a comment. According to my equally vague understanding, a quiet NaN (if used in operations, instead of being overwritten with something valid) will silently propagate down to the assert, which will complain that it's not equal to whatever you were expecting. That would detect any

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 55683. STL_MSFT added a comment. This moves "str" as requested. It also adds void casts to another file, and removes an unused argc/argv pair. http://reviews.llvm.org/D19625 Files: test/std/depr/depr.c.hea

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT marked 2 inline comments as done. STL_MSFT added a comment. What I'm doing is running libcxx's tests against MSVC's compiler and libraries. I could aggressively suppress warnings (and indeed I'm doing that for the noisiest, lowest-value warnings), but instead I'm building the tests with

RE: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

[David Blaikie] > Unused-variable seems pretty low value. Yeah, but it still has the potential to detect mistakes (e.g. typos, or code you intended to write but forgot about). I figured I'd submit a patch, since there weren't actually that many occurrences, and they were all easy to silence in

RE: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

[STL] > When my work is finished (currently 3132 tests are passing out of 4541), I > expect that > we'll start running libcxx's tests in our automation, which will detect > regressions rapidly and reliably. [David Blaikie] > It'd be great to have this sort of stuff upstream (in a public facing

[PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f = ATOMIC_FLAG_INIT;". The test init03.pass.cpp is explicitly testing this non-Standar

[PATCH] D19759: [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy. Also, fix MSVC "warning C4101: 'ex': unreferenced local variable". http://reviews

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT added a comment. No problem! With these changes, my test runs are currently clean wrt "warning C4100: unreferenced formal parameter" and "warning C4101: unreferenced local variable", but note that (1) Clang may emit unused-variable warnings in somewhat different situations, and (2) I'v

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Since you control the definition of ATOMIC_FLAG_INIT, can you make it something like __secret_tag_type() in C++03? That would allow you to continue to provide the atomic_flag(bool) extension in C++03. http://reviews.llvm.org/D19758

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Makes sense. MSVC will never have C++03 or C++11 modes (only 14/17/future) so anything you do in C++03 mode is fine by me. http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f; "

STL_MSFT added a comment. I think this will work for me. Thanks! http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20918: [libcxx] [test] Silence more "unreferenced local variable" warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence more "unreferenced local variable" warnings. http://reviews.llvm.org/D20918 Files: test/std/depr/depr.c.headers/wchar_h.pass.cpp Index: test/std/depr/depr.c.headers

[PATCH] D20919: [libcxx] [test] Rename b to b2 in order to avoid shadowing between nested catch blocks.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename b to b2 in order to avoid shadowing between nested catch blocks. Fixes MSVC warning C6246 "Local declaration of 'b' hides declaration of the same name in outer scope."

[PATCH] D20920: [libcxx] [test] Rename d to dbl in order to avoid shadowing distributions named d.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename d to dbl in order to avoid shadowing distributions named d. This was almost always declared as double d, except in rand.dist.uni.real where it was D::result_type d (sti

[PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Slightly rearrange scopes in order to avoid shadowing M typedefs. Fixes MSVC warning C4456 "declaration of 'M' hides previous local declaration". http://reviews.llvm.org/D2092

[PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety. Fixes MSVC warning C4459 "declaration of 'x' hides global declaration". NOTE: As the

RE: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

[Asiri Rathnayake] > The `constexpr` mutex constructor is apparently also a > pain point on windows [1], I'm sure @STL_MSFT knows more about it. That's because of MSVC-specific issues, where we need to dynamically switch between WinAPI and ConcRT implementations depending on whether the end user'

Re: [PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this in, so I'm closing this. http://reviews.llvm.org/D20922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this one in too, closing. http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21092: [libcxx] [test] Fix vector tests that were using ints copy-pasted from vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix vector tests that were using ints copy-pasted from vector tests. I copied the bool a[] 0/1 pattern from another vector test. Fixes MSVC warning C4305 "'argument': truncati

[PATCH] D21093: [libcxx] [test] In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning. Fixes MSVC warning C4305 "'argument': truncation from 'double' to 'const std::hash::_Kty'". ht

[PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In test/support/test_allocator.h, fix construct() to avoid moving immovable types. This improves the allocator's conformance, and fixes compiler errors with MSVC's STL. The s

[PATCH] D21095: [libcxx] [test] Fix another MSVC warning C4101 "unreferenced local variable".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix another MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21095 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/

[PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix MSVC warning C4125 "decimal digit terminates octal escape sequence". MSVC somewhat justifiably warns when it sees an octal escape immediately followed by a decimal digit,

RE: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

[Eric Fiselier] > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the > following C++11 features: > - `cxx_noexcept` > - `cxx_atomic` > - `cxx_access_control_sfinae` > Also if the entire test is wrapped in a `TEST_HAS_FEATURE(XXX)` please > translate that into a `// UNSUP

Re: [PATCH] D21320: Alternative to D1332

STL_MSFT resigned from this revision. STL_MSFT removed a reviewer: STL_MSFT. STL_MSFT added a comment. My only concern is that the tests in test/std shouldn't exercise this bug in the standard, as MSVC's implementation doesn't special-case it. If you'd like to special-case it in your product cod

Re: [PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT updated this revision to Diff 60736. STL_MSFT added a comment. Inspect TEST_STD_VER and cast to void* as requested. I used a static_cast to avoid triggering any old-style cast warnings. (I also just noticed that I deleted an empty line, but was too lazy to regenerate the diff. Oops.)

[PATCH] D21346: [libcxx] [test] Improve portability of random_device tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of random_device tests. These tests were failing for MSVC, because we ignore the token (as permitted by the Standard). Marking the asserts as libcxx-specif

[PATCH] D21347: [libcxx] [test] Improve portability of hash tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of hash tests. These tests were expecting libcxx's identity-hash behavior, which isn't guaranteed by the Standard and isn't provided by MSVC (we currently

[PATCH] D21348: [libcxx] [test] Improve portability of vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of vector tests. This test was assuming libcxx's 2x growth factor, which isn't guaranteed by the Standard and isn't provided by MSVC (we use 1.5x). As a re

[PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix a typo in commented-out code. http://reviews.llvm.org/D21349 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp Index: test/std/utilit

[PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. TOTALLY OPTIONAL, feel free to reject this, I won't mind. Newly-added libcxx tests for C++17 features have been using C++17 terse static_asserts occasionally. This is problema

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

STL_MSFT added a comment. I gotta wait for them, I don't have commit access. :-> (Nor do I need it at the moment) Haven't encountered problems with those locale tests yet, although I'm still processing 670-ish compiletime and runtime failures. http://reviews.llvm.org/D21345 ___

[PATCH] D21581: [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence unused variable warnings in invoke.pass.cpp. Fixes MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21581 Files: test/std/utilities/functi

[PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid mixing assignment and returning. "return locked = true;" looks really suspicious, even though it happens to be correct here. Spend an extra statement to make the code cl

[PATCH] D21583: [libcxx] [test] Make unord.hash/integral.pass.cpp portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make unord.hash/integral.pass.cpp portable. This was assuming identity hashing, which is a non-Standard assumption. Guarding this with LIBCPP_ASSERT makes the test portable.

[PATCH] D21584: [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix an operator precedence mistake in valarray.unary/not.pass.cpp. This one was sneaky - the test happened to be passing, but totally by accident. You can thank MSVC warning C

[PATCH] D21585: [libcxx] [test] Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter". This is a C1XX bug, tracked by VSO#188582. C1XX has found some good issues, so I would like to ask

RE: [PATCH] D21581: [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.

Oops, that's because it touched the same file as my "avoid C++17 terse static_assert" patch, which hadn't been accepted yet. Thanks for fixing it up. STL -Original Message- From: Eric Fiselier [mailto:e...@efcs.ca] Sent: Tuesday, June 21, 2016 6:05 PM To: Stephan T. Lavavej ; mclow.li..

[PATCH] D21587: [libcxx] [test] Fix comment typos, strip trailing whitespace. No code changes.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix comment typos, strip trailing whitespace. No code changes. http://reviews.llvm.org/D21587 Files: test/std/strings/char.traits/char.traits.specializations/char.traits.sp

[PATCH] D21625: [libcxx] [test] Mark throw_bad_alloc_helper() as [[noreturn]].

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Mark throw_bad_alloc_helper() as [[noreturn]]. This avoids MSVC /analyze warnings about new returning null, since [[noreturn]] allows the analyzer to see what's happening. ht

[PATCH] D21629: [libcxx] [test] Add assertions to quiet analysis warnings about array bounds.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Add assertions to quiet analysis warnings about array bounds. In the partial_sort tests, the N >= M assertion is just a good sanity check, to detect bogus testcases. MSVC's /a

[PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid narrowing conversions in quoted.pass.cpp. According to the Standard, when char has a signed range and wchar_t has an unsigned range, brace-init has to reject the potenti

[PATCH] D21713: [libcxx] [test] Use L"cat" L"dog" when concatenating string literals.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Use L"cat" L"dog" when concatenating string literals. MSVC dislikes seeing L"23" "\x65F6". It's actually unclear to me what the Standard says here - I suspect that MSVC is cor

[PATCH] D21714: [libcxx] [test] In atomics.types.generic/address.pass.cpp, use T(0) for consistency.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. In atomics.types.generic/address.pass.cpp, use T(0) for consistency. Fixes MSVC "error C2593: 'operator ==' is ambiguous". There is almost certainly an MSVC compiler bug invol

[PATCH] D21715: [libcxx] [test] Make default_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make default_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-default-constructible: ordered/unordered associative cont

[PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-move-constructible: ordered/unordered associative containers

[PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make dtor_noexcept.pass.cpp tests more portable. They were static_asserting that in certain situations, the following things have throwing destructors: ordered/unordered asso

[PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_assign_noexcept.pass.cpp tests more portable. Note that the relevant wording here was modified by C++17 N4258 "Cleaning-up noexcept in the Library (Rev 3)", which MS

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62001. STL_MSFT added a comment. Adding test_macros.h as requested. http://reviews.llvm.org/D21717 Files: test/std/containers/associative/map/map.cons/dtor_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/dtor_noexcept.pass.cpp

Re: [PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62002. STL_MSFT added a comment. Test macros for the test macro throne! http://reviews.llvm.org/D21716 Files: test/std/containers/associative/map/map.cons/move_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/move_noexcept.pass.

Re: [PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62003. STL_MSFT added a comment. Population, 9 billion. All test macros. http://reviews.llvm.org/D21718 Files: test/std/containers/associative/map/map.cons/move_assign_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/move_assig

[PATCH] D21820: [libcxx] [test] Make swap_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make swap_noexcept.pass.cpp tests more portable. These tests define types like some_alloc, which dramatically fail to meet the allocator requirements. They don't even have all

[PATCH] D21870: [libcxx] [test] Avoid applying unary minus to unsigned integers.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid applying unary minus to unsigned integers. This is confusing because first you have to remember what unsigned negation does, then you have to worry about the usual arith

[PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make vector.bool/construct_default.pass.cpp more portable. vector's default ctor and allocator ctor aren't depicted as noexcept in the Working Paper. We're already directly in

[PATCH] D21872: [libcxx] [test] Fix unary_function inheritance assumption.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix unary_function inheritance assumption. C++11 didn't require std::hash to derive from std::unary_function. The portable thing to do is to inspect the typedefs, as the other

[PATCH] D21874: [libcxx] [test] std::array's iterators aren't guaranteed to be pointers.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. std::array's iterators aren't guaranteed to be pointers. Include test_macros.h and mark these static_asserts as libcxx-specific. http://reviews.llvm.org/D21874 Files: test/

[PATCH] D21875: [libcxx] [test] The Standard requires meow_insert_iterator::reference to be void.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. The Standard requires meow_insert_iterator::reference to be void. This is a libcxx product and test bug, since the type is observable. Mark these static_asserts as libcxx-spec

[PATCH] D21876: [libcxx] [test] Make istreambuf.iterator/types.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make istreambuf.iterator/types.pass.cpp more portable. There are two issues here. First, istreambuf_iterator::pointer is unspecified (and MSVC uses a different type). Second,

[PATCH] D21877: [libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. is_swappable_include_order.pass.cpp was using a terse static_assert. As before, this unnecessarily limits compatibility with MSVC and old versions of GCC. http://reviews.llvm

[PATCH] D21878: [libcxx] [test] Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable. future_errc.pass.cpp was assuming specific values, which aren't guaranteed by the Standard, and M

[PATCH] D21879: [libcxx] [test] Fix MSVC "warning C4100: 'argv': unreferenced formal parameter".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix MSVC "warning C4100: 'argv': unreferenced formal parameter". http://reviews.llvm.org/D21879 Files: test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf

Re: [PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

STL_MSFT abandoned this revision. STL_MSFT added a comment. Nah, they can totally be noexcept like the primary template. Usually we don't strengthen beyond the WP, but the wording is so clearly defective here, I'll go ahead and do this. No test changes necessary now. http://reviews.llvm.org/D2

[PATCH] D22012: [libcxx] [tests] Add missing includes, especially , to priority.queue/types.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Add missing includes, especially , to priority.queue/types.pass.cpp. This is required according to the Standard, and it fixes compiler errors with MSVC (as our headers don't u

[PATCH] D22013: [libcxx] [test] bind's function call operator isn't guaranteed to SFINAE.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. bind's function call operator isn't guaranteed to SFINAE. There's nothing in the Standard that specifies this, and MSVC's implementation doesn't do it (we explode in a tuple b

[PATCH] D22014: [libcxx] [test] Follow LWG 2520 "N4089 broke initializing unique_ptr from a nullptr".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Follow LWG 2520 "N4089 broke initializing unique_ptr from a nullptr". This library issue permits nullptr, but not 0 or NULL (which can be 0). In null_ctor.pass.cpp, replace 0

[PATCH] D22016: [libcxx] [test] Fix a non-Standard allocator in vector.cons/construct_iter_iter_alloc.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix a non-Standard allocator in vector.cons/construct_iter_iter_alloc.pass.cpp. You gotta have a rebinding constructor. MSVC loves rebinding. http://reviews.llvm.org/D22016 F

[PATCH] D22017: [libcxx] [test] Work around MSVC's non-Standard ABI for enums.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Work around MSVC's non-Standard ABI for enums. So this is definitely an MSVC bug, but one that's baked into our layout behavior, so even Clang has to enable it unconditionally

Re: [PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

STL_MSFT closed this revision. STL_MSFT added a comment. Closing - Marshall fixed the typo and uncommented the code. http://reviews.llvm.org/D21349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D22059: [libcxx] [test] Fix MSVC "warning C4100: 'val': unreferenced formal parameter".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix MSVC "warning C4100: 'val': unreferenced formal parameter". http://reviews.llvm.org/D22059 Files: test/std/utilities/tuple/tuple.tuple/tuple.assign/convert_move.pass.cpp

[PATCH] D22155: [libcxx] [test] Fix portability issues in tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix portability issues in tests. Three tests were asserting equal() after shuffling a sequence, which assumes the exact behavior of libc++'s implementation. To be portable, y

[PATCH] D22157: [libcxx] [test] Mark bucket() assertions as nonportable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Mark bucket() assertions as nonportable. The Standard doesn't guarantee what bucket an element will land in, even if you control the hash. All such assertions are inherently n

[PATCH] D22159: [libcxx] [test] Mark bucket_size() assertions as nonportable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Mark bucket_size() assertions as nonportable. Even if you control the hash, the Standard doesn't guarantee what the bucket population sizes will be. All of these assertions ar

[PATCH] D22165: [libcxx] [test] Make bucket_count() greater-equal assertions portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make bucket_count() greater-equal assertions portable. The Standard provides a guarantee here, but these assertions were going beyond that guarantee. These containers have 8 e

[clang-tools-extra] 8bd106a - [NFC] Fix typos in release notes.

Author: Stephan T. Lavavej Date: 2021-12-14T14:19:42-08:00 New Revision: 8bd106a891726f6542c9364ff4041764a62aa2b7 URL: https://github.com/llvm/llvm-project/commit/8bd106a891726f6542c9364ff4041764a62aa2b7 DIFF: https://github.com/llvm/llvm-project/commit/8bd106a891726f6542c9364ff4041764a62aa2b7.

<    1   2   3