[PATCH] D138274: Add version to all LLVM cmake package

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa2d3d9943: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138274: Add version to all LLVM cmake package

thopre updated this revision to Diff 477916. thopre added a comment. Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138274 Files:

[PATCH] D138274: Add version to all LLVM cmake package

thopre reopened this revision. thopre added inline comments. This revision is now accepted and ready to land. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM

[PATCH] D138274: Add version to all LLVM cmake package

This revision was automatically updated to reflect the committed changes. Closed by commit rGad485b71b511: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/

[PATCH] D138274: Add version to all LLVM cmake package

thopre added a comment. In D138274#3938218 , @arsenm wrote: > I thought we had this already. The amount of boiler plate required repeated > in each component is depressing, but I wouldn't be surprised if it's really > needed I could configure the

[PATCH] D138274: Add version to all LLVM cmake package

thopre created this revision. thopre added reviewers: smeenai, arsenm, stella.stamenova, stellaraccident, Ericson2314, pmccormick, beanz. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov,

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a86a23c10d: [Test] Fix driverkit-path.c with lib64 dir (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

thopre created this revision. thopre added reviewers: yln, rsmith. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137484 Files:

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c failure (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest , StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + if

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest , StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + if

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre updated this revision to Diff 430029. thopre marked an inline comment as done. thopre added a comment. Be more conservative in what we reject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 Files:

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest , StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + if

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre created this revision. thopre added reviewers: sconstab, craig.topper, andrew.w.kaylor, zbrid, chandlerc. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a7a28075b7f: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre updated this revision to Diff 373214. thopre added a comment. Remove old PM tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109956/new/ https://reviews.llvm.org/D109956 Files: clang/test/CodeGen/pgo-sample-thinlto-summary.c Index:

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added a comment. In D109234#3004253 , @gregmiller wrote: > Hello, > We are maintaining a downstream version of the monorepo based on the LLVM > main branch. We have not transitioned to the new PM yet. In a recent attempt > to merge the latest

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre created this revision. thopre added reviewers: gregmiller, tejohnson, davide, danielcdh. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Re-add -fexperimental-new-pass-manager to

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG005fc11ebdd6: [PGO] Change ThinLTO test for targets with loop unrolling disabled (authored by Sherwin da Cruz 59867245+sherwin...@users.noreply.github.com, committed by thopre). Repository: rG LLVM

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o -

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Ah fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. In D104854#2957735 , @kpn wrote: > In D104854#2957490 , @lebedev.ri > wrote: > >> In D104854#2957471 , @sepavloff >> wrote: >> >>> In

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e11ccad837c: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86 (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D107633: Set supported target for asan-use-callbacks test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1397e19129ef: Set supported target for asan-use-callbacks test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre updated this revision to Diff 365465. thopre added a comment. Remove REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 Files: clang/test/CodeGen/asan-use-callbacks.cpp Index:

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre updated this revision to Diff 365425. thopre added a comment. Use x86_64-linux-gnu as triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/ https://reviews.llvm.org/D107667 Files:

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre created this revision. thopre added reviewers: xur, tejohnson, lebedev.ri. Herald added subscribers: ormris, pengfei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre created this revision. thopre added reviewers: kstoimenov, vitalybuka. Herald added subscribers: pengfei, krytarowski. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicitely set x86_64-linux-gnu as a target for

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. LGTM (besides comment fix) but I'm not too familiar with the vector side of things Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6967 + // NaN has all exp bits set and a non zero significand. Therefore: + // isnan(V) == ((exp mask -

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

thopre added a comment. +1 for this change but being a downstream target only I prefer to let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } jdoerfert wrote: > thopre

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } I'm getting #0 for both

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv()

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre updated this revision to Diff 338811. thopre marked an inline comment as done. thopre added a comment. Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335640. thopre added a comment. Rename NUW_RN for CHECK-YES to NUW Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index:

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335618. thopre added a comment. Change attribute check to a positive match Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ddunbar, MaskRay, rjmccall, spatel, arsenm, hfinkel, void, mcrosier. thopre requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Clang test CodeGen/libcalls.c contains CHECK-NOT directives using a

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG828ec9e9e5da: [OpenCL, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99857/new/

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3e0feca92: [DebugInfo, CallSites, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99830/new/

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG292726b6443c: [HIP, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99832/new/

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41b5100e438: [HIP-Clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99831/new/

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: hliao, craig.topper, neil.hickey, yaxunl, baldrick. Herald added subscribers: ldrumm, Anastasia. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenOpenCL/fpmath.cl uses a variable defined in an earlier

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99838/new/

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre created this revision. thopre added reviewers: respindola, pcc, EricWF. thopre requested review of this revision. Herald added a project: clang. The NSS FileCheck variables at the end of the CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in the use of an undefined

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

thopre created this revision. thopre added reviewers: rsmith, EricWF, akhuang. thopre requested review of this revision. Herald added a project: clang. Commit f495de43bd5da50286da6020e508d106cfc60f57 forgot two lines when

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: yaxunl, ashi1, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenCUDA/kernel-stub-name.cu uses never defined DKERN variable in a CHECK-NOT directive. This commit replace the

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ashi1, yaxunl, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Commit 8129521318accc44c2a009647572f6ebd3fc56dd changed a line defining PREFIX in clang test CodeGenCUDA/device-stub.cu into a

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: djtodoro, vsk. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGen/debug-info-extern-call.c tries to check for the absence of a sequence of instructions with several CHECK-NOT with one of those

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG95f448aa86cd: [PGO, test] Fix typo in FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99821/new/

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

thopre created this revision. thopre added reviewers: bogner, xur, davidxl. Herald added a subscriber: wenlei. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99821

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e458935ba6: [OpenMP, test] Fix use of undef DECL FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99771/new/

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd222a07d3023: [OpenMP, test] Fix uses of undef S*VAR FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

thopre created this revision. thopre added reviewers: ABataev, mikerice, jdoerfert, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Remove the CHECK-NOT directive

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre updated this revision to Diff 334846. thopre added a comment. Fix one more testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99770/new/ https://reviews.llvm.org/D99770 Files: clang/test/OpenMP/for_firstprivate_codegen.cpp

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

thopre created this revision. thopre added reviewers: cchen, ABataev, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenMP test

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre created this revision. thopre added reviewers: ABataev, MaskRay, jdoerfert. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Fix the many cases of use of undefined

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cd5b352ff4: [test] Fix variable definition in acle_sve_ld1.sh (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre added a comment. In D98852#2634189 , @sdesmalen wrote: > LGTM, thanks for fixing! > > I'm curious, how did you find this case? :) The issue was caught by a patch of mine to FileCheck: https://reviews.llvm.org/D98691 Repository: rG LLVM Github

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre created this revision. thopre added reviewers: andwar, david-arm, sdesmalen, SjoerdMeijer, kmclaughlin. Herald added a subscriber: tschuett. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test acle_sve_ld1.sh is

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2426b1fa66f9: [Test] Fix undef var in attr-speculative-load-hardening.c (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was automatically updated to reflect the committed changes. Closed by commit rGf60b35340fd7: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. In D97125#2603832 , @thopre wrote: > Requesting review since the logic has changed. This time I've also tested > isfinite against glibc's result. All looks good. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre requested review of this revision. thopre added a comment. Requesting review since the logic has changed. This time I've also tested isfinite against glibc's result. All looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > uweigand wrote: > > thopre wrote: > > > jonpa wrote: > > > > What are

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328171. thopre added a comment. Add isfinite testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328170. thopre added a comment. Fix isfinite logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre updated this revision to Diff 328130. thopre added a comment. Adapt to revert of __builtin_isinf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 Files: clang/test/CodeGen/strictfp_builtins.c

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; uweigand wrote: > thopre wrote: > > jonpa wrote: > > > What are these variants all

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; jonpa wrote: > What are these variants all about...? > They were introduced in

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre created this revision. thopre added reviewers: mibintc, kpn, efriedma, sepavloff, rjmccall, jonpa. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9 Files:

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6eb56aa0ea: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. Ping? Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT:

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added reviewers: rsmith, rnk, kristof.beyls. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added inline comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT:

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 325718. thopre added a comment. - Add half testcase - Fixup existing testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. I think we should also add tests for half Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 ___ cfe-commits mailing list

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre created this revision. thopre added reviewers: kpn, efriedma, mibintc, sepavloff, rjmccall. Herald added a subscriber: pengfei. thopre requested review of this revision. Herald added a project: clang. __builtin_isinf currently generates a floating-point compare operation which triggers a

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2567145 , @jonpa wrote: > In D96568#2559476 , @thopre wrote: > >> In D96568#2559475 , @uweigand wrote: >> >>> In D96568#2559336

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00a62547da7e: Stop traping on sNaN in __builtin_isnan (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre added inline comments. Comment at: clang/test/CodeGen/aarch64-strictfp-builtins.c:1 +// RUN: %clang_cc1 %s -emit-llvm -ffp-exception-behavior=maytrap -fexperimental-strict-floating-point -o - -triple arm64-none-linux-gnu | FileCheck %s + AArch64 is not

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321554. thopre added a comment. Add AArch64 testcase and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321107. thopre marked 2 inline comments as done. thopre added a comment. - Fix order of sub operands in comments and use fully parenthesized expression - Explain how LShr is equivalent to < 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2995 +Builder.getDefaultConstrainedExcept() == fp::ebIgnore || +!Ty->isIEEE()) { + V = Builder.CreateFCmpUNO(V, V, "cmp"); I'm

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V =

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre created this revision. thopre added reviewers: efriedma, kpn, mibintc, sepavloff, rjmccall. Herald added subscribers: dexonsmith, pengfei. thopre requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. __builtin_isnan currently

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >