[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann created this revision. tahonermann added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) This change completes adjustments of source locations for FunctionDecl definitions

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann added a comment. See PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) for more details. The patch posted here differs slightly from what is posted in the PR; `getLocation()` is called instead of `getBeginLoc()` since the latter may return a customized begin location. I

[PATCH] D72053: [RFC] Handling implementation limits

tahonermann added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:11 +This page lists the limits implemented in the Clang compiler. The available +resources on the system running Clang may imposse other limits. For example, +the system may have insufficient

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann accepted this revision. tahonermann added a comment. I'm not a regular Clang reviewer. But for what it is worth, the changes look correct, clear, and appropriate from my lens (though I disagree slightly with some of the lint recommendations in the cases where the recommendation

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann added a comment. @Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions,

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for string and character literals">; def target_cpu : Separate<["-"],

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:244 bool Pascal; + ConversionState TranslationState; + abhina.sreeskantharajan wrote: > tahonermann wrote: > > Same concern here with respect to persisting the conversion

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/test/CodeGen/systemz-charset.c:4 + +char *UpperCaseLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; +// CHECK: c"\C1\C2\C3\C4\C5\C6\C7\C8\C9\D1\D2\D3\D4\D5\D6\D7\D8\D9\E2\E3\E4\E5\E6\E7\E8\E9\00" `const char *` please

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for string and character literals">; def target_cpu : Separate<["-"],

[PATCH] D93031: Enable fexec-charset option

tahonermann added a comment. Hi, Abhina. Sorry for the delay getting back to you. I added some more comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:191 +Preprocessor , tok::TokenKind kind, +ConversionState

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

tahonermann added inline comments. Comment at: clang/include/clang/AST/Expr.h:1846-1871 + std::string getStringAsChar() const { +assert(getCharByteWidth() == 1 && + "This function is used in places that assume strings use char"); +return

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

tahonermann added inline comments. Comment at: clang/lib/AST/Type.cpp:1962 +bool Type::isType(const std::string TypeName) const { + QualType Desugar = this->getLocallyUnqualifiedSingleStepDesugaredType(); MarcusJohnson91 wrote: > efriedma wrote: > >

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tahonermann published this revision for review. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds a "multiversion" annotation to textual

[PATCH] D121954: [clang] Add test cases for multiversion function overload scenarios in C.

tahonermann created this revision. Herald added a project: All. tahonermann added reviewers: erichkeane, aaron.ballman. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change resolves both

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Checking of multiversion function declarations performed

[PATCH] D121957: [clang] NFC: Redundant code removal in SemaDecl.cpp, CheckTargetCausesMultiVersioning().

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D121955: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction().

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann added a comment. > Is there a need for this functionality? Not a strong need, but I found it helpful in two scenarios: 1. A forward declaration of a multiversion function is not required to include a multiversion function attribute; later declarations might trigger

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann updated this revision to Diff 416604. tahonermann added a comment. Updates to address clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958 Files:

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann added a comment. > Hmm... my understanding is "MergeTypeWithPrevious" is important for cases > where we decide that this is a redeclaration, right? We need to set it to > 'false' when we "know" that this is a different declaration, right? So at > least the '=false' was correct? As

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann added a comment. > These words have no power here. No power, but not uninformative to some. I promise to keep such references out of git's permanent record :) Comment at: clang/test/Sema/attr-cpuspecific.c:133 -// FIXME: Declaration of a non-overloadable

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416618. tahonermann added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann updated this revision to Diff 416632. tahonermann added a comment. Fix bad merge conflict resolution that I failed to even test compiling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416645. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

tahonermann updated this revision to Diff 416646. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121962/new/ https://reviews.llvm.org/D121962 Files: clang/test/OpenMP/declare_variant_messages.c Index:

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

tahonermann updated this revision to Diff 416647. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121963/new/ https://reviews.llvm.org/D121963 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann updated this revision to Diff 416643. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann updated this revision to Diff 416644. tahonermann added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121960/new/ https://reviews.llvm.org/D121960 Files: clang/lib/Sema/SemaDecl.cpp Index:

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann updated this revision to Diff 416665. tahonermann added a comment. Corrected a clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann updated this revision to Diff 41. tahonermann added a comment. Rebase with a correction for an incorrect merge conflict resolution that propagated from D121958 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416668. tahonermann added a comment. Rebase to acquire fixes from parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files:

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

tahonermann updated this revision to Diff 416670. tahonermann added a comment. Rebase to acquire fixes from parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121963/new/ https://reviews.llvm.org/D121963 Files:

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

tahonermann updated this revision to Diff 416669. tahonermann added a comment. Rebase to acquire fixes from parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121962/new/ https://reviews.llvm.org/D121962 Files:

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3462 - case 'u': // Identifier (uber) or C11/C++11 UTF-8 or UTF-16 string literal + case 'u': // Identifier (uber) or C11/C2x/C++11 UTF-8 or UTF-16 string literal // Notify MIOpt that we read a

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3565 else Ty = Context.CharTy; // 'x' -> char in C++ Perhaps worth updating this comment? e.g., // 'x' -> char in C++; u8'x' -> char in C11-C17 and in C++ without char8_t.

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann added a comment. > I was surprised to see the Windows CI pass with that sed invocation! Ha! I didn't even think about that. I had copied the `RUN` lines from another test and only adjusted what was necessary. The bots must have Cygwin, MSYS[2], GnuWin32, or similar installed.

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6348-6349 +} else { + // If neither of these things, we have a user we don't know how to handle, + // so default to previous behavior of emitting a terrible error message. +

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6393 +// If Val is null, that implies there were multiple declarations that each +// had a claim to the unmangled name. In this case, generation of hte alias +// is suppressed. See

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! I left one final comment about a double period that was my fault. Comment at: clang/lib/CodeGen/CodeGenModule.h:1578 + /// may not reference

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. tahonermann updated this revision to Diff 419919. tahonermann added a comment. tahonermann updated this revision to Diff 420008.

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver().

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change modifies

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann added inline comments. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122953: [clang] Emit target_clones resolver functions as COMDAT.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, resolver functions synthesized for

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann added a comment. > but I DO have the opposite problem: Figuring out what the associated tests > are for a patch I also have that issue, but I don't see the relevance here. The changes in D122958 that fixes the issues revealed by these tests

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann added a comment. > FWIW, I dislike this idea of doing tests in separate commits from the patch > itself, it makes the review of the patch more difficult, and makes looking > through history more difficult. Here is my perspective on this. When adding a new feature, I agree that

[PATCH] D121954: [clang] Add test cases for multiversion function overload scenarios in C.

This revision was automatically updated to reflect the committed changes. Closed by commit rG325c4c29d68c: [clang] Add test cases for multiversion function overload scenarios in C. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121955: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction().

This revision was automatically updated to reflect the committed changes. Closed by commit rG77472a659e25: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction(). (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b6f1cbb21c5: [clang] Add missing diagnostics for invalid overloads of multiversion functions… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58c202a3d83d: [clang] NFC: Rename MVType variables to MVKind for consistency with their… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG059a953d8819: [clang] [OpenMP] Diagnose use of target_clones in OpenMP variant declarations. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121957: [clang] NFC: Redundant code removal in SemaDecl.cpp, CheckTargetCausesMultiVersioning().

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b2e0567c54: [clang] NFC: Redundant code removal in SemaDecl.cpp… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121957/new/

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42e4c5b2610d: [clang] NFC: Remove forced type merging in multiversion function checks. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cceee755992: [clang] Produce a multiversion annotation in textual AST output. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ff8c3ac0dd6: [clang] [OpenMP] Extend OpenMP variant declaration tests. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121962/new/

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6319 +/// If all uses of the GV are from an IFunc resolver, which can happen when the +/// IFunc resolver is a static-function, but the name ends up being different, +/// return the IFunc so it

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

tahonermann closed this revision. tahonermann added a comment. Closing per commit 3531a4fa3b7038d43ac20f56871da88aa25bf53d (I failed to add "Differential Revision" to the commit message). Repository: rG

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

tahonermann updated this revision to Diff 420586. tahonermann added a comment. Reworded a comment to address code review commentary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122955/new/ https://reviews.llvm.org/D122955 Files:

[PATCH] D122953: [clang] Emit target_clones resolver functions as COMDAT.

tahonermann closed this revision. tahonermann added a comment. Closing per commit 7c53fc4fe1308f5b2a7527d14ea41fabb18109b8 (I failed to add "Differential Revision" to the commit message). Repository: rG

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann abandoned this revision. tahonermann added a comment. Abandoning this review; the changes made here have been squashed into D122958 . With regard to prior comments, it seems we have divergent experience regarding the utility of separating commits

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

tahonermann updated this revision to Diff 420587. tahonermann added a comment. Squashed the addition of tests originally made in D122954 to this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122958/new/

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5531abaf7158: [clang] Corrections for target_clones multiversion functions. (authored by tahonermann). Repository: rG LLVM Github Monorepo

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tahonermann marked an inline comment as done. Closed by commit rGbed5ee3f4ba2: [clang] NFC: Enhance comments in CodeGen for multiversion function support. (authored by

[PATCH] D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver().

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ace0100aec3: [clang] NFC: Simplify the interface to CodeGenModule… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122956/new/

[PATCH] D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG40af8df6fe64: [clang] NFC: Preparation for merging code to emit target and target_clones… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

tahonermann added a comment. This looks pretty good to me. I added a few comments. I mostly just reviewed the lexer related code; I didn't dive into the name matching code. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:130-131 def

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

tahonermann marked an inline comment as done. tahonermann added inline comments. Comment at: clang/test/CodeGen/attr-target-mv.c:95-111 +// WINDOWS: $foo_used = comdat any +// WINDOWS: $foo_used2.avx_sse4.2 = comdat any +// WINDOWS: $pr50025.resolver = comdat any +// WINDOWS:

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann added a comment. > This might've caused a regression? > (https://github.com/llvm/llvm-project/issues/54892) @dblaikie, it most definitely did. Note that I'm the author of the patch that introduced the regression, the reporter of the regression, and the assignee for fixing the

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann accepted this revision. tahonermann added a comment. Looks good to me! Thank you for filing the separate issue. Comment at: clang/test/Lexer/utf8-char-literal.cpp:23 +char f = u8'ab';// expected-error {{Unicode character literals may not contain

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

tahonermann added a comment. A couple of observations with regard to compatibility: gcc,, at least by default, emits the TC implementations as local functions, the resolver as a weak global function, and the undecorated name as an ifunc. When only a TC declaration (not a definition) is

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

tahonermann added a comment. I think it would also be a good idea to exercise the test case for a target that lacks ifunc support to ensure that inter-TU calls work as expected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158666/new/ https://reviews.llvm.org/D158666

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann updated this revision to Diff 556592. tahonermann edited the summary of this revision. tahonermann added a comment. Rebased patch uploaded. This retains the same code change, but includes additional test updates for tests added since the first patch was submitted, as well as an

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann added a comment. @Endill, thank you for the reminder about this old patch! @cor3ntin, I added an additional test and updated a few other recently (relative to the original patch!) added tests. Would you be so kind as to give this another quick review? Repository: rG LLVM Github

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann updated this revision to Diff 556604. tahonermann added a comment. Moved the added release note to the correct section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087 Files:

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

tahonermann added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}}

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, @Manna, these changes look good to me! Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:175 SmallVector Bases; -for (const auto

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann updated this revision to Diff 554413. tahonermann marked an inline comment as done. tahonermann edited the summary of this revision. tahonermann added a comment. Address prior review feedback. This update also modifies the propagation of the `MSInheritanceAttr` attribute for

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + assert(CurLexer && "Invalid lexer value"); Would you mind splitting out all of

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Soumi, looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 ___

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann updated this revision to Diff 555076. tahonermann added a comment. Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158869/new/ https://reviews.llvm.org/D158869 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6658db5e5014: [clang] Fix timing of propagation of MSInheritanceAttr for template… (authored by tahonermann). Repository: rG LLVM Github Monorepo

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

tahonermann added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}}

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

tahonermann accepted this revision. tahonermann added a comment. Even better than I asked for. I held back on suggesting the change of `Tok` to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change anyway! You must have read my mind! :) Repository: rG LLVM Github Monorepo

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

tahonermann added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}}

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me modulo a couple of nits. Comment at: clang/include/clang/Lex/Lexer.h:806-807 /// Try to consume an identifier character encoded in UTF-8.

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann added a comment. @cor3ntin, any concerns or suggestions per my recent updates? I'll plan to land this in the next couple of days otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

tahonermann added a comment. @codemzs, I'm sorry for the very long delay following up on this review. I've been struggling to keep up, but expect to be able to devote some time to this next week. I'm committed to helping to ensure we land this before Phabricator stops accepting new diffs

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

tahonermann updated this revision to Diff 556970. tahonermann added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087 Files: clang/docs/ReleaseNotes.rst

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG256a0b298c68: [clang] Correct source locations for instantiations of function templates. (authored by tahonermann). Repository: rG LLVM Github

[PATCH] D156565: Diagnose use of VLAs in C++ by default

tahonermann added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " + "'static_assert'?">, InGroup; I

[PATCH] D156565: Diagnose use of VLAs in C++ by default

tahonermann added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " + "'static_assert'?">, InGroup;

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

tahonermann added a comment. > To me, an important metric of a quality patch is if the title and the summary > describe why we have this patch, and what we do about it. @steakhal, I'll work with the people submitting these patches to add more context to the title, summary, and commit comments.

[PATCH] D158293: [NFC][CLANG] Fix potential dereferencing of null return values

tahonermann added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann added reviewers: rnk, zequanwu. tahonermann added a comment. Adding Erich as attributes owner, and Reid and Zequan for MS ABI. This patch slightly modifies the changes made via D94646 and committed as rG4fffbc150cca1638051b8ad2a20f4b8240df0869

  1   2   3   4   >