[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137224 Files: clang/CMakeLists.txt

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. This fixes a bug where tests would be disabled when LLVM_EXTERNAL_LIT was set if lit couldn't be found in

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138472 Files: clang/CMakeLists.txt

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar added inline comments. Comment at: clang/CMakeLists.txt:103 if (LLVM_LIT AND LLVM_UTILS_PROVIDED) - set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest) - if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h - AND NOT EXISTS

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added a comment. In D138258#3936260 , @kwk wrote: > As much as I would like this to be fixed. I vote against this patch because > in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece > of code >

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. In D137024#3931499 , @thetruestblue wrote: > In D137024#3931497 , @tstellar > wrote: > >> @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? > > TBD. > So far this

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:799 +.Default(false); +} + I wasn't sure exactly how to determine if something is a system path, so I'm open to other ideas here. Repository: rG LLVM Github Monorepo

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar created this revision. tstellar added reviewers: JonChesterfield, MaskRay. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added inline comments. Herald added a subscriber: asb. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { Do these changes have any affected on the output html? Is there another

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added a subscriber: gkistanova. tstellar added a comment. @luke You'll need to contact the bot owners so they can update machine. The workers running the publish-sphinx-docs will need to be updated too. @gkistanova should be able to help. Repository: rG LLVM Github Monorepo

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

tstellar added inline comments. Comment at: clang/test/Driver/SOURCE_DATE_EPOCH.c:2 +// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH +// NO_EPOCH-NOT: "-source-date-epoch" + Hi @benlangmuir, this test fails in our build environment, because

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

tstellar added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK:

[PATCH] D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142511/new/ https://reviews.llvm.org/D142511

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I spent some time looking at this. Rather than changing the dependency from RISCVTargetParserTableGen to LLVMTargetParser, I think the correct fix is to handle RISCVTargetParserTableGen in llvm/cmake/modules/LLVMConfig.cmake.in. alongside the intrinsics_gen,

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. In D142606#4082783 , @serge-sans-paille wrote: > In D142606#4082753 , @tstellar > wrote: > >> Does this mean that clang will no longer search for the ROCM and CUDA >> library paths

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Can you add something to the release notes about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142199/new/

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli Please go ahead and push this since it is blocking others, we can fix up any of the other issues later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli The solution is to add RISCVTargetParserTableGen to the Depnds list of clang/lib/Driver and clang/lib/Basic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. I tested this patch and it works, so I'll give it an LGTM. However, I think the LLVMConfig.cmake.in changes are now unnecessary since the RISCVTargetParserTableGen has been dropped from

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) Doesn't this break the monorepo (non-standalone) build? If the monorepo build still works with this, then you don't need the changes to

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I don't think this is the correct way to specify dependencies if it's just an issue of the header being included before a generated file it needs has been generated. Are there other places in the code where a generated header file is included by another header?

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. In D142403#4074905 , @fpetrogalli wrote: > In D142403#4074885 , @tstellar > wrote: > >> This is still the wrong change IMO. I don't know, maybe I'm not being >> clear, but I don't

[PATCH] D142403: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. I tested and this fixes the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142403/new/ https://reviews.llvm.org/D142403

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. Is LLVMTargetParser a library In D141581#4057177 , @fpetrogalli wrote: > In D141581#4056825 , @barannikov88 > wrote: > >> clangBasic and clangDriver already have a dependency on

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. So, what's the actual dependency here? Do libBasic and libDriver just need the header to be generated or does it actually need to link to the library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/

[PATCH] D125860: [clang] Only use major version in resource dir

tstellar added a comment. @tbaeder That CI failure seems unrelated. Maybe just commit early in the day so you have time to deal with the bot failures (if any). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar created this revision. tstellar added reviewers: phosek, mgorny, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the FileCheck, count, and not tools are not found in

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3916493 , @mgorny wrote: > Could you issue a warning though? It's really annoying when targets disappear > like that and you have to guess which of the checks failed. What about just making it an error if

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3915899 , @mstorsjo wrote: > This does, somewhat, coincide with what I'm trying to do in D131052 > . There, I don't point out the binaries for > `FileCheck` and similar, but point

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a959334707: clang/cmake: Simplify lit detection for standalone builds (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/

[PATCH] D131919: Move googletest to the third-party directory

tstellar added a comment. Herald added a subscriber: Moerafaat. @probinson Does this latest update look better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919

[PATCH] D131919: Move googletest to the third-party directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59052468c3e3: Move googletest to the third-party directory (authored by tstellar). Changed prior to commit:

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. I think this looks OK. What kind of errors were you seeing before this fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. In D137917#3925161 , @Trass3r wrote: > Thanks could you also commit it? Sure, what name and email should I use for you when committing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da41fe69622: [cmake] Fix _GNU_SOURCE being added unconditionally (authored by Trass3r, committed by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

tstellar added a comment. We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar abandoned this revision. tstellar added a comment. -fopenmp-add-rpath has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142174/new/ https://reviews.llvm.org/D142174 ___

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds (authored by tstellar). Changed prior to commit:

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4142023 , @JonChesterfield wrote: > I don't mind hugely what mechanism is used but would really like clang++ > -fopenmp foo.cpp to build a program that runs. How can we preserve that > 'works' feature without

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. FWIW, I'm in favor of this patch. System directory rpaths (e.g. /usr/lib64) are not allowed in Fedora Linux. The current default makes building packages with clang+openmp more difficult. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

tstellar added a comment. Would this make more sense in a config file rather than a CMake option? @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144853/new/ https://reviews.llvm.org/D144853

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. @JonChesterfield I don't think we should be putting any Fedora specific logic into clang's build system or the driver, if that's what you are suggesting. Fedora can always patch the compiler or install a config file to change the default behavior, even though this is

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4145432 , @MaskRay wrote: > This is the point. Specifying a driver option to use > libc++/libc++abi/libunwind doesn't magically change `DT_RUNPATH`. This is > exactly the behavior a user wants for a system Clang. >

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar updated this revision to Diff 509912. tstellar added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348 ___ cfe-commits mailing list

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. I think we could remove some of the duplication by making the docs_target parameter into a list and passing both docs-clang-html and docs-clang-man to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. In D149809#4317763 , @aidengrossman wrote: > In D149809#4317610 , @tstellar > wrote: > >> I think we could remove some of the duplication by making the docs_target >> parameter into a

[PATCH] D155509: Revert "Remove rdar links; NFC"

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe88fe8181e36: clang/openmp: Fix alignment for ThreadID Address variables (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, wenlei, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I was not sure what to do with inline functions and also functions that were implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY macro to most of those functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4355229 , @paperchalice wrote: > In D141907#4355228 , @tstellar > wrote: > >> @paperchalice Do you need someone to commit this for you? > > Sure, I don't have the commit

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. @paperchalice Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 ___ cfe-commits mailing

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I chatted with @compnerd on Discord, and I'm going to try to update D109192 and get that committed and then come back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. > ! In D152051#4403167 , @compnerd > wrote: > Please do not use LLVM_EXTERNAL_VISIBILITY but rather introduce a new macro > (this will prevent the use on Windows). OK, so should I create a clang specific macro for this? And

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

tstellar added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/cmake/base-config-ix.cmake:126 +set(COMPILER_RT_INSTALL_DATA_DIR "${default_install_path}" CACHE PATH + "Path where compiler-rt data files should be

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4409973 , @MaskRay wrote: > In D141907#4094748 , @MaskRay wrote: > >> [...] >> edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable >>

[PATCH] D156599: [profiling] Move option declarations into headers

tstellar created this revision. tstellar added reviewers: bogner, dnovillo, hoy, huangjd. Herald added subscribers: wlei, Enna1, ormris, wenlei, hiraditya. Herald added a project: All. tstellar requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > >

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar created this revision. tstellar added a reviewer: jlpeyton. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar updated this revision to Diff 522853. tstellar added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150723/new/ https://reviews.llvm.org/D150723 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've tested this and it works for my build configuration. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() paperchalice wrote: > tstellar wrote: > > Why is

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > paperchalice wrote: > >

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Herald added subscribers: ekilmer, jplehr. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() Why

<    1   2   3   4