[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9afc57dcb2e5: [CodeGen][UBSan] Handle sugared QualTypes correctly in (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550477. usama54321 added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/ https://reviews.llvm.org/D157445 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550475. usama54321 retitled this revision from "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash." to "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.". usama54321

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

usama54321 created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. usama54321 requested review of this revision. Herald added a

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

usama54321 updated this revision to Diff 430469. usama54321 added a comment. Fixed clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125840/new/ https://reviews.llvm.org/D125840 Files:

[PATCH] D125840: [Analyzer] Removed extra space from NSErrorChecker debug message and updated relevant tests

usama54321 updated this revision to Diff 430450. usama54321 added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125840/new/ https://reviews.llvm.org/D125840 Files: clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431516. usama54321 added a comment. - updated canResolveToExpr to accept both statements and expressions. Removed unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431490. usama54321 added a comment. Added a separate check for unevaluated statements. Updated InfiniteLoopCheck to use new check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

This revision was automatically updated to reflect the committed changes. usama54321 marked an inline comment as done. Closed by commit rG602682225ad6: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops (authored by usama54321). Changed prior to commit:

[PATCH] D126246: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. This revision was not accepted when it landed; it landed in state "Draft". This revision was automatically updated to reflect the committed changes. Closed by commit rG63ecb7dcc80d: bugfix in

[PATCH] D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 updated this revision to Diff 431497. usama54321 added a comment. Updating patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126034/new/ https://reviews.llvm.org/D126034 Files:

[PATCH] D126245: Added a separate check for unevaluated statements. Updated InfiniteLoopCheck to use new check

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. usama54321 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D126034: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. usama54321 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

usama54321 updated this revision to Diff 488408. usama54321 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141550/new/ https://reviews.llvm.org/D141550 Files:

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

usama54321 marked 3 inline comments as done. usama54321 added inline comments. Comment at: compiler-rt/lib/ubsan/CMakeLists.txt:118 +if (NOT APPLE) + add_compiler_rt_runtime(clang_rt.ubsan +STATIC delcypher wrote: > I think you may have

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

usama54321 marked an inline comment as done. usama54321 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:219 +def err_drv_unsupported_static_ubsan_darwin : Error< + "Static UBSan runtime is not supported on darwin">; def

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

usama54321 created this revision. Herald added a subscriber: Enna1. Herald added a project: All. usama54321 requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers. This patch removes the static ubsan runtime on Apple

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa44477b1f4b5: [CompilerRT] Remove ubsan static runtime on Apple (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. rdar://99200922 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142421 Files:

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6dbdecba0b: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended (authored by usama54321). Repository: rG LLVM Github

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142243 Files:

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142242 Files:

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490922. usama54321 added a comment. Renaming identifiers in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142242/new/ https://reviews.llvm.org/D142242 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490923. usama54321 added a comment. Renaming identifiers in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142242/new/ https://reviews.llvm.org/D142242 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490949. usama54321 added a comment. Removing unnecessary code from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142243/new/ https://reviews.llvm.org/D142243 Files:

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 added a comment. The libcxx test failure seems unrelated and seems to be failing on master https://buildkite.com/llvm-project/libcxx-ci/builds?branch=master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142243/new/

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57690a8ece9e: [Sanitizers] fix -fno-sanitize-link-runtime for darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added a comment. I have reverted the commit for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > zixuw wrote: > > dmaclach wrote: > > > yln

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG665e32ee0ffd: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Changed prior to commit: https://reviews.llvm.org/D144672?vs=502474=502569#toc Repository: rG LLVM Github

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > usama54321 wrote: > > yln wrote: > > > zixuw

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7d40e0928c: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 accepted this revision. usama54321 added a comment. This revision is now accepted and ready to land. I was verifying that static versions of these libraries are not present on darwin. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 reopened this revision. usama54321 added a comment. This revision is now accepted and ready to land. @dmaclach Can you please take a look and fix this? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/

[PATCH] D157445: [CodeGen][UBSan] getUBSanFunctionTypeHash does not handle the attributed function case correctly, leading to an assertion failure. This patch desugars the QualType if it is of Attribu

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://113144087 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157445 Files:

[PATCH] D157445: [CodeGen][UBSan] getUBSanFunctionTypeHash does not handle the attributed function case correctly, leading to an assertion failure. This patch desugars the QualType if it is of Attribu

usama54321 updated this revision to Diff 548723. usama54321 added a comment. Fix commit message and description, and added comment explaining the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/ https://reviews.llvm.org/D157445