vleschuk retitled this revision from "DebugInfo: use
llvm::DINode::FlagAlignment to mark forcibly aligned data" to "DebugInfo: Pass
non-zero alignment to DIBuilder only if aligment was forced".
vleschuk updated the summary for this revision.
vleschuk updated this revision to Diff 70965.
vleschuk
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:608
@@ -608,2 +607,3 @@
uint64_t Size = CGM.getContext().getTypeSize(Ty);
+ uint64_t Align = 0;
rnk wrote:
> IMO this is what we should be doing everywhere, rather than manually
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3691
@@ -3635,1 +3690,3 @@
+ if (D->hasAttr())
+AlignInBits = D->getMaxAlignment();
StringRef DeclName, LinkageName;
probinson wrote:
> dblaikie wrote:
> > is max alignment the right
vleschuk created this revision.
vleschuk added reviewers: echristo, aprantl, dblaikie, mehdi_amini.
vleschuk added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Add llvm::DINode::FlagAlignment to entities marked with C++11 'alignas', C11
'_Alignas' keywords or ObjC clang
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:979
@@ -978,4 +978,3 @@
llvm::DIType *
-CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc,
- AccessSpecifier AS, uint64_t offsetInBits,
-
vleschuk updated this revision to Diff 70949.
vleschuk added a comment.
Reverted formatting changes.
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
Index: lib/CodeGen/CGDebugInfo.h
vleschuk marked 2 inline comments as done.
vleschuk added a comment.
https://reviews.llvm.org/D24426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vleschuk updated this revision to Diff 73537.
vleschuk added a comment.
Pass alignment in bits instead of bytes to backend (conversion is done when
emitting DW_AT_alignment).
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
vleschuk updated this revision to Diff 73318.
vleschuk added a comment.
Fix code style:
- Two overloaded methods instead of 1 template
- lower-case-headed method names
- static methods instead of anon namespace
- extra new line between methods
https://reviews.llvm.org/D24426
Files:
vleschuk updated this revision to Diff 73228.
vleschuk added a comment.
- Move alignment detection into helper functions in anon namespace
- Use updated LLVM DIBuilder API (from https://reviews.llvm.org/D24425)
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
vleschuk marked 3 inline comments as done.
vleschuk added inline comments.
> vleschuk wrote in CGDebugInfo.cpp:608
> Will check if this works in all cases. I think it's worth putting this
> snippet into helper function within anon namespace.
That is correct for types, for particular decls we
Author: vleschuk
Date: Wed Oct 19 19:37:07 2016
New Revision: 284683
URL: http://llvm.org/viewvc/llvm-project?rev=284683=rev
Log:
Upgrade debug-info-vla test: we do not pass default alignment now
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-vla.cpp
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284651: DebugInfo: use uint32_t for alignment variables.
(authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D25621?vs=75143=75241#toc
Repository:
rL LLVM
Author: vleschuk
Date: Wed Oct 19 17:11:07 2016
New Revision: 284651
URL: http://llvm.org/viewvc/llvm-project?rev=284651=rev
Log:
DebugInfo: use uint32_t for alignment variables.
LLVM now uses uint32_t for DebugInfo alignment for space efficiency,
in this patch we change frontend
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284679: DebugInfo: pass alignment value only if it was
forced (authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D24426?vs=74686=75261#toc
Repository:
rL LLVM
Author: vleschuk
Date: Wed Oct 19 19:13:19 2016
New Revision: 284679
URL: http://llvm.org/viewvc/llvm-project?rev=284679=rev
Log:
DebugInfo: pass alignment value only if it was forced
Preparation to implement DW_AT_alignment support:
- We pass non-zero align value to DIBuilder only when
vleschuk created this revision.
vleschuk added reviewers: aprantl, mehdi_amini, dblaikie, echristo.
vleschuk added a subscriber: cfe-commits.
Use DIAlignment type introduced in https://reviews.llvm.org/D25620
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h
vleschuk updated this revision to Diff 74686.
vleschuk added a comment.
Use DIAlignment type instead of uint64_t for alignment in DebugInfo.
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGen/debug-info-packed-struct.c
vleschuk updated this revision to Diff 75143.
vleschuk added a comment.
- Removed all changes non-related to CGDebugInfo: will post them in separate
NFC patch which will switch all unsigned alignment entries to uint32_t.
https://reviews.llvm.org/D25621
Files:
lib/CodeGen/CGDebugInfo.cpp
vleschuk added a comment.
In https://reviews.llvm.org/D25621#573671, @aprantl wrote:
> This patch is conflating two set of changes:
> (1) NFC: rename all occurrences of unsigned for alignment purposes in the
> frontend with uint32_t
> (2) shrink all debug-info-related alignment variables from
vleschuk added a comment.
Can anyone take a look at this please? =)
https://reviews.llvm.org/D25621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vleschuk created this revision.
vleschuk added reviewers: mehdi_amini, echristo, dblaikie, aprantl.
vleschuk added a subscriber: cfe-commits.
Mark C11 _Atomic variables with DW_TAG_atomic_type tag.
This is the simplest way to achieve the goal: modifying Qualifiers results in
much more changes
vleschuk added inline comments.
Comment at: test/CodeGen/debug-info-atomic.c:3
+
+// CHECK: !DIDerivedType(tag: DW_TAG_const_type
+// CHECK: !DIDerivedType(tag: DW_TAG_atomic_type
aprantl wrote:
> Why do we need the const here?
I thought it would be better to
vleschuk updated this revision to Diff 76441.
vleschuk added a comment.
Made test more strict: it now checks that variable i is atomic.
https://reviews.llvm.org/D26145
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-atomic.c
Index: test/CodeGen/debug-info-atomic.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285625: DebugInfo: support for DW_TAG_atomic_type (authored
by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D26145?vs=76441=76458#toc
Repository:
rL LLVM
Author: vleschuk
Date: Mon Oct 31 14:09:47 2016
New Revision: 285625
URL: http://llvm.org/viewvc/llvm-project?rev=285625=rev
Log:
DebugInfo: support for DW_TAG_atomic_type
Mark C11 _Atomic variables with DW_TAG_atomic_type tag.
Differential Revision: https://reviews.llvm.org/D26145
Added:
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
aprantl wrote:
> I'm not sure we want
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
vleschuk wrote:
> aprantl wrote:
> >
vleschuk updated this revision to Diff 74899.
vleschuk added a comment.
- Use uint32_t directly for alignment instead of creating typedef ofr it
- Get rid of DebugInfo dependency in AST
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DeclBase.h
Author: vleschuk
Date: Sat Jul 29 01:18:38 2017
New Revision: 309484
URL: http://llvm.org/viewvc/llvm-project?rev=309484=rev
Log:
Fix incorrect assertion condition.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
Hello everyone,
LLVM buildmaster will be updated and restarted approximately at 08:00 AM
PDT 4th August.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hello everyone,
LLVM buildmaster was updated and restarted, downtime was about 2 minutes.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hello everyone,
LLVM buildmaster was updated and restarted, downtime was about 2 minutes.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hello all, buildbot is currently down due to hardware failure. We are
currently working on it. Sorry for the inconvenience.
--
Best Regards,
Victor
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
There is power outage in the area where the servers are located. They
say the power will be restored at 10:45 AM PDT, I'd estimate buildbot
online time about ~12:00.
On 08/02/2017 06:31 PM, Victor Leschuk wrote:
> Hello all, buildbot is currently down due to hardware failure. We are
> currently
Buildbot is up and running. Sorry for the delay.
On 08/02/2017 06:31 PM, Victor Leschuk wrote:
> Hello all, buildbot is currently down due to hardware failure. We are
> currently working on it. Sorry for the inconvenience.
>
--
Best Regards,
Victor
Hello everyone,
LLVM buildmaster will be updated and restarted approximately at 08:00 AM
PDT 28th July.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ps4-buildslave2 will be temporary disconnected from build master for
debugging purposes. It will be done approximately at 6:00 PM PDT 18, Aug
(Friday).
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
ps4-buildslave2 is now disconnected from buildmaster, it will be back
online when we solve the problem with hanging tests.
On 08/18/2017 12:03 AM, Victor Leschuk wrote:
> ps4-buildslave2 will be temporary disconnected from build master for
> debugging purposes. It will be done approximately at
Hello all, ps4-buildslave1a is currently down. We are detecting the
cause and will fix it ASAP. I will inform when it is accessible again.
Sorry for the inconvenience.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
ps4-buildslave1a is back.
On 08/23/2017 08:49 AM, Victor Leschuk wrote:
> Hello all, ps4-buildslave1a is currently down. We are detecting the
> cause and will fix it ASAP. I will inform when it is accessible again.
>
> Sorry for the inconvenience.
>
--
Best Regards,
Victor Leschuk | Software
Both buildmasters were updated and currently are up and running.
On 08/20/2017 10:47 AM, Victor Leschuk wrote:
> Hello everyone,
> LLVM buildmasters (both main and staging) will be restarted in 2 hours
> (~3:00 AM PDT).
>
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
Hello everyone,
LLVM buildmasters (both main and staging) will be restarted in 2 hours
(~3:00 AM PDT).
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hello Boris, looks like this revision broke tests on our win10 builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760
Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp
I had to revert this revision. Could you please take a look?
Author: vleschuk
Date: Wed Aug 30 04:31:56 2017
New Revision: 312112
URL: http://llvm.org/viewvc/llvm-project?rev=312112=rev
Log:
Revert r312105 [modules] Add ability to specify module name to module file
mapping
Looks like it breaks win10 builder.
Removed:
45 matches
Mail list logo
