[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,51 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handlePreferredTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 1/9] [clang] Add clang::debug_info_type attribute ---

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/11] [clang] Add clang::debug_info_type attribute ---

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/12] [clang] Add clang::debug_info_type attribute ---

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,51 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handlePreferredTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > but I also see "you got what you asked for!" as being a reasonable defense to > that. That's my thinking indeed, and the reason why I opposed to Aaron's proposal to implicitly mark 1-bit bit-fields as `preferred_type(bool)`. https://github.com/llvm/llvm-project/pull/69104

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/10] [clang] Add clang::debug_info_type attribute ---

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > There's some danger here. _BitInt is a C23 feature as are enumerations with a > fixed underlying type. Enumerations with a fixed underlying type explicitly > disallow using a bit-precise integer type as the underlying type. See C23 > 6.7.2.2p4, which says in part, "For all

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-21 Thread Vlad Serebrennikov via cfe-commits
@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); Endilll wrote: My

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. LGTM, but you should wait for other reviewers before merging. https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: On the topic of ABI, Itanium and Microsoft type layouts are not compatible, even for standard-layout (POD) types. For [example](https://godbolt.org/z/zxfvMa9nE), bit-fields are [allowed](http://eel.is/c++draft/class.prop#3) in standard-layout types, but only Microsoft ABI

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-21 Thread Vlad Serebrennikov via cfe-commits
@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); Endilll wrote: That

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/69916 Refactor `uintptr_t` inside of `clang::Selector` that holds a pointer to `IdentifierInfo` or `MultiKeywordSelector` and `IdentifierInfoFlag` enum into `PointerIntPair`. This is a part of `PointerIntPair`

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/14] [clang] Add clang::debug_info_type attribute ---

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
@@ -7219,6 +7219,31 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def PreferredTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows adjusting the type of a bit-field in debug information.

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Thank you @AaronBallman for writing even more documentation! https://github.com/llvm/llvm-project/pull/69104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-23 Thread Vlad Serebrennikov via cfe-commits
@@ -7219,6 +7219,31 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def PreferredTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows adjusting the type of a bit-field in debug information.

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-15 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Does this issue not apply to other platforms? As far as I understand, MS ABI forces compilers to insert padding between bitfields more often than Itanium. Probably because of that GCC and Clang are able to merge separate loads of bitfields into single load on Linux. > I'd

[clang] [clang][NFC] Replace TypeAlignment with alignof(T) (PR #69185)

2023-10-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/69185 This patch replaces usages of `TypeAlignment` with `alignof(T)`, where `T` is type that will be created in allocated storage with placement-new. This is now possible, because `alignof` reports the correct

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69916 >From 58ebdda4e44b3fa2547d85a6cc9d5b0aa913b22a Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 23 Oct 2023 13:55:46 +0300 Subject: [PATCH 1/2] [clang][NFC] Refactor `Selector` to use

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69916 >From 58ebdda4e44b3fa2547d85a6cc9d5b0aa913b22a Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 23 Oct 2023 13:55:46 +0300 Subject: [PATCH 1/3] [clang][NFC] Refactor `Selector` to use

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-11 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Tagging @llvm/pr-subscribers-compiler-rt-sanitizer for visibility again, since this PR is abandoned. https://github.com/llvm/llvm-project/pull/67673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2023-11-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/71709 This patch refactors how values are stored inside `IdentifierInfo::ObjcOrBuiltinID` bit-field, and annotates it with `preferred_type`. In order to make the value easier to interpret by debuggers, a new

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2023-11-08 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @ChuanqiXu9 Can I use some of your help? This PR breaks two module tests: ``` Clang :: Modules/cxx20-hu-04.cpp Clang :: Modules/cxx20-module-file-info-macros.cpp ``` Apparently I somehow break import or export of header unit macros. In `cxx20-module-file-info-macros.cpp`, the

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2023-11-09 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Oh, I didn't look into the identifier's system before. I took a while to look > at the patch but I failed to understand it and I failed to find the > relationships between this patch and header units... Yeah, the part this PR touches in not the most straightforward one. Thank

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2023-11-09 Thread Vlad Serebrennikov via cfe-commits
@@ -86,19 +87,26 @@ enum { IdentifierInfoAlignment = 8 }; static constexpr int ObjCOrBuiltinIDBits = 16; /// The "layout" of ObjCOrBuiltinID is: -/// - The first value (0) represents "not a special identifier". -/// - The next (NUM_OBJC_KEYWORDS - 1) values represent

[clang] 5e09c4e - [clang][NFC] Partially annotate `IdentifierInfo` with `preferred_type`

2023-11-08 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-11-08T15:44:46+03:00 New Revision: 5e09c4e6a865707ed26f9a893dbef8b499591459 URL: https://github.com/llvm/llvm-project/commit/5e09c4e6a865707ed26f9a893dbef8b499591459 DIFF:

[clang] 6d971cb - [clang] Mark CWG554 as N/A

2022-12-06 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-06T12:39:19+03:00 New Revision: 6d971cb840dbb3f05689469bf11e49046ce2fae1 URL: https://github.com/llvm/llvm-project/commit/6d971cb840dbb3f05689469bf11e49046ce2fae1 DIFF:

[clang] 90d4cbb - [clang] Add test for CWG418

2022-12-08 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-08T21:57:07+03:00 New Revision: 90d4cbb87ce297d93159d39528767f5f46aa4da4 URL: https://github.com/llvm/llvm-project/commit/90d4cbb87ce297d93159d39528767f5f46aa4da4 DIFF:

[clang] 7e31d07 - [clang] Add test for CWG600

2022-12-06 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-06T12:42:35+03:00 New Revision: 7e31d0723dbf8ab9355cb58cfc6309be51be3e25 URL: https://github.com/llvm/llvm-project/commit/7e31d0723dbf8ab9355cb58cfc6309be51be3e25 DIFF:

[clang] 5b22c51 - [clang] Add test for CWG952

2022-12-06 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-06T12:27:22+03:00 New Revision: 5b22c5129c11f5c762c5092d7c52e1ac3d536903 URL: https://github.com/llvm/llvm-project/commit/5b22c5129c11f5c762c5092d7c52e1ac3d536903 DIFF:

[clang] 80bae9a - [clang] Add test for CWG405

2022-12-06 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-06T12:35:21+03:00 New Revision: 80bae9aacc1452d18bfb1fe7437f5dcd160614d3 URL: https://github.com/llvm/llvm-project/commit/80bae9aacc1452d18bfb1fe7437f5dcd160614d3 DIFF:

[clang] 3f950ad - [clang] Add test for CWG360

2022-12-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-01T17:23:26+03:00 New Revision: 3f950ad58919309882a29bcb4bf6f8db62ffc384 URL: https://github.com/llvm/llvm-project/commit/3f950ad58919309882a29bcb4bf6f8db62ffc384 DIFF:

[clang] eba4efc - [clang] Remove unused bookmark in CWG360 test (NFC)

2022-12-02 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-02T11:52:19+03:00 New Revision: eba4efcb056ccea1804a5c578b0ddc736100ebcc URL: https://github.com/llvm/llvm-project/commit/eba4efcb056ccea1804a5c578b0ddc736100ebcc DIFF:

[clang] f5993fc - [clang] Add test for CWG36

2022-12-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2022-12-01T21:10:28+03:00 New Revision: f5993fc7757e37a9076c5cd22de8f275e5c6097e URL: https://github.com/llvm/llvm-project/commit/f5993fc7757e37a9076c5cd22de8f275e5c6097e DIFF:

[clang] 55c9ad9 - [clang] Add test for CWG1960

2023-01-26 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-01-26T14:31:24+03:00 New Revision: 55c9ad99d12d18ee91a4c3e3609a0aacbaa5174e URL: https://github.com/llvm/llvm-project/commit/55c9ad99d12d18ee91a4c3e3609a0aacbaa5174e DIFF:

[clang] 839eae3 - [clang] Add test for CWG1960

2023-01-26 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-01-26T14:40:47+03:00 New Revision: 839eae38a4e4064568e1b3b0ee9538958ead8a40 URL: https://github.com/llvm/llvm-project/commit/839eae38a4e4064568e1b3b0ee9538958ead8a40 DIFF:

[clang] 467ed27 - [clang] Extend pragma dump to support expressions

2023-03-24 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-03-24T17:35:35+03:00 New Revision: 467ed2798772344e2a3b4a8d368575f1f9d1a8c6 URL: https://github.com/llvm/llvm-project/commit/467ed2798772344e2a3b4a8d368575f1f9d1a8c6 DIFF:

[clang] d945b64 - [clang] Make make_cxx_dr_status script runnable from anywhere

2023-04-12 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-12T20:46:05+03:00 New Revision: d945b6496ec6604f692804d501fc96583069d432 URL: https://github.com/llvm/llvm-project/commit/d945b6496ec6604f692804d501fc96583069d432 DIFF:

[clang] 19ef8e8 - [clang] Mark CWG2331 as N/A

2023-04-15 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-15T13:15:45+03:00 New Revision: 19ef8e8446df10b6bebf6301c1a3e9e8000f842c URL: https://github.com/llvm/llvm-project/commit/19ef8e8446df10b6bebf6301c1a3e9e8000f842c DIFF:

[clang] b9d84b5 - [clang][NFC] Fix DR test ordering

2023-04-15 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-15T18:25:08+03:00 New Revision: b9d84b57f680cb294da906a6eeca2d0598c11568 URL: https://github.com/llvm/llvm-project/commit/b9d84b57f680cb294da906a6eeca2d0598c11568 DIFF:

[clang] 0a113c4 - [clang] Mark CWG2009 as N/A

2023-04-24 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-24T11:53:04+03:00 New Revision: 0a113c4c50f65a7d26d20be84bfb56562154753f URL: https://github.com/llvm/llvm-project/commit/0a113c4c50f65a7d26d20be84bfb56562154753f DIFF:

[clang] 5cda0d1 - [clang] Add test for CWG1821

2023-04-25 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-25T09:03:46+03:00 New Revision: 5cda0d165a752c8041e8da4d39632c001463fa30 URL: https://github.com/llvm/llvm-project/commit/5cda0d165a752c8041e8da4d39632c001463fa30 DIFF:

[clang] 6737a15 - [clang] Mark CWG536 as N/A

2023-04-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-10T13:18:19+03:00 New Revision: 6737a1520900a506a884db6677a03fa729c2f197 URL: https://github.com/llvm/llvm-project/commit/6737a1520900a506a884db6677a03fa729c2f197 DIFF:

[clang] 86946eb - [clang] Add test for CWG1822

2023-04-11 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-11T11:08:22+03:00 New Revision: 86946ebb796c4ccde85b34aa52964e9aadabc692 URL: https://github.com/llvm/llvm-project/commit/86946ebb796c4ccde85b34aa52964e9aadabc692 DIFF:

[clang] a4beece - [clang] Add test for CWG2007

2023-04-11 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-11T22:13:43+03:00 New Revision: a4beecef8f40ad0d42f61e7c495acb2d2d819b10 URL: https://github.com/llvm/llvm-project/commit/a4beecef8f40ad0d42f61e7c495acb2d2d819b10 DIFF:

[clang] aa7aedd - [clang] Add test for CWG1837

2023-04-11 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-11T22:15:11+03:00 New Revision: aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec URL: https://github.com/llvm/llvm-project/commit/aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec DIFF:

[clang] feb93d2 - [clang] Add test for CWG2370

2023-04-11 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-11T22:04:02+03:00 New Revision: feb93d28b02c41ca6b069ec1f9e62fdfbb4c8b6c URL: https://github.com/llvm/llvm-project/commit/feb93d28b02c41ca6b069ec1f9e62fdfbb4c8b6c DIFF:

[clang] 653a82e - [clang] Add test for CWG191

2023-04-07 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-07T17:54:38+04:00 New Revision: 653a82e95257a7cd3f22c24e40d54459a6608429 URL: https://github.com/llvm/llvm-project/commit/653a82e95257a7cd3f22c24e40d54459a6608429 DIFF:

[clang] 154825b - [clang] Mark CWG562 as N/A

2023-04-07 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-07T18:33:56+04:00 New Revision: 154825bdf6fb5ec5b4cd7d53cf93d68b185ca55d URL: https://github.com/llvm/llvm-project/commit/154825bdf6fb5ec5b4cd7d53cf93d68b185ca55d DIFF:

[clang] 33e8431 - [clang] Add test for CWG255

2023-04-07 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-07T18:33:33+04:00 New Revision: 33e84315e7d674cf6327d23f035aa4a2f28ac8ee URL: https://github.com/llvm/llvm-project/commit/33e84315e7d674cf6327d23f035aa4a2f28ac8ee DIFF:

[clang] 4b03869 - [clang] Add test for CWG607

2023-04-07 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-07T18:40:35+04:00 New Revision: 4b03869402558d6aa24ce08766825eef34d6aff6 URL: https://github.com/llvm/llvm-project/commit/4b03869402558d6aa24ce08766825eef34d6aff6 DIFF:

[clang] 576c752 - [clang] Add test for CWG1894 and CWG2199

2023-04-14 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-04-14T10:15:21+03:00 New Revision: 576c752410e71229f271ec7defb22f3596338c00 URL: https://github.com/llvm/llvm-project/commit/576c752410e71229f271ec7defb22f3596338c00 DIFF:

[clang] d0e24f0 - [clang] Mark CWG2165 as N/A

2023-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-11T09:46:18+03:00 New Revision: d0e24f0c97ecf4f4e72604adcae5cd4c6b02cb48 URL: https://github.com/llvm/llvm-project/commit/d0e24f0c97ecf4f4e72604adcae5cd4c6b02cb48 DIFF:

[clang] 5eaaf8f - Revert "[clang] Mark CWG2165 as N/A"

2023-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-11T09:48:40+03:00 New Revision: 5eaaf8f18093740200ffed76b32884ad9cfec12e URL: https://github.com/llvm/llvm-project/commit/5eaaf8f18093740200ffed76b32884ad9cfec12e DIFF:

[clang] 89ba737 - [clang] Mark CWG2165 as N/A

2023-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-11T09:50:25+03:00 New Revision: 89ba737bcf3444a6afe2f4ed75ce957029380267 URL: https://github.com/llvm/llvm-project/commit/89ba737bcf3444a6afe2f4ed75ce957029380267 DIFF:

[clang] 5fc73b7 - [clang] Add test for CWG1111

2023-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-11T10:53:08+03:00 New Revision: 5fc73b7502fbbb46faa57a558c8661822b2b5215 URL: https://github.com/llvm/llvm-project/commit/5fc73b7502fbbb46faa57a558c8661822b2b5215 DIFF:

[clang] 22fb66e - [clang][NFC] Add another example to CWG952 test

2023-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-11T10:25:59+03:00 New Revision: 22fb66eb94b643c858c2beecbcfac438a7fa29ed URL: https://github.com/llvm/llvm-project/commit/22fb66eb94b643c858c2beecbcfac438a7fa29ed DIFF:

[clang] 51a07fc - [clang] Add test for CWG2396

2023-02-13 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-02-13T21:53:00+03:00 New Revision: 51a07fc24cb909011e0b16793800aab4b93031ed URL: https://github.com/llvm/llvm-project/commit/51a07fc24cb909011e0b16793800aab4b93031ed DIFF:

[clang] 1bbaabb - [clang] Add test for CWG1710 and related issues

2023-07-11 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-07-11T16:24:39+03:00 New Revision: 1bbaabb90dd72f78ea290b71dfe3bf2689ad7403 URL: https://github.com/llvm/llvm-project/commit/1bbaabb90dd72f78ea290b71dfe3bf2689ad7403 DIFF:

[clang] 9c561e8 - [clang] Add test for CWG1397

2023-05-30 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-30T12:09:02+03:00 New Revision: 9c561e8f3c2e8292bce9d7b36657144ba26a1c91 URL: https://github.com/llvm/llvm-project/commit/9c561e8f3c2e8292bce9d7b36657144ba26a1c91 DIFF:

[clang] 238f158 - [clang] Add test for CWG873

2023-05-31 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-31T10:17:27+03:00 New Revision: 238f15820e71080b0bbc7d6ee95303fdb430d6fa URL: https://github.com/llvm/llvm-project/commit/238f15820e71080b0bbc7d6ee95303fdb430d6fa DIFF:

[clang] 70688e8 - Revert "[clang] Add tests for CWG issues 977, 1482, 2516"

2023-05-23 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-23T15:29:14+03:00 New Revision: 70688e82e2fd6b486931669b981c18f3830385b5 URL: https://github.com/llvm/llvm-project/commit/70688e82e2fd6b486931669b981c18f3830385b5 DIFF:

[clang] 85452b5 - [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-23T12:50:42+03:00 New Revision: 85452b5f9b5aba5bdf0259b7f0d7400362f95535 URL: https://github.com/llvm/llvm-project/commit/85452b5f9b5aba5bdf0259b7f0d7400362f95535 DIFF:

[clang] 71bc3dd - [clang] Add test for CWG2213

2023-05-23 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-23T12:44:24+03:00 New Revision: 71bc3dd42e2939a25e4394dbebf6239e3e6403a9 URL: https://github.com/llvm/llvm-project/commit/71bc3dd42e2939a25e4394dbebf6239e3e6403a9 DIFF:

[clang] 1c5a749 - Reland "[clang] Add tests for CWG issues 977, 1482, 2516"

2023-05-23 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-23T21:04:23+03:00 New Revision: 1c5a749754a1c352a7efa0e8be26c1d4132fe9c7 URL: https://github.com/llvm/llvm-project/commit/1c5a749754a1c352a7efa0e8be26c1d4132fe9c7 DIFF:

[clang] 5b4fed6 - [clang][NFC] Update latest released Clang versions in make_cxx_dr_status

2023-05-28 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-28T15:58:52+03:00 New Revision: 5b4fed66efe245bb0cc246755a669ab3a17de9ed URL: https://github.com/llvm/llvm-project/commit/5b4fed66efe245bb0cc246755a669ab3a17de9ed DIFF:

[clang] 14f245d - [clang] Add test for CWG399

2023-05-20 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-20T11:17:44+03:00 New Revision: 14f245d01a1ee489a13e843e9c77cecf5c7183a9 URL: https://github.com/llvm/llvm-project/commit/14f245d01a1ee489a13e843e9c77cecf5c7183a9 DIFF:

[clang] abbb22c - [clang][NFC] Fix CWG399 test

2023-05-20 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-05-20T12:56:52+03:00 New Revision: abbb22cc0c9c33dedb8d53c2bd3e703f92baace7 URL: https://github.com/llvm/llvm-project/commit/abbb22cc0c9c33dedb8d53c2bd3e703f92baace7 DIFF:

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2024-01-19 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @frederick-vs-ja PR description is going to be used as a commit message. You can edit it. Let me know when it's ready. https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > I have reviewed the tests for libclang and it appears that there are already > tests for the rewriter, which are more extensive than the ones I wrote. > Therefore, I have decided to mirror the tests from libclang in the Python > binding. Please let me know if this approach is

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libc] [compiler-rt] [clang] [libcxx] [clang-tools-extra] [flang] [clang] Remove `CXXNewInitializationStyle::Implicit` (PR #78793)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/78793 >From f6a599d6e662121f19529f59ffa44cc6177c0835 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sat, 20 Jan 2024 00:58:06 +0300 Subject: [PATCH] [clang] Remove `CXXNewInitializationStyle::Implicit` This

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-24 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @linux4life798 Can you review the last update? https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. LGTM PR description is going to become a commit message after merging. Let me know when it's ready. https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list

[clang] [clang][Sema] Add checks for validity of default ctor's class (PR #78898)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I decided to not include tests, because our testing infrastructure is not ready to test that Clang doesn't crash without overspecifying the tests using `-verify` mode. https://github.com/llvm/llvm-project/pull/78898 ___ cfe-commits

[flang] [clang] [libc] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [mlir] [clang] Remove `CXXNewInitializationStyle::Implicit` (PR #78793)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/78793 >From f6a599d6e662121f19529f59ffa44cc6177c0835 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sat, 20 Jan 2024 00:58:06 +0300 Subject: [PATCH] [clang] Remove `CXXNewInitializationStyle::Implicit` This

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add checks for validity of default ctor's class (PR #78898)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/78898 Fixes #10518 Fixes #67914 Fixes #78388 Also addresses the second example in #49103 This patch is based on suggestion from @cor3ntin in https://github.com/llvm/llvm-project/issues/67914#issuecomment-1896011898

[clang-tools-extra] [llvm] [flang] [mlir] [clang] [compiler-rt] [libc] [libcxx] [clang] Remove `CXXNewInitializationStyle::Implicit` (PR #78793)

2024-01-21 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/78793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][IdentifierInfo] Use llvm::Bitfield for the bitfield (PR #79366)

2024-01-24 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I find `llvm::Bitfield` API with all its explicit setters with explicit storage parameter clunky compared to language bit-fields. But that's minor. My major issue with this patch is that `uint64_t Storage;` is as opaque for debuggers as it gets. It would take so much work to

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-04 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > gentle ping. Please check the mergeability of this PR. Friendly reminder of one ping per week policy. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
@@ -1,5 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -Wunused-variable -Wunused-label -Wno-c++1y-extensions -verify %s -// RUN: %clang_cc1 -fsyntax-only -Wunused-variable -Wunused-label -Wno-c++1y-extensions -verify -std=gnu++11 %s +// RUN: %clang_cc1 -fsyntax-only

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
@@ -1,5 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -Wunused-variable -Wunused-label -Wno-c++1y-extensions -verify %s -// RUN: %clang_cc1 -fsyntax-only -Wunused-variable -Wunused-label -Wno-c++1y-extensions -verify -std=gnu++11 %s +// RUN: %clang_cc1 -fsyntax-only

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
@@ -17242,6 +17242,23 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc, return true; } + if (TUK == TUK_Friend && Kind == TagTypeKind::Enum) { +// C++23 [dcl.type.elab]p4: +// If an elaborated-type-specifier appears with

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/80823 This patch covers CWG issues [201](https://cplusplus.github.io/CWG/issues/201.html), [210](https://cplusplus.github.io/CWG/issues/210.html), [292](https://cplusplus.github.io/CWG/issues/292.html).

[clang] [llvm] [clang-tools-extra] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -O0 -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu

[clang-tools-extra] [clang] [llvm] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -O0 -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu

[llvm] [clang] [clang-tools-extra] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -O0 -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu

[clang] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -disable-llvm-passes -O0 -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu

[clang] [Clang] Add some CodeGen tests for CWG 2xx issues (PR #80823)

2024-02-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/80823 >From 560713b5d45236956198654a10e0795eb56cad7b Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 6 Feb 2024 13:23:36 +0300 Subject: [PATCH 1/2] [Clang] Add some CodeGen tests for CWG 2xx issues This

<    1   2   3   4   5   6   7   8   9   10   >