[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657195 , @zequanwu wrote: > In D138846#4657194 , @alanphipps > wrote: > >> In D138846#4657193 , @zequanwu >> wrote: >> >>> In

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657194 , @alanphipps wrote: > In D138846#4657193 , @zequanwu > wrote: > >> In D138846#4657175 , @hans wrote: >> >>> We're seeing

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657175 , @hans wrote: > We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to > this commit. I think Zequan is investigating: > https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 It

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607 +// compiler has broken. +assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid"); +assert((!EndLoc || EndLoc->isValid()) && "End location is not valid");

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

zequanwu added a comment. Hi, compiling llvm-10 code with this change causing compilation errors: ../../third_party/swiftshader/third_party/llvm-10.0/llvm/include/llvm/ADT/Optional.h:289:8: error: cannot overload a member function with ref-qualifier '&&' with a member function without a

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4648313 , @ellis wrote: > I have seen that MachO sections remain in the header even if the size is zero > which seems to be the case here. You could use `llvm-objdump` to verify that > the section exists but the

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. I feel like either this feature not working well with mac or we should keep `__llvm_prf_names` section in the binary. Current idea is to completely get rid of `__llvm_prf_names` section in the binary. Even if I fixed the issue https://reviews.llvm.org/D157913#4648296,

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu marked an inline comment as done. zequanwu added a comment. For some unknown reasons, linker still generates __llvm_prf_names section in the final binary on mac even if the object file doesn't have this section. And I cannot use llvm-objdump to get anything from that section. $

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/lib/ProfileData/InstrProfCorrelator.cpp:42 +const char *InstrProfCorrelator::CovFunctionNameAttributeName = +"Cov Function Name"; phosek wrote: > I missed this

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4646718 , @thakis wrote: > Looks like this breaks check-clang on mac: > http://45.33.8.238/macm1/69297/step_7.txt > > Please take a look and revert for now if it takes a while to fix.

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32db121b29f7: [Coverage] Allow Clang coverage to be used with debug info correlation. (authored by zequanwu). Changed prior to commit:

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4646184 , @ellis wrote: > It looks like `debug-info-correlate-coverage.ll` was renamed twice. Is this > intended? I just moved `llvm/test/Instrumentation/InstrProfiling/debug-info-correlate-coverage.ll.` to

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 556809. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/ https://reviews.llvm.org/D157913 Files:

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 556805. zequanwu added a comment. Remove profile name section. Unused coverage function names are stored in debug info as a fake global variable info: 0x000b: DW_TAG_compile_unit ... 0x0071: DW_TAG_variable DW_AT_name

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4638569 , @phosek wrote: > In D157913#4626007 , @zequanwu > wrote: > >>> It seems that the `__llvm_prf_names` is retained in this mode. What is the >>> overhead of this

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added inline comments. Comment at: compiler-rt/test/profile/Darwin/coverage-debug-info-correlate.cpp:29 + +// RUN: llvm-cov report --instr-profile=%t.profdata %t | FileCheck %s -check-prefix=NONAME + ellis wrote: > Is it worth testing that

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 555889. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/ https://reviews.llvm.org/D157913 Files:

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. > It seems that the `__llvm_prf_names` is retained in this mode. What is the > overhead of this section generally? Can we instead use debug info to lookup > function names? With debug info correlation enabled, `__llvm_prf_names` section will only contain functions

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 554048. zequanwu added a comment. __llvm_prf_names section in the binary could be non-zero because non-instrumented function names are store there to indicate execution of 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf52f8e817ea3: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D157632?vs=550051=554035#toc Repository: rG LLVM

[PATCH] D126586: [InstrProf] Single byte counters in coverage

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4812 +} else + CGF.incrementProfileCounter(E); + } This can be hoist outside `if (llvm::EnableSingleByteCoverage)` Comment at:

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGd80992032fd0: Reland [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit:

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

zequanwu created this revision. zequanwu added reviewers: ellis, aeubanks. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Fixed the issue

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 551219. zequanwu added a comment. Update. Binary may still contains __llvm_prf_names sections for functions that are not emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu created this revision. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Debug info correlation is an option

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2cf195d5fb: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 550039. zequanwu marked 3 inline comments as done. zequanwu added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4581219 , @ellis wrote: > In D157632#4580576 , @zequanwu > wrote: > >> BTW, I noticed something strange with `-pgo-function-entry-coverage` when >> merging via

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. BTW, I noticed something strange with `-pgo-function-entry-coverage` when merging via llvm-profdata. In this file `compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c`, I ran the following: // RUN: %clang_pgogen -o %t.cov.normal -mllvm

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4578582 , @ellis wrote: > I've just published https://reviews.llvm.org/D157664, so you'll want to > rebase ontop of it if it lands soon. I would also like to see some more tests > added to `instrprof-merge-error.c`

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:129 + // enabled. + if (Header->DataSize == 0) { +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { ellis wrote: > Since we don't have the data

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 549424. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 549077. zequanwu added a comment. Remove debug includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu created this revision. zequanwu added reviewers: ellis, MaskRay, davidxl. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. When

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu added a comment. In D152472#4425713 , @thakis wrote: > This is still breaking check-clang on windows: > http://45.33.8.238/win/79908/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Sorry, I thought I applied

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu added a comment. In D152472#4423160 , @thakis wrote: > Also on http://45.33.8.238/win/79874/step_7.txt > > Reverted in 9c560350dd57d0dcb849c5915fa7c50b139ce671 > for now.

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d54213ee557: [Clang][MS] Remove assertion on BaseOffset cant be smaller than Size. (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu updated this revision to Diff 531438. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://reviews.llvm.org/D152472 Files:

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu updated this revision to Diff 529757. zequanwu added a comment. Herald added subscribers: ChuanqiXu, mgrang. Extend the output and reading of -fdump-record-layouts-simple. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu created this revision. zequanwu added a reviewer: rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This assertion triggered when we have two base classes sharing the same offset and the

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

zequanwu added a comment. In D150817#4356305 , @TWeaver wrote: > Hello and good afternoon from the UK, > > I believe this patch has caused failures on the following buildbot: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21493 > > are you able

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75993812d5c1: Use windows baskslash on anonymous tag locations if using MSVCFormatting and… (authored by zequanwu). Changed prior to commit:

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a nondeterminism on debug info when building on windows natively vs cross

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8f622c79b2: [DebugInfo] Fix file path separator when targeting windows. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > zequanwu wrote: > > hans

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 514287. zequanwu marked an inline comment as done. zequanwu added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files:

[PATCH] D148529: [clang] Replace find_executable with shutil.which in creduce script

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148529/new/ https://reviews.llvm.org/D148529

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > zequanwu wrote: > > hans

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > Won't the code above (line

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513611. zequanwu added a comment. Added clang-cl option test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513252. zequanwu added a comment. Herald added a subscriber: MaskRay. - Move remove_dots to clang driver. - Revert changes to llc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0529da5b948c: [Coverage] Handle invalid end location of an expression/statement. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D147073?vs=512971=513236#toc Repository: rG

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512971. zequanwu edited the summary of this revision. zequanwu added a comment. - Filed an github issue: - Added release note. - Updated commit message and summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4261949 , @hans wrote: >> Well, MSVC cl removes redundant dots so we shouldn't remove >> llvm::sys::path::remove_dots. > > Could we do the `remove_dots` on the Clang side, where we can decide based on > the

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512868. zequanwu added a comment. Add assertion on source locations in `pushRegion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258981 , @aaron.ballman wrote: > In D147073#4258664 , @zequanwu > wrote: > >> In D147073#4258529 , >> @aaron.ballman wrote: >>

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4258419 , @zequanwu wrote: > In D147256#4257797 , @hans wrote: > >> In D147256#4249527 , @zequanwu >> wrote: >> >>> - Add a

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258529 , @aaron.ballman wrote: > In D147073#4258426 , @zequanwu > wrote: > >> In D147073#4258396 , >> @aaron.ballman wrote: >>

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258396 , @aaron.ballman wrote: > In D147073#4258384 , @hans wrote: > >> Again not an expert here, but lgtm. >> >> (Nit: the >>

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4257797 , @hans wrote: > In D147256#4249527 , @zequanwu > wrote: > >> - Add a `-use-target-path-separator` flag for llc. >> - Add test for llc with that flag. > > But where

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 511496. zequanwu added a comment. - Add a `-use-target-path-separator` flag for llc. - Add test for llc with that flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu added a comment. Added the missing release note at rG5bab9097ce5b093289e8d40809d02f002febe910 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93bd417445: [Coverage] Fix crash when visiting PseudoObjectExpr. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 58. zequanwu added a comment. Herald added a subscriber: ormris. - Pass `LangOptions.UseTargetPathSeparator` down to TargetOptions to use host path separator when it's set. - Add a test case. The problem is when if we are targeting to linux, clang

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 510938. zequanwu added a comment. Split to another patch: D147569 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu updated this revision to Diff 510918. zequanwu added a comment. Add the crash repro as test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/ https://reviews.llvm.org/D147569 Files:

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, gulfem, hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a split of D147073 .

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 510514. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu marked an inline comment as done. zequanwu added a comment. In D147073#4240017 , @hans wrote: > I'm not familiar with this code. I suppose the question is whether it's > reasonable for this code to expect that the source locations are always

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4236522 , @hans wrote: > Thanks for working on this! > > The `-ffile-reproducible` flag name refers to making `#file` directives > reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader > :) I

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 510057. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 509802. zequanwu added a comment. Add test case from https://github.com/llvm/llvm-project/issues/45481#issuecomment-981028897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine ) { +buf[task].first = moduleName.str(); return std::make_unique( int3 wrote: > Any reason why this doesn't instead store the module name in the

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu created this revision. zequanwu added reviewers: hans, aaron.ballman, ayzhao, aganea. Herald added a subscriber: hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. I'm trying to add the test case from: https://github.com/llvm/llvm-project/issues/45481#issuecomment-981028897, but lit test fails in `` not found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 509098. zequanwu added a comment. - Handle invalid start location. - Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu created this revision. zequanwu added reviewers: hans, shafik, rsmith, MaggieYi, gulfem. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/45481

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu added a comment. In D146164#4200414 , @rsmith wrote: > FYI: this attribute appears to not work on (at least) x86 and arm currently, > because the backend also does some merging: https://godbolt.org/z/d43M83oax Thanks for reporting it. I'll

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:44 + + [[clang::nomerge]] __builtin_trap(); } hans wrote: > Maybe do __debugbreak() too since that's also mentioned on the debug. The `__debugbreak()` is also emitted from

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu updated this revision to Diff 505837. zequanwu marked 3 inline comments as done. zequanwu added a comment. - Add test case for __debugbreak(). - Handle named trap instructions and add test case for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu created this revision. zequanwu added reviewers: hans, craig.topper. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. 1. It fixes

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 ___ cfe-commits mailing list

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

zequanwu added a comment. Thanks for fixing it. Just one comment. Comment at: clang/test/CoverageMapping/terminate-statements.cpp:335 + ( true ? void (0) : abort() ); // CHECK: Gap,File 0, [[@LINE]]:33 -> [[@LINE+1]]:3 = #1 + ( false ? void (0) : abort() ); // CHECK:

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

zequanwu added a comment. Landed at: https://reviews.llvm.org/rGbb5bcddcdbc151119f449be2d1e0d90f2e9c4258. Forgot to add the "Revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138326/new/ https://reviews.llvm.org/D138326

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3945136 , @glandium wrote: > Still broken: > > task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ > --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3944952 , @glandium wrote: > This broke the gold plugin: > > [task 2022-11-22T21:03:29.486Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: > error: no matching function for call to

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Relanded here to match api changes at https://reviews.llvm.org/D135590 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG531ed6d5aa65: [LTO][COFF] Use bitcode file names in lto native object file names. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D137217?vs=477014=477246#toc Repository:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 477014. zequanwu added a comment. Update `Twine` argument to `const Twine&`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

zequanwu added a comment. In D138326#3938128 , @rnk wrote: > Since Clang creates the member list and only adds types for the benefit of > codeview, should we change clang instead? Yes, that's something clang does only for codeview, changed in clang

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

zequanwu updated this revision to Diff 476621. zequanwu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reverted previous change and change clang side so that it doesn't emit nested anonymous record type when emitting code-view. Repository: rG LLVM

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); tejohnson wrote: > MaskRay wrote: > > What if

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475895. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29c92879171d: [AST] Fix class layout when using external layout under MS ABI. (authored by zequanwu). Changed prior to commit:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475538. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return std::make_unique(std::move(OS), tejohnson wrote: > I think you might need

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475296. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/override-layout-virtual-base.cpp:25-43 +// CHECK: *** Dumping AST Record Layout +// CHECK-NEXT: 0 | struct S2 +// CHECK-NEXT: 0 | (S2 vftable pointer) +// CHECK-NEXT: 8 | (S2

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

zequanwu created this revision. zequanwu added a reviewer: rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137806 Files:

  1   2   3   4   5   >