[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

AlexeySachkov added a comment. Looks like the issue is fixed in https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e247756c4d51733616bb2f356 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

AlexeySachkov added inline comments. Comment at: clang/include/clang/AST/Type.h:1827-1830 +if (Dependent) + Deps |= TypeDependence::Dependent | TypeDependence::Instantiation; +if (InstantiationDependent) + Deps |= TypeDependence::Instantiation;

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

AlexeySachkov added inline comments. Comment at: clang/include/clang/AST/Type.h:1827-1830 +if (Dependent) + Deps |= TypeDependence::Dependent | TypeDependence::Instantiation; +if (InstantiationDependent) + Deps |= TypeDependence::Instantiation;

[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

AlexeySachkov updated this revision to Diff 174919. AlexeySachkov retitled this revision from "[OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl" to "[OpenCL] Launch opencl-types.cl test only on x86". AlexeySachkov edited the summary of this revision. AlexeySachkov added a

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov added a comment. I'm running OpenCL on an x886 and everything is fine, but there are a lot of build bots which build different targets on different architectures. Since there are no `target` option specified, `c-index-test` uses native target. I just realized: may be it is better

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov added a comment. If I understand correctly, not all extensions are available on non-x86 targets and some declarations are marked as `(invalid)` - that is the only difference I saw Repository: rC Clang https://reviews.llvm.org/D54253

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, asavonic. Herald added subscribers: arphaman, yaxunl. The problem here is that test only checks default target. I recently introduced regression which wasn't detected by local testing: I missed that some declarations

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 173130. AlexeySachkov changed the repository for this revision from rL LLVM to rC Clang. AlexeySachkov removed a subscriber: llvm-commits. AlexeySachkov added a comment. Fixed issue in `test/Index/opencl-types.cl` Repository: rC Clang

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 172946. AlexeySachkov added a comment. Rebased to ToT. https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/OpenCLExtensionTypes.def

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 172917. AlexeySachkov added a comment. Updated opencl-c.h header: fixed typos in built-in declarations. Applied comment from Alexey https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h

[PATCH] D54152: [OpenCL] Fix diagnostic message about overload candidates

AlexeySachkov created this revision. AlexeySachkov added reviewers: asavonic, Anastasia. Herald added a subscriber: yaxunl. I wonder if there are some extension which need to be disabled to get overloadable candidate available. Repository: rC Clang https://reviews.llvm.org/D54152 Files:

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:43 g(0); // expected-error {{no matching function for call to 'g'}} -// expected-note@-26 {{candidate unavailable as it requires OpenCL extension 'my_ext' to be disabled}} -//

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov marked 2 inline comments as done. AlexeySachkov added inline comments. Comment at: lib/Headers/opencl-c.h:16197 +#ifdef cl_intel_device_side_avc_motion_estimation +#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable +

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 170657. AlexeySachkov added a comment. Applied comments. Rebased to ToT https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/OpenCLExtensionTypes.def

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov updated this revision to Diff 170630. AlexeySachkov added a comment. Rebase to the ToT https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def include/clang/Sema/Initialization.h lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov updated this revision to Diff 170601. AlexeySachkov added a comment. Updated tests https://reviews.llvm.org/D53200 Files: lib/Serialization/ASTWriter.cpp test/SemaOpenCL/extension-begin.cl test/SemaOpenCL/extension-begin.h Index: test/SemaOpenCL/extension-begin.h

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov added inline comments. Comment at: test/Headers/opencl-pragma-extension-begin.cl:1 +// RUN: rm -rf %t +// RUN: mkdir -p %t Anastasia wrote: > I think the tests in this folder are for standard includes only but you are > testing custom include file

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov added a comment. @yaxunl could you please review this patch? It fixes a bug in a feature implemented by you in: commit c6fb598a301143e9d21156a012cc6ef669ff0188 Author: Yaxun Liu

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov updated this revision to Diff 169978. AlexeySachkov added a comment. Removed unnecessary empty line from test https://reviews.llvm.org/D53200 Files: lib/Serialization/ASTWriter.cpp test/Headers/opencl-pragma-extension-begin.cl test/Headers/opencl-pragma-extension-begin.h

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov updated this revision to Diff 169851. AlexeySachkov added a comment. Added test https://reviews.llvm.org/D53200 Files: lib/Serialization/ASTWriter.cpp test/Headers/opencl-pragma-extension-begin.cl test/Headers/opencl-pragma-extension-begin.h Index:

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. I recently discovered that adding the following code into `opencl-c.h` causes failure of `test/Headers/opencl-c-header.cl`: #pragma OPENCL EXTENSION cl_my_ext : begin void cl_my_ext_foobarbaz(); #pragma

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov added inline comments. Comment at: test/SemaOpenCL/intel-subgroup-avc-ext-types.cl:26 + char4 c4, event_t e, struct st ss) { + intel_sub_group_avc_mce_payload_t payload_mce = 0; // No zero initializer for mce types + // expected-error@-1 {{initializing

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 169368. AlexeySachkov marked an inline comment as done. AlexeySachkov added a comment. Updated tests. Reverted usage of `#pragma OPENCL EXTENSION my_ext : begin` due to a failed LIT tests: `test/Headers/opencl-c-header.cl` Test failed on the following

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov marked an inline comment as done. AlexeySachkov added inline comments. Comment at: lib/Sema/SemaInit.cpp:5291 - Sequence.AddOCLZeroQueueStep(DestType); - return true; +Sequence.AddOCLZeroQueueStep(DestType); +return true; Anastasia

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov updated this revision to Diff 168947. AlexeySachkov added a comment. Applied comments from Anastasia. Updated patch with more code unified https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def include/clang/Sema/Initialization.h lib/AST/Expr.cpp

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov marked 7 inline comments as done. AlexeySachkov added inline comments. Comment at: test/SemaOpenCL/intel-subgroup-avc-ext-types.cl:13 + +#define CLK_AVC_IME_PAYLOAD_INITIALIZE_INTEL { 0 } +#define CLK_AVC_REF_PAYLOAD_INITIALIZE_INTEL { 0 }

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 168115. AlexeySachkov added a comment. Herald added a subscriber: arphaman. Applied comments from Anastasia. Updated headers to conform with the latest spec https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov added a comment. This is an initial version. I guess there are some other enums related to CK_ZeroToOCL* which also can be merged. Also, I'm not sure that `CK_ZeroToOCLOpaqueType` is a good name. Thoughts? Repository: rC Clang https://reviews.llvm.org/D52654

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Repository: rC Clang https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 166423. AlexeySachkov added a comment. Updated patch with new functionality and tests https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/OperationKinds.def include/clang/AST/Type.h

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27 + +INTEL_SGAVC_TYPE(mce_payload_t, McePayload) +INTEL_SGAVC_TYPE(ime_payload_t, ImePayload) Anastasia wrote: > AlexeySotkin wrote: > > Anastasia wrote: > > >

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:1 +//===-- OpenCLExtensionTypes.def - Metadata about BuiltinTypes --*- C++ -*-===// +// Anastasia wrote: > I am confused about the purpose of this file. Is it

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Documentation can be found at https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_device_side_avc_motion_estimation.txt Patch by Kristina Bessonova Repository: rC Clang

[PATCH] D51302: [OpenCL] Relax diagnostics on OpenCL access qualifiers

AlexeySachkov updated this revision to Diff 163086. AlexeySachkov added a comment. Applied comment from Anastasia https://reviews.llvm.org/D51302 Files: lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/access-qualifier.cl Index: lib/Sema/SemaType.cpp

[PATCH] D51302: [OpenCL] Relax diagnostics on OpenCL access qualifiers

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Emit warning for multiple access qualifiers if they do not conflict. Patch by Alexey Bader Repository: rC Clang https://reviews.llvm.org/D51302 Files: lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaType.cpp