This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb9dae2fa22d3: [Clang][SVE2.1] Add builtins for svrevd
(authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
CarolineConcatto updated this revision to Diff 557788.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151709/new/
https://reviews.llvm.org/D151709
Files:
clang/include/clang/Basic/arm_sve.td
clang/test/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG200a92520c25: [Clang][SVE2.1] Add builtins and intrinsics
for SVBFMLSLB/T (authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHA
CarolineConcatto updated this revision to Diff 557785.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151461/new/
https://reviews.llvm.org/D151461
Files:
clang/include/clang/Basic/arm_sve.td
clang/inclu
CarolineConcatto updated this revision to Diff 557784.
CarolineConcatto added a comment.
- Rebase and
- change test names to use _lane instead of _idx
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151461/new/
https://reviews.llvm.org/D151461
Files
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f93a99a096c: [Clang][SVE2.1] Add builtins for 2-way svdot
(vectors, indexed) (authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CarolineConcatto updated this revision to Diff 557782.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151439/new/
https://reviews.llvm.org/D151439
Files:
clang/include/clang/Basic/arm_sve.td
clang/test/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ed0dfe6adfe: [Clang][SVE2.1] Add svwhile
(predicate-as-counter) builtins (authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHA
This revision was automatically updated to reflect the committed changes.
Closed by commit rGba47bc7fd412: [Clang][SVE2.1] Add pfalse builtin (authored
by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151199/new/
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b93e15bcd9a: [Clang][SVE2p1] Add svpsel builtins (authored
by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.
CarolineConcatto updated this revision to Diff 557758.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151199/new/
https://reviews.llvm.org/D151199
Files:
clang/include/clang/Basic/arm_sve.td
clang/lib/C
CarolineConcatto updated this revision to Diff 557756.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.llvm.org/D151197
Files:
clang/include/clang/Basic/arm_sve.td
clang/lib/C
CarolineConcatto updated this revision to Diff 557754.
CarolineConcatto added a comment.
-rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151461/new/
https://reviews.llvm.org/D151461
Files:
clang/include/clang/Basic/arm_sve.td
clang/inclu
CarolineConcatto updated this revision to Diff 557751.
CarolineConcatto added a comment.
Herald added a subscriber: sunshaoce.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151439/new/
https://reviews.llvm.org/D151439
Files:
clang/include
CarolineConcatto updated this revision to Diff 557747.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151307/new/
https://reviews.llvm.org/D151307
Files:
clang/include/clang/Basic/arm_sve.td
clang/test/
CarolineConcatto updated this revision to Diff 557746.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151199/new/
https://reviews.llvm.org/D151199
Files:
clang/include/clang/Basic/arm_sve.td
clang/lib/C
CarolineConcatto updated this revision to Diff 557739.
CarolineConcatto added a comment.
-Remove immediate+base from psel and rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.llvm.org/D151197
Files:
clang/include/
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7cad5a9eb48e: [Clang][SVE2.1] Add svpext builtins (authored
by CarolineConcatto).
Changed prior to commit:
https://reviews.llvm.org/D151081?vs=557730&id=557737#toc
Repository:
rG LLVM Github Monorepo
CarolineConcatto updated this revision to Diff 557730.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151081/new/
https://reviews.llvm.org/D151081
Files:
clang/include/clang/Basic/arm_sve.td
clang/inclu
This revision was automatically updated to reflect the committed changes.
Closed by commit rG81d8fa5a1d01: [Clang][SVE2.1] Add svcntp prototype (authored
by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150961/new/
https://reviews
CarolineConcatto updated this revision to Diff 557728.
CarolineConcatto added a comment.
Herald added a subscriber: wangpc.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151081/new/
https://reviews.llvm.org/D151081
Files:
clang/include/c
CarolineConcatto updated this revision to Diff 557724.
CarolineConcatto added a comment.
-remove wrong tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150961/new/
https://reviews.llvm.org/D150961
Files:
clang/include/clang/Basic/arm_sve.td
CarolineConcatto added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:2129
+def SVWHILEGE_COUNT : SInst<"svwhilege_{d}", "}lli", "QcQsQiQl", MergeNone,
"aarch64_sve_whilege_{d}", [IsOverloadNone], [ImmCheck<2, ImmCheck2_4_Mul2>]>;
+def SVWHILEGT_COUNT : S
CarolineConcatto added inline comments.
Herald added a subscriber: wangpc.
Comment at: clang/include/clang/Basic/arm_sve.td:2123
+
+def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone,
"", [], [ImmCheck<3, ImmCheck0_15>]>;
+def SVPSEL_COUNT_ALIAS_H : SIn
This revision was automatically updated to reflect the committed changes.
CarolineConcatto marked an inline comment as done.
Closed by commit rGfc8acb563ae0: [Clang][SVE2.1] Add clang support for builtins
using svcount_t (authored by CarolineConcatto).
Changed prior to commit:
https://reviews.
CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:56
// P: boolean
+// Qa: svcount
// U: unsigned
hassnaa-arm wrote:
> sdesmalen wrote:
> > The typespec modifier in this f
CarolineConcatto updated this revision to Diff 527021.
CarolineConcatto added a comment.
- Remove Qa from arm_sve.td and its dependencies
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150953/new/
https://reviews.llvm.org/D150953
Files:
clang/inc
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p
CarolineConcatto created this revision.
Herald added subscribers: hiraditya, kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
As described in: https://g
CarolineConcatto created this revision.
Herald added subscribers: arphaman, kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-softw
CarolineConcatto updated this revision to Diff 525508.
CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added a comment.
Add doxygen comments to FormSVEBuiltinResult function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151081/ne
CarolineConcatto updated this revision to Diff 525146.
CarolineConcatto marked an inline comment as done.
CarolineConcatto edited the summary of this revision.
CarolineConcatto added a comment.
-Address review's comments about Q target type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p
This revision was automatically updated to reflect the committed changes.
Closed by commit rGba1f31fb066a: [CLANG][AArch64][SVE2.1] Add
UCLAMP/SCLAMP/FCLAMP function prototypes (authored by CarolineConcatto).
Changed prior to commit:
https://reviews.llvm.org/D150863?vs=523343&id=523793#toc
Rep
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Patch by : David Sherwood
Repository:
rG LLVM Gith
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
In this patch it is used for the prototype:
- svptrue_
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Submitting this patch in the name of:
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
This revision is now accepted and ready to land.
Thank you Matt. It LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145505/new/
https://reviews.llvm.org/D145505
___
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5bb8ead4e9dc: [AArch64][NFC] Rename AEK_SMEF64 and
AEK_SMEI64 feature flags (authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CarolineConcatto created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Update clang feature flag names for:
AEK_SMEF6 to AEK_SMEF64F64
CarolineConcatto marked an inline comment as done.
CarolineConcatto added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll:127
; CHECK-NEXT:ptrue p0.d
-; CHECK-NEXT:st1d { z16.d }, p0, [sp]
-; CHECK-NEXT:st1d { z17.d }, p0, [sp,
CarolineConcatto added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll:22
+; CHECK-NEXT:mov z4.d, z8.d
+; CHECK-NEXT:bl llvm.aarch64.vector.insert.nxv8f64.nx2f64
+; CHECK-NEXT:mov w0, #2
sdesmalen wrote:
> There
CarolineConcatto added a comment.
> Are you intending to AutoUpgrade the existing intrinsics in IR?
@RKSimon
AFAIK we want to remove them altogether.
It is not expected that external projects depend on these intrinsics.
It is a legacy intrinsic that was introduced before we had vector.extract
CarolineConcatto added a comment.
Just passing by, but I was wondering when I saw this patch.
Why you did not remove this also from lib/Driver/ToolChains/Arch/AArch64.cpp?
And the ones in llvm (AArch64.td, AArch64InstrInfo.td)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2186b011e966: [Driver][AArch64]Add driver support for
neoverse-512tvb target (authored by CarolineConcatto).
Changed prior to commit:
https://revi
CarolineConcatto marked an inline comment as done.
CarolineConcatto added a comment.
Thank you for your review @dmgreen and @tschuett.
I rebase the patch, now VScaleForTuning is being set.
And I removed support for neoverse-512tvb from Arm 32 bits.
@paulwalker-arm pointed me that neoverse-512t
CarolineConcatto updated this revision to Diff 382273.
CarolineConcatto added a comment.
- Rebase and remove support on for ARM 32 bits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112406/new/
https://reviews.llvm.org/D112406
Files:
clang/test/
CarolineConcatto updated this revision to Diff 382004.
CarolineConcatto added a comment.
- remove neoverse-512tvb from Host.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112406/new/
https://reviews.llvm.org/D112406
Files:
clang/test/Driver/a
CarolineConcatto created this revision.
Herald added subscribers: dexonsmith, hiraditya, kristof.beyls.
CarolineConcatto requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
The support for neoverse-512tvb mirrors the same opt
CarolineConcatto added a comment.
Hi @ bsmith,
Thank you for adding me as a reviewer, although I don't think I am the more
qualified to approve or not this patch.
But I have a question:
Why is this patch only changing int_aarch64_neon_frintn and not
int_aarch64_sve_frintn?
Is there a particula
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
Thank you @awarzynski for implementing fsyntax-only.
It is another feature that the new driver provides, it is nice to see thing
falling into place.
The patch looks good to me!
Comment at: flang/includ
CarolineConcatto added inline comments.
Comment at: flang/lib/Frontend/FrontendActions.cpp:87
+ defaultKinds, features, ci.allCookedSources()};
+ semanticsContext.set_moduleDirectory("."s);
+ Fortran::semantics::Semantics semantics{
Just a quick question:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for
TypeSize comparison in clang (authored by CarolineConcatto).
Repository:
rG LLVM Githu
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG145e44bb1885: [SVE]Fix implicit TypeSize casts in
EmitCheckValue (authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
CarolineConcatto updated this revision to Diff 297884.
CarolineConcatto added a comment.
-Use getFixedSize instead of isKnowXY
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89312/new/
https://reviews.llvm.org/D89312
Files:
clang/lib/CodeGen/CGBu
CarolineConcatto created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
CarolineConcatto requested review of this revision.
Using getFixedSize() with:
V->getType()->getPrimitiveSizeInBits()
like this:
V->getType()->getPrimitiveSizeInBits().getFixedSize()
m
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, psnobl, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: clang.
CarolineConcatto requested review of this revision.
The patch replaces comparison greater/lower or equal than by
TypeSize::isKnownXY, w
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
This revision is now accepted and ready to land.
Thank you @awarzynski for working on this.
It is good because now we do not depend on clang frontend to build flang
frontend.
LGTM
Repository:
rG LLVM Github Monorepo
C
CarolineConcatto marked 7 inline comments as done.
CarolineConcatto added a comment.
@awarzynski patch updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
__
CarolineConcatto updated this revision to Diff 296066.
CarolineConcatto edited the summary of this revision.
CarolineConcatto added a comment.
address reviews comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org
CarolineConcatto added a comment.
Hi Folks,
@awarzynski and @kiranchandramohan, Diana was working in an out-of-tree build.
This is the patch:
https://reviews.llvm.org/D87085
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87774/new/
https://reviews.
CarolineConcatto added a comment.
Thank you @awarzynski for updating the patch.
It looks good to me. I've build it locally and played a little bit.
It works fine with gcc9.3. I did not try to build out-of-tree. But I don't see
any reason it should not work.
I have two minor comments. But besides
CarolineConcatto updated this revision to Diff 294612.
CarolineConcatto added a comment.
Remove -E from FlangOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88381/new/
https://reviews.llvm.org/D88381
Files:
clang/include/clang/Driver/Optio
CarolineConcatto updated this revision to Diff 294558.
CarolineConcatto added a comment.
Fix typos
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88381/new/
https://reviews.llvm.org/D88381
Files:
clang/include/clang/Driver/Options.td
flang/incl
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, dang, mgorny.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added a project: clang.
CarolineConcatto requested review of this revision.
This patch runs Preprocess and PrintProcess actio
CarolineConcatto updated this revision to Diff 294356.
CarolineConcatto added a comment.
Rebase on top of master
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
Files:
clang/include/clang/Driver/Options.t
CarolineConcatto marked 23 inline comments as done.
CarolineConcatto added a comment.
@awarzynski thank you for the review.
It is a big patch to review at once.
I accepted almost all of your changes.
Comment at: flang/test/Flang-Driver/emit-obj.f90:2
! RUN: not %flang-new %s
CarolineConcatto updated this revision to Diff 294288.
CarolineConcatto added a comment.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
Solve review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
CarolineConcatto added a comment.
Thank you @awarzynski for this patch.
Very good that you added color feature for Fortran.
It is just a shame that we do not test. Is there a way to add a regression test
for it?
I don't see any inconsistency with what we have on clang side, so it is good.
My com
CarolineConcatto updated this revision to Diff 293024.
CarolineConcatto added a comment.
- remove changes from cmakefiles
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
Files:
clang/include/clang/Driver/
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, dang, mgorny.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added a project: clang.
CarolineConcatto requested review of this revision.
The sole purpose of this action is to read a file
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG257b29715bb2: [flang][driver] Add the new flang compiler and
frontend drivers (authored by CarolineConcatto).
Changed prior to commit:
https://rev
CarolineConcatto marked 17 inline comments as done.
CarolineConcatto added a comment.
Hey Folks,
Fist of all, thank you very much for your review.
I have answered some questions and update some of the requests.
There are some that I did not had time to go inside yet.
I have the week of 24th off.
CarolineConcatto updated this revision to Diff 287270.
CarolineConcatto added a comment.
Address review comments
Replace namespace flang for Fortran::frontend
and fix style
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86089/new/
https://reviews.
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG33c554d8444a: [clang][driver]Add quotation mark in
test/fortran.f95 to avoid false positive (authored by CarolineConcatto).
Repository:
rG LLVM G
CarolineConcatto updated this revision to Diff 286257.
CarolineConcatto added a comment.
Missing a -
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86132/new/
https://reviews.llvm.org/D86132
Files:
clang/test/Driver/fortran.f95
Index: clang/tes
CarolineConcatto created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
CarolineConcatto requested review of this revision.
If a folder's name, where the test fortran.f95 is running, has cc1 the test
fails because of CHECK-ASM-NOT: cc1.
The solution used in
CarolineConcatto created this revision.
Herald added subscribers: llvm-commits, cfe-commits, dang, usaxena95, kadircet,
hiraditya, mgorny.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added projects: clang, LLVM.
CarolineConcatto requested review of this revision
CarolineConcatto added a comment.
I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
CarolineConcatto abandoned this revision.
CarolineConcatto added a comment.
I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.
Repository:
rG LLVM Github Monorepo
CHANGES
CarolineConcatto updated this revision to Diff 261806.
CarolineConcatto marked 7 inline comments as done.
CarolineConcatto added a comment.
Rename the flag and fix reviews comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73951/new/
https://re
CarolineConcatto added inline comments.
Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10
+! RUN: cp %clang %t1
+! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 |
FileCheck --check-prefixes=ALL %s
+
awarzynski wrote
CarolineConcatto updated this revision to Diff 261451.
CarolineConcatto marked 3 inline comments as done.
CarolineConcatto added a comment.
This patch updates the flag name from ffc-fortran-name to cfc-fortran-name,
where cfc stands for custom frontend compiler.
Moreover, the tests need pruning t
CarolineConcatto abandoned this revision.
CarolineConcatto added a comment.
This patch has landed here by mistake.
This is should be an update on:
https://reviews.llvm.org/D73951
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79170/new/
https://r
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added a project: clang.
Signed-off-by: Caroline Concatto
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/
CarolineConcatto added a comment.
@awarzynski If we don't foresee a use for this flag beside the problem I've
faced, then I am fine to remove and only replace by flang-tmp.
But as we discuss this flag enables flang driver to call another driver,
basically cross-compilation.
That could be a usef
CarolineConcatto marked an inline comment as done.
CarolineConcatto added inline comments.
Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10
+! RUN: cp %clang %t1
+! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 |
FileCheck --check-
CarolineConcatto updated this revision to Diff 244635.
CarolineConcatto added a comment.
- [Clang]Rename flag and update the tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73951/new/
https://reviews.llvm.org/D73951
Files:
clang/include/clan
CarolineConcatto added a comment.
@richard.barton.arm A new patch will land today with the changes asked by you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73951/new/
https://reviews.llvm.org/D73951
__
CarolineConcatto marked 5 inline comments as done.
CarolineConcatto added inline comments.
Comment at: clang/include/clang/Driver/Options.td:264
MetaVarName<"">;
+def fcc_fortran_name : Separate<["-"], "ffc-fortran-name">, InternalDriverOpt,
+ HelpText<"Name for native Fortra
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
This patch adds more logic to Flang.cpp to search for the
flang frontend.
A new flag(ffc-fortran-name) was created in this patch to
implement the logic in Flang driver.
Th
94 matches
Mail list logo
