[PATCH] D117929: [XRay] Add support for RISCV

dberris added a comment. In D117929#3317813 , @ashwin98 wrote: > In D117929#3314355 , @ashwin98 > wrote: > >> On including RISCV64 to the check, I see new issues while reading the >> instrumentation map. How do

[PATCH] D117929: [XRay] Add support for RISCV

dberris added a comment. In D117929#3276843 , @ashwin98 wrote: > Fixed another lint issue, they should all be done for now hopefully. > > @dberris Sorry, I'm a little confused, do you mean I need to update some of > the clang tests for XRay instrumentati

[PATCH] D117929: [XRay] Add support for RISCV

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. It looks like you'll need to address the lint issues (using clang-format). I'm not an expert on RISCV assembly so you might need to get someone familiar with the ISA reviewing this

[PATCH] D113638: [xray] Add support for hexagon architecture

dberris added a comment. Whoops -- sorry, I had forgotten to change my email settings and missed this. Thanks for the patch, it's exciting to see XRay being supported in the Hexagon architecture! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11363

[PATCH] D89441: [xray] Honor xray-never function-instrument attribute

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM -- thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89441/new/ https://reviews.llvm.org/D89441

[PATCH] D89441: RFC: Potential fixes to function-instrument=xray-never

dberris added a comment. > Do you think we should fix this by handling the xray-never attribute in > XRayInstrumentation, or having CodeGenFunction remove the threshold if > xray-never is set? Good catch, thanks! I think we should go with the former (handling the case in XRayInstrumentation)

[PATCH] D87953: [xray] Function coverage groups

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Okay, I think I understand the motivation a little bit more now (i.e. sampling seems to be a useful thing to do anyway, regardless of whether we have the other facilities). Repository: r

[PATCH] D87953: [xray] Function coverage groups

dberris added a comment. There's two tensions I'm trying to resolve in my mind with this patch: - Is there a way to make this more deterministic, instead of using a random sampling mechanism based on the name? - This looks like it's a subset of a more general facility to group functions by "mod

[PATCH] D87953: [xray] Function coverage groups

dberris added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817 +CurFn->getName().bytes_end()); + auto Group = crc32(FuncName) % FuncGroups; + if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup && ---

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM from me if XRay actually does work on non-x86_64 macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85773/new/ https://reviews.llvm.org

[PATCH] D81995: [xray] Option to omit the function index

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81995/new/ https://reviews.llvm.org/D81995

[PATCH] D77191: [clang][xray] Add xray attributes to functions without decls too

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77191/new/ https://reviews.llvm.org/D77191 _

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Do you mind adding x86 tests too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72890/new/ https://reviews.llvm.org/D72890 __

[PATCH] D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ributzka. LGTM -- apologies for the delay, I hope this isn't too late. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___ cfe

[PATCH] D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD

dberris added inline comments. Comment at: lib/xray/xray_defs.h:22 +#if !SANITIZER_NETBSD +#define XRAY_TLS_ALIGNAS(x) alignas(x) krytarowski wrote: > I would switch the order, in order to remove unneeded negation. > > ``` > #if SANITIZER_NETBSD > ... > #else

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks, @mgorny! Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55891/new/ https://reviews.llvm.org/D55891 _

[PATCH] D54784: Use --push/pop-state with XRay link deps

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D54784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rC342715: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1 (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D52342?vs=166410&id=166412#toc Repository:

[PATCH] D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1

dberris updated this revision to Diff 166410. dberris added a comment. Move the test to the driver, more appropriate location. https://reviews.llvm.org/D52342 Files: clang/include/clang/Basic/XRayInstr.h clang/lib/Driver/XRayArgs.cpp clang/test/Driver/XRay/xray-instrumentation-bundles-fla

[PATCH] D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1

dberris created this revision. dberris added reviewers: mboerger, tejohnson. Add a test and ensure that we propagate the -fxray-instrumentation-bundle flag from the driver invocation to the -cc1 options. https://reviews.llvm.org/D52342 Files: clang/include/clang/Basic/XRayInstr.h clang/lib/

[PATCH] D52160: [Driver] Support XRay on Fuchsia

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D52015: [XRay][clang] Emit "never-instrument" attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC342200: [XRay][clang] Emit "never-instrument" attribute (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D52015?vs=165407&id=165408#toc Repository: rC Clang ht

[PATCH] D52015: [XRay][clang] Emit "never-instrument" attribute

dberris updated this revision to Diff 165407. dberris retitled this revision from "[XRay][clang] Always emit XRay attributes for LLVM IR" to "[XRay][clang] Emit "never-instrument" attribute". dberris added a comment. Retitle, add different test case for -fno-xray-instrument. https://reviews.llv

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris updated this revision to Diff 165220. dberris edited the summary of this revision. dberris added a comment. Revise description. https://reviews.llvm.org/D52015 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/xray-attributes-suppo

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris updated this revision to Diff 165219. dberris added a subscriber: llvm-commits. dberris added a comment. This revision is now accepted and ready to land. Adding an end-to-end test in compiler-rt to ensure that we are not suddenly instrumenting functions that must not be instrumented. Maki

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris planned changes to this revision. dberris added a comment. This change is still incomplete -- we should really only convey that the 'never' attribute gets preserved. Otherwise we're going to have to invent a way to communicate to the XRay pass in LLVM that we should ignore the XRay attr

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris created this revision. dberris added reviewers: mboerger, eizan. Herald added subscribers: dexonsmith, mehdi_amini. Before this change, we only emit the XRay attributes in LLVM IR when the -fxray-instrument flag is provided. This may cause issues with thinlto when the final binary is being

[PATCH] D51269: [Xray] Darwin - Enable in the driver side

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Thanks for this @devnexen -- but do any of the tests actually run on Darwin yet? Repository: rC Clang https://reviews.llvm.org/D51269 ___ cf

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM PS. I really wish at some point this will lead to an OpenBSD build bot! Repository: rC Clang https://reviews.llvm.org/D48574 ___ cfe-c

[PATCH] D33537: [clang-tidy] Exception Escape Checker

dberris added a comment. I'm really excited by this clang-tidy check and I think it's worth having. I do think there's more work needed to bring it up to a level of quality that would be helpful to more users. Comment at: docs/clang-tidy/checks/bugprone-exception-escape.rst:6

[PATCH] D46998: [XRay][compiler-rt] Limit reliance on C++ ABI features

dberris updated this revision to Diff 147453. dberris added a comment. - fixup: revert unnecessary change to clang https://reviews.llvm.org/D46998 Files: compiler-rt/lib/xray/xray_basic_logging.cc compiler-rt/test/xray/TestCases/Posix/c-test.cc Index: compiler-rt/test/xray/TestCases/Posix/

[PATCH] D46998: [XRay][compiler-rt] Limit reliance on C++ ABI features

dberris updated this revision to Diff 147451. dberris retitled this revision from "[XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib" to "[XRay][compiler-rt] Limit reliance on C++ ABI features". dberris edited the summary of this revision. dberris added a comment. Retitle, and upd

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

dberris added a comment. In https://reviews.llvm.org/D46998#1103397, @dblaikie wrote: > "In the future we can revisit this when we have a better idea as to why not > depending on the C++ ABI functionality is a better solution." - this was > discussed previously in the thread linked from the bu

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

dberris created this revision. dberris added reviewers: dblaikie, echristo. This is related to http://llvm.org/PR32274. When building with XRay, always depend on a C++ standard library. We're doing this to automate the linking of the C++ ABI functionality that the modes use by default. In partic

[PATCH] D33537: [clang-tidy] Exception Escape Checker

dberris added inline comments. Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:154-155 + if (const auto *TD = ThrownType->getAsTagDecl()) { +if (TD->getDeclName().isIdentifier() && TD->getName() == "bad_alloc") + return Results; + } ---

[PATCH] D33537: [clang-tidy] Exception Escape Checker

dberris added a comment. How about tests for functions with conditional noexcept? Comment at: docs/clang-tidy/checks/bugprone-exception-escape.rst:8-9 +* Destructors +* Copy constructors +* Copy assignment operators +* The ``main()`` functions Are copy construc

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rL330310: OpenBSD add C++ runtime in a driver's standpoint (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45662?vs=142811

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks for working through this @devnexen! I can land this a little later on my day (Sydney, Australia). https://reviews.llvm.org/D45662 ___

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options:

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options:

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options:

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D45716#1069567, @dberris wrote: > In https://reviews.llvm.org/D45716#1069557, @kpw wrote: > > > My editor got a bit carried away with automatically clang-formattin

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

dberris added a comment. In https://reviews.llvm.org/D45716#1069557, @kpw wrote: > My editor got a bit carried away with automatically clang-formatting > lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the > revision history. Yes please. :) Also, if you can add to t

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added a comment. Okay, can you help me understand why this isn't required for builds in OpenBSD which don't use sanitizers, but want C++ builds that also add the `-pg` flag? I would have thought that those situations would break, no? https://reviews.llvm.org/D45662 _

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. Thanks, Keith -- we're going to need to add this to the list of instrumentation points we can enable/disable through flags. Comment at: lib/CodeGen/CGBuiltin.cpp

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +}

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

dberris added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +}

[PATCH] D45610: [XRay][clang] Make -fxray-modes= additive

This revision was automatically updated to reflect the committed changes. Closed by commit rL329989: [XRay][clang] Make -fxray-modes= additive (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45610?vs=142333&id=142

[PATCH] D45610: [XRay][clang] Make -fxray-modes= additive

dberris created this revision. dberris added reviewers: eizan, kpw, pelikan. This allows us to do the following: clang -fxray-modes=none ... -fxray-modes=xray-basic It's important to be able to do this in cases where we'd like to specialise the configuration for the invocation of the compiler,

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rC329985: [XRay][clang] Add flag to choose instrumentation bundles (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D44970?vs=142315&id=142317#toc Repository: rC

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 142315. dberris marked 5 inline comments as done. dberris added a comment. - fixup: Address comments https://reviews.llvm.org/D44970 Files: clang/include/clang/Basic/XRayInstr.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris added a comment. Thanks, Martin! Landing now, after suggested changes. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:471 bool CodeGenFunction::AlwaysEmitXRayCustomEvents() const { - return CGM.getCodeGenOpts().XRayAlwaysEmitCustomEvents; + return CGM.getCodeGenOp

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 141958. dberris marked an inline comment as done. dberris added a comment. Herald added a subscriber: mgorny. - Rebase - Address comments to use a bitmask/bitset for instrumentation bundle https://reviews.llvm.org/D44970 Files: clang/include/clang/Basic/X

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

This revision was automatically updated to reflect the committed changes. Closed by commit rC329779: Adding fuzzer flags support to OpenBSD driver (authored by dberris, committed by ). Repository: rC Clang https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

dberris added a comment. ACK -- let me land now. :) https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

This revision was automatically updated to reflect the committed changes. Closed by commit rL329772: [XRay][clang+compiler-rt] Support build-time mode selection (authored by dberris, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D45474?v

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

dberris updated this revision to Diff 141940. dberris marked an inline comment as done. dberris added a comment. Revert unnecessary one-liner change. https://reviews.llvm.org/D45474 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolCha

[PATCH] D44878: libFuzzer OpenBSD support

dberris added a comment. In the interest of better documentation, can you please update the description of this change to reflect what we're trying to achieve here? Something more descriptive than "libFuzzer OpenBSD Support" that substantiates the change, along with related changes to other pro

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

dberris created this revision. dberris added reviewers: echristo, eizan, chandlerc. Herald added subscribers: mgrang, mgorny. This patch implements the `-fxray-modes=` flag which allows users building with XRay instrumentation to decide which modes to pre-package into the binary being linked. The

[PATCH] D44878: libFuzzer OpenBSD support

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

This revision was automatically updated to reflect the committed changes. Closed by commit rL329543: [XRay][llvm+clang] Consolidate attribute list files (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D45357?vs=141578&id=141581#toc Repository: rL LLVM

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

dberris updated this revision to Diff 141578. dberris added a comment. - fixup: fix typo https://reviews.llvm.org/D45357 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/Basic/XRayLists.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h cla

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

dberris created this revision. dberris added reviewers: echristo, vlad.tsyrklevich, eugenis. This change consolidates the always/never lists that may be provided to clang to externally control which functions should be XRay instrumented by imbuing attributes. The files follow the same format as de

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rL329376: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

dberris created this revision. dberris added reviewers: eizan, echristo, chandlerc. This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The `-fnoxray-link-deps` allows for directly controlling which specific XRay runtime to link. The default is for clang to link the XRay runtime th

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL329372: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

dberris updated this revision to Diff 141265. dberris added a comment. - fixup: Rebase, and re-do OpenBSD specific changes https://reviews.llvm.org/D45243 Files: clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h cla

[PATCH] D45126: Xray, OpenBSD support

This revision was automatically updated to reflect the committed changes. Closed by commit rC329183: [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD (authored by dberris, committed by ). Repository: rC Clang https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChai

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

dberris added a comment. In https://reviews.llvm.org/D45243#1056549, @devnexen wrote: > Do the unit tests have same outcome with these changes ? Otherwise, > appreciate the simplification. Yes, locally, `ninja check-all` on Linux works just fine for me. No idea whether this will be the case f

[PATCH] D45126: Xray, OpenBSD support

dberris added a comment. Do you need to have someone land this for you, or can you land it yourself? If @brad isn't able to get to it anytime soon, then I'm happy for this to land either way. https://reviews.llvm.org/D45126 ___ cfe-commits mailing

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

dberris created this revision. dberris added reviewers: echristo, devnexen. Herald added a subscriber: emaste. This change fixes http://llvm.org/PR36985 to define a single place in CommonArgs.{h,cpp} where XRay runtime flags and link-time dependencies are processed for all toolchains that support

[PATCH] D45126: Xray, OpenBSD support

dberris accepted this revision. dberris added a comment. LGTM -- I'll defer to @brad on confirming and landing. https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D45126: Xray, OpenBSD support

dberris added inline comments. Comment at: lib/Driver/XRayArgs.cpp:53 +} else if (Triple.getOS() == llvm::Triple::FreeBSD || + Triple.getOS() == llvm::Triple::OpenBSD) { if (Triple.getArch() != llvm::Triple::x86_64) { I just noticed this

[PATCH] D45126: Xray, OpenBSD support

dberris added a comment. In https://reviews.llvm.org/D45126#1055451, @devnexen wrote: > In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > > > LGTM -- at some point, it would be good to refactor all these flag settings > > to a single place. Maybe file a bug so that we can track that

[PATCH] D45126: Xray, OpenBSD support

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM -- at some point, it would be good to refactor all these flag settings to a single place. Maybe file a bug so that we can track that issue on XRay? If you can't do it now, I'd be happy

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 140735. dberris added a comment. - fixup: Fix tests for better coverage of settings https://reviews.llvm.org/D44970 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h clang/include/clang/Frontend/CodeGenOptions.def cl

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris added inline comments. Comment at: clang/include/clang/Frontend/CodeGenOptions.h:110 + enum XRayInstrumentationPointBundle { +XRay_All, // Always emit all the instrumentation points. pelikan wrote: > To me, this feels like a bitfield wo

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 140731. dberris marked 8 inline comments as done. dberris added a comment. - fixup: address comments https://reviews.llvm.org/D44970 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h clang/include/clang/Frontend/CodeGe

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris created this revision. dberris added reviewers: echristo, kpw, eizan, pelikan. This change addresses http://llvm.org/PR36926 by allowing users to pick which instrumentation bundles to use, when instrumenting with XRay. In particular, the flag `-fxray-instrumentation-bundle=` has four valid

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

dberris added a comment. Looks OK, but can we have a test for this somehow? https://reviews.llvm.org/D43378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

This revision was automatically updated to reflect the committed changes. Closed by commit rL319388: [XRay][clang] Introduce -fxray-always-emit-customevents (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D40601?vs=124842&id=124846#toc Repository: rL LLVM https://re

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dberris added inline comments. Comment at: clang/lib/Driver/XRayArgs.cpp:32-33 constexpr char XRayNeverInstrumentOption[] = "-fxray-never-instrument="; +constexpr char XRayAlwaysEmitCustomEventsOption[] = +"-fxray-always-emit-customevents"; } // namespace d

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dberris updated this revision to Diff 124842. dberris marked an inline comment as done. dberris edited the summary of this revision. dberris added a comment. Updated description, address review comment(s). https://reviews.llvm.org/D40601 Files: clang/include/clang/Basic/LangOptions.def clan

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris closed this revision. dberris added a comment. Already commited; closing this revision out now. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dberris created this revision. The -fxray-always-emit-customevents flag instructs clang to always emit the LLVM IR for calls to the `__xray_customevent(...)` built-in function. The default behaviour currently respects whether the function has an `[[clang::xray_never_instrument]]` attribute, and th

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124717. dberris added a comment. - [XRay][compiler-rt][Darwin] Use dynamic initialisation as an alternative https://reviews.llvm.org/D39114 Files: compiler-rt/cmake/config-ix.cmake compiler-rt/lib/xray/CMakeLists.txt compiler-rt/lib/xray/weak_symbols.

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris added a comment. In https://reviews.llvm.org/D39114#938134, @Hahnfeld wrote: > I'm getting "multiple definition" errors on powerpc64le when linking the unit > tests, for example `XRayBufferQueueTest`: > > src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of > `__

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris added a comment. Landing this now and seeing whether there's fallout from the build bots. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124539. dberris edited the summary of this revision. dberris added a comment. Update description to not use tabs. https://reviews.llvm.org/D39114 Files: compiler-rt/cmake/config-ix.cmake compiler-rt/lib/xray/CMakeLists.txt compiler-rt/lib/xray/weak_sy

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124538. dberris retitled this revision from "[XRay][darwin] Initial XRay in Darwin Support" to "[XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin". dberris edited the summary of this revision. dberris added a comment. This revision is now accept

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris added a comment. In https://reviews.llvm.org/D39114#930461, @kubamracek wrote: > Hi, can you split the patch and send individual changes as separate patches? > It's getting hard to follow. And I think we should land the parts that are > "safe to land", e.g. the ASM changes or some of th

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris planned changes to this revision. dberris added a comment. The FDR mode calls to `clock_gettime` needs a bit more attention, let me try and isolate those before attempting to land again. https://reviews.llvm.org/D39114 ___ cfe-commits maili

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris updated this revision to Diff 123529. dberris added a comment. This revision is now accepted and ready to land. Remove some uses of clock_gettime from XRay naive mode logging and some support libraries. Up next should be the FDR mode calls to clock_gettime. https://reviews.llvm.org/D39

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris planned changes to this revision. dberris added a comment. In https://reviews.llvm.org/D39114#929706, @kubamracek wrote: > Can we just not use clock_gettime on Darwin and instead use > mach_absolute_time? That's a good suggestion. Let me make that change. Thanks! Repository: rL LL

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris reopened this revision. dberris added a comment. This revision is now accepted and ready to land. Hi @kubamracek -- do you know how to work around the lack of `clock_gettime` from the 10.11 SDK? The build bots will complain again if this lands, and it'd be a real shame if we didn't get

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris added a comment. Reverted in https://reviews.llvm.org/rL317877 -- I'm going to try again next week instead. Repository: rL LLVM https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris added a comment. Landing now, will deal with the test and dynamic/ Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75 - .globl __xray_FunctionEntry + .globl ASM_TSAN_SYMBOL(__xray_FunctionEntry) .align 16, 0x90 kuba

  1   2   >