[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

2019-07-09 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 208736. hintonda added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Make GeneralCategory a ManagedStatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

2019-06-16 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. This test fails to compile on Windows 64 bit builds. Please see http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77 Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; +

[PATCH] D62839: [clangd] Index API and implementations for relations

2019-06-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio. I believe the following patch should fix the problem: diff --git

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-06-14 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D59754#1543949 , @sokolovd wrote: > This looks like exactly what we need for my project. We're using Clang and > Designated Initializers but would like to make sure that we use those in > C++20 compatible manner. Is this

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-06-14 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61697#1543443 , @thakis wrote: > I reverted this in r363379 to unbreak check-lld on mac. I think the > > if config.enable_shared: > features.add("enable_shared") > > > bit belongs in

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62873#1530197 , @Szelethus wrote: > I seem to have missed out on previous commits that moved analyzer plugins > around -- would you mind adding `[analyzer]` to the revision names that > affect the Static Analyzer? Many of

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Szelethus wrote: > Is this file a thing?

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM... Comment at: test/CMakeLists.txt:122 -if (CLANG_ENABLE_STATIC_ANALYZER) - if (LLVM_ENABLE_PLUGINS) -list(APPEND CLANG_TEST_DEPS - SampleAnalyzerPlugin

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62873#1529800 , @nathanchance wrote: > Thanks for the quick fix, looks good to me! Ah, sorry, just saw this. I just committed r362555 that addresses this. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62445: [test] Fix plugin tests

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) hintonda wrote: > nathanchance wrote: > > I think this should have

[PATCH] D62445: [test] Fix plugin tests

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) nathanchance wrote: > I think this should have a dependency on

[PATCH] D62445: [test] Fix plugin tests

2019-06-03 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62445#1527368 , @davezarzycki wrote: > This broke non-PIC builds. Fixed: r362399 Sorry for the breakage, and thanks for the fix! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/

[PATCH] D62445: [test] Fix plugin tests

2019-06-01 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 202573. hintonda added a comment. - Fix dependencies so required plugins get built before tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 Files:

[PATCH] D62445: [test] Fix plugin tests

2019-06-01 Thread Don Hinton via Phabricator via cfe-commits
hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. This patch broke some of the bots, so reopening to track the fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-05-31 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62445: [test] Fix plugin tests

2019-05-27 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62445: [test] Fix plugin tests

2019-05-27 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62445: [test] Fix plugin tests

2019-05-25 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: beanz, phosek, george.karpenkov, NoQ, ahatanak, rjmccall. Herald added subscribers: llvm-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. hintonda edited the summary of this revision. The following changes were required to

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

2019-05-23 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: mikhail.ramalho, beanz. Herald added a subscriber: mgorny. Herald added a project: clang. This file was moved to llvm in D54978 , r356929, but the old file was never removed. Repository: rG LLVM Github

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

2019-05-21 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62050#1509400 , @vitalybuka wrote: > In D62050#1509384 , @vitalybuka > wrote: > > > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake > > in empty directory)

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62157#1509289 , @juliehockett wrote: > @hintonda Aha so it is :) I don't think it's at all controversial, so I'll commit D61747 tomorrow unless someone raises an issue. Thanks...

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. If no further comments, I'll commit it for you tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. Great idea. Please see D61747 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() hintonda wrote: > This is a breaking patch. What's the rational for

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() This is a breaking patch. What's the rational for unilaterally

[PATCH] D62138: [Docs] Increase Doxygen cache size

2019-05-20 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I'll give it a day for further comments, and barring any, commit it for you tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

2019-05-16 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. After thinking about it, I agree with this change -- there's no way to provide an appropriate default at this level. So, LGTM, but wait for @alexfh's okay. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/

[PATCH] D61756: Add a __FILE_NAME__ macro.

2019-05-16 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61756#1504109 , @kristina wrote: > Reverted in rL360842 as Windows bots were > failing. > > I suspect the `MSVCCompat` case may need to be handled differently depending > on the host OS

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

2019-05-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. I've also had issues with this behavior. It's a bad default, as the PR notes, but is there a way to provide a better one and still respect the config file? Also, could you add a test for this? Perhaps in `clang-tools-extra/test//clang-tidy/run-clang-tidy.cpp`.

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-14 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. I'll be happy to commit for you, but will give it till tomorrow just to make sure no one else has any additional comments. Thanks again! Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-loop-convert.rst:262 +not been used on code with

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-13 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Awesome, thanks... LGTM, but you may want to give @alexfh or @aaron.ballman a day to comment before you commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61827#1499368 , @lebedev.ri wrote: > In D61827#1499347 , @hintonda wrote: > > > > >> Are you saying this patch is a regression? > > Not in general, no. This is most certainly an

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. I pulled down you patch, compiled and ran it. Once I fixed the two problems I mentioned, it ran clean, e.g.: $ bin/llvm-lit -vv ../../llvm-project/clang-tools-extra/test/clang-tidy/modernize-loop-convert-[be]*.cpp -- Testing: 2 tests, 2 threads -- PASS: Clang

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61827#1499335 , @lebedev.ri wrote: > In D61827#1499333 , @hintonda wrote: > > > When I asked for a test above, I understood you to say you couldn't provide > > one, but If I

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61827#1499309 , @lebedev.ri wrote: > In D61827#1499306 , @hintonda wrote: > > > In D61827#1499303 , @torbjoernk > > wrote: > > > > > In

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61827#1499303 , @torbjoernk wrote: > In D61827#1499184 , @lebedev.ri > wrote: > > > In D61827#1499183 , @hintonda > > wrote: > > > > > In

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61827#1499160 , @lebedev.ri wrote: > This will now trigger on https://godbolt.org/z/9oFMcB right? > Just want to point out that this will then have "false-positives" when that > loop > is an OpenMP for loop, since

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-loop-convert-basic.cpp:273 + for (S::const_iterator It = Ss.begin(), E = Ss.end(); It != E; ++It) { +printf("s has value %d\n", (*It).X); I think you need to fix the

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-05-08 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. @zturner, I only disabled this on Darwin because that's all I can test on right now. Please let me know if there's a better way to do this or if it should fire on different platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-05-08 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added a reviewer: zturner. Herald added subscribers: llvm-commits, delcypher. Herald added projects: clang, LLVM. This test fails to link shared libraries because tries to run a copied version of clang-check to see if the mock version of libcxx in the same

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-05-08 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60629#1494908 , @aaron.ballman wrote: > This LGTM, but you may want to wait a day or so to see if @alexfh has any > remaining concerns. Will do, thanks Aaron... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-05-07 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

2019-05-03 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61269#1490176 , @thakis wrote: > I happened to see this go by. Is there an explanation of the overall goal > somewhere? In general, requiring -- for long flags sounds like a great change > to me, but there are a few

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. Ping. Is this the direction you'd like to go? Or would you prefer something else? thanks... don Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D61270#1483661 , @MaskRay wrote: > Thank you for the patch series! > > > This is consistent with GNU getopt behavior. > > This is not GNU specific :) It is POSIX Utility Syntax Guidelines 5 >

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 197466. hintonda added a comment. - Refactor and fix additional dashes in error messages and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61269/new/ https://reviews.llvm.org/D61269 Files:

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:95 + +static size_t argPrefixesSize(size_t len) { + if (len == 1) thopre wrote: > Any reason why not take a StringRef of the option to

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 197272. hintonda added a comment. Minimize diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61270/new/ https://reviews.llvm.org/D61270 Files: llvm/include/llvm/Support/CommandLine.h

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 197271. hintonda added a comment. Herald added subscribers: cfe-commits, thopre. Herald added a project: clang. - Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61270/new/

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

2019-04-30 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 197267. hintonda added a comment. Herald added subscribers: cfe-commits, thopre. Herald added a project: clang. - Fix dashes in error messages and in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60910: [WIP] Dumping the AST to JSON

2019-04-25 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: include/clang/Frontend/FrontendOptions.h:311 + /// Specifies the output format of the AST. + enum ASTOutputFormat { +AOF_Default, aaron.ballman wrote: > hintonda wrote: > > Why can't you use the enum defined in

[PATCH] D60910: [WIP] Dumping the AST to JSON

2019-04-25 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. Looks good, but just a couple of questions. Comment at: include/clang/AST/JSONNodeDumper.h:73 + Indentation.clear(); + OS << "\n" << Indentation << "}\n"; + TopLevel = true; Just curious, since you clear Indentation on

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-24 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:267 - if old_module != new_module: + if old_module != new_module or new_module == 'llvm': +if new_module == 'llvm': alexfh

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-24 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 196531. hintonda added a comment. - Change check back to previous version which is much clearer. - Apply namespace change to new check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-24 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 196521. hintonda added a comment. - Remove unnecessary comparison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-23 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D59802#1475596 , @aaron.ballman wrote: > In D59802#1474300 , @hintonda wrote: > > > @aaron.ballman, I just ran it over llvm/lib, including all in-tree headers, > > and it seems to

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-22 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. @aaron.ballman, I just ran it over llvm/lib, including all in-tree headers, and it seems to work fine. However, it did miss this one: - if (V && isa(V) && (EntInst = cast(V)) && +if (isa_and_nonnull(V) && (EntInst = cast(V)) && It got the first, but not the

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-04-22 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2069-2072 +if (!VerifyOnly && HasDesignatedInit && SemaRef.getLangOpts().CPlusPlus2a) { + SemaRef.Diag(Init->getBeginLoc(), diag::ext_c20_designated_init)

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-04-21 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2069-2072 +if (!VerifyOnly && HasDesignatedInit && SemaRef.getLangOpts().CPlusPlus2a) { + SemaRef.Diag(Init->getBeginLoc(), diag::ext_c20_designated_init)

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-21 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 196011. hintonda added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-21 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:218 header_guard_variants = [ + (args.old_check_name.replace('-', '_') + '_Check').upper(), + (old_module + '_' +

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

2019-04-18 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:77 +Opts["abseil-make-unique.MakeSmartPtrFunction"] = "absl::make_unique"; +Opts["abseil-make-unique.IgnoreListInit"] = true; +return Options; This is defined as

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} hintonda wrote: > axzhang wrote: > >

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} axzhang wrote: > hintonda wrote: > >

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} You’re setting it false here.

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195611. hintonda added a comment. - Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195610. hintonda added a comment. - Removed auto and added specific warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files:

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked 2 inline comments as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381 + # Don't allow 'clang' or 'llvm' namespaces + if module == 'llvm' or module == 'clang': +namespace = module + '_check'

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195581. hintonda added a comment. - Remove clang module check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-17 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFactories.registerCheck("llvm-include-order"); +CheckFactories.registerCheck( +

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-16 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFactories.registerCheck("llvm-include-order"); +CheckFactories.registerCheck( +

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195278. hintonda added a comment. - Change `llvm_checker` to `llvm_check`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195270. hintonda added a comment. - Alphabetize registration calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:382 + if module == 'llvm' or module == 'clang': +namespace = module + '_checker' + else: aaron.ballman wrote: > I thought

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added a comment. In D59802#1467363 , @aaron.ballman wrote: > LGTM aside from a nit and the ultimate name for the `isa_and_nonnull<>` API. Thanks. I'll ping the list again at the end of the week, then

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195218. hintonda added a comment. - Add new test back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files: clang/lib/Tooling/CommonOptionsParser.cpp

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 195217. hintonda added a comment. - Original patch, r358337, that was reverted. - Make sure to clear DefaultOptions on reset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-15 Thread Don Hinton via Phabricator via cfe-commits
hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen to track fix after buildbot failure and revert -- r358414. http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190415/644037.html Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-13 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D59746#1465445 , @klimek wrote: > lg Thanks again for the help and the suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60629#1464945 , @Eugene.Zelenko wrote: > Please use check for consistency with rest of Clang-tidy. Thanks for taking a look — I’ll Fix that on the next upload. So are you okay with llvm_check? I sorta like it, but happy

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194940. hintonda added a comment. - Remove leftover comments, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files:

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194941. hintonda added a comment. - Add missing 'clang'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. Change the namespace for llvm checkers from 'llvm' to 'llvm_checker', and modify add_new_check.py and rename_check.py to support the new namespace.

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda abandoned this revision. hintonda added a comment. Replaced by D60629 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60151/new/ https://reviews.llvm.org/D60151

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194899. hintonda added a comment. - Fix comments and add isDefaultOption per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194782. hintonda added a comment. - Update isa_and_nonnull diagnostic message, and fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferIsaOrDynCastInConditionalsCheck.h:37-39 +/// if (var && isa(var)) {} +/// // is replaced by: +/// if (dyn_cast_or_null(var.foo())) {}

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60151#1463484 , @MyDeveloperDay wrote: > >> I suppose we could keep the names and directory structure and just change > >> the namespace. That would just be a special case in the scripts. Haven't > >> looked into it yet,

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. @klimek, this patch is now ready for review. Thanks... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 ___ cfe-commits mailing list

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194729. hintonda added a comment. Enhance Option::reset to reset the default value and remove the option if it's a cl::DefaultOption. Also, make sure removeOption only removes an option if both the name and the Option matches, not just the name -- different

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60151#1462850 , @MyDeveloperDay wrote: > are we supporting "-llvm-*" in existing .clang-tidy files? > > If people selectively turn checkers off, won't all of a sudden everyone start > getting llvm-project checks and fixes

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194708. hintonda added a comment. - Add unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files: clang/lib/Tooling/CommonOptionsParser.cpp

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D59746#1462352 , @jhenderson wrote: > I've not looked at the implementation in depth, but cl::DefaultOption seems > like a nice way of handling this. Please make sure that there is testing in > llvm-readobj and llvm-objdump

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked 2 inline comments as done. hintonda added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:282 else { - for (auto SC : O->Subs) -updateArgStr(O, NewName, SC); + if (O->isInAllSubCommands()) { +for (auto SC :

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194669. hintonda added a comment. - Delay actually adding default options until ParseCommandLineOptions which simplifies handling and makes it easy to only add them to the correct SubCommand. Add simple tests. Repository: rG LLVM Github Monorepo

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

2019-04-10 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 194633. hintonda edited the summary of this revision. hintonda added a comment. - Fix bug in updateArgStr() where it didn't handle isInAllSubCommands() correctly, and refactored code based on how SubCommands work. Repository: rG LLVM Github Monorepo

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-04-10 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-04-10 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping, and should we add new warning messages as suggested by @Rakete ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 ___

  1   2   3   4   >