[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina abandoned this revision. eklepilkina added a comment. Herald added a subscriber: jobnoorman. Another implementation was merged to upsteam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 497620. eklepilkina added a comment. - [RISCV] Prepare work to be ready for adding separate Zicsr and Zifencei extensions - [RISCV] Proper support of extensions Zicsr and Zifencei - Updated I extension verson - Fixing after updating Repository: rG

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. @reames Thank you for fixing documentation, missed this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. > Maybe multi-lib handling should split into another patch? I can do this. But if I separate I still can't choose one that should be merged firstly, they will be needed to merge both at once, because tests will fail. If separate them right way (fixes for multilibs

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. I've created one more patch connected with lto https://reviews.llvm.org/D142191 and it also uses attributes of functions as the way to get right TargetMachine in linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? More detailed answer. We work with bitcode files only when use `lto`. If we don't use `lto` clang produces `.o` file that are already contains target information. We don't work with function attributes to get subtarget without lto.

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? This problem appeared only under lto as far as it's processed as one module. > Is this not just one of many symptoms of RISC-V not having the right > module-level subtarget under LTO, which is a real problem that needs fixing? Not

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Herald added a subscriber: luke. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 490056. eklepilkina added a comment. - Updated I extension verson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 Files:

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Thank you for comments! > The key aspect this patch misses right now is the versioning issue - I is > still marked as 2.0. I can update `I` extension version or separate diffrent isa versions as you mentioned. I can fix comments and make proposed by community

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. We are interested in proper support for `Zicsr` and `Zifencei`. Could someone look at patch or explain why these extensions were included by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

eklepilkina added a comment. @lewis-revill could you please provide the case where the LTO linker would not receive any information about target features? We met similar problems, it appears on runtime functions in our cases. I made a small fix for this problem

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,