Re: [PATCH] D17026: Changed ASTImporter DiagnosticsEngine from FromDiag to ToDiag for unsupported ASTNodes Import.

2016-02-20 Thread Elisavet Sakellari via cfe-commits
esakella added a comment. In http://reviews.llvm.org/D17026#356418, @akyrtzi wrote: > Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored > by VerifyDiagnosticConsumer ? Why specifically change only this two and what > are we going to do with the others ? > This

Re: [PATCH] D17029: [AST] Implemented missing import for the Template type parameter and Injected Class Name in ASTImporter class.

2016-02-20 Thread Elisavet Sakellari via cfe-commits
esakella added a comment. In http://reviews.llvm.org/D17029#356428, @akyrtzi wrote: > If I apply just the test changes without the rest of the changes, I don't see > any failures, so I'm not sure these are effective tests. This happens because also one of the changes is the new line 4304

[PATCH] D17136: [AST] VisitFunctionTemplateDecl implementation in ASTImporter class.

2016-02-11 Thread Elisavet Sakellari via cfe-commits
esakella created this revision. esakella added reviewers: rsmith, klimek, bkramer, spyffe. esakella added subscribers: karies, cfe-commits. Herald added a subscriber: aemerson. Implemented the VisitFunctionTemplateDecl function for the import of template function definitions. Note that this

[PATCH] D17075: [AST] Added SubstTemplateTypeParm, DependentNameType, DependentSizedArrayType import functions in the ASTImporter.

2016-02-10 Thread Elisavet Sakellari via cfe-commits
esakella created this revision. esakella added reviewers: klimek, bkramer, rsmith, spyffe. esakella added subscribers: karies, cfe-commits. Herald added subscribers: rengolin, aemerson. Implemented the VisitSubstTemplateTypeParmType VisitDependentNameType VisitDependentSizedArrayType