r282251 - [asan] Fix incorrect SEH symbol mangling on win64.

Author: etienneb Date: Fri Sep 23 09:07:47 2016 New Revision: 282251 URL: http://llvm.org/viewvc/llvm-project?rev=282251=rev Log: [asan] Fix incorrect SEH symbol mangling on win64. Summary: The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol name: ``` LINK : error

[PATCH] D24841: [asan] Fix incorrect SEH symbol mangling on win64.

etienneb created this revision. etienneb added reviewers: rnk, kcc. etienneb added subscribers: cfe-commits, chrisha. The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol name: ``` LINK : error LNK2001: unresolved external symbol ___asan_seh_interceptor ``` On win64,

r280127 - typo + indentation [NFC]

Author: etienneb Date: Tue Aug 30 13:38:25 2016 New Revision: 280127 URL: http://llvm.org/viewvc/llvm-project?rev=280127=rev Log: typo + indentation [NFC] Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp

[clang-tools-extra] r277578 - [extra-tools] Fix extra tools build bot warnings due to incorrect doc

Author: etienneb Date: Wed Aug 3 01:59:46 2016 New Revision: 277578 URL: http://llvm.org/viewvc/llvm-project?rev=277578=rev Log: [extra-tools] Fix extra tools build bot warnings due to incorrect doc

Re: [PATCH] D23105: [clang/test] Fix a flaky unittest on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL277576: [clang/test] Fix a flaky unittest on windows (authored by etienneb). Changed prior to commit: https://reviews.llvm.org/D23105?vs=66615=66616#toc Repository: rL LLVM

r277576 - [clang/test] Fix a flaky unittest on windows

Author: etienneb Date: Wed Aug 3 01:10:15 2016 New Revision: 277576 URL: http://llvm.org/viewvc/llvm-project?rev=277576=rev Log: [clang/test] Fix a flaky unittest on windows Summary: The append operator on a shell command for quick command-line is causing trouble on windows. [NFC] The easiest

[PATCH] D23105: [clang/test] Fix a flaky unittest on windows

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added subscribers: chrisha, cfe-commits. The append operator on a shell command for quick command-line is causing trouble on windows. [NFC] The easiest way to fix them is to avoid using them. This patch is an attempt to fix

[clang-tools-extra] r277539 - [clang-tidy] Fix missing dependency to static analyzer

Author: etienneb Date: Tue Aug 2 17:51:46 2016 New Revision: 277539 URL: http://llvm.org/viewvc/llvm-project?rev=277539=rev Log: [clang-tidy] Fix missing dependency to static analyzer Summary: This patch is fixing the build bot broken for a missing dependency. The missing dependency is

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

etienneb added inline comments. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:73 @@ +72,3 @@ + Finder->addMatcher( + callExpr(allOf(callee(functionDecl(matchesName("::memcpy"))), + argumentCountIs(3))) It's more efficient to use

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

etienneb added a comment. In https://reviews.llvm.org/D22725#494167, @Prazek wrote: > hmm It seems that I mislead you, I suck at C api - memmove source and > destination can overlap, but std::move can't. So I guess you have to remove > the memmove support. Sorry. On windows (MSVC CRT), both

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

etienneb added a subscriber: etienneb. etienneb added a comment. thx for the check Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:25 @@ +24,3 @@ + const SourceManager = Context->getSourceManager(); + const LangOptions LangOpts = Context->getLangOpts(); +

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

etienneb added a comment. some nits Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:37 @@ +36,3 @@ +unsigned flag; +flag = A | H; //OK, disjoint value intervalls in the enum types > probably good use +flag = B | F; //warning, have common values so they are probably

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

etienneb added a comment. drive-by, some comments. Thanks for the check Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:20 @@ +19,3 @@ +// Return the number of EnumConstantDecls in an EnumDecl. +static int enumLen(const EnumDecl *EnumDec) { + int Counter = 0;

r275256 - fix missing whitespace in sphinx doc

Author: etienneb Date: Wed Jul 13 01:37:39 2016 New Revision: 275256 URL: http://llvm.org/viewvc/llvm-project?rev=275256=rev Log: fix missing whitespace in sphinx doc Modified: cfe/trunk/docs/ClangFormat.rst Modified: cfe/trunk/docs/ClangFormat.rst URL:

[clang-tools-extra] r275254 - fix missing newline in sphinx doc

Author: etienneb Date: Wed Jul 13 01:06:48 2016 New Revision: 275254 URL: http://llvm.org/viewvc/llvm-project?rev=275254=rev Log: fix missing newline in sphinx doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst Modified:

[clang-tools-extra] r274731 - [clang-tidy] Enhance redundant-expression check

Author: etienneb Date: Wed Jul 6 23:03:05 2016 New Revision: 274731 URL: http://llvm.org/viewvc/llvm-project?rev=274731=rev Log: [clang-tidy] Enhance redundant-expression check Summary: This patch is adding support to recognize more complex redundant expressions. Reviewers: alexfh

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 63020. etienneb marked 2 inline comments as done. etienneb added a comment. nits http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:27 @@ -25,1 +26,3 @@ +static bool incrementWithoutOverflow(const llvm::APSInt , + llvm::APSInt ) { aaron.ballman wrote: > I think this

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 61984. etienneb marked 12 inline comments as done. etienneb added a comment. address comments http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 60983. etienneb added a comment. refactoring http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h test/clang-tidy/misc-redundant-expression.cpp Index:

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb added a comment. thx Aaron. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:131 @@ +130,3 @@ + + // Handle the case where constants are off by one: x <= 4 <==> x < 5. + llvm::APSInt ValueLHS_plus1 = ValueLHS; aaron.ballman wrote: > Why is

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 60982. etienneb marked 7 inline comments as done. etienneb added a comment. address comments http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h

r272832 - Add support to clang-cl driver for /GS switch

Author: etienneb Date: Wed Jun 15 15:34:33 2016 New Revision: 272832 URL: http://llvm.org/viewvc/llvm-project?rev=272832=rev Log: Add support to clang-cl driver for /GS switch Summary: This patch is adding command-line support for the MSVC buffer security check. The buffer security check is

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

etienneb added a subscriber: etienneb. etienneb added a comment. I was wondering why we didn't created that Matcher: IgnoreImplicit I believe it's more commonly used than 'ignoringExprWithCleanups'. It can be implemented by calling 'Stmt.IgnoreImplicit'. /// Skip past any implicit AST nodes

Re: [PATCH] D21298: [Clang-tidy] delete null check

etienneb added a comment. Some comments after a quick look to the code. Comment at: clang-tidy/misc/DeleteNullCheck.cpp:22 @@ +21,3 @@ +void DeleteNullCheck::registerMatchers(MatchFinder *Finder) { + const auto HasDeleteExpr = +

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

etienneb added inline comments. Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:23 @@ +22,3 @@ + +// Matcher checking if the declaration is non-macro existent mutable which is +// not dependent on context. add an anonymous namespace around this

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added inline comments. Comment at: test/clang-tidy/modernize-operator-void-pointer.cpp:39 @@ +38,3 @@ +class SomethingGoodNonConstVoidPtr { + // A non-const void* is unlikely to to be meant as operator bool before C++11 + // let us use explicit. You

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. In http://reviews.llvm.org/D20857#446784, @murrayc wrote: > In http://reviews.llvm.org/D20857#446732, @etienneb wrote: > > > Enabling/disabling can be done with options (see SizeofExpressionCheck). > > > Thanks. Am I being asked to combine the checks? I'll let alexfh@

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. In http://reviews.llvm.org/D20857#446654, @murrayc wrote: > In http://reviews.llvm.org/D20857#446101, @etienneb wrote: > > > I wonder if these two checks should not be merge in one checker. > > > Personally I find it cleaner to keep them separate, but I would be happy

r271431 - [Sema] Fix incorrect enum token namespace

Author: etienneb Date: Wed Jun 1 16:17:32 2016 New Revision: 271431 URL: http://llvm.org/viewvc/llvm-project?rev=271431=rev Log: [Sema] Fix incorrect enum token namespace Summary: This patch fix the scoping of enum literal. They were not resolving to the right type. It was not causing any

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. I wonder if these two checks should not be merge in one checker. modernize-explicit-conversion-operator Comment at: clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp:21 @@ +20,3 @@ +void ExplicitOperatorBoolCheck::registerMatchers(MatchFinder

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#445911, @Eugene.Zelenko wrote: > There is a way to tell IWYU about compound headers with pragmas > . > I also suggested to make this

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#444802, @Eugene.Zelenko wrote: > Point of Include What You Use suggestions to rely on explicit dependencies, > not implicit ones. It's true most of the time. In some case, splitting the header file is for maintainability and

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. drive-by Comment at: clang-tidy/ClangTidy.cpp:24 @@ -24,2 +23,3 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Frontend/ASTConsumers.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "clang/Basic/FileManager.h"

[clang-tools-extra] r271210 - [clang-tidy] Remove redundant quote in add_new_check script

Author: etienneb Date: Mon May 30 10:42:08 2016 New Revision: 271210 URL: http://llvm.org/viewvc/llvm-project?rev=271210=rev Log: [clang-tidy] Remove redundant quote in add_new_check script Summary: Remove redundant quote. These quotes were added here: http://reviews.llvm.org/D20766 Reviewers:

Re: [PATCH] D20792: [clang-tidy] Remove redundant quote in add_new_check script

etienneb updated this revision to Diff 58969. etienneb added a comment. nits http://reviews.llvm.org/D20792 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py === --- clang-tidy/add_new_check.py +++

[PATCH] D20792: [clang-tidy] Remove redundant quote in add_new_check script

etienneb created this revision. etienneb added a reviewer: bkramer. etienneb added a subscriber: cfe-commits. Remove redundant quote. These quotes were added here: http://reviews.llvm.org/D20766 http://reviews.llvm.org/D20792 Files: clang-tidy/add_new_check.py

r271208 - [ASTMatchers] Add support of hasCondition for SwitchStmt.

Author: etienneb Date: Mon May 30 10:25:25 2016 New Revision: 271208 URL: http://llvm.org/viewvc/llvm-project?rev=271208=rev Log: [ASTMatchers] Add support of hasCondition for SwitchStmt. Summary: The switch statement could be added to the hasCondition matcher. Example: ``` clang-query> match

[clang-tools-extra] r271207 - [clang-tidy] Fix script adding new clang-tidy check

Author: etienneb Date: Mon May 30 10:05:10 2016 New Revision: 271207 URL: http://llvm.org/viewvc/llvm-project?rev=271207=rev Log: [clang-tidy] Fix script adding new clang-tidy check Summary: The `getName()` call is useless. It's better to show a better example as tutorial. Reviewers: alexfh

Re: [PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check

This revision was automatically updated to reflect the committed changes. Closed by commit rL271207: [clang-tidy] Fix script adding new clang-tidy check (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20766?vs=58878=58958#toc Repository: rL LLVM

[PATCH] D20773: [Sema] Fix incorrect enum token namespace

etienneb created this revision. etienneb added a reviewer: rsmith. etienneb added a subscriber: cfe-commits. This patch fix the scoping of enum literal. They were not resolving to the right type. It was not causing any problem as one is a copy of the other one. The literal in the switch are

[PATCH] D20767: [ASTMatchers] Add support of hasCondition for SwitchStmt.

etienneb created this revision. etienneb added reviewers: aaron.ballman, sbenza. etienneb added a subscriber: cfe-commits. Herald added a subscriber: klimek. The switch statement could be added to the hasCondition matcher. Example: ``` clang-query> match

[PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The `getName()` call is useless. It's better to show a better example as tutorial. http://reviews.llvm.org/D20766 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

etienneb added a comment. This patch needs land after http://reviews.llvm.org/D20346. thx for the review. http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

etienneb updated this revision to Diff 58502. etienneb marked an inline comment as done. etienneb added a comment. more tests http://reviews.llvm.org/D20347 Files: include/clang/Driver/CLCompatOptions.td lib/Driver/Tools.cpp test/Driver/cl-fallback.c test/Driver/cl-options.c Index:

[clang-tools-extra] r269804 - [clang-tidy] Lift common matchers to utils namespace

Author: etienneb Date: Tue May 17 14:36:09 2016 New Revision: 269804 URL: http://llvm.org/viewvc/llvm-project?rev=269804=rev Log: [clang-tidy] Lift common matchers to utils namespace Summary: This patch is lifting matchers used by more than one checkers to the common namespace. Reviewers:

[clang-tools-extra] r269656 - [clang-tidy] Cleanups utils files

Author: etienneb Date: Mon May 16 09:34:20 2016 New Revision: 269656 URL: http://llvm.org/viewvc/llvm-project?rev=269656=rev Log: [clang-tidy] Cleanups utils files Summary: Cleanup some code by using appropriate APIs. Some coding style cleanups. There is no behavior changes. - Function

[PATCH] D20279: [clang-tidy] Cleanups utils files

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Cleanup some code by using appropriate APIs. Some coding style cleanups. There is no behavior changes. http://reviews.llvm.org/D20279 Files: clang-tidy/utils/DeclRefExprUtils.cpp

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

etienneb updated this revision to Diff 57316. etienneb added a comment. nits: indent http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp clang-tidy/modernize/UseNullptrCheck.cpp clang-tidy/performance/FasterStringFindCheck.cpp

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

etienneb updated this revision to Diff 57314. etienneb marked an inline comment as done. etienneb added a comment. rebase over trunk. matchers are lifted to ASTMatchers. http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

etienneb added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:22 @@ +21,3 @@ +static StringRef +MakeDynamicExceptionString(const SourceManager , + const CharSourceRange ) { coding style: MakeDynamicExceptionString

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

etienneb added inline comments. Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:35 @@ +34,3 @@ + cxxOperatorCallExpr(hasAnyArgument(ignoringImpCasts(declRefExpr(BasicStringType))), + hasOverloadedOperatorName("+")); +

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb added a comment. In http://reviews.llvm.org/D20261#430151, @rnk wrote: > Will this put the libraries in build/Release/bin/../lib/. aka > build/Release/lib, or will they collide between build types? If I get your question correctly, they won't collide since the first folder below

[PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. When using a multi-configuration build (i.e. MSVC) the output path where libraries are dropped is incorrect. Example: ``` C:\src\llvm\examples>d:\src\llvm\build\Release\bin\clang-cl.exe

r269460 - Add an AST matcher for CastExpr kind

Author: etienneb Date: Fri May 13 14:36:55 2016 New Revision: 269460 URL: http://llvm.org/viewvc/llvm-project?rev=269460=rev Log: Add an AST matcher for CastExpr kind Summary: This AST matcher will match a given CastExpr kind. It's an narrowing matcher on CastExpr. Reviewers: klimek, alexfh,

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. In http://reviews.llvm.org/D20240#429910, @vmiklos wrote: > Thanks for fixing the problem I introduced. :-) No worries, I did the same twice this week. http://reviews.llvm.org/D20240 ___ cfe-commits mailing list

Re: [PATCH] D20245: [include-fixer] Fix broken dependency shared build

This revision was automatically updated to reflect the committed changes. Closed by commit rL269441: [include-fixer] Fix broken dependency shared build (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20245?vs=57208=57221#toc Repository: rL LLVM

[clang-tools-extra] r269441 - [include-fixer] Fix broken dependency shared build

Author: etienneb Date: Fri May 13 12:38:22 2016 New Revision: 269441 URL: http://llvm.org/viewvc/llvm-project?rev=269441=rev Log: [include-fixer] Fix broken dependency shared build Summary: The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release

[PATCH] D20245: [include-fixer] Fix broken dependency shared build

etienneb created this revision. etienneb added reviewers: bkramer, hokein. etienneb added a subscriber: cfe-commits. The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Errors: ```

[clang-tools-extra] r269429 - [clang-rename] Fix broken dependency on shared build.

Author: etienneb Date: Fri May 13 10:38:54 2016 New Revision: 269429 URL: http://llvm.org/viewvc/llvm-project?rev=269429=rev Log: [clang-rename] Fix broken dependency on shared build. Summary: The build is broken due to a missing dependency. To repro: [Release + Shared] ```

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. thanks, landing as soon as my other checkouts complete their tests (few minutes). http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb added a comment. In http://reviews.llvm.org/D19871#429466, @Prazek wrote: > +1 I will probably also use this. > > Does hasCastKind works for implicitCastExpr? Yes, there is a unittest with the code. http://reviews.llvm.org/D19871 ___

r269418 - [AST] Add missing const qualifiers to AstContext in Type.cpp

Author: etienneb Date: Fri May 13 09:31:44 2016 New Revision: 269418 URL: http://llvm.org/viewvc/llvm-project?rev=269418=rev Log: [AST] Add missing const qualifiers to AstContext in Type.cpp Summary: Add some missing const qualifiers to AstContext. The ASTContext can't be modified with

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

etienneb added inline comments. Comment at: clang-tidy/utils/TypeTraits.cpp:42 @@ -27,3 +41,3 @@ llvm::Optional isExpensiveToCopy(QualType Type, ASTContext ) { if (Type->isDependentType()) You're right too. But, it's possible to fix these prototypes:

[PATCH] D20226: [AST] Add missing const qualifiers to AstContext in Type.cpp

etienneb created this revision. etienneb added a reviewer: rsmith. etienneb added a subscriber: cfe-commits. Add some missing const qualifiers to AstContext. The ASTContext can't be modified with accessors. There is no behavior change. This patch is cleanup only. http://reviews.llvm.org/D20226

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

etienneb added inline comments. Comment at: clang-tidy/utils/TypeTraits.cpp:22 @@ -20,2 +21,3 @@ + bool classHasTrivialCopyAndDestroy(QualType Type) { auto *Record = Type->getAsCXXRecordDecl(); My bad! I didn't saw the file change when reading. Forget about

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb updated this revision to Diff 57124. etienneb added a comment. nit: indentation http://reviews.llvm.org/D19871 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Marshallers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb added a comment. In http://reviews.llvm.org/D19871#428997, @jroelofs wrote: > Drive-by thought: I think it would be useful to be able to match implicit > casts separately from explicit casts when using this new matcher. Jonathan, I think what you are asking for is already supported.

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb updated this revision to Diff 57123. etienneb added a comment. add unittest http://reviews.llvm.org/D19871 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Marshallers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb updated this revision to Diff 57101. etienneb marked an inline comment as done. etienneb added a comment. regenerate doc http://reviews.llvm.org/D19871 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Marshallers.h

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

etienneb added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:98 @@ +97,3 @@ + const auto *FuncDecl = Result.Nodes.getNodeAs("functionDecl"); + if (!FuncDecl) +return; I'm not saying to use 'const *FuncDecl', but 'const auto*'

r269347 - [AST] Move operations enum to a definition file.

Author: etienneb Date: Thu May 12 15:58:56 2016 New Revision: 269347 URL: http://llvm.org/viewvc/llvm-project?rev=269347=rev Log: [AST] Move operations enum to a definition file. Summary: This patch moves the enum definitions to a definition (.def) file. These modifications provide way to list

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

etienneb added a subscriber: etienneb. Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:38 @@ +37,3 @@ + + void RunSearch(Decl *Declaration) { +auto *Body = Declaration->getBody(); nit: Decl *Declaration -> const Decl *Declaration and other visitor

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

etienneb added a subscriber: etienneb. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:32 @@ +31,3 @@ + + diag(MatchedDecl->getLocStart(), "use using instead of typedef") + << FixItHint::CreateReplacement( I think 'using' should be quote. This message is

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

etienneb added inline comments. Comment at: clang-tidy/utils/TypeTraits.cpp:24 @@ -20,2 +23,3 @@ + bool classHasTrivialCopyAndDestroy(QualType Type) { auto *Record = Type->getAsCXXRecordDecl(); Should this be lifted to 'type_traits' ? The same function

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

etienneb added a subscriber: etienneb. Comment at: clang-tidy/utils/TypeTraits.cpp:35 @@ +34,3 @@ +return false; + for (const CXXConstructorDecl *Constructor : Record->ctors()) { +if (Constructor->isCopyConstructor() && Constructor->isDeleted())

r269334 - [Tooling] Fix broken dependency for shared build

Author: etienneb Date: Thu May 12 14:51:18 2016 New Revision: 269334 URL: http://llvm.org/viewvc/llvm-project?rev=269334=rev Log: [Tooling] Fix broken dependency for shared build Summary: There virtual destructor can't be found and cause a compilation error on a shared build. To repro: [Release

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

etienneb added a subscriber: etienneb. etienneb added a comment. drive by Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:40 @@ +39,3 @@ + unsigned ) { + SourceManager = *Result.SourceManager; + const ASTContext = *Result.Context;

Re: [PATCH] D20218: [Tooling] Fix broken dependency for shared build

etienneb added a comment. note: To repro, you must compile the tests. % ninja check-all http://reviews.llvm.org/D20218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20218: [Tooling] Fix broken dependency for shared build

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. There virtual destructor can't be found and cause a compilation error on a shared build. To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Which

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

etienneb added a subscriber: etienneb. etienneb added a comment. drive-by, some nits. Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:31 @@ +30,3 @@ +void InefficientStringAdditionCheck::registerMatchers(MatchFinder *Finder) { + auto BasicStringType =

Re: [PATCH] D20207: [AST] Move operations enum to a definition file.

etienneb marked an inline comment as done. etienneb added a comment. Comment at: include/clang/AST/OperationKinds.def:15 @@ +14,3 @@ +// +/// @file OperationKinds.def +/// aaron.ballman wrote: > Do we use @file doxygen comments usually? I'm not certain if I've

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb marked 3 inline comments as done. etienneb added a comment. This patch has been modified to support dynamic matchers. It rely on : http://reviews.llvm.org/D20207 Comments? Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102 @@ +101,3 @@ + static clang::CastKind

Re: [PATCH] D20207: [AST] Move operations enum to a definition file.

etienneb updated this revision to Diff 57045. etienneb added a comment. remove incorrect patch upload (sorry) http://reviews.llvm.org/D20207 Files: include/clang/AST/OperationKinds.def include/clang/AST/OperationKinds.h include/clang/module.modulemap lib/AST/Expr.cpp Index:

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

etienneb updated this revision to Diff 57044. etienneb marked an inline comment as done. etienneb added a comment. rebase over AST modifications http://reviews.llvm.org/D19871 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Marshallers.h

Re: [PATCH] D20207: [AST] Move operations enum to a definition file.

etienneb updated this revision to Diff 57043. etienneb added a comment. Herald added a subscriber: klimek. rebase over AST modifications http://reviews.llvm.org/D20207 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Marshallers.h

[PATCH] D20207: [AST] Move operations enum to a definition file.

etienneb created this revision. etienneb added reviewers: klimek, aaron.ballman. etienneb added subscribers: cfe-commits, alexfh, sbenza. This patch moves the enum definitions to a definition (.def) file. These modifications provide way to list enumerator of a given type. As an example, this

[clang-tools-extra] r269275 - [clang-tidy] Improve misc-redundant-expression and decrease false-positive

Author: etienneb Date: Wed May 11 23:32:47 2016 New Revision: 269275 URL: http://llvm.org/viewvc/llvm-project?rev=269275=rev Log: [clang-tidy] Improve misc-redundant-expression and decrease false-positive Summary: This patch is adding support for conditional expression and overloaded operators.

r269274 - Add an AST matcher for string-literal length

Author: etienneb Date: Wed May 11 23:20:04 2016 New Revision: 269274 URL: http://llvm.org/viewvc/llvm-project?rev=269274=rev Log: Add an AST matcher for string-literal length Summary: This patch is adding support for a matcher to check string literal length. This matcher is used in clang-tidy

r269257 - [tooling] Remove redundant inline keyword

Author: etienneb Date: Wed May 11 19:22:28 2016 New Revision: 269257 URL: http://llvm.org/viewvc/llvm-project?rev=269257=rev Log: [tooling] Remove redundant inline keyword Summary: The inline keywords are redundant. Introduce by this commit to try to fix broken build bots:

Re: [PATCH] D20180: [tooling] Fix missing inline keyworkd, breaking build bot.

etienneb added a comment. In http://reviews.llvm.org/D20180#427893, @rnk wrote: > In http://reviews.llvm.org/D20180#427840, @alexfh wrote: > > > `inline` seems to be completely redundant here. Can you try removing it and > > running whatever build configurations were failing without > >

[PATCH] D20189: [tooling] Remove redundant inline keyword

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Herald added a subscriber: klimek. The inline keywords are redundant. Introduce by this commit to try to fix broken build bots: http://reviews.llvm.org/D20180 Tested on Debug and

Re: [PATCH] D20180: [tooling] Fix missing inline keyworkd, breaking build bot.

etienneb added a comment. I'm sure you're right: they are redundant keywords. I'm preparing the revert patch, and I'm running tests over multiple build types. Repository: rL LLVM http://reviews.llvm.org/D20180 ___ cfe-commits mailing list

Re: [PATCH] D20182: [clang-tidy] Add missing dependency of libtooling to misc module

This revision was automatically updated to reflect the committed changes. Closed by commit rL269240: [clang-tidy] Add missing dependency of libtooling to misc module (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20182?vs=56963=56966#toc Repository: rL LLVM

[clang-tools-extra] r269240 - [clang-tidy] Add missing dependency of libtooling to misc module

Author: etienneb Date: Wed May 11 16:32:29 2016 New Revision: 269240 URL: http://llvm.org/viewvc/llvm-project?rev=269240=rev Log: [clang-tidy] Add missing dependency of libtooling to misc module Summary: The new API for fixit is in libtooling and the library misc in clang-tidy didn't had the

[PATCH] D20182: [clang-tidy] Add missing dependency of libtooling to misc module

etienneb created this revision. etienneb added reviewers: alexfh, rnk. etienneb added a subscriber: cfe-commits. The new API for fixit is in libtooling and the library misc in clang-tidy didn't had the appropriate dependency. This commit was breaking some build bots:

Re: [PATCH] D20180: [tooling] Fix missing inline keyworkd, breaking build bot.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269224: [tooling] Fix missing inline keyworkd, breaking build bot. (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20180?vs=56949=56954#toc Repository: rL LLVM

r269224 - [tooling] Fix missing inline keyworkd, breaking build bot.

Author: etienneb Date: Wed May 11 15:09:17 2016 New Revision: 269224 URL: http://llvm.org/viewvc/llvm-project?rev=269224=rev Log: [tooling] Fix missing inline keyworkd, breaking build bot. Summary: The missing keyword "inline" is causing some buildbot to fail. The symbol is not available. see:

[PATCH] D20180: [tooling] Fix missing inline keyworkd, breaking build bot.

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. Herald added a subscriber: klimek. The missing keyword "inline" is causing some buildbot to fail. The symbol is not available. see:

[clang-tools-extra] r269210 - [clang-tidy] Refactoring of FixHintUtils

Author: etienneb Date: Wed May 11 12:38:22 2016 New Revision: 269210 URL: http://llvm.org/viewvc/llvm-project?rev=269210=rev Log: [clang-tidy] Refactoring of FixHintUtils Summary: Refactor some checkers to use the tooling re-writing API. see: http://reviews.llvm.org/D19941 Reviewers: klimek,

  1   2   3   4   >