[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

Hahnfeld added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()

This revision was automatically updated to reflect the committed changes. Closed by commit rGabb9eb2778dc: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D158415?vs=556849&id=557607#toc Repository: rG

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3116d60494f2: [Lex] Introduce Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; v.g.vassilev wrote: > Hahnfeld wrote: > > aaron.ballman wrote: > > > v.g.vassilev wrote: > > > > aaron.ballman wrote: > > > > > Hah

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 557603. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Address minor naming convention nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/Lex/Preproces

[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

Hahnfeld added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556849. Hahnfeld retitled this revision from "[Lex] Handle repl_input_end in Preprocessor::LexAll()" to "[Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()". Hahnfeld added a comment. Rebase on D158413 CHAN

[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

Hahnfeld updated this revision to Diff 556848. Hahnfeld retitled this revision from "[LexerTest] Use LexAll() in StringifyArgs" to "[LexerTest] Use LexTokensUntilEOF() in StringifyArgs". Hahnfeld edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; aaron.ballman wrote: > v.g.vassilev wrote: > > aaron.ballman wrote: > > > Hahnfeld wrote: > > > > aaron.ballman wrote: > > > > > I'

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556834. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Handle all of `tok::unknown, tok::eof, tok::eod`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:998 +std::vector Preprocessor::LexAll() { + std::vector toks; aaron.ballman wrote: > v.g.vassilev wrote: > > Shouldn't we take the results as

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556791. Hahnfeld retitled this revision from "[Lex] Introduce Preprocessor::LexAll()" to "[Lex] Introduce Preprocessor::LexTokensUntilEOF()". Hahnfeld edited the summary of this revision. Hahnfeld added a comment. Rename to `Preprocessor::LexTokensUntilEOF()

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld added a comment. This revision cannot land without https://reviews.llvm.org/D158413 and for that one I really want to have feedback from somebody working in that area... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://re

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c274ba4108b: [clang-repl] Disambiguate declarations with private typedefs (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157838/new/

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld created this revision. Hahnfeld added reviewers: aaron.ballman, v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes many unit tests when trying to enable `IncrementalExtens

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

Hahnfeld created this revision. Hahnfeld added a reviewer: erichkeane. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rely on `Preprocessor::LexAll()` and just replace `tok::comma` by `tok::eof` and p

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Hahnfeld created this revision. Hahnfeld added reviewers: hokein, aaron.ballman. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This new method repeatedly c

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

Hahnfeld added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:94 + // involve namespaces and friend declarations. + if (NextToken().is(tok::identifier)) +return true; v.g.vassilev wrote: > I am wondering what is the

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc861d32d7c27: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. I reverted the change yesterday because the test wasn't passing on Windows, for example https://lab.llvm.org/buildbot/#/builders/216/builds/25769/steps/7/logs/FAIL__Clang__inline-virtual_cpp. The problem is that the JIT cannot find `??_7type_info@@6B@` related to RTTI.

[PATCH] D158252: Fix regression of D157680

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG. IMHO such fixes to the tests can be committed without review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158252/new/ https://review

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld updated this revision to Diff 551401. Hahnfeld added a comment. Disable RTTI to (hopefully) avoid problems on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Interpret

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Hahnfeld added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s 2

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8dadefd4afc: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd43a3d634696: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15737

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb719e410781c: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI. (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ htt

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

Hahnfeld added a comment. I dsabled two tests without `{arm,aarch64}-registered-target` in rGeeac4321c517ee8afc30ebe62c5b1778efc1173d ; two post-commit comments inline Comment at: llvm/test/CodeGen/Generic/

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3fe3ed97bc: [CodeGen] Remove Constant arguments from linkage functions, NFCI. (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld added a comment. ping - this one is the only prerequisite left for three of my patches that were accepted yesterday... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156891/new/ https://reviews.llvm.org/D156891 ___

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGba475a4a3440: [clang-repl] Disambiguate global namespace identifiers (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157480/new/ https

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, rsmith. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Member functions and static variable definitions may use typedefs that are

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Hahnfeld added a comment. gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld added a comment. gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156891/new/ https://reviews.llvm.org/D156891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda555f750ab2: [clang-repl] Additional test for disambiguation of templates (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/global-namespace-disambiguate.cpp:6 +struct A { ~A(); }; +::A::~A() {} + v.g.vassilev wrote: > Can we add this test to `disambiguate-decl-stmt.cpp` instead where we track > these things? done C

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

Hahnfeld updated this revision to Diff 548562. Hahnfeld marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157480/new/ https://reviews.llvm.org/D157480 Files: clang/lib/Parse/ParseTentative.cpp clang/test/Interpreter/disambiguate-decl-stmt.cpp Index: cl

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/namespace-template-disambiguate.cpp:7 +namespace NS2 { struct A { public: using S = int; }; } +namespace NS2 { A::S f(A::S a); } + v.g.vassilev wrote: > It might be a good idea to add this test to

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

Hahnfeld updated this revision to Diff 548558. Hahnfeld retitled this revision from "[clang-repl] Add test for disambiguation of templates" to "[clang-repl] Additional test for disambiguation of templates". Hahnfeld edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A double colon starts an identifier name in the global namespace an

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test case was fixed in commit rG2c4620c1

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. In D156537#4554413 , @v.g.vassilev wrote: > In D156537#4554052 , @Hahnfeld > wrote: > >> @v.g.vassilev do we have a means to detect this case? In D156897 >>

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reemission is only needed in incremental mode. With this early

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. `test/Driver/openmp-offload-jit.c` was still failing for me with CUDA installed, so I pushed rGcb3136b0d3596f5c3984e4fb49359e2a1a28a547 to add an explicit `--cuda-path` and make it return exit code 0

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. @v.g.vassilev do we have a means to detect this case? In D156897 , I'm refactoring all accesses to `EmittedDeferredDecl` to go via `addEmittedDeferredDecl`, so we should just add an early return when not emitting for a REPL. Reposito

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `GlobalDecl`s should only be added to `EmittedDeferredDecl` if

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, efriedma, asl. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was unused since commit rGdd2362a8ba

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. Hi, after this change I have three failing tests: Failed Tests (3): Clang :: Driver/lto.cu Clang :: Driver/openmp-offload-gpu.c Clang :: Driver/openmp-offload-jit.c I have CUDA installed on my system, not sure if a bot is testing this configuration... Cou

[PATCH] D156806: [Modules] Add test for merging of template member parent

This revision was automatically updated to reflect the committed changes. Closed by commit rG99b54743106b: [Modules] Add test for merging of template member parent (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156806/new/ htt

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. The problem is back, but has been fixed upstream by https://reviews.llvm.org/rG61c7a9140becb19c5b1bc644e54452c6f782f5d5. I managed to reduce a test case triggering the assert touched in this revision, see https://reviews.llvm.org/D156806 Repository: rG LLVM Github

[PATCH] D156806: [Modules] Add test for merging of template member parent

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, ChuanqiXu. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a reduced test case originally meant to be addressed by https://revi

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea647dea635: [CodeGen] Assert that EmittedDeferredDecls is empty (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156660/new/ https://

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, junaire, rjmccall. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Its contents are transferred into `DeferredDecls` in `Release()

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

Hahnfeld added a comment. Right, it's not ideal to land APIs without usage in Clang itself... The context is, once again, ROOT and the Cling interpreter (where we are already using this API via downstream patches): When unloading a "transaction" (now `PartialTranslationUnit` in `clang-repl`) we

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, rjmccall, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An inline virtual function must be emitted, but we need t

[PATCH] D156425: [clang-repl] Remove redundant tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac6e9e69bac7: [clang-repl] Remove redundant tests (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D156425: [clang-repl] Remove redundant tests

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They only need to be tested once in `execute.cpp` and `fail.cpp`. Repository:

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

Hahnfeld added a comment. In D154324#4522551 , @alexfh wrote: > BTW, if in a.h I change > > typename std::enable_if<::p::P::value>::type> > > to > > typename std::enable_if::value>::type> > > Compilation succeeds. For the fun of it, could you test ht

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

Hahnfeld added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154328/new/ https://reviews.llvm.org/D154328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

Hahnfeld added a comment. Ok, turns out I had old test binaries around that got automatically picked up by `lit`. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

Hahnfeld added a comment. Hi @tejohnson, I'm seeing crashes after this revision: Failed Tests (2): LLVM-Unit :: Passes/./PluginsTests/0/2 LLVM-Unit :: Passes/./PluginsTests/1/2 A stack trace looks as follows: #0 0x7fba1f899667 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int)

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Hahnfeld added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:786-788 +uint32_t DeclID = ~0U; +unsigned ODRHash = ~0U; +bool IsPartial = false; ChuanqiXu wrote: > Maybe this can save some space. Can you elaborate why this would sa

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Hahnfeld added a comment. In D41416#4487516 , @ChuanqiXu wrote: > But some local in tree tests got failed. I took some time to investigate them > but I didn't get insights : ( If the failures involve template template parameters, please note that you ne

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. In D134813#4482822 , @aaron.ballman wrote: > In D134813#4482819 , @Hahnfeld > wrote: > >> Thanks! Note that the same probably holds true (but I didn't test) for all >> other classes th

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. In D134813#4482808 , @aaron.ballman wrote: > In D134813#4482674 , @Hahnfeld > wrote: > >> Out of curiosity, not sure if it's worth fixing because it's easy enough to >> work around: I

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

Hahnfeld added a comment. Out of curiosity, not sure if it's worth fixing because it's easy enough to work around: I think after this change, it's not possible anymore to call `printName(raw_ostream &OS)` on a (statically typed) `TagDecl` / `EnumDecl` because it's hidden by `TagDecl::printName(

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld abandoned this revision. Hahnfeld added a comment. apparently not needed anymore downstream... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://reviews.llvm.org/D137787 ___ cfe-

[PATCH] D154328: [AST] Add API to iterate already loaded specializations

Hahnfeld created this revision. Hahnfeld added reviewers: erichkeane, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These new functions allow to look at specializations without triggeri

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4458323 , @ChuanqiXu wrote: > In D153003#4456595 , @rsmith wrote: > >> I think the behavior change for the testcase here is correct, though I'm not >> sure that the patch is g

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld abandoned this revision. Hahnfeld added a comment. Ok, I understand that fixing `ODRHash` is the wrong approach for our needs - we'll likely need to implement a custom hashing of template arguments to work as a lookup for lazy loading. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. > We can't say this abstractly. It should be fine to work in ODRHash for C++20 > modules issues as long as we don't lose informations. I honestly don't understand this: For the approach to work, we would need to hash the two cases of an unqualified and a qualified temp

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4427412 , @ChuanqiXu wrote: > An important node here is that ODRHash is used to check the AST Nodes are > keeping the same across compilations. There is gap to use ODRHash to check > the semantical equality. Oh ok..

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. > For example, the template name with QualifiedTemplate kind has different hash > name with the name with DependentTemplate kind. But it is not true after the > patch. Yes, I do understand. However, what I'm asking is why we need to differentiate between the two, ie i

[PATCH] D152995: Remove clang/ModuleInfo.txt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8ff3facc63: Remove clang/ModuleInfo.txt (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4423926 , @ChuanqiXu wrote: > This looks not so good. In this way, we can't disambiguate other template > types. At least we added the kind and a TODO here. Which template name types would we need to disambiguate? We

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld created this revision. Hahnfeld added reviewers: rtrieu, vsapsai, ChuanqiXu, Bigcheese. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For hashing, we should not differentiate between template

[PATCH] D152995: Remove clang/ModuleInfo.txt

Hahnfeld added a comment. Just checking to be sure there is no other use case that the file is used for, but I doubt it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152995/new/ https://reviews.llvm.org/D152995

[PATCH] D152995: Remove clang/ModuleInfo.txt

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The script `build-for-llvm-top.sh` and LLVM's `ModuleInfo.txt` are gone s

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53c03a3db16c: [clang][modules] Add features for recent C++ versions (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

Hahnfeld updated this revision to Diff 523021. Hahnfeld added a comment. > LGTM, but please add a release note when landing. There wasn't a category specific to modules, so I just added two entries for C++20 and C++23 - ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150773/new/ htt

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

Hahnfeld created this revision. Hahnfeld added reviewers: ChuanqiXu, Bigcheese, v.g.vassilev, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `cplusplus20`, `cplusplus23`, and `cplusp

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Hahnfeld abandoned this revision. Hahnfeld added a comment. Linker relaxation and proper alignment handling for RISC-V is implemented in https://reviews.llvm.org/D149526, so this isn't needed anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added a comment. Some comments, but otherwise LGTM Comment at: clang/include/clang/Interpreter/Interpreter.h:43 public: + IncrementalCompilerBuilder(){}; + and this should probably be run through `clang-format`... Comment at: clang

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, sgraenitz, lhames, StephenFan. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Hahnfeld reques

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:296 } + LinkModules.clear(); return false; // success v.g.vassilev wrote: > argentite wrote: > > Hahnfeld wrote: > > > This looks like a change that has implication

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:43-44 public: static llvm::Expected> create(std::vector &ClangArgv); + static llvm::Expected> If I understand the change correctly, the "old" `create` function on it

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. In D146497#4216226 , @aaron.ballman wrote: > The issue doesn't reproduce for me locally on my Windows machine, so it may > be something specific to the VE setup. FWIW I'm not doing anything specific for VE, just set(CMAKE_C

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. FYI this commit breaks `clang/test/Index/index-file.cu` for me: warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] /home/jhahnfel/LLVM/src/clang/test/Inde

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

Hahnfeld reopened this revision. Hahnfeld added a comment. This broke `clang/test/Driver/rocm-detect.hip` on a number of platforms (including the pre-merge checks on this PR), I've reverted for now in b5ee4f755fcff56243f6ff0cea9e7a722259304a

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. In D142196#4077708 , @jansvoboda11 wrote: > Yes, I meant the `pp-trace` docs. Why would "we didn't find the included > file" not be a traceable event? My thinking is the following: If the preprocessor cannot find the included

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I checked a second time and couldn't find other API docs. I've now pushed this change for now (also to get it included in `release/16.x`), but please let me know for any follow-ups. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rG01eb01c7fd7a: [clang][Lex] Add back PPCallbacks::FileNotFound (authored by Hahnfeld). Repository: rG LL

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In D142196#4074249 , @jansvoboda11 wrote: > Also I think we should mention this API in our docs, right where the removed > original used to be. Which API docs are you referring to? I'

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld updated this revision to Diff 491522. Hahnfeld added a comment. Update comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Lex/PPDirectives.cpp clang/unittests/Lex/PPCa

  1   2   3   4   5   6   >