[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. In D96082#2566984 , @steveire wrote: > In D96082#2565339 , @aaron.ballman > wrote: > >> A somewhat similar check that would be interesting is a function that >> returns the same value

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 324132. LukasHanel added a comment. Handle the case of a global variable being the "return value" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/new/ https://reviews.llvm.org/D96082 Files:

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. In D96082#2549943 , @steveire wrote: > In D96082#2545807 , @LukasHanel > wrote: > >> Hi, thanks for discussing my proposal! >> >> - Usefulness of the fix-it's > > I agree with @njames93

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. Hi, thanks for discussing my proposal! Although I think it can stand as is, I was looking for feedback: - Is the name good? - Is the `readability` group good? Or better in `misc`? - too slow, too fast? - More precision required? - Usefulness of the fix-it's - Should

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel marked 9 inline comments as done. LukasHanel added a comment. Thanks for the review! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-useless-return-value.rst:43 +int ret = 0; +return; + } Eugene.Zelenko wrote: > Return is

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 321715. LukasHanel added a comment. Address review comments, fix C++ unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/new/ https://reviews.llvm.org/D96082 Files:

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 321580. LukasHanel edited projects, added clang-tools-extra; removed clang. LukasHanel added a comment. Herald added a project: clang. Add the real changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel created this revision. Herald added subscribers: nullptr.cpp, xazax.hun, mgorny. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96082 Files:

[PATCH] D96080: format

LukasHanel created this revision. Herald added a subscriber: nullptr.cpp. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96080 Files: