[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM marked 2 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:21 -; CHECK: bb.2.bb2: +; CHECK: bb.1.bb: ; CHECK: successors: %bb.4(0x4000), %bb.3(0x4000) dmgreen wrote: >

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM marked 3 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:22 +; CHECK: bb.1.bb2: +; CHECK: successors: %bb.2(0x4000) dmgreen wrote: > I'm not sure this is still checking

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM added a comment. In D118044#3266521 , @DavidSpickett wrote: > Please define what "complex" is, in the commit message and (if it doesn't > make the description a whole paragraph) the command line help. > > Given that we're flipping a

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10977 -Warning(IDLoc, "deprecated instruction in IT block"); - } } DavidSpickett wrote: > Is this warning something you'd still want if you opted

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM added a comment. In D109825#3001622 , @dmgreen wrote: >> As I did the downstream work for this, I'm happy with it to go in in this >> form. > > This doesn't seem.. wise. Please make sure the reviews you do are at a > sufficient quality,

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. As I did the downstream work for this, I'm happy with it to go in in this form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

MarkMurrayARM added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // dmgreen wrote: >

[PATCH] D101606: [ARM] vcreateq lane ordering for big endian

MarkMurrayARM added a comment. Not sure yet. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // Surely there is a

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7cce2fa4d1: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer… (authored by MarkMurrayARM). Repository: rG LLVM Github

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4a8bc417bf: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification… (authored by MarkMurrayARM). Repository: rG LLVM

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM updated this revision to Diff 314579. MarkMurrayARM added a comment. Fixed the parent commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews.llvm.org/D94083 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313700. MarkMurrayARM added a comment. More review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313694. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313678. MarkMurrayARM added a comment. Incorporate reviewer comments. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files:

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM marked 4 inline comments as done. MarkMurrayARM added a comment. Marked addressed comments as "done". Some debug code has been abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 311856. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch upstreams support for the Arm-v8 Cortex-A78C

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6691894ab6: [ARM][AArch64] Adding Neoverse N2 CPU support (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 307083. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306408. MarkMurrayARM added a comment. Address reviewer comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306373. MarkMurrayARM added a comment. Address more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM added a comment. In D91695#2402616 , @tschuett wrote: > The features still differ from gcc. > https://github.com/gcc-mirror/gcc/blob/cb1a4876a0e724ca3962ec14dce9e7819fa72ea5/gcc/config/aarch64/aarch64-cores.def#L146 > It has SVE2_Bitperm.

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM added a comment. In D91695#2402495 , @tschuett wrote: > In the first version N2 had FeatureTME. Did you remove that on purpose? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306063. MarkMurrayARM added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306062. MarkMurrayARM added a comment. Herald added a subscriber: dexonsmith. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files:

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. MarkMurrayARM requested review of this revision. Add support for the Neoverse N2 CPU to the ARM and AArch64 backends. Repository:

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/ https://reviews.llvm.org/D81740

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76490/new/ https://reviews.llvm.org/D76490

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/ https://reviews.llvm.org/D76300

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. I like to use of the macros instead of a huge cross-product of types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76299/new/ https://reviews.llvm.org/D76299

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://reviews.llvm.org/D76298 ___ cfe-commits mailing

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.llvm.org/D76296 ___ cfe-commits mailing

[PATCH] D75165: [ARM,MVE] Add predicated intrinsics for many unary functions.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75165/new/ https://reviews.llvm.org/D75165

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/ https://reviews.llvm.org/D74845

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

MarkMurrayARM added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://reviews.llvm.org/D74838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74331/new/ https://reviews.llvm.org/D74331

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74332/new/ https://reviews.llvm.org/D74332

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. This looks familiar and reassuring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/ https://reviews.llvm.org/D74134

[PATCH] D73268: [ARM,MVE] Make the MVE intrinsics work in C++!

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73268/new/ https://reviews.llvm.org/D73268

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb10a0eb04adf: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics first… (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

MarkMurrayARM updated this revision to Diff 239112. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72830/new/ https://reviews.llvm.org/D72830 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: dmgreen, simon_tatham. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Fix VMINNMAQ, VMAXNMAQ intrinsics; BOTH arguments have the absolute values taken.

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM marked an inline comment as done. MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3658 +// Unpredicated v(max|min)nma +def : Pat<(VTI.Vec (unpred_op (VTI.Vec MQPR:$Qd), (fabs (VTI.Vec MQPR:$Qm, +

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda9d57d2c2dc: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM updated this revision to Diff 238269. MarkMurrayARM added a comment. Much better impementation after review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72761/new/ https://reviews.llvm.org/D72761 Files:

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, miyuki, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics and unit tests. Repository:

[PATCH] D72690: [ARM,MVE] Use the new Tablegen `defvar` and `if` statements.

MarkMurrayARM accepted this revision. MarkMurrayARM added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2464 + defvar pred_int = int_arm_mve_vshll_imm_predicated; + defvar imm= inst_imm.immediateType;

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0eb099273918: [ARM][MVE][Intrinsics] remove extraneous intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71466/new/

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added a reviewer: simon_tatham. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. I overstepped my reach and generated too many intrinsics; these never made it into the tests. Remove these extras. Some

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. Tiny observation of types - fix only if you feel like it. Comment at: clang/include/clang/Basic/arm_mve.td:845 + +let params = [s16, s32] in { +defm vmlaldav : MVEBinaryVectorHoriz64; Types

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2399 + foreach pred_int = [int_arm_mve_vshll_imm_predicated] in + foreach imm = [inst_imm.immediateType]

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. *LIKE* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71335/new/ https://reviews.llvm.org/D71335 ___ cfe-commits mailing list

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3417cb5a9d: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ… (authored by MarkMurrayARM). Changed prior to commit: https://reviews.llvm.org/D71198?vs=232872=232880#toc

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eb61fa5d685: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232872. MarkMurrayARM added a comment. Address review comment delivered out-of-band. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files:

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM marked 2 inline comments as done. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 ___

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232842. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232841. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232827. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232820. MarkMurrayARM added a comment. Fix long lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. This looks scary and fragile, but it seems to work, so OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71062/new/

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen, miyuki. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ

[PATCH] D71190: [ARM][MVE] Add complex vector intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:932 + def "": Intrinsic; + def _predicated: Intrinsic; I like this!!

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71065/new/ https://reviews.llvm.org/D71065

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232367. MarkMurrayARM added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232355. MarkMurrayARM added a comment. Correct name of intrinsics in commit message. D'oh! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files:

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:448 +// for example (u32 x) where x is 0 is transformed into (u32 { 0 }) by the +// Tablegen parser. +def V { See D71066; I just used the numbers bare, so 0 or 1 not (u32

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMULH/VRMULH intrinsics and unit tests. Repository: rG LLVM Github

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3f62ceac0ce: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM updated this revision to Diff 232094. MarkMurrayARM marked an inline comment as done. MarkMurrayARM added a comment. Fix incorrect argument order error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM updated this revision to Diff 232093. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/ https://reviews.llvm.org/D70948 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM marked 3 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3644 +multiclass MVE_VxMULH_m { dmgreen wrote: > Formatting. I took a guess as to what you wanted here. Repository: rG LLVM

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VMULH/VRMULH intrinsics and unit tests. Repository: rG LLVM Github

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG510792a2e0e3: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM marked an inline comment as done. MarkMurrayARM added a comment. Nit terminated with extreme prejudice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM updated this revision to Diff 231664. MarkMurrayARM added a comment. Address whitespace nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM updated this revision to Diff 231540. MarkMurrayARM added a comment. Fix non-predicated floats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM created this revision. Herald added subscribers: llvm-commits, cfe-commits, dmgreen, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics and their predicated versions. Add unit tests. Repository: rG LLVM Github Monorepo

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa048bf87fb65: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics. Add unit… (authored by MarkMurrayARM). Changed prior to commit: https://reviews.llvm.org/D70547?vs=231057=231272#toc

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a8dbe9c458: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics. Remove annoying t1 from VMUL*… (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4bba07b87ce: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics. Add unit tests. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 231057. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM updated this revision to Diff 231056. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70546/new/ https://reviews.llvm.org/D70546 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 231055. MarkMurrayARM added a comment. Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/ https://reviews.llvm.org/D70545 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 231037. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM updated this revision to Diff 231035. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70546/new/ https://reviews.llvm.org/D70546 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 231034. MarkMurrayARM added a comment. Rebase and reupload patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/ https://reviews.llvm.org/D70545 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230896. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230895. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230891. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 230890. MarkMurrayARM added a comment. Merge all VABD intrinis types under T.Usual instead of doing the floats separately. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VMUL intrinsics. Repository: rG LLVM Github Monorepo

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics. Repository: rG LLVM Github

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VABD intrinsics. Repository: rG LLVM Github Monorepo