[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

maryammo added a comment. It looks good to me, just added a minor question as I was not able to verify that. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector")

[PATCH] D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

This revision was automatically updated to reflect the committed changes. Closed by commit rG155abd0678ab: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144611: [PowerPC] Adding test coverage for vector compatibility warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b117aa8149: [PowerPC] Adding test coverage for vector compatibility warning (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to isolate the lax vector conversions warning only for PPC,

[PATCH] D144611: [PowerPC] Adding test coverage for vector compatibility warning

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to test D143210 patch to have the

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG02a71b05fc67: [PowerPC] Include vector bool and pixel when emitting lax warning (authored by maryammo). Changed prior to

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee815ff2ce8d: [PowerPC] Fix the implicit casting for the emulated intrinsics (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo updated this revision to Diff 499273. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144293/new/ https://reviews.llvm.org/D144293 Files: clang/lib/Headers/ppc_wrappers/emmintrin.h

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/smmintrin.h:310 __charmask = vec_gb(__charmask); - __v8hu __shortmask = (__v8hu)vec_unpackh(__charmask); + __v8hu __shortmask = (__v8hu)vec_unpackh((__v16qi)__charmask); #ifdef __BIG_ENDIAN__

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

maryammo created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to fix some implicit castings for emulated intrinsics

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9845 if (anyAltivecTypes(RHSType, LHSType) && -!areSameVectorElemTypes(RHSType, LHSType)) +!Context.areCompatibleVectorTypes(RHSType, LHSType))

[PATCH] D143210: PowerPC] Include vector bool and pixel when emitting lax warning

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to fix some missing lax-vector-conversion warnings including

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b4ed4905017: [PowerPC] Remove the lax warning for explicit casts (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

maryammo updated this revision to Diff 490895. maryammo added a comment. Adding test for template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to remove the erroneous lax vector conversion warning for

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

maryammo added a comment. @kadircet, this commit causes failure on https://lab.llvm.org/buildbot/#/builders/121 which is possible to reproduce locally, can you please take a look? [ 35/111] Linking CXX executable tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

maryammo added a comment. This commit causes build failure on `https://lab.llvm.org/buildbot/#/builders/121/builds/24947` : [43/635] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/Types.cpp.o FAILED:

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437740. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7723 + + if (SrcTy->isVectorType()) { +VectorType::VectorKind SrcVecKind = maryammo wrote: > lei wrote: > > do we really need this check since we have an assert above? > Yes, without

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7723 + + if (SrcTy->isVectorType()) { +VectorType::VectorKind SrcVecKind = lei wrote: > do we really need this check since we have an assert above? Yes, without this check there is

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437317. maryammo added a comment. Fixing unintentional merge from previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files:

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437313. maryammo added a comment. Herald added a subscriber: kbarton. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files:

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437311. maryammo added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437310. maryammo added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437303. maryammo marked an inline comment as not done. maryammo added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files:

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); lei wrote: > maryammo wrote: > > amyk wrote: > > >

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); amyk wrote: > Can we add some brief documentation

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437161. maryammo added a comment. Tune the logic to emit warning when at least one of the vectors is altivec one and overloading resolution is done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 432553. maryammo added a comment. NFC update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is the last prerequisite to switch the default behaviour to

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo added a comment. In D124093#3528639 , @amyk wrote: > I was wondering where are the test cases in this patch. Did they get missed > when updating the revision? The test case's modification were not needed as part of addressing Nemanja's

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo updated this revision to Diff 425086. maryammo added a comment. [PowerPC] Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 Files:

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

maryammo added a comment. It seems it breaks the following builds: https://lab.llvm.org/buildbot/#/builders/121/builds/18618 https://lab.llvm.org/buildbot/#/builders/57/builds/17125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo updated this revision to Diff 424050. maryammo added a comment. [NFC] Fix the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 Files: clang/lib/Headers/altivec.h

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. XL considers different vector types to be incompatible with each

[PATCH] D123300: [Clang] Enable opaque pointers by default

maryammo added a comment. @nikic, it seems breaking the clang-ppc64le-rhel build htps://lab.llvm.org/buildbot/#/builders/57/builds/16776 Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/