Re: [clang] - b26e9e2 - Revert "[static analyzer] Define __clang_analyzer__ macro in driver"

[Mike Edwards via cfe-commits]

Sorry folks, please ignore this email.  I'm working on the GitHub email
hooks.  My apologies for any confusion.

-Mike

On Wed, Oct 16, 2019 at 7:07 PM Jan Korous via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

>
> Author: Jan Korous
> Date: 2019-09-24T03:21:22Z
> New Revision: b26e9e2a8f1865711c4e9b9aa7be712589169b3d
>
> URL:
> https://github.com/llvm/llvm-project/commit/b26e9e2a8f1865711c4e9b9aa7be712589169b3d
> DIFF:
> https://github.com/llvm/llvm-project/commit/b26e9e2a8f1865711c4e9b9aa7be712589169b3d.diff
>
> LOG: Revert "[static analyzer] Define __clang_analyzer__ macro in
> driver"
>
> This reverts commit fbd13570b0d5f92ef2cf6bcfe7cc2f6178500187.
>
> llvm-svn: 372687
>
> Added:
>
>
> Modified:
>clang/lib/Driver/ToolChains/Clang.cpp
>clang/lib/Frontend/InitPreprocessor.cpp
>clang/test/Analysis/misc-ps.m
>
> Removed:
>clang/test/Analysis/misc-driver.c
>
>
>
> 
> diff  --git a/clang/lib/Driver/ToolChains/Clang.cpp
> b/clang/lib/Driver/ToolChains/Clang.cpp
> index 6453af73b0a5..aa17efbee32b 100644
> --- a/clang/lib/Driver/ToolChains/Clang.cpp
> +++ b/clang/lib/Driver/ToolChains/Clang.cpp
> @@ -3896,10 +3896,8 @@ void Clang::ConstructJob(Compilation , const
> JobAction ,
>if (Args.hasArg(options::OPT_municode))
>  CmdArgs.push_back("-DUNICODE");
>
> -  if (isa(JA)) {
> +  if (isa(JA))
>  RenderAnalyzerOptions(Args, CmdArgs, Triple, Input);
> -CmdArgs.push_back("-D__clang_analyzer__");
> -  }
>
>// Enable compatilibily mode to avoid analyzer-config related errors.
>// Since we can't access frontend flags through hasArg, let's manually
> iterate
>
> diff  --git a/clang/lib/Frontend/InitPreprocessor.cpp
> b/clang/lib/Frontend/InitPreprocessor.cpp
> index 9da37e0a446d..95d9f62c6087 100644
> --- a/clang/lib/Frontend/InitPreprocessor.cpp
> +++ b/clang/lib/Frontend/InitPreprocessor.cpp
> @@ -990,6 +990,10 @@ static void InitializePredefinedMacros(const
> TargetInfo ,
>else if (LangOpts.getStackProtector() == LangOptions::SSPReq)
>  Builder.defineMacro("__SSP_ALL__", "3");
>
> +  // Define a macro that exists only when using the static analyzer.
> +  if (FEOpts.ProgramAction == frontend::RunAnalysis)
> +Builder.defineMacro("__clang_analyzer__");
> +
>if (LangOpts.FastRelaxedMath)
>  Builder.defineMacro("__FAST_RELAXED_MATH__");
>
>
> diff  --git a/clang/test/Analysis/misc-driver.c
> b/clang/test/Analysis/misc-driver.c
> deleted file mode 100644
> index f9e7fe373d3c..
> --- a/clang/test/Analysis/misc-driver.c
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -// RUN: %clang --analyze %s
> -
> -#ifndef __clang_analyzer__
> -#error __clang_analyzer__ not defined
> -#endif
>
> diff  --git a/clang/test/Analysis/misc-ps.m b/clang/test/Analysis/misc-ps.m
> index 1cfd2eb1caf2..9a75cfd87b62 100644
> --- a/clang/test/Analysis/misc-ps.m
> +++ b/clang/test/Analysis/misc-ps.m
> @@ -2,6 +2,10 @@
>  // RUN: %clang_analyze_cc1 -triple i386-apple-darwin10
> -analyzer-checker=core,alpha.core,osx.cocoa.AtSync -analyzer-store=region
> -verify -fblocks -Wno-unreachable-code -Wno-null-dereference
> -Wno-objc-root-class %s
>  // RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin10
> -analyzer-checker=core,alpha.core,osx.cocoa.AtSync -analyzer-store=region
> -verify -fblocks -Wno-unreachable-code -Wno-null-dereference
> -Wno-objc-root-class %s
>
> +#ifndef __clang_analyzer__
> +#error __clang_analyzer__ not defined
> +#endif
> +
>  typedef struct objc_ivar *Ivar;
>  typedef struct objc_selector *SEL;
>  typedef signed char BOOL;
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Notice: The buildbot bb.pgr.jp will be suspended within a few days

[Mike Edwards via cfe-commits]

Takumi,
I am very sorry it took me almost 18 months to respond to this note.  I'm
sorry to see you had to shutter bb.pgr.jp.  It was a very helpful resource
to the community.  Thank you very much for your contribution of effort and
resources to make bb.pgr.jp available to the LLVM community for as long as
you were able.  Your efforts are always very much appreciated.

Respectfully,
Mike

On Mon, Nov 20, 2017 at 1:44 AM NAKAMURA Takumi via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:

> Due to resource issue, I have to terminate it. As you know, it has been
> working for several years and I am certain it has been useful and helpful
> to guys.
> I am not sure whether I could restart it or not.
> I loved it.
>
> Thank you,
> Takumi Nakamura
> ___
> llvm-commits mailing list
> llvm-comm...@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r338098 - [WWW] Fixing file permissions for the .html pages.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Thu Jul 26 21:41:37 2018
New Revision: 338098

URL: http://llvm.org/viewvc/llvm-project?rev=338098=rev
Log:
[WWW] Fixing file permissions for the .html pages.

Modified:
cfe/trunk/www/OpenProjects.html   (props changed)
cfe/trunk/www/UniversalDriver.html   (props changed)
cfe/trunk/www/clang_video-05-25-2007.html   (props changed)
cfe/trunk/www/clang_video-07-25-2007.html   (props changed)
cfe/trunk/www/comparison.html   (props changed)
cfe/trunk/www/compatibility.html   (props changed)
cfe/trunk/www/cxx_compatibility.html   (props changed)
cfe/trunk/www/cxx_dr_status.html   (props changed)
cfe/trunk/www/cxx_status.html   (props changed)
cfe/trunk/www/diagnostics.html   (props changed)
cfe/trunk/www/features.html   (props changed)
cfe/trunk/www/get_involved.html   (props changed)
cfe/trunk/www/get_started.html   (props changed)
cfe/trunk/www/hacking.html   (props changed)
cfe/trunk/www/index.html   (props changed)
cfe/trunk/www/related.html   (props changed)

Propchange: cfe/trunk/www/OpenProjects.html
--
svn:executable = *

Propchange: cfe/trunk/www/UniversalDriver.html
--
svn:executable = *

Propchange: cfe/trunk/www/clang_video-05-25-2007.html
--
svn:executable = *

Propchange: cfe/trunk/www/clang_video-07-25-2007.html
--
svn:executable = *

Propchange: cfe/trunk/www/comparison.html
--
svn:executable = *

Propchange: cfe/trunk/www/compatibility.html
--
svn:executable = *

Propchange: cfe/trunk/www/cxx_compatibility.html
--
svn:executable = *

Propchange: cfe/trunk/www/cxx_dr_status.html
--
svn:executable = *

Propchange: cfe/trunk/www/cxx_status.html
--
svn:executable = *

Propchange: cfe/trunk/www/diagnostics.html
--
svn:executable = *

Propchange: cfe/trunk/www/features.html
--
svn:executable = *

Propchange: cfe/trunk/www/get_involved.html
--
svn:executable = *

Propchange: cfe/trunk/www/get_started.html
--
svn:executable = *

Propchange: cfe/trunk/www/hacking.html
--
svn:executable = *

Propchange: cfe/trunk/www/index.html
--
svn:executable = *

Propchange: cfe/trunk/www/related.html
--
svn:executable = *


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r338087 - [WWW] Removing my test file as the auto-deployment script has been fixed.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Thu Jul 26 16:29:54 2018
New Revision: 338087

URL: http://llvm.org/viewvc/llvm-project?rev=338087=rev
Log:
[WWW] Removing my test file as the auto-deployment script has been fixed.

Removed:
cfe/trunk/www/test.html

Removed: cfe/trunk/www/test.html
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/www/test.html?rev=338086=auto
==
--- cfe/trunk/www/test.html (original)
+++ cfe/trunk/www/test.html (removed)
@@ -1,6 +0,0 @@
-
-
-
-Hello World!
-
-


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r338086 - [WWW] Adding a test page to work out an auto-deployment issue.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Thu Jul 26 16:23:40 2018
New Revision: 338086

URL: http://llvm.org/viewvc/llvm-project?rev=338086=rev
Log:
[WWW] Adding a test page to work out an auto-deployment issue.

Added:
cfe/trunk/www/test.html

Added: cfe/trunk/www/test.html
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/www/test.html?rev=338086=auto
==
--- cfe/trunk/www/test.html (added)
+++ cfe/trunk/www/test.html Thu Jul 26 16:23:40 2018
@@ -0,0 +1,6 @@
+
+
+
+Hello World!
+
+


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Fwd: [llvm-dev] [LLVM.ORG] Scheduled Restart of llvm.org services Saturday 2018-07-21 @ 20:00PDT

[Mike Edwards via cfe-commits]

-- Forwarded message --
From: Mike Edwards 
Date: Sat, Jul 21, 2018 at 8:32 PM
Subject: Re: [llvm-dev] [LLVM.ORG] Scheduled Restart of llvm.org services
Saturday 2018-07-21 @ 20:00PDT
To: llvm-dev 


Hello,
The system update and restart of the llvm.org servers has been completed
successfully.  All systems appear to be back online and processing tasks
normally.  Thank for your patience and cooperation.  We hope you enjoy the
rest of your evening and weekend.

Respectfully,
Mike Edwards

On Thu, Jul 19, 2018 at 10:09 AM, Mike Edwards  wrote:

> Tl;dr: LLVM.org services will be restarted Saturday July 21, 2018 @
> 20:00PDT.
>
> Hi,
> We will be applying security updates to the llvm.org
>  servers on Saturday July 21st.  As a result we
> will need to restart the server at 20:00PDT.  The restart should only take
> a few minutes.  This server provides the following services to the
> community:
>
> * llvm.org website services
> * mailing list services
> * svn services
>
> We hope to have everything back up and running at or before 21:00PDT.  A
> follow up notification will be sent once the restart has been completed and
> the server is back online.  We understand this is a disruptive restart and
> we thank you for your patience and cooperation.
>
> Respectfully,
> Mike Edwards
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r333498 - Sema: Add a flag for rejecting member pointers with incomplete base types.

[Mike Edwards via cfe-commits]

Ah, sorry I just saw 333501 and this already passed on the bot.  All green
again.  Thanks for the quick patch, sorry for the noise.

-Mike

On Tue, May 29, 2018 at 9:33 PM, Mike Edwards  wrote:

> Hi Peter,
> Would you please have a look at:
> http://green.lab.llvm.org/green/job/clang-stage1-cmake-
> RA-incremental/48945/
>
> It looks like this commit cause a test failure on the Green Dragon
> Incremental Builder.
>
> Thanks,
> Mike
>
> On Tue, May 29, 2018 at 8:40 PM, Peter Collingbourne via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: pcc
>> Date: Tue May 29 20:40:04 2018
>> New Revision: 333498
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=333498=rev
>> Log:
>> Sema: Add a flag for rejecting member pointers with incomplete base types.
>>
>> Codebases that need to be compatible with the Microsoft ABI can pass
>> this flag to avoid issues caused by the lack of a fixed ABI for
>> incomplete member pointers.
>>
>> Differential Revision: https://reviews.llvm.org/D47503
>>
>> Added:
>> cfe/trunk/test/Driver/complete-member-pointers.cpp
>> cfe/trunk/test/SemaCXX/complete-member-pointers.cpp
>> Modified:
>> cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>> cfe/trunk/include/clang/Basic/LangOptions.def
>> cfe/trunk/include/clang/Driver/Options.td
>> cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>> cfe/trunk/lib/Sema/SemaType.cpp
>>
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/
>> Basic/DiagnosticSemaKinds.td?rev=333498=333497=333498=diff
>> 
>> ==
>> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue May 29
>> 20:40:04 2018
>> @@ -6350,6 +6350,8 @@ def err_bad_memptr_rhs : Error<
>>  def err_bad_memptr_lhs : Error<
>>"left hand operand to %0 must be a %select{|pointer to }1class "
>>"compatible with the right hand operand, but is %2">;
>> +def err_memptr_incomplete : Error<
>> +  "member pointer has incomplete base type %0">;
>>  def warn_exception_caught_by_earlier_handler : Warning<
>>"exception of type %0 will be caught by earlier handler">,
>>InGroup;
>>
>> Modified: cfe/trunk/include/clang/Basic/LangOptions.def
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/
>> Basic/LangOptions.def?rev=333498=333497=333498=diff
>> 
>> ==
>> --- cfe/trunk/include/clang/Basic/LangOptions.def (original)
>> +++ cfe/trunk/include/clang/Basic/LangOptions.def Tue May 29 20:40:04
>> 2018
>> @@ -247,6 +247,10 @@ ENUM_LANGOPT(AddressSpaceMapMangling , A
>>  LANGOPT(IncludeDefaultHeader, 1, 0, "Include default header file for
>> OpenCL")
>>  BENIGN_LANGOPT(DelayedTemplateParsing , 1, 0, "delayed template
>> parsing")
>>  LANGOPT(BlocksRuntimeOptional , 1, 0, "optional blocks runtime")
>> +LANGOPT(
>> +CompleteMemberPointers, 1, 0,
>> +"Require member pointer base types to be complete at the point where
>> the "
>> +"type's inheritance model would be determined under the Microsoft
>> ABI")
>>
>>  ENUM_LANGOPT(GC, GCMode, 2, NonGC, "Objective-C Garbage Collection mode")
>>  ENUM_LANGOPT(ValueVisibilityMode, Visibility, 3, DefaultVisibility,
>>
>> Modified: cfe/trunk/include/clang/Driver/Options.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/
>> Driver/Options.td?rev=333498=333497=333498=diff
>> 
>> ==
>> --- cfe/trunk/include/clang/Driver/Options.td (original)
>> +++ cfe/trunk/include/clang/Driver/Options.td Tue May 29 20:40:04 2018
>> @@ -782,6 +782,12 @@ def fcomment_block_commands : CommaJoine
>>  def fparse_all_comments : Flag<["-"], "fparse-all-comments">,
>> Group, Flags<[CC1Option]>;
>>  def fcommon : Flag<["-"], "fcommon">, Group;
>>  def fcompile_resource_EQ : Joined<["-"], "fcompile-resource=">,
>> Group;
>> +def fcomplete_member_pointers : Flag<["-"],
>> "fcomplete-member-pointers">, Group,
>> +   Flags<[CoreOption, CC1Option]>,
>> +   HelpText<"Require member pointer base types to be complete if they
>> would be significant under the Microsoft ABI">;
>> +def fno_complete_member_pointers : Flag<["-"],
>> "fno-complete-member-pointers">, Group,
>> +   Flags<[CoreOption]>,
>> +   HelpText<"Do not require member pointer base types to be complete if
>> they would be significant under the Microsoft ABI">;
>>  def fconstant_cfstrings : Flag<["-"], "fconstant-cfstrings">,
>> Group;
>>  def fconstant_string_class_EQ : Joined<["-"],
>> "fconstant-string-class=">, Group;
>>  def fconstexpr_depth_EQ : Joined<["-"], "fconstexpr-depth=">,
>> Group;
>>
>> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> URL: 

Re: r333498 - Sema: Add a flag for rejecting member pointers with incomplete base types.

[Mike Edwards via cfe-commits]

Hi Peter,
Would you please have a look at:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/48945/

It looks like this commit cause a test failure on the Green Dragon
Incremental Builder.

Thanks,
Mike

On Tue, May 29, 2018 at 8:40 PM, Peter Collingbourne via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: pcc
> Date: Tue May 29 20:40:04 2018
> New Revision: 333498
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333498=rev
> Log:
> Sema: Add a flag for rejecting member pointers with incomplete base types.
>
> Codebases that need to be compatible with the Microsoft ABI can pass
> this flag to avoid issues caused by the lack of a fixed ABI for
> incomplete member pointers.
>
> Differential Revision: https://reviews.llvm.org/D47503
>
> Added:
> cfe/trunk/test/Driver/complete-member-pointers.cpp
> cfe/trunk/test/SemaCXX/complete-member-pointers.cpp
> Modified:
> cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
> cfe/trunk/include/clang/Basic/LangOptions.def
> cfe/trunk/include/clang/Driver/Options.td
> cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> cfe/trunk/lib/Frontend/CompilerInvocation.cpp
> cfe/trunk/lib/Sema/SemaType.cpp
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/
> DiagnosticSemaKinds.td?rev=333498=333497=333498=diff
> 
> ==
> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue May 29
> 20:40:04 2018
> @@ -6350,6 +6350,8 @@ def err_bad_memptr_rhs : Error<
>  def err_bad_memptr_lhs : Error<
>"left hand operand to %0 must be a %select{|pointer to }1class "
>"compatible with the right hand operand, but is %2">;
> +def err_memptr_incomplete : Error<
> +  "member pointer has incomplete base type %0">;
>  def warn_exception_caught_by_earlier_handler : Warning<
>"exception of type %0 will be caught by earlier handler">,
>InGroup;
>
> Modified: cfe/trunk/include/clang/Basic/LangOptions.def
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/
> clang/Basic/LangOptions.def?rev=333498=333497=333498=diff
> 
> ==
> --- cfe/trunk/include/clang/Basic/LangOptions.def (original)
> +++ cfe/trunk/include/clang/Basic/LangOptions.def Tue May 29 20:40:04 2018
> @@ -247,6 +247,10 @@ ENUM_LANGOPT(AddressSpaceMapMangling , A
>  LANGOPT(IncludeDefaultHeader, 1, 0, "Include default header file for
> OpenCL")
>  BENIGN_LANGOPT(DelayedTemplateParsing , 1, 0, "delayed template parsing")
>  LANGOPT(BlocksRuntimeOptional , 1, 0, "optional blocks runtime")
> +LANGOPT(
> +CompleteMemberPointers, 1, 0,
> +"Require member pointer base types to be complete at the point where
> the "
> +"type's inheritance model would be determined under the Microsoft
> ABI")
>
>  ENUM_LANGOPT(GC, GCMode, 2, NonGC, "Objective-C Garbage Collection mode")
>  ENUM_LANGOPT(ValueVisibilityMode, Visibility, 3, DefaultVisibility,
>
> Modified: cfe/trunk/include/clang/Driver/Options.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/
> clang/Driver/Options.td?rev=333498=333497=333498=diff
> 
> ==
> --- cfe/trunk/include/clang/Driver/Options.td (original)
> +++ cfe/trunk/include/clang/Driver/Options.td Tue May 29 20:40:04 2018
> @@ -782,6 +782,12 @@ def fcomment_block_commands : CommaJoine
>  def fparse_all_comments : Flag<["-"], "fparse-all-comments">,
> Group, Flags<[CC1Option]>;
>  def fcommon : Flag<["-"], "fcommon">, Group;
>  def fcompile_resource_EQ : Joined<["-"], "fcompile-resource=">,
> Group;
> +def fcomplete_member_pointers : Flag<["-"], "fcomplete-member-pointers">,
> Group,
> +   Flags<[CoreOption, CC1Option]>,
> +   HelpText<"Require member pointer base types to be complete if they
> would be significant under the Microsoft ABI">;
> +def fno_complete_member_pointers : Flag<["-"],
> "fno-complete-member-pointers">, Group,
> +   Flags<[CoreOption]>,
> +   HelpText<"Do not require member pointer base types to be complete if
> they would be significant under the Microsoft ABI">;
>  def fconstant_cfstrings : Flag<["-"], "fconstant-cfstrings">,
> Group;
>  def fconstant_string_class_EQ : Joined<["-"], "fconstant-string-class=">,
> Group;
>  def fconstexpr_depth_EQ : Joined<["-"], "fconstexpr-depth=">,
> Group;
>
> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/
> ToolChains/Clang.cpp?rev=333498=333497=333498=diff
> 
> ==
> --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)
> +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Tue May 29 20:40:04 2018
> @@ -4784,6 +4784,10 @@ void 

[clang-tools-extra] r328997 - Revert r328932 as it caused Windows and MacOS bot failures.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Mon Apr  2 11:02:36 2018
New Revision: 328997

URL: http://llvm.org/viewvc/llvm-project?rev=328997=rev
Log:
Revert r328932 as it caused Windows and MacOS bot failures.

http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/43991/

Removed:

clang-tools-extra/trunk/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp

Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp?rev=328997=328996=328997=diff
==
--- clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Mon Apr  2 11:02:36 2018
@@ -481,16 +481,6 @@ void runClangTidy(clang::tidy::ClangTidy
   ClangTool Tool(Compilations, InputFiles,
  std::make_shared(), BaseFS);
 
-  // Add __clang_analyzer__ macro definition for compatibility with the clang
-  // static analyzer.
-  ArgumentsAdjuster ClangTidyMacroDefinitionInserter =
-  [](const CommandLineArguments , StringRef Filename) {
-ClangTidyOptions Opts = Context.getOptionsForFile(Filename);
-CommandLineArguments AdjustedArgs = Args;
-AdjustedArgs.emplace_back("-D__clang_analyzer__");
-return AdjustedArgs;
-  };
-
   // Add extra arguments passed by the clang-tidy command-line.
   ArgumentsAdjuster PerFileExtraArgumentsInserter =
   [](const CommandLineArguments , StringRef Filename) {
@@ -525,7 +515,6 @@ void runClangTidy(clang::tidy::ClangTidy
 return AdjustedArgs;
   };
 
-  Tool.appendArgumentsAdjuster(ClangTidyMacroDefinitionInserter);
   Tool.appendArgumentsAdjuster(PerFileExtraArgumentsInserter);
   Tool.appendArgumentsAdjuster(PluginArgumentsRemover);
   if (Profile)

Removed: 
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp?rev=328996=auto
==
--- 
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp 
(original)
+++ 
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp 
(removed)
@@ -1,8 +0,0 @@
-// RUN: %check_clang_tidy %s * %t
-
-#if defined(__clang_analyzer__)
-#warning __clang_analyzer__ is defined
-#endif
-// CHECK-MESSAGES: :[[@LINE-2]]:2: warning: __clang_analyzer__ is defined 
[clang-diagnostic-#warnings]
-
-


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r327304 - [libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail.cpp.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Mon Mar 12 11:06:37 2018
New Revision: 327304

URL: http://llvm.org/viewvc/llvm-project?rev=327304=rev
Log:
[libcxx][test] Adding apple-clang-9 to UNSUPPORTED in 
iter_alloc_deduction.fail.cpp.


After two failed attempts last week to make this work I am
going back to a known good method of making this test pass on
macOS...adding the current apple-clang version to the
UNSUPPORTED list.

During a previous patch review (https://reviews.llvm.org/D44103)
it was suggested to just XFAIL libcpp-no-deduction-guides
as was done to iter_alloc_deduction.pass.cpp. However
this caused a an unexpected pass on:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-gcc-tot-latest-std/builds/214

I then attempted to just mark libcpp-no-deduction-guides
as UNSUPPORTED, however this caused an additional bot
failure.  So I reverted everything (https://reviews.llvm.org/rCXX327191).

To solve this and get work unblocked I am adding
apple-clang-9 to the original UNSUPPORTED list.


Modified:

libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

Modified: 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp?rev=327304=327303=327304=diff
==
--- 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 (original)
+++ 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 Mon Mar 12 11:06:37 2018
@@ -10,7 +10,7 @@
 // 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, 
clang-3.8, clang-3.9, clang-4.0
-// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0
+// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0, apple-clang-9
 
 // template::value_type>>


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r327191 - [libcxx][test] Reverting r327178 and r327190.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Fri Mar  9 16:53:05 2018
New Revision: 327191

URL: http://llvm.org/viewvc/llvm-project?rev=327191=rev
Log:
[libcxx][test] Reverting r327178 and r327190.

Reverting changes made to iter_alloc_deduction.fail.cpp
as my changes seem to be making several Linux bots angry.


Modified:

libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

Modified: 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp?rev=327191=327190=327191=diff
==
--- 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 (original)
+++ 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 Fri Mar  9 16:53:05 2018
@@ -9,7 +9,8 @@
 
 // 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// UNSUPPORTED: libcpp-no-deduction-guides
+// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, 
clang-3.8, clang-3.9, clang-4.0
+// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0
 
 // template::value_type>>


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r327190 - [libcxx][test] Marking libcpp-no-deduction-guides unsupported.

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Fri Mar  9 16:19:25 2018
New Revision: 327190

URL: http://llvm.org/viewvc/llvm-project?rev=327190=rev
Log:
[libcxx][test] Marking libcpp-no-deduction-guides unsupported.


This fixes linux bot failures with r327178.


Modified:

libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

Modified: 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp?rev=327190=327189=327190=diff
==
--- 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 (original)
+++ 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 Fri Mar  9 16:19:25 2018
@@ -9,7 +9,7 @@
 
 // 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: libcpp-no-deduction-guides
+// UNSUPPORTED: libcpp-no-deduction-guides
 
 // template::value_type>>


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r327178 - XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Fri Mar  9 14:13:12 2018
New Revision: 327178

URL: http://llvm.org/viewvc/llvm-project?rev=327178=rev
Log:
XFAIL: libcpp-no-deduction-guides in 
libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

Summary: Refactor the previous version method of marking each apple-clang 
version as UNSUPPORTED and just XFAIL'ing the libcpp-no-deduction-guides 
instead.  This brings this test inline with the same style as 
iter_alloc_deduction.pass.cpp

Reviewers: EricWF, dexonsmith

Reviewed By: EricWF

Subscribers: EricWF, vsapsai, vsk, cfe-commits

Differential Revision: https://reviews.llvm.org/D44103

Modified:

libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

Modified: 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp?rev=327178=327177=327178=diff
==
--- 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 (original)
+++ 
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
 Fri Mar  9 14:13:12 2018
@@ -9,8 +9,7 @@
 
 // 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, 
clang-3.8, clang-3.9, clang-4.0
-// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0
+// XFAIL: libcpp-no-deduction-guides
 
 // template::value_type>>


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D44103: Adding additional UNSUPPORTED platform in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[Mike Edwards via cfe-commits]

Eric,
Any chance you could have one more look at this and let me know if the
patch is acceptable?

Thanks,
Mike

On Mon, Mar 5, 2018 at 4:16 PM, Mike Edwards via Phabricator <
revi...@reviews.llvm.org> wrote:

> sqlbyme updated this revision to Diff 137104.
> sqlbyme added a comment.
>
> I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/
> 6878e852d1d26cca0abee3013822311cd894ca3e.  I have tested this on our bots
> and the fix works fine.
>
>
> https://reviews.llvm.org/D44103
>
> Files:
>   test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
>
>
> Index: test/std/strings/basic.string/string.cons/iter_alloc_
> deduction.fail.cpp
> ===
> --- test/std/strings/basic.string/string.cons/iter_alloc_
> deduction.fail.cpp
> +++ test/std/strings/basic.string/string.cons/iter_alloc_
> deduction.fail.cpp
> @@ -9,8 +9,7 @@
>
>  // 
>  // UNSUPPORTED: c++98, c++03, c++11, c++14
> -// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,
> clang-3.8, clang-3.9, clang-4.0
> -// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0
> +// XFAIL: libcpp-no-deduction-guides
>
>  // template  //  class Allocator = allocator iterator_traits::value_type>>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r318600 - [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

[Mike Edwards via cfe-commits]

Hi,
We are seeing a bot failure with this commit.  Please see the bot page here:
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/5470/consoleFull#17462642768254eaf0-7326-4999-85b0-388101f2d404

Please let me know if you will be able to provide a patch for this in the
next couple of hours, otherwise I will need to revert your commit.  Thank
you for your assistance in keeping our bots green.

Respectfully,
Mike Edwards

On Sat, Nov 18, 2017 at 11:48 AM, Jonas Toth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: jonastoth
> Date: Sat Nov 18 11:48:33 2017
> New Revision: 318600
>
> URL: http://llvm.org/viewvc/llvm-project?rev=318600=rev
> Log:
> [clang-tidy] Add new hicpp-multiway-paths-covered check for missing
> branches
>
> Summary:
> This check searches for missing `else` branches in `if-else if`-chains and
> missing `default` labels in `switch` statements, that use integers as
> condition.
>
> It is very similar to -Wswitch, but concentrates on integers only, since
> enums are
> already covered.
>
> The option to warn for missing `else` branches is deactivated by default,
> since it is
> very noise on larger code bases.
>
> Running it on LLVM:
> {F5354858} for default configuration
> {F5354866} just for llvm/lib/Analysis/ScalarEvolution.cpp, the else-path
> checker is very noisy!
>
> Reviewers: alexfh, aaron.ballman, hokein
>
> Reviewed By: aaron.ballman
>
> Subscribers: lebedev.ri, Eugene.Zelenko, cfe-commits, mgorny,
> JDevlieghere, xazax.hun
>
> Tags: #clang-tools-extra
>
> Differential Revision: https://reviews.llvm.org/D37808
>
>
> Added:
> clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp
> clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.h
> clang-tools-extra/trunk/docs/clang-tidy/checks/hicpp-
> multiway-paths-covered.rst
> clang-tools-extra/trunk/test/clang-tidy/hicpp-multiway-
> paths-covered-else.cpp
> clang-tools-extra/trunk/test/clang-tidy/hicpp-multiway-
> paths-covered.cpp
> Modified:
> clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt
> clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp
> clang-tools-extra/trunk/docs/ReleaseNotes.rst
> clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
>
> Modified: clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/
> trunk/clang-tidy/hicpp/CMakeLists.txt?rev=318600=
> 318599=318600=diff
> 
> ==
> --- clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt Sat Nov 18
> 11:48:33 2017
> @@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS support)
>
>  add_clang_library(clangTidyHICPPModule
>ExceptionBaseclassCheck.cpp
> +  MultiwayPathsCoveredCheck.cpp
>NoAssemblerCheck.cpp
>HICPPTidyModule.cpp
>SignedBitwiseCheck.cpp
>
> Modified: clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/
> trunk/clang-tidy/hicpp/HICPPTidyModule.cpp?rev=318600=318599=318600&
> view=diff
> 
> ==
> --- clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp
> (original)
> +++ clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp Sat Nov
> 18 11:48:33 2017
> @@ -35,6 +35,7 @@
>  #include "../readability/FunctionSizeCheck.h"
>  #include "../readability/IdentifierNamingCheck.h"
>  #include "ExceptionBaseclassCheck.h"
> +#include "MultiwayPathsCoveredCheck.h"
>  #include "NoAssemblerCheck.h"
>  #include "SignedBitwiseCheck.h"
>
> @@ -53,6 +54,8 @@ public:
>  "hicpp-exception-baseclass");
>  CheckFactories.registerCheck(
>  "hicpp-signed-bitwise");
> +CheckFactories.registerCheck(
> +"hicpp-multiway-paths-covered");
>  CheckFactories.registerCheck(
>  "hicpp-explicit-conversions");
>  CheckFactories.registerCheck(
>
> Added: clang-tools-extra/trunk/clang-tidy/hicpp/
> MultiwayPathsCoveredCheck.cpp
> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/
> trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp?rev=318600=auto
> 
> ==
> --- clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp
> (added)
> +++ clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp
> Sat Nov 18 11:48:33 2017
> @@ -0,0 +1,179 @@
> +//===--- MultiwayPathsCoveredCheck.cpp - clang-tidy
> ===//
> +//
> +// The LLVM Compiler Infrastructure
> +//
> +// This file is distributed under the University of Illinois Open Source
> +// License. See LICENSE.TXT for details.
> +//
> +//===--
> ===//
> +
> +#include "MultiwayPathsCoveredCheck.h"
> +#include 

Re: r313082 - [Driver] MinGW: Remove custom linker detection

[Mike Edwards via cfe-commits]

Hi,
Would you please have a look at:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/42380/

it appears this commit is causing some tests to fail on our bots.  Any
assistance you may provide in getting the bots back green would be greatly
appreciated.

Respectfully,
Mike Edwards

On Tue, Sep 12, 2017 at 3:14 PM, Martell Malone via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: martell
> Date: Tue Sep 12 15:14:18 2017
> New Revision: 313082
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313082=rev
> Log:
> [Driver] MinGW: Remove custom linker detection
>
> In rL289668 the ability to specify the default linker at compile time
> was added but because the MinGW driver used custom detection we could
> not take advantage of this new CMAKE flag CLANG_DEFAULT_LINKER.
>
> Modified:
> cfe/trunk/lib/Driver/ToolChains/MinGW.cpp
> cfe/trunk/test/Driver/mingw-useld.c
>
> Modified: cfe/trunk/lib/Driver/ToolChains/MinGW.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/
> ToolChains/MinGW.cpp?rev=313082=313081=313082=diff
> 
> ==
> --- cfe/trunk/lib/Driver/ToolChains/MinGW.cpp (original)
> +++ cfe/trunk/lib/Driver/ToolChains/MinGW.cpp Tue Sep 12 15:14:18 2017
> @@ -104,14 +104,6 @@ void tools::MinGW::Linker::ConstructJob(
>// handled somewhere else.
>Args.ClaimAllArgs(options::OPT_w);
>
> -  StringRef LinkerName = Args.getLastArgValue(options::OPT_fuse_ld_EQ,
> "ld");
> -  if (LinkerName.equals_lower("lld")) {
> -CmdArgs.push_back("-flavor");
> -CmdArgs.push_back("gnu");
> -  } else if (!LinkerName.equals_lower("ld")) {
> -D.Diag(diag::err_drv_unsupported_linker) << LinkerName;
> -  }
> -
>if (!D.SysRoot.empty())
>  CmdArgs.push_back(Args.MakeArgString("--sysroot=" + D.SysRoot));
>
> @@ -241,7 +233,7 @@ void tools::MinGW::Linker::ConstructJob(
>
>if (Args.hasArg(options::OPT_static))
>  CmdArgs.push_back("--end-group");
> -  else if (!LinkerName.equals_lower("lld"))
> +  else
>  AddLibGCC(Args, CmdArgs);
>  }
>
> @@ -252,7 +244,7 @@ void tools::MinGW::Linker::ConstructJob(
>CmdArgs.push_back(Args.MakeArgString(TC.GetFilePath("crtend.o")));
>  }
>}
> -  const char *Exec = Args.MakeArgString(TC.GetProgramPath(LinkerName.
> data()));
> +  const char *Exec = Args.MakeArgString(TC.GetLinkerPath());
>C.addCommand(llvm::make_unique(JA, *this, Exec, CmdArgs,
> Inputs));
>  }
>
>
> Modified: cfe/trunk/test/Driver/mingw-useld.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/
> mingw-useld.c?rev=313082=313081=313082=diff
> 
> ==
> --- cfe/trunk/test/Driver/mingw-useld.c (original)
> +++ cfe/trunk/test/Driver/mingw-useld.c Tue Sep 12 15:14:18 2017
> @@ -1,19 +1,19 @@
> -// RUN: %clang -### -target i686-pc-windows-gnu 
> --sysroot=%S/Inputs/mingw_clang_tree/mingw32
> %s 2>&1 | FileCheck -check-prefix=CHECK_LD_32 %s
> -// CHECK_LD_32: ld{{(.exe)?}}"
> +// RUN: %clang -### -target i686-pc-windows-gnu 
> --sysroot=%S/Inputs/mingw_clang_tree/mingw32
> %s -fuse-ld=platform 2>&1 | FileCheck -check-prefix=CHECK_LD_32 %s
> +// CHECK_LD_32: "{{[^"]*}}ld{{(.exe)?}}"
>  // CHECK_LD_32: "i386pe"
> -// CHECK_LD_32-NOT: "-flavor" "gnu"
> +// CHECK_LD_32-NOT: "{{[^"]*}}ld.lld{{(.exe)?}}"
>
>  // RUN: %clang -### -target i686-pc-windows-gnu 
> --sysroot=%S/Inputs/mingw_clang_tree/mingw32
> %s -fuse-ld=lld 2>&1 | FileCheck -check-prefix=CHECK_LLD_32 %s
>  // CHECK_LLD_32-NOT: invalid linker name in argument
> -// CHECK_LLD_32: lld{{(.exe)?}}" "-flavor" "gnu"
> +// CHECK_LLD_32: "{{[^"]*}}ld.lld{{(.exe)?}}"
>  // CHECK_LLD_32: "i386pe"
>
>  // RUN: %clang -### -target x86_64-pc-windows-gnu
> --sysroot=%S/Inputs/mingw_clang_tree/mingw32 %s -fuse-ld=lld 2>&1 |
> FileCheck -check-prefix=CHECK_LLD_64 %s
>  // CHECK_LLD_64-NOT: invalid linker name in argument
> -// CHECK_LLD_64: lld{{(.exe)?}}" "-flavor" "gnu"
> +// CHECK_LLD_64: "{{[^"]*}}ld.lld{{(.exe)?}}"
>  // CHECK_LLD_64: "i386pep"
>
>  // RUN: %clang -### -target arm-pc-windows-gnu 
> --sysroot=%S/Inputs/mingw_clang_tree/mingw32
> %s -fuse-ld=lld 2>&1 | FileCheck -check-prefix=CHECK_LLD_ARM %s
>  // CHECK_LLD_ARM-NOT: invalid linker name in argument
> -// CHECK_LLD_ARM: lld{{(.exe)?}}" "-flavor" "gnu"
> +// CHECK_LLD_ARM: "{{[^"]*}}ld.lld{{(.exe)?}}"
>  // CHECK_LLD_ARM: "thumb2pe"
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

[Mike Edwards via cfe-commits]

Hi,
Fragmentation of the bots is not ideal.  While I totally understand Eric's
reasoning for doing so, and am delighted to see  another Windows bot
helping to ensure quality code, I think this is a bit of a slippery slope.
We already have the main Buildbots, Green Dragon, Chapuni's Bots, a myriad
of private bots and now this new bot.  I don't think it is reasonable to
ask people to have to visit several different places to check if their
commit broke something.  Anecdotally, I find many people will only look at
lab.llvm.org:8011.  They will check Green Dragon if they get an email and
then only if the email does not get lost in the noise.  Some folks are
regular users of bb.pgr.jp but the actual number or regular visitors I
don't know.

Perhaps it would be a more beneficial discussion to talk about putting
together some type of portal which displays results from all the CI systems
in one place?  I for one would love an interface which would be able to
show any given commit and how is has performed across the board.  Something
like this could possibly allow for anyone to stand up a bot or CI
infrastructure of their choosing and then have that system integrated in a
common reporting platform so it is useful and accessible to everyone.

Thoughts?

-Mike

On Thu, Apr 20, 2017 at 7:22 PM, Mehdi Amini via llvm-dev <
llvm-...@lists.llvm.org> wrote:

>
> On Apr 20, 2017, at 7:03 PM, Eric Fiselier  wrote:
>
>
>
> On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini 
> wrote:
>
>>
>> On Apr 20, 2017, at 12:30 PM, Eric Fiselier  wrote:
>>
>>
>>
>> On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini 
>> wrote:
>>
>>>
>>> On Apr 20, 2017, at 12:39 AM, Eric Fiselier  wrote:
>>>
>>>
>>>
>>> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini 
>>> wrote:
>>>
 What would be the status of these buildbots? Is it for your private
 usage?

>>>
>>> I intend for them to be public Windows buildbots for libc++.
>>>
>>>
>>>
>>> I’m not sure it’d be OK to send blame email to contributors based on
>>> this though.
>>>
>>
>> I don't see why not (at least once the bot is stable). Can you elaborate?
>>
>>
>> I don’t think there is a precedent for having a bot that does not
>> checkout from SVN and email using the canonical SVN revision number.
>>
>
> I understand share your concern about the emails using nonsensical git
> hashes as opposed to SVN revision numbers.
> Apart from that I have no idea why the version control used by the CI
> matters. It should have to effect on the build or the results.
>
>
> I don’t know, but other people may have other concern that I don’t
> necessarily anticipate..
>
>
>
>>
>> So it does not seems like a given to me  (not that I’m against it) and
>> would require a discussion on the mailing-list first IMO.
>>
>
> We might as well continue having it now since it's been started. I'll
> re-raise the issue in a month or so when the bot is
> actually stable enough to consider sending emails.
>
>
> I think it deserve a separate thread to deal with this, so that the thread
> title help making sure no-one miss the discussion.
>
> —
> Mehdi
>
>
> ___
> LLVM Developers mailing list
> llvm-...@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283950 - Revert - When optimizing for size, enable loop rerolling by default

[Mike Edwards via cfe-commits]

Author: sqlbyme
Date: Tue Oct 11 17:09:13 2016
New Revision: 283950

URL: http://llvm.org/viewvc/llvm-project?rev=283950=rev
Log:
Revert - When optimizing for size, enable loop rerolling by default

This reverts r283685 as it is causing test failures on Green Dragon.

Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/clang_f_opts.c

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=283950=283949=283950=diff
==
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Tue Oct 11 17:09:13 2016
@@ -5229,18 +5229,9 @@ void Clang::ConstructJob(Compilation ,
   }
 
   if (Arg *A = Args.getLastArg(options::OPT_freroll_loops,
-   options::OPT_fno_reroll_loops)) {
+   options::OPT_fno_reroll_loops))
 if (A->getOption().matches(options::OPT_freroll_loops))
   CmdArgs.push_back("-freroll-loops");
-  } else if (Arg *A = Args.getLastArg(options::OPT_O_Group)) {
-// If rerolling is not explicitly enabled or disabled, then enable when
-// optimizing for size.
-if (A->getOption().matches(options::OPT_O)) {
-  StringRef S(A->getValue());
-  if (S == "s" || S == "z")
-CmdArgs.push_back("-freroll-loops");
-}
-  }
 
   Args.AddLastArg(CmdArgs, options::OPT_fwritable_strings);
   Args.AddLastArg(CmdArgs, options::OPT_funroll_loops,

Modified: cfe/trunk/test/Driver/clang_f_opts.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=283950=283949=283950=diff
==
--- cfe/trunk/test/Driver/clang_f_opts.c (original)
+++ cfe/trunk/test/Driver/clang_f_opts.c Tue Oct 11 17:09:13 2016
@@ -47,12 +47,7 @@
 // CHECK-NO-UNROLL-LOOPS: "-fno-unroll-loops"
 
 // RUN: %clang -### -S -freroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-REROLL-LOOPS %s
-// RUN: %clang -### -S -Os %s 2>&1 | FileCheck 
-check-prefix=CHECK-REROLL-LOOPS %s
-// RUN: %clang -### -S -Oz %s 2>&1 | FileCheck 
-check-prefix=CHECK-REROLL-LOOPS %s
 // RUN: %clang -### -S -fno-reroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-REROLL-LOOPS %s
-// RUN: %clang -### -S -Os -fno-reroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-REROLL-LOOPS %s
-// RUN: %clang -### -S -Oz -fno-reroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-REROLL-LOOPS %s
-// RUN: %clang -### -S -O1 %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-REROLL-LOOPS %s
 // RUN: %clang -### -S -fno-reroll-loops -freroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-REROLL-LOOPS %s
 // RUN: %clang -### -S -freroll-loops -fno-reroll-loops %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-REROLL-LOOPS %s
 // CHECK-REROLL-LOOPS: "-freroll-loops"


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits