[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4f96290ac9: [Clang][M68k] Add Clang support for the new

[PATCH] D158698: [Clang][M68k] Use `DefineStd` for target-specific macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230558e444c2: [Clang][M68k] Use `DefineStd` for target-specific macros (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4603853 , @aaron.ballman wrote: > In D149867#4544489 , @myhsu wrote: > >> Sorry I was busy on my phd defense (which I passed!) in the past month. I'll >> get back to this next

[PATCH] D158698: [Clang][M68k] Use `DefineStd` for target-specific macros

myhsu created this revision. myhsu added reviewers: jrtc27, 0x59616e. Herald added a project: All. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. (From the comments of D149867 ) Use `DefineStd` for

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:10 +// X86: call x86_stdcallcc i32 @bar( +#ifndef mc68000 bar(arg); jrtc27 wrote: > Uh, this shouldn't be defined in ISO C; GCC's using builtin_define_std, so > you should only get

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 552596. myhsu marked 2 inline comments as done. myhsu added a comment. Addressed comments in `test/CodeGen/mrtd.c` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/Sema/m68k-mrtd.c:4-9 +#ifdef MRTD +// expected-error@+3 {{function with no prototype cannot use the m68k_rtd calling convention}} +#endif +void foo(int arg) { + bar(arg); +} aaron.ballman wrote: > myhsu

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 551797. myhsu marked 4 inline comments as done. myhsu added a comment. - Add more C++ tests for `m68k_rtd`, both Sema and CodeGen ones - Addressed other comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4544281 , @glaubitz wrote: > Any update on this? Sorry I was busy on my phd defense (which I passed!) in the past month. I'll get back to this next week. CHANGES SINCE LAST ACTION

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:559 +emitError |= DefaultCC == LangOptions::DCC_StdCall && + Arch != llvm::Triple::m68k && Arch != llvm::Triple::x86; emitError |= (DefaultCC ==

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 532423. myhsu marked 5 inline comments as done. myhsu edited the summary of this revision. myhsu added a comment. Herald added a subscriber: MaskRay. - Add a new default calling convention `-fdefault-calling-conv=rtdcall` to model using `m68k_rtdcc` globally -

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu marked 3 inline comments as done. myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:4 -// CHECK: mrtd.c:10:3: warning: function with no prototype cannot use the stdcall calling convention +// CHECK: mrtd.c:13:3: warning: function with no prototype

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 530089. myhsu retitled this revision from "[M68k] Add Clang support for the new M68k_RTD CC" to "[Clang][M68k] Add Clang support for the new M68k_RTD CC". myhsu edited the summary of this revision. myhsu set the repository for this revision to rG LLVM Github

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4325040 , @jrtc27 wrote: > So GCC gives me: > > warning: ‘stdcall’ attribute directive ignored [-Wattributes] > > when trying to use `__attribute__((stdcall))` on m68k, which matches the fact > it's only mentioned in

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519983. myhsu added a comment. Minor updates. NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/Targets/M68k.h clang/lib/CodeGen/CGCall.cpp

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519982. myhsu added a comment. Introduce `m68k_rtdcc` the textual LLVM IR designation for M68k_RTD CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:9 +// X86: define{{.*}} x86_stdcallcc void @foo(i32 noundef %arg) [[NUW:#[0-9]+]] +// M68k: define{{.*}} cc104 void @foo(i32 noundef %arg) void foo(int arg) { 0x59616e wrote: > 0x59616e wrote: >

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon, craig.topper. Herald added a subscriber: pengfei. Herald added a project: All. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We basically piggyback most of

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

myhsu added a comment. In D148094#4284316 , @barannikov88 wrote: > ping > Does the approach look right? This definitely improves the readability and potentially the compilation time. > Would it be better to put everything into cpp files and only

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b617081420d: [M68k] Add basic Clang support for M68881/2 (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu updated this revision to Diff 511477. myhsu marked 2 inline comments as done. myhsu added a comment. - Explicit add `isa-68882` even for newer (>=68040) CPUs. Such that's it's a lot easier to conditionally add related macro definitions with TargetOptions::FeatureMap - Add cases to test

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon. Herald added a project: All. myhsu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add the `-m68881` flag - Add floating point feature detection - Macro

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu abandoned this revision. myhsu added a comment. Herald added subscribers: wlei, ormris, MaskRay. Herald added a project: All. just realized I haven't updated this patch for years. I'll come up with an up-to-date version when I have time. CHANGES SINCE LAST ACTION

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7335cd051370: [M68k] Add support for basic memory constraints in inline asm (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D143529?vs=495647=503509#toc Repository: rG LLVM

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon, nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu requested changes to this revision. myhsu added a comment. This revision now requires changes to proceed. In D140695#4018127 , @0x59616e wrote: > FYI the pre-merge checks seem to have some issues. Here is the output: > > Command Output (stderr):

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D135488: [codegen] Display stack layouts in console

myhsu added a comment. Just some drive-by comments Comment at: llvm/lib/CodeGen/StackFramePrinterPass.cpp:79 + + void printBody(raw_ostream , SlotData ) const { +OS << formatv("{0,-11} {1,-5} {2,-9} {3,-10}\n", genStackOffset(D.Offset), const SlotData &?

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

myhsu added a comment. > I pushed this change, but for some reason phabricator doesn't show it and > close the review... I wonder if it's because I rebased it? You forgot to add "Differential Revison:

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

myhsu added a comment. Just curious: Have you considered using llvm::opt or even llvm::cl infrastructure? What are the pros & cons? Comment at: clang/utils/TableGen/ClangSAConfigsEmitter.cpp:24 + +using SortedRecords = llvm::StringMap; +

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

myhsu added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:43 #include "llvm/Pass.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h" Hmm...did you use clang-format-diff.py? I wonder why this was changed

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. since D119053 was accepted, I don't see any reason why this patch shouldn't be :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117605: [time-trace] Add optimizer and codegen regions to NPM

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. LGTM I think this is neat. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117605/new/ https://reviews.llvm.org/D117605

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6685a3f3e4c4: [cfe] Support target-specific escaped character in inline asm (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

myhsu updated this revision to Diff 347574. myhsu marked 3 inline comments as done. myhsu added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103036/new/ https://reviews.llvm.org/D103036 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/Stmt.cpp

[PATCH] D103036: [cfe][inline-asm] Support target-specific escaped character in inline asm

myhsu created this revision. myhsu added reviewers: nickdesaulniers, nathanchance, m_zuckerman, rnk. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC allows each target to define a set of non-letter and non-digit escaped

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdccf5c7dfb9e: [M68k] Support for inline asm operands w/ simple constraints (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102805: [M68k] Allow user to preserve certain registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe620bea21199: [M68k] Allow user to preserve certain registers (authored by myhsu). Changed prior to commit:

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added a comment. In D102585#2769887 , @nickdesaulniers wrote: > Looking good @myhsu . Also, I got your LLVM book recently! You'll need to > sign it for me at the next llvm conf in person. Thank you :-) Hope you will like it. I'll start to

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346638. myhsu marked 4 inline comments as done. myhsu added a comment. - Add test cases for valid constraints - Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files:

[PATCH] D102805: [M68k] Allow user to preserve certain registers

myhsu updated this revision to Diff 346627. myhsu marked an inline comment as done. myhsu added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102805/new/ https://reviews.llvm.org/D102805 Files: clang/include/clang/Driver/Options.td

[PATCH] D102805: [M68k] Allow user to preserve certain registers

myhsu created this revision. myhsu added reviewers: nickdesaulniers, simoncook. Herald added subscribers: dang, s.egerton, hiraditya. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add `-ffixed-a[0-6]` and

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); nickdesaulniers wrote: > did you mean to drop support for `'f'`? To drop it for

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346338. myhsu marked 2 inline comments as done. myhsu added a comment. Fixed lint warning and added more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files: clang/lib/Basic/Targets/M68k.cpp

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu created this revision. myhsu added reviewers: echristo, craig.topper. Herald added a subscriber: hiraditya. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds supports for inline assembly operands

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5509748f2ce5: [cfe][driver][M68k](8/8) Clang driver support (authored by myhsu). Changed prior to commit:

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb7a5814a5c: [cfe][M68k](7/8) Clang basic support (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 327029. myhsu marked 4 inline comments as done. myhsu added a comment. [NFC] Update FileCheck prefix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380 ve::getVETargetFeatures(D, Args, Features); +break; } jrtc27 wrote: > jrtc27 wrote: > > Unrelated > I committed this as

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 326506. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu marked an inline comment as done. myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:142 +const char *, TargetInfo::ConstraintInfo ) const { + // FIXME: implement + switch (*Name) { jrtc27 wrote: > This is implemented? only

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 326505. myhsu marked 4 inline comments as done. myhsu added a comment. - [NFC] Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:77-79 + Builder.defineMacro("M68k"); + Builder.defineMacro("__M68k__"); + Builder.defineMacro("__M68K__"); jrtc27 wrote: > myhsu wrote: > > jrtc27 wrote: > > > Where are these coming

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 320604. myhsu added a comment. - Addressed feedback - Remove redundant target macro definitions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2101 + static const char *const M68kLibDirs[] = {"/lib"}; + static const char *const M68kTriples[] = { MaskRay wrote: > The second `const ` is redundant I don't think so...first,

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 320586. myhsu marked 5 inline comments as done. myhsu added a comment. Herald added a reviewer: jansvoboda11. - Addressed feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files:

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:63 +.Case("generic", CK_68000) +.Case("M68000", CK_68000) +.Case("M68010", CK_68010) jrtc27 wrote: > GCC's -mcpu excludes any M prefix and is just the

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 320585. myhsu marked 4 inline comments as done. myhsu added a comment. - Addressed feedbacks - Now M68k tries to use ABI that is compatible with GCC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files:

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 310755. myhsu marked an inline comment as done. myhsu added a comment. - [NFC] Fix minor formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu marked 2 inline comments as done. myhsu added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; myhsu wrote: > bruno wrote: > > rengolin wrote: > > > Same

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 309462. myhsu added a comment. - Add support for M68060 sub-target CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/CMakeLists.txt

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 309461. myhsu added a comment. - Add support for M68060 sub-target CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets.cpp:314 +default: + return new M68kTargetInfo(Triple, Opts); +} rengolin wrote: > No support for bare-metal? currently we don't have any plan for that Comment at:

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308866. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed all the feedbacks - Fixed minor issues that would retrieve the wrong TargetCodeGenInfo instance CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; bruno wrote: > rengolin wrote: > > Same question as @RKSimon had below: Shouldn't this cover all

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 308551. myhsu marked 11 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files:

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308550. myhsu marked 5 inline comments as done. myhsu added a comment. - Rebased to latest changes - Addressed some of the feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files:

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 302188. myhsu retitled this revision from "[Driver][M68K] (Patch 8/8) Add driver support for M68K" to "[Driver][M68k] (Patch 8/8) Add driver support for M68k". myhsu edited the summary of this revision. myhsu added a comment. [NFC] Rename M680x0 to M68k

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 302187. myhsu retitled this revision from "[cfe][M68K] (Patch 7/8) Basic Clang support" to "[cfe][M68k] (Patch 7/8) Basic Clang support". myhsu edited the summary of this revision. myhsu added a comment. Herald added a subscriber: dexonsmith. [NFC] Rename

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu updated this revision to Diff 296065. myhsu added a comment. - Use the canonical CPU name (i.e. names started with upper case 'M') - Tell the driver to use integrated assembler (i.e. MC) by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 296064. myhsu added a comment. Fix the CPU name passing to the Backend CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 295706. myhsu added a comment. Update licenses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu updated this revision to Diff 295469. myhsu added a reviewer: aaron.ballman. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 295468. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a project: clang. myhsu requested review of this revision. Herald added a subscriber: ormris. Add new toolchain and driver options for the M680x0 target Repository: rG LLVM Github Monorepo

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: clang. myhsu requested review of this revision. 1. Add M68K as new Clang target 2. Add new attribute to support M68K's ISR (Interrupt Service Routine)

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu updated this revision to Diff 290849. myhsu edited the summary of this revision. myhsu added a comment. Unified driver options from "-fprofile-deopt-cold-*" into "-fprofile-omit-cold-opt" and "-fprofile-omit-cold-opt=". Where the former one is just a shorthand of

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu updated this revision to Diff 290769. myhsu added a comment. Fix a bug in driver that accidentally made this feature turn on by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87338/new/ https://reviews.llvm.org/D87338 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu created this revision. myhsu added reviewers: rsmith, bogner, xur. Herald added subscribers: cfe-commits, wenlei, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. myhsu requested review of this revision. Following up https://reviews.llvm.org/D87337 . This patch add

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG4431d64c10cb: Support ExtVectorType conditional operator (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D80574?vs=267277=267913#toc Repository: rG LLVM Github Monorepo

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu added a comment. > Btw does your change fix this bug: > https://bugs.llvm.org/show_bug.cgi?id=33103 As mentioned in the description, this patch only affect C code not C++ code. So strictly speaking this patch doesn't fix the bug, but if the same code attached in the bug report is

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu added a comment. Thank you @Anastasia ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267277. myhsu added a comment. Use full set of OpenCL semantic rules for ext_vector_type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu marked 2 inline comments as done. myhsu added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7484 + // Only ext vector is allowed + if (const auto *VecCondTy = Cond->getType()->getAs()) { +QualType EleTy = VecCondTy->getElementType();

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267027. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sema/ext_vector_comparisons.c

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu marked 2 inline comments as done. myhsu added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7484 + // Only ext vector is allowed + if (const auto *VecCondTy = Cond->getType()->getAs()) { +QualType EleTy = VecCondTy->getElementType();

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267024. myhsu added a comment. Fix document section CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu created this revision. myhsu added reviewers: Anastasia, bader, hfinkel, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extension vectors now can be used in element-wise conditional selector. For example: R[i] = C[i]? A[i] : B[i] This feature was