owenv marked an inline comment as done.
owenv added inline comments.
Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323
+ // A documentation URL has an ID and path size.
+ if (Record.size() != 2)
+return SDError::MalformedDiagnosticRecord;
---
owenv marked an inline comment as done.
owenv added a comment.
@jkorous I'd like to add support for urls in clang-emitted diagnostics too, but
I can't really commit to a timeframe for getting that done atm. I'm hoping to
have some time to work on it in the next few weeks.
Com
owenv updated this revision to Diff 265592.
owenv added a comment.
- Update a few comments
- Simplify test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80126/new/
https://reviews.llvm.org/D80126
Files:
clang/include/clang-c/Index.h
clang
owenv added a comment.
Reviewers added are a best guess based on arc cover. Sorry if I made a mistake,
it's my first time contributing to LLVM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80126/new/
https://reviews.llvm.org/D80126
___
owenv updated this revision to Diff 265294.
owenv added a comment.
Updated terminology to generalize the feature so Clang diagnostics can adopt it
in the future.
Also switched from local paths to URLs so local and remote documentation can
both be supported if desired
Repository:
rG LLVM Gith
owenv created this revision.
Herald added subscribers: cfe-commits, arphaman.
Herald added a project: clang.
An educational note is attached to a diagnostic and is essentially just a path
to associated documentation somewhere in a compiler toolchain. The
documentation can then be displayed alongsi
