[PATCH] D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses

LegalizeAdulthood added inline comments. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/redundant-void-arg.cpp:596 + +// Explicitly specifying `(void)` is a way to sidestep -Wvexing-parse,

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. In D128697#3638467 , @Sockke wrote: > In D128697#3619310 , > @LegalizeAdulthood wrote: > >> This whole check seems weird to me. I mean, alm

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. In D133102#3774151 , @alexfh wrote: > For example, LLVM coding standards recommends using early exits: > https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-si

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90 // Underscores are allowed to disable a test with the DISABLED_ prefix. -// https://github.com/google/googletest/blob/master/google

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. I'm not certain that the result of the transformation is more "readable"; is this check intended to aid conformance to a style guide? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. How does this check interact with macros that expand to `if` statements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630 ___

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

LegalizeAdulthood resigned from this revision. LegalizeAdulthood added a comment. This revision now requires review to proceed. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. No action taken, removing myself as a reviewer Repository: rG LLV

[PATCH] D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134590/new/ https://reviews.llvm.org/D134590 _

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a80c3d08d4: [clang-tidy] Properly forward clang-tidy output when running tests (authored by nicovank, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

LegalizeAdulthood added a comment. I will submit it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127807/new/ https://reviews.llvm.org/D127807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65a3bffd31f: [clang-tidy] Don't treat invalid branches as identical (authored by ishaangandhi, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:130 +- New :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check. Sort new checks by check name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:131 +- New :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check. + This link is wrong, please install Sphinx and build the target `docs-clang-tools-html` t

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3612741 , @myhsu wrote: > You forgot to add > > "Differential Revison: https://reviews.llvm.org/DXX"; in the commit

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Improved :doc:`bugprone-signal-handler + ` check. Partial sort by check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D128511: [clang-tidy] Make the cert/uppercase-literal-suffix-integer fully hermetic.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/integral_constant.h:1 +#ifndef _INTEGRAL_CONSTANT_H_ +#define _INTEGRAL_CONSTANT_H_ Identifiers beginning with `_` followed by an uppercase letter are

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Thanks for this, like Nathan James this has been pestering me for a while `:)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. Please provide the name and email address you wish to use on the commit and I will submit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-tidy tests and docs have been moved to subdirectories by module, please rebase to `main:HEAD` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Please add a summary of the fix to the release notes for this check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

LegalizeAdulthood added a comment. This whole check seems weird to me. I mean, almost every use of a standard container could throw `std::bad_alloc` but we don't insist on a local `catch` for `bad_alloc` at every possible throwing call site. Why would we assume that every call site of `stoi` o

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/confusable-identifiers.cpp:43 + return q0 < q1; +} aaron.ballman wrote: > It looks like there's quite a bit of missing test coverage for all the > various situ

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mail

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Well, it must have been unrelated to your change or some weird interaction on my machine because I rebased and ran `check-clang-extra` again and it passed this time. Re

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:282 +// These are all class names in ExprCXX.h without 'CXX' prefix. +#define CXXStmts \ + ArrayTypeTraitExpr,\ I'm not a fan of this macro, and we'

[PATCH] D128372: [Clang-Tidy] Empty Check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-standalone-empty.cpp:1 +// RUN: %check_clang_tidy %s bugprone-standalone-

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Rebase against main to get updated docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. I get a test failure when I run with your change: -- Testing: 972 tests, 12 workers -- FAIL: Clang Tools :: clang-apply-replacements/basic.cpp (680 of 97

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3605829 , @jspam wrote: > I see :) Yes, looks like Git's rename detection did its job. > > Thanks for the review. Could you or someone else please merge this for me? > Author: Joachim Priesner I can submit,

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:190 + +containsFunc |= (CanDecl == Func); +overlap |= Callees.contains(CanDecl); Personally I'm not a fan of using bitwise operators with bool

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. OK, I've pushed the link fix and the sorting fix to main so if you rebase again, it should just show your changes to the release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:221-224 +- Fixed a crash in :doc:`performance-unnecessary-value-param + ` when the specialization + template has an unnecessary value parameter. Removed the fix for a template. + -

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 _

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. Herald added a project: All. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripping the module pre

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. Herald added a project: All. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripping the module pre

[PATCH] D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. In D128157#3605504 , @jspam wrote: > @LegalizeAdulthood Not sure what exactly you mean by "fold your changes into > `checkers/cppcoreguidelines/virtual-class-destructor.cpp`". The only rebase > conflict was in `Virtual

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128372: Clang-Tidy Empty Check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches + involve unknown expressions. This link is wrong, needs to use the `bugprone/` direc

[PATCH] D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Herald added a project: All. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into th

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D126735: [clang-tidy] Silence modernize-redundant-void-arg in the case of vexing parses

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D124918: [clang-tidy] Add a new check for non-trivial unused variables.

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs, stripp

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto main:HEAD and: - fold your changes into the appropriate subdirs, strippin

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Tests and docs have moved to subdirectories by module name. Please rebase onto HEAD and: - move `test/clang-tidy/checkers/cppcoreguidelines-avoid-const-or-ref-

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Please rebase this and folder your changes into `checkers/cppcoreguidelines/virtual-class-destructor.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89a1d03e2b37: [clang-tidy] Organize test files into subdirectories by module (NFC) (authored by LegalizeAdulthood). Changed prior to commit: https

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D128072#3598634 , @aaron.ballman wrote: > This sounds like a sensible direction to me. I spot-checked the changes and > they all seem reasonable. Giving my LG, but please wait a bit before landing > in case someone

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: njames93, aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: bzcheeseman, carlosgalvezp, abrachet, lebedev.ri, jdoerfert, arphaman, zzheng, kbarton, xazax.hun, nemanjai. Herald a

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3588787 , @aaron.ballman wrote: > In D126495#3574115 , > @LegalizeAdulthood wrote: > >> In D126495#3571511 , @njames93 >>

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. Ping. All review comments should be addressed in the latest diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126495/new/ https://reviews.llvm.org/D126495 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3571511 , @njames93 wrote: > Search engines isn't really an issue, its more people who are using older > versions of llvm that try and go to the documentation which turns out is a > dead link. > Having said

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3570767 , @aaron.ballman wrote: > In D126495#3569863 , > @LegalizeAdulthood wrote: > >> In D126495#3569029 , @njames93 >>

[PATCH] D118711: [hack] Build a tree of preprocessing directives

LegalizeAdulthood added a comment. Herald added a project: All. I'm discarding this review, as it was just for comment purposes, until I have a proper implementation to discuss. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118711/new/ https://reviews.llvm.org/D118711

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3569029 , @njames93 wrote: > In D126495#3568998 , > @LegalizeAdulthood wrote: > >> Gentle ping > > My previous point about the links in the header files not being upd

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. Gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126495/new/ https://reviews.llvm.org/D126495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3553183 , @LegalizeAdulthood wrote: > In D126495#3552887 , @njames93 > wrote: > >> Can I ask what the motivation is for this change? > > https://discourse.llvm.org/t

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3552887 , @njames93 wrote: > Can I ask what the motivation is for this change? https://discourse.llvm.org/t/clang-tidy-rfc-use-module-name-as-a-directory-for-organizing-files/62499 CHANGES SINCE LAST ACTION

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. I know this is a rather huge diff, but the part that needs to be reviewed is the python script changes. I've rebuilt the HTML docs with sphinx and tested all the manually modified links to verify that they still go to the correct page. The existing Release No

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb418ef5cb90b: [clang-tidy] Reject invalid enum initializers in C files (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 433648. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://reviews.llvm.org/D125622 Files: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMat

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:3-7 +// C requires enum values to fit into an int. +#define TOO_BIG1 1L +#define TOO_BIG2 1UL +#define TO

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 432676. LegalizeAdulthood added a comment. - Add C++ test case for acceptable `operator,` initializer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://reviews.llvm.org/D125622 Files: clang-tools-extra/clang-tidy/moderni

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 5 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:324 { - IntegralLiteralExpressionMatcher Matcher(MacroTokens); - return Matcher.match(); + IntegralLiteralExpre

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood updated this revision to Diff 432675. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. - Update from review comments - Disallow operator, unless inside parentheses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125622/new/ https://r

[PATCH] D126247: `readability-indentifier-naming` resolution order and examples

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:2742 double dValueDouble = 0.0; ULONGulValueUlong = 0; Phabricator says there is no context available. Did you genera

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e663c4f83a: [clang-tidy] Improve add_new_check.py to recognize more checks (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file = get_module_filename(module_path, module_name) +if not os.path.isfile(module_file): + return '' +with io.open(module_file, 'r') as f:

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood updated this revision to Diff 431383. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126134/new/ https://reviews.llvm.org/D126134 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra/d

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:352 + stmt = code[stmt_start_pos+1:stmt_end_pos] + matches = re.search('registerCheck<([^>:]*)>\(\s*"([^"]*)"\s*\)', stmt) + if matches and matches[2] == full_check_n

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Another observation: If some new pattern comes up and fixits aren't recognized for a check, it might be better to switch to a whitelist for checks with fixits rather than going crazier on the file scraping.

[PATCH] D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126162/new/ https://reviews.llvm.org/D126162 _

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:335-336 +module_file = get_module_filename(module_path, module_name) +if not os.path.isfile(module_file): + return '

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93, alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. W

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++(98|11|14|17|20)[-or-later]: +This flag will cause multiple runs within the same check_clang_tidy +execution. Make sure you don't have shared state acr

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

LegalizeAdulthood added a comment. Herald added a project: All. Are we waiting on some sort of benchmark before accepting/rejecting this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460 ___

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Herald added a project: All. If the only thing holding this up is my comments about following the Law of Demeter, I don't think that should block submitting this change.

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209 _

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Address one nit and ship. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125769/new/ https://reviews.llvm.org/D125769

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:180 + the ``CheckHeaderFile=true`` option if header files of the project only + included by c++ source files. Capitalize to `C++` Comment at: clan

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:22 [-check-suffixes=] \ +[-std=(c++11-or-later|c++17)] \ \ These aren't the only two valid options for this argument Valid values are:

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.h:63 std::vector IncludesToBeProcessed; + bool WarnIntoHeaders; }; whisperity wrote: > LegalizeAdulthood wrote: > > 1) How is this different fr

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added a comment. In D125771#3525252 , @njames93 wrote: > Tbh the whole testing infrastructure for clang-tidy is a mess. When I have > wanted to verify fixes and diagnostics for header files, I find manually > invoking clang-tidy is bet

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:116 `bugprone-virtual-near-miss `_, "Yes" - `cert-dcl21-cpp `_, + `cert-dcl21-cpp `_, "Yes" `cert-dcl50-cpp `_, LegalizeAdulthood wrote: > The probl

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:116 `bugprone-virtual-near-miss `_, "Yes" - `cert-dcl21-cpp `_, + `cert-dcl21-cpp `_, "Yes" `cert-dcl50-cpp `_, The problem with making this change

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

LegalizeAdulthood added a comment. In D124806#3523228 , @njames93 wrote: > In D124806#3523109 , > @LegalizeAdulthood wrote: > >> LGTM! Thanks for taking my idea and implementing it much better than what I >> ha

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125770/new/ https://reviews.llvm.org/D125770 _

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Discarding in favor of Nathan James's improved implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 ___ cfe-co

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM! Thanks for taking my idea and implementing it much better than what I had `:)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D125770: [clang-tidy] modernize-deprecated-headers should ignore system headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:37 -#include // FIXME: We should have no warning into system headers. -// CHECK-MESSAGES-WARN-INTO-HEADERS: mysystemlib.h:1:10: warning:

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 _

  1   2   3   4   5   >