[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

sdmitriev accepted this revision. sdmitriev added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117120/new/ https://reviews.llvm.org/D117120

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b553297ef3e: [clang-offload-bundler] Reuse original file extension for device archive member (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

sdmitriev created this revision. sdmitriev added reviewers: saiislam, ABataev. sdmitriev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes clang-offload-bundler to use the origin

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8444a8e9422: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: cla

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8998a8aa97f8: [clang-offload-bundler] Add sections and set section flags using one llvm… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. llvm-objcopy has been

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev). Repository: rG LLVM Github

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > sdmitriev wrote: > > ABataev wrote: > > > What about `llvm::iplist`?

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411 private: - SmallVector, 4u> Files; + std::forward_list> Files; }; ABataev wrote: > What about `llvm::iplist`? It can be changed to iplist as well, but w

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev requested review of this revision. Use a different container that preserves existing elements on modification for storing temporary file names. Cur

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

sdmitriev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common bader wrote: > Anastasia wrote:

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG5be2ca29217a: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73738/new/

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73738 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/too

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bfdb7096cf: [Clang][Driver] Disable llvm passes for the first host OpenMP offload… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert, hfinkel. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. With OpenMP offloading host compilation is done in two phases to capture host IR that is passed to all device compilations as in

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

This revision was automatically updated to reflect the committed changes. Closed by commit rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev added a comment. @ABataev, do you have any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:378 + // Creates temporary file with given contents. + Expected Create(Optional> Contents) { +SmallString<128u> File; -

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241278. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241269. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fat object size has significantly increased after D65819

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e82d0dfd8df: [Clang][Bundler] Add 'exclude' flag to target objects sections (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added a comment. Any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev updated this revision to Diff 240676. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag tells link editor to exclude section from linker inputs when linking execut

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

sdmitriev added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:1 -; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck %s +; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-pre

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Wrapper tool is invoked at link phase, therefore there just could be no .bc files available to read data layout from. Ok, looks like there is no good solution for the data layout problem, so I will drop the idea of passing wrapper .bc directly to the linker when LTO i

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. I would agree with you if data layout was indeed available in the driver, but unfortunately driver does not have access to any existing TargetInfo instance (or maybe I just have not found it). So, I have to create TargetInfo and build data layout even for the case whe

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Ok, it is possible to do it like you suggested, but I think that teaching wrapper tool to set data layout without external help is more preferable. There is a certain difference between opt and wrapper tool – opt works on the existing .bc that is provided in command l

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755768 , @ABataev wrote: > In D70551#1755761 , @sdmitriev wrote: > > > In D70551#1755583 , @ABataev wrote: > > > > > In D70551#173 <

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755583 , @ABataev wrote: > In D70551#173 , @sdmitriev wrote: > > > In D70551#1755527 , @ABataev wrote: > > > > > Why do we need this

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755527 , @ABataev wrote: > Why do we need this? To pass wrapper bitcode directly to the linker when LTO is enabled. LTO plugin does not accept bc if there is no data layout. Repository: rG LLVM Github Monorepo

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70551 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd501045cdea: [Clang][Bundler] Error reporting improvements (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D67031?vs=224726&id=226521#toc Repository: rG LLVM Github Monore

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6caada4eb465: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69140 Files: clang/test/Driver/clang-offload-wrapper.

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev abandoned this revision. sdmitriev added a comment. All three parts have been committed, so I am abandoning the original patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commi

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

sdmitriev accepted this revision. sdmitriev added a comment. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68931/new/ https://reviews.llvm.org/D68931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 224726. sdmitriev added a comment. Rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: -

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added a subscriber: grokos. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ---

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:174 + /// Global variable that represents BinDesc is returned. + GlobalVariable *createBinDesc(ArrayRef> Bufs) { +// Create external begin/end symbols for the offload entr

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ABataev wrote: > Same question as be

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1702487 , @thakis wrote: > Out of interest (or ignorance :) ), why is this a separate binary instead of > just part of the normal `clang` driver? C, C++, Objective-C, and assembly all > can do with a single driver, ye

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the last part to https://reviews.llvm.org/D68746 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d83768f108: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D68166?vs=223335&id=224146#toc Reposit

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 223335. sdmitriev added a comment. Rebased patch and changed clang-offload-wrapper CMakeLists.txt to use add_clang_tool() rather than add_clang_executable() with a custom install rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ http

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1692071 , @JonChesterfield wrote: > I think this patch is a behaviour change. Currently, the target binary is > embedded in the host binary at link time. With this change, the contents of > the binary are embedded in

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 222917. sdmitriev marked 2 inline comments as done. sdmitriev added a comment. Addressed some comments and rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 Files: clang/include/clang/Driver

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:133 /// returned if there are no more bundles to be read. - virtual StringRef ReadBundleStart(MemoryBuffer &Input) = 0; + virtual Expected> + ReadBundleStart(MemoryBuffer

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373523: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments. (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev added a comment. In D68355#1691961 , @ABataev wrote: > Mark the patch as NFC. I think I have already done that by adding [NFC] to the commit message. Do I need to do anything in addition to that? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D68355: [Clang][Driver][NFC] Corrected DeviceActionBuilder methods' comments.

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. sdmitriev added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68355 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2284-2289 -/// Append top level actions generated by the builder. Return true if errors -/// were found. +/// Append top level actions generated by the builder. virtual void appendTopLevelA

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ https://reviews.llvm.org/D68166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. The second part was uploaded to https://reviews.llvm.org/D68166. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the first part to https://reviews.llvm.org/D68070 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev abandoned this revision. sdmitriev added a comment. This patch is no longer relevant since it was agreed to split https://reviews.llvm.org/D64943 into pieces in a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 __

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1668006 , @JonChesterfield wrote: > >> Does this diff mix getting rid of the linker script with other changes? > >> E.g. it looks like the metadata generation is moving from clang to the new > >> tool, but that seems

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1667469 , @JonChesterfield wrote: > I'm on board with getting rid of the linker script. Gold's limited support > for that seems conclusive. > > I believe the current script does two things: > 1/ takes a binary and em

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1666924 , @JonChesterfield wrote: > In D64943#1666849 , @sdmitriev wrote: > > > In D64943#136 , > > @JonChesterfield wrote: > > > >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#136 , @JonChesterfield wrote: > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > runtime is ideal. Since the data is stored in a common section anyway, please > could we rename it to

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#193 , @JonChesterfield wrote: > In D64943#179 , @ABataev wrote: > > > In D64943#178 , > > @JonChesterfield wrote: > > > > >

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 219750. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/CMakeLists.txt clang/tools/clang-offload-wrapper

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 219742. sdmitriev added a reviewer: Hahnfeld. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offloa

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. I think I have addressed all comments posted so far. Do you have more notes/comments/suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing l

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > sdmit

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218776. sdmitriev edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > sdmit

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundle

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > The c

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added a comment. Any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218250. sdmitriev added a comment. Removed trailing '.' from error messages and added few additional changes for better error handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906 +Msg << ", unknown target triple '" << Triple << "'"; + reportError(createStringError(errc::invalid_argument, Msg.st

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > The code still uses (in the order of marked incl

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218224. sdmitriev retitled this revision from "[Clang][Bundler] Error reporting improvements [NFC]" to "[Clang][Bundler] Error reporting improvements". sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D67031 Files: clang/test/Driver/cl

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 217682. sdmitriev added a comment. Rebased and synced up changes with https://reviews.llvm.org/D64943 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c cl

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Looks like there will be no more comments. If so, I will update the first part https://reviews.llvm.org/D65130 which adds clang-offload-wrapper tool with the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D6

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rL370143: [Clang][Bundler] Do not require host triple for extracting device bundles (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217522. sdmitriev marked an inline comment as done. sdmitriev added a comment. Added tests for each file type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundl

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

This revision was automatically updated to reflect the committed changes. Closed by commit rL370115: [Clang][Bundler] Fix for a hang when unbundling fat binary (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); ABataev

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:301 assert(CurBundleInfo != BundlesInfo.end() && "Invalid reader info!"); ++CurBundleInfo; } Just notic

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev added a comment. Sure. The main unbundling loop looks as follows (see loop on line 745) while (!Worklist.empty()) { StringRef CurTriple = FH.get()->ReadBundleStart(Input); if (CurTriple.empty()) break; auto Output = Worklist.find(CurTriple); if (Output == W

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:228-231 +// Check that we can extract target parts without providing host triple. +// RUN: clang-offload-bundler -type=ast -targets=openmp-powerpc64

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

  1   2   >