[clang] Propeller config for clang (PR #91002)

@@ -928,6 +928,186 @@ if (CLANG_BOLT AND NOT LLVM_BUILD_INSTRUMENTED) ) endif() +if (CLANG_PROPELLER_INSTRUMENT AND NOT LLVM_BUILD_INSTRUMENTED) + set(CLANG_PATH ${LLVM_RUNTIME_OUTPUT_INTDIR}/clang) + set(CLANGXX_PATH ${CLANG_PATH}++) + set(PROPELLER_ARTIFACTS_DIR ${CMAKE

[clang] Propeller config for clang (PR #91002)

https://github.com/tmsri updated https://github.com/llvm/llvm-project/pull/91002 >From a9daae4fafb096253a985054bbfa8482669796e0 Mon Sep 17 00:00:00 2001 From: Sriraman Tallam Date: Fri, 3 May 2024 12:43:29 -0700 Subject: [PATCH 1/2] Propeller config for clang This patch adds a Propeller config

[clang] Propeller config for clang (PR #91002)

https://github.com/tmsri created https://github.com/llvm/llvm-project/pull/91002 This patch adds a Propeller config to cmake to allow building a Propeller optimized clang. Building a propeller optimizing clang requires hardware LBR support and a built create_llvm_prof binary from: https://github

Re: [PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

On Wed, Mar 2, 2022 at 11:08 AM Ellis Hoag via Phabricator < revi...@reviews.llvm.org> wrote: > ellis added a comment. > Herald added a subscriber: ormris. > Herald added a project: All. > > Hi @tmsriram. I found a clang crash when using the flag > `-funique-internal-linkage-names` that only happe

[clang] cdb42a4 - Disable unique linkage suffixes ifor global vars until demanglers can be fixed.

Author: Sriraman Tallam Date: 2021-03-11T20:59:30-08:00 New Revision: cdb42a4cc4239c0b592fc82021c945ce02ebe5cc URL: https://github.com/llvm/llvm-project/commit/cdb42a4cc4239c0b592fc82021c945ce02ebe5cc DIFF: https://github.com/llvm/llvm-project/commit/cdb42a4cc4239c0b592fc82021c945ce02ebe5cc.dif

[clang] 78d0e91 - Refactor -funique-internal-linakge-names implementation.

Author: Sriraman Tallam Date: 2021-03-05T13:32:17-08:00 New Revision: 78d0e91865f6038adb23ec272c3e1e7e1525057f URL: https://github.com/llvm/llvm-project/commit/78d0e91865f6038adb23ec272c3e1e7e1525057f DIFF: https://github.com/llvm/llvm-project/commit/78d0e91865f6038adb23ec272c3e1e7e1525057f.dif

[clang] e741916 - Basic block sections should enable not function sections implicitly.

Author: Sriraman Tallam Date: 2021-02-17T12:37:50-08:00 New Revision: e74191633036905388245818f54553813c880f83 URL: https://github.com/llvm/llvm-project/commit/e74191633036905388245818f54553813c880f83 DIFF: https://github.com/llvm/llvm-project/commit/e74191633036905388245818f54553813c880f83.dif

[clang] d8c6d24 - -funique-internal-linkage-names appends a hex md5hash suffix to the symbol name which is not demangler friendly, convert it to decimal.

Author: Sriraman Tallam Date: 2021-01-11T11:10:29-08:00 New Revision: d8c6d24359f17c55a8966231ef74e8f4b03ad282 URL: https://github.com/llvm/llvm-project/commit/d8c6d24359f17c55a8966231ef74e8f4b03ad282 DIFF: https://github.com/llvm/llvm-project/commit/d8c6d24359f17c55a8966231ef74e8f4b03ad282.dif

[clang] 34e70d7 - Append ".__part." to every basic block section symbol.

Author: Sriraman Tallam Date: 2020-12-23T11:35:44-08:00 New Revision: 34e70d722dfd0e73d460802e8d43d3a885d24784 URL: https://github.com/llvm/llvm-project/commit/34e70d722dfd0e73d460802e8d43d3a885d24784 DIFF: https://github.com/llvm/llvm-project/commit/34e70d722dfd0e73d460802e8d43d3a885d24784.dif

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < revi...@reviews.llvm.org> wrote: > dblaikie added a comment. > > @tmsriram ping on the follow-up here > I checked in the patch that emits llvm instead of obj which spews garbage to the terminal as I wasn't redirecting it to /dev/null

[clang] ad1b9da - Prepend "__uniq" to symbol names hash with -funique-internal-linkage-names.

Author: Sriraman Tallam Date: 2020-10-26T14:24:28-07:00 New Revision: ad1b9daa4bf40c1907794fd5de7807aad1f0553c URL: https://github.com/llvm/llvm-project/commit/ad1b9daa4bf40c1907794fd5de7807aad1f0553c DIFF: https://github.com/llvm/llvm-project/commit/ad1b9daa4bf40c1907794fd5de7807aad1f0553c.dif

[clang] eef2e67 - Simple fix to basic-block-sections to replace emit-obj with emit-llvm

Author: Sriraman Tallam Date: 2020-10-21T13:52:33-07:00 New Revision: eef2e67d2326e7d4027fddb29eefdb69371dc24a URL: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a DIFF: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a.dif

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:59 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > > wrote: > > > > > > dblaikie added a comment. > > > > > > In D89500#2344234

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > wrote: > > > > dblaikie added a comment. > > > > In D89500#2344234 , @davezarzycki > > wrote: > > > > > I think I fixed it. Please

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 20, 2020 at 6:19 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/26253/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Sorry I saw this message late. Looks like Fan

[clang] f887854 - Improve file doesnt exist error with -fbasic-block-sections=

Author: Sriraman Tallam Date: 2020-10-20T16:41:56-07:00 New Revision: f88785460ecf40a9176f58637d38fb785eb91ac4 URL: https://github.com/llvm/llvm-project/commit/f88785460ecf40a9176f58637d38fb785eb91ac4 DIFF: https://github.com/llvm/llvm-project/commit/f88785460ecf40a9176f58637d38fb785eb91ac4.dif

[clang] 7d0bbe4 - Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot failure.

Author: Sriraman Tallam Date: 2020-09-23T10:28:40-07:00 New Revision: 7d0bbe40901cf60558c619c3174d71d7c53ca144 URL: https://github.com/llvm/llvm-project/commit/7d0bbe40901cf60558c619c3174d71d7c53ca144 DIFF: https://github.com/llvm/llvm-project/commit/7d0bbe40901cf60558c619c3174d71d7c53ca144.dif

[clang] b89059a - Revert "The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled."

Author: Sriraman Tallam Date: 2020-09-22T12:32:43-07:00 New Revision: b89059a31347dd09b55a96b99b3dbe38d7749908 URL: https://github.com/llvm/llvm-project/commit/b89059a31347dd09b55a96b99b3dbe38d7749908 DIFF: https://github.com/llvm/llvm-project/commit/b89059a31347dd09b55a96b99b3dbe38d7749908.dif

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 11:28 AM Albion Fung via Phabricator wrote: > > Conanap added a comment. > > It looks like this commit is causing a few failures on nearly all PPC bots > and a sanitizer bot; would it be possible to revert this commit for now until > the issue is resolved? Ya sure, I can

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 8:34 AM Fāng-ruì Sòng wrote: > > FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a > powerpc64le machine. All tests passed. I cannot connect the failure to > the clang patch. Thanks for doing this! Much appreciated! > > On Mon, Sep 21, 2020 at 10:02 PM S

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

[clang] 6950db3 - The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled.

Author: Sriraman Tallam Date: 2020-09-21T10:00:12-07:00 New Revision: 6950db36d33d85d18e3241ab6c87494c05ebe0fb URL: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb DIFF: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb.dif

[clang] e0bca46 - Options for Basic Block Sections, enabled in D68063 and D73674.

Author: Sriraman Tallam Date: 2020-06-02T00:23:32-07:00 New Revision: e0bca46b0854143b2f93b60aac99e669c9776979 URL: https://github.com/llvm/llvm-project/commit/e0bca46b0854143b2f93b60aac99e669c9776979 DIFF: https://github.com/llvm/llvm-project/commit/e0bca46b0854143b2f93b60aac99e669c9776979.dif

[clang] e8147ad - Uniuqe Names for Internal Linkage Symbols.

Author: Sriraman Tallam Date: 2020-05-07T18:18:37-07:00 New Revision: e8147ad8222602d16728c370d5fac086260d058c URL: https://github.com/llvm/llvm-project/commit/e8147ad8222602d16728c370d5fac086260d058c DIFF: https://github.com/llvm/llvm-project/commit/e8147ad8222602d16728c370d5fac086260d058c.dif

r325961 - Set Module Metadata "RtLibUseGOT" when fno-plt is used.

Author: tmsriram Date: Fri Feb 23 13:27:33 2018 New Revision: 325961 URL: http://llvm.org/viewvc/llvm-project?rev=325961&view=rev Log: Set Module Metadata "RtLibUseGOT" when fno-plt is used. Differential Revision: https://reviews.llvm.org/D42217 Modified: cfe/trunk/lib/CodeGen/CodeGenModule.

Re: [PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

On Fri, Feb 23, 2018 at 11:54 AM, Rafael Avila de Espindola wrote: > Sriraman Tallam via Phabricator writes: >> + if (CodeGenOpts.NoPLT) { >> +getModule().setAvoidPLT(); >> + } >> + > > You don't need the {}. > > LGTM with that. Thanks! Sri > > Cheers, > Rafael ___

r317627 - Change noplt.c to work for non-x86 targets.

Author: tmsriram Date: Tue Nov 7 14:34:55 2017 New Revision: 317627 URL: http://llvm.org/viewvc/llvm-project?rev=317627&view=rev Log: Change noplt.c to work for non-x86 targets. Differential Revision: https://reviews.llvm.org/D39759 Modified: cfe/trunk/test/CodeGen/noplt.c Modified: cfe/tr

r317605 - New clang option -fno-plt which avoids the PLT and lazy binding while making external calls.

Author: tmsriram Date: Tue Nov 7 11:37:51 2017 New Revision: 317605 URL: http://llvm.org/viewvc/llvm-project?rev=317605&view=rev Log: New clang option -fno-plt which avoids the PLT and lazy binding while making external calls. Differential Revision: https://reviews.llvm.org/D39079 Added: c

Re: [PATCH] D39079: New clang option -fno-plt to avoid PLT for external calls

On Tue, Oct 24, 2017 at 10:25 AM, Joerg Sonnenberger via Phabricator wrote: > joerg added a comment. > > Let me phrase it differently. What is this patch (and the matching backend > PR) supposed to achieve? There are effectively two ways to get rid of PLT > entries: > (1) Bind references locally

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

This revision was automatically updated to reflect the committed changes. Closed by commit rL284638: New clang option -mpie-copy-relocations to use copy relocations for PIE builds. (authored by tmsriram). Changed prior to commit: https://reviews.llvm.org/D19996?vs=75189&id=75212#toc Repository

r284638 - New clang option -mpie-copy-relocations to use copy relocations for PIE builds.

Author: tmsriram Date: Wed Oct 19 15:24:06 2016 New Revision: 284638 URL: http://llvm.org/viewvc/llvm-project?rev=284638&view=rev Log: New clang option -mpie-copy-relocations to use copy relocations for PIE builds. Differential Revision: https://reviews.llvm.org/D19996 Modified: cfe/trunk/in

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

tmsriram updated this revision to Diff 75189. tmsriram added a comment. - Fix Help text. - Fix indentation. https://reviews.llvm.org/D19996 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp lib/Driver/Tools.cpp lib/Frontend/Co

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

tmsriram added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:589 Args.hasArg(OPT_mincremental_linker_compatible); + Opts.PIECopyRelocations = + Args.hasArg(OPT_mpie_copy_relocations); mgrang wrote: > You should also check for the n

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

tmsriram updated this revision to Diff 75179. tmsriram added a comment. - Changed help text to "Avail copy relocations support for PIE builds" - Removed mno-pie... as a CC1 option - Removed help text from mno-pie.. https://reviews.llvm.org/D19996 Files: include/clang/Driver/Options.td inclu

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

tmsriram retitled this revision from "New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE" to "New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE". tmsriram updated the summary for this rev

Re: [PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

On Thu, May 5, 2016 at 2:31 PM, Rafael Espíndola wrote: > Is there a gcc option or they just assume they are targeting the > linker that was around when gcc was built? It is done at configure time, the linker is checked for copy relocations support. I recently saw a request to replace this with

[PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

tmsriram created this revision. tmsriram added a reviewer: rnk. tmsriram added subscribers: cfe-commits, davidxl, rafael. With linker copy relocations, PIE can generate better code for external global variable accesses. This patch adds a new option to clang to specify this. Please see http://

Re: [PATCH] D19749: Delete store to Target option PositionIndependentExecutable

This revision was automatically updated to reflect the committed changes. Closed by commit rL268137: Delete store to Target option PositionIndependentExecutable as PIE is now set… (authored by tmsriram). Changed prior to commit: http://reviews.llvm.org/D19749?vs=55676&id=55687#toc Repository:

r268137 - Delete store to Target option PositionIndependentExecutable as PIE is now set in module flags.

Author: tmsriram Date: Fri Apr 29 18:38:53 2016 New Revision: 268137 URL: http://llvm.org/viewvc/llvm-project?rev=268137&view=rev Log: Delete store to Target option PositionIndependentExecutable as PIE is now set in module flags. Differential Revision: http://reviews.llvm.org/D19749 Modified:

[PATCH] D19749: Delete store to Target option PositionIndependentExecutable

tmsriram created this revision. tmsriram added a reviewer: rnk. tmsriram added subscribers: cfe-commits, davidxl. Delete store to Target option PositionIndependentExecutable which will be deleted. PIE is set in module flags. http://reviews.llvm.org/D19749 Files: lib/CodeGen/BackendUtil.cpp

Re: [PATCH] D19687: Set PIELevel module flag

tmsriram closed this revision. tmsriram added a comment. 267948 http://reviews.llvm.org/D19687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267948 - Differential Revision: http://reviews.llvm.org/D19687

Author: tmsriram Date: Thu Apr 28 17:34:00 2016 New Revision: 267948 URL: http://llvm.org/viewvc/llvm-project?rev=267948&view=rev Log: Differential Revision: http://reviews.llvm.org/D19687 Set module flag PIELevel. Simplify code that sets PICLevel flag. Modified: cfe/trunk/lib/CodeGen/CodeGe

Re: [PATCH] D19687: Set PIELevel module flag

tmsriram updated this revision to Diff 55493. tmsriram added a comment. Simplify code setting PICLevel and PIELevel module flags. http://reviews.llvm.org/D19687 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp =

[PATCH] D19687: Set PIELevel module flag

tmsriram created this revision. tmsriram added reviewers: rnk, davidxl. tmsriram added a subscriber: cfe-commits. In patch http://reviews.llvm.org/D19671, I added a patch to create PIELevel module flag. This patch sets the flag. http://reviews.llvm.org/D19687 Files: lib/CodeGen/CodeGenModule

Re: [PATCH] D18843: Always have clang pass -pie-level and -pic-level values to the code generator

tmsriram updated this revision to Diff 52945. tmsriram added a comment. Cleanup the code to use a local variable to store *Res.getLangOpts() http://reviews.llvm.org/D18843 Files: lib/Frontend/CompilerInvocation.cpp Index: lib/Frontend/CompilerInvocation.cpp ==

[PATCH] D18843: Always have clang pass -pie-level and -pic-level values to the code generator

tmsriram created this revision. tmsriram added reviewers: rnk, davidxl. tmsriram added a subscriber: cfe-commits. clang does not pass pie-level and pic-level option values to the code generator with "-x ir" due to the following code in CompilerInvocation.cpp: if (DashX == IK_AST || DashX == I