[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

svenvh added a comment. If we go with this approach, please also remove sqrt from `clang/lib/Sema/OpenCLBuiltins.td` (and ideally add a comment pointing out that sqrt is handled in `opencl-c-base.h`) Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __c

[PATCH] D151339: [OpenCL] Add cl_ext_image_raw10_raw12 extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e8b44cc447e: [OpenCL] Add cl_ext_image_raw10_raw12 extension (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D151339?vs=5

[PATCH] D151339: [OpenCL] Add cl_ext_image_raw10_raw12 extension

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the defines for the `cl_ext_image_

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb843d09942: [OpenCL] Add builtin header TableGen emitter (authored by svenvh). Herald added a subscriber: mgrang. Changed prior to commit: https://reviews.llvm.org/D104040?vs=417678&id=503704#toc Rep

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

svenvh accepted this revision. svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + Anastasia

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + It's slightly more than that: clang adds

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG149521091499: [OpenCL] Always add nounwind attribute for OpenCL (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

svenvh added a comment. In D142033#4062671 , @bader wrote: > Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to > validate function attributes other than `convergent`? It's not obvious that > presence of `nounwind` attribute is

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl, bader. Herald added subscribers: kosarev, Naghasan, ldrumm, kerbowa, jvesely. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Neith

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

svenvh added inline comments. Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute. +// FIXME: we don't, though. // CHECK-LABEL: @test_const_attr lebedev.ri wrote:

[PATCH] D141297: [OpenCL] Allow undefining header-only features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60b8f468119: [OpenCL] Allow undefining header-only features (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh added a comment. In D141297#4043122 , @Anastasia wrote: > Btw I wonder if in the future we could add some error or warning in case > someone uses the same approach for frontend specific features, i.e. > > #ifdef __undef___opencl_c_generic_addres

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh created this revision. svenvh added reviewers: Anastasia, FMarno. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `opencl-c-base.h` always define

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

svenvh added a comment. > it may be more appropriate to make these triggered off of a hidden option > defaulted to off for now, or maybe based on whether or not opaque pointers > are enabled There isn't really a meaningful alternative representation for these opaque types when opaque pointers

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added a comment. > @svenvh I remember that we have also discussed the addition of a vendor > specific header where such feature/extension macro definition can be added to > avoid the macro pollution but I feel this is somewhat orthogonal i.e. the > fine grained control of macro defines i

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:123 +OPENCL_OPTIONALCOREFEATURE(__opencl_c_work_group_collective_functions, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_int64, false, 300, OCL_C_30) I am

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

svenvh added a comment. > I have attempted to workaround this issue for the reported test cases, > however it still doesn't quite work when the type is created from the > template parameter (see FIXME test case in the patch). I presume we want to > allow this? If so we might need to disable laz

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/docs/ReleaseNotes.rst:676 + LLVM backend when generating SPIR-V binary. + Floating Point Support in Clang Anastasia wrote:

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

svenvh added a comment. In D132473#3742688 , @Anastasia wrote: > @svenvh as you made quite a lot of changes in the headers feel free to expand > the description if you feel we should document some of those in more detail. I think you have captured it qu

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

svenvh accepted this revision. svenvh added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130768/new/ https://reviews.llvm.org/D130768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8e658ec9ff5: [OpenCL] Remove fast_ half geometric builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128436/new/ https://reviews.

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d421e6e3b78: [OpenCL] Remove half scalar vload/vstore builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128434/new/ https://revi

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG663e47a50f50: [OpenCL] Reduce emitting candidate notes for builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not mentio

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not mentio

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:11224 + // so do not generate such notes. + if (S.getLangOpts().OpenCL && Fn->isImplicit() && + Cand->FailureKind != ovl_fail_bad_conversion) Anastasia wrote: > It would have been ni

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. When overload resolution fails, clang

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG7acc88be0312: [OpenCL] Reword unknown extension pragma diagnostic (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126660/new/ https://re

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

svenvh added a comment. In D126660#3550356 , @Anastasia wrote: > Ok, makes sense! Thanks! > > Btw I was thinking we should provide some way for developers to know what > extensions are being supported either through documentation or by querying > clang

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

svenvh created this revision. svenvh added reviewers: Anastasia, stuart. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. For newer OpenCL extensions tha

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c29a8ae053: [OpenCL] Add cl_khr_subgroup_rotate builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.l

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGb250cca11d59: [OpenCL] Do not guard vload/store_half builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://review

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

svenvh updated this revision to Diff 428952. svenvh added a comment. Add test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://reviews.llvm.org/D125401 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Sema/OpenCLBuiltins.td clang/test/SemaOpenCL/half.cl

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The vload*_half* and vstore*_half* bui

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh added a comment. In D124256#3474043 , @Anastasia wrote: > LGTM! I imagine tablegen side is being tested automatically? The TableGen definitions are tested by `clang/test/Headers/opencl-builtins.cl` > Btw do we need to set the feature macro for SP

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh updated this revision to Diff 428652. svenvh added a comment. Added macro and macro test. Added reference to Extension spec section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124256/new/ https://reviews.llvm.org/D124256 Files: clang/lib/Headers/opencl-c-base.h clang/lib

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM; just a few minor suggestions that you can address at commit time. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins for the new OpenCL ex

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ee0afc6739: [OpenCL] opencl-c.h: Add const to get_image_num_samples (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122728/new/ https:

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. I've submitted the fix in `4dfec37037f5`. As for testing, unfortunately I couldn't just extend the `SemaOpenCL/fdeclare-opencl-builtins.cl` test: the OpenCL 1.2 RUN lines explicitly disable the `cl_intel_subgroups` extension (which is the extension that brings in `sub_g

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3419221 , @hvdijk wrote: > This was worked around by modifying tests, but I believe this is a > fundamental problem in this change and was able to reproduce the error with > plain old clang: > > $ cat test.cl > voi

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Align with the `-fdeclare-opencl-built

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh updated this revision to Diff 417678. svenvh added a comment. Herald added a subscriber: Naghasan. Herald added a project: All. Rebased on latest `main`. Also takes TypeExtensions into account now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104040/new/ https://reviews.llvm.or

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGba18c360b2f3: [clang-tidy] Remove opencl-c.h inclusion from tests (authored by svenvh). Repository: rG LLVM Github Mono

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh added a comment. Since this is a simple test update I'll commit this now (before code review), to get affected CI back to green. Please let me know if there are any post-commit concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120470/

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28cdcf8e3c8e: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh updated this revision to Diff 411106. svenvh edited the summary of this revision. svenvh added reviewers: Anastasia, ffrankies. svenvh added a comment. After a bit of digging I realized we don't need the explicit include at all anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. Thanks, I could reproduce the problem with your cmake line. I have uploaded a fix for review in https://reviews.llvm.org/D120470 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120254/new/ https://reviews.llvm.org/D120254 _

[PATCH] D120470: [clang-tidy] Update tests to include opencl-c-base.h

svenvh created this revision. svenvh added a reviewer: dyung. Herald added subscribers: Naghasan, ldrumm, xazax.hun, Anastasia, yaxunl. svenvh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. After D120254

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3342551 , @dyung wrote: > Hi, our internal release build bots are showing failures in two clang-tidy > tests that I bisected back to your commit, > clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and > cla

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh marked 2 inline comments as done. svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:1183 + SmallVector ExtVec; + TypeExt.split(ExtVec, " "); + for (const auto Ext : ExtVec) { arkangath wrote: > Just

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh marked 2 inline comments as done. svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:296-298 + // Emit an #if guard for all type extensions required for the given type + // strings. arkangath wrote: > Shouldn't

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh updated this revision to Diff 410822. svenvh added a comment. Use StringRef and extend comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120262/new/ https://reviews.llvm.org/D120262 Files: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp Index: clang/utils/TableGen/Cla

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. svenvh marked an inline comment as done. Closed by commit rGaa9c2d19d9b7: [OpenCL] Align subgroup builtin guards (authored by svenvh). Repository: rG LLVM Github Mon

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif azabaznov wrote: > svenvh wrote: > > I'm

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e17b30d02d: [OpenCL] opencl-c.h: use uint/ulong consistently (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, any types that had TypeExtensions attached to them were

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif I'm in doubt whether we could just reuse `__opencl_c_subgroups` for this? Repos

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh created this revision. svenvh added a reviewer: azabaznov. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, subgroup builtins are available with `opencl-c.h` when a

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Most places already seem to use the short spelling instead of 'unsi

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9798b33d1dc1: [OpenCL] Guard 64-bit atomic types (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rG477bc8e8b931: [OpenCL] Guard atomic_double with cl_khr_int64_* (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119398?vs=407506&id=409179#toc Repository: rG LLVM Github Monor

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh added a comment. In D119858#3323565 , @Anastasia wrote: > LGTM! Thanks! > > I imagine this is another change to align with `opencl-c.h`? Yes. This addresses the issue of D119398 for tablegen (although the proble

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, overloads with a 64-bit atomic type argument we

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, just suggesting a minor textual improvement that can be made at commit time. Comment at: clang/docs/UsersManual.rst:3063 -There is ongoing support for OpenCL v3.0 th

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

svenvh added a comment. In D119560#3322531 , @Anastasia wrote: >> also makes the header no longer "claim" the identifiers "success", >> "failure", "desired", "value" (such that you can compile with -Dvalue=... >> when including the header for example, whi

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:262 +- Added parsing support for optionality of device side enqueue and blocks (not + fully incomplete yet!). +- Added missing support for optionality of various builtin functions: incomplete

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added a comment. In D118605#3313990 , @Anastasia wrote: > In D118605#3313859 , @azabaznov > wrote: > >>> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >>> we need this check t

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f8abb9f40a: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119420?vs=407432&id=407813#toc Repository: rG LLVM

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh accepted this revision. svenvh added a comment. Thanks, LGTM! I'll try to followup with the .td changes soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 __

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh added a comment. In D119398#3310746 , @Anastasia wrote: > This might interfere with https://reviews.llvm.org/D119420 Yes it will conflict. Atomic doubles are not guarded properly for other builtins (outside of the `cl_ext_float_atomics` extensio

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the atomic overloads for the `global` and `local` addr

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). --

[PATCH] D119011: [clang] Cache OpenCL types

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 __

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e6099291dcb: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CH

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:73 #if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define __opencl_c_generic_address_space 1 #define cl_khr_subgroup_extended_types 1 Anastasia wr

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfd8210f6f47: [OpenCL] opencl-c.h: refactor named addrspace builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D1181

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh updated this revision to Diff 403705. svenvh edited the summary of this revision. svenvh added a comment. Make use of the `__opencl_c_named_address_space_builtins` internal feature added by D118158 . This should avoid affecting OpenCL 2.0. CHANGES SINC

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

svenvh created this revision. svenvh added a reviewer: clang. Herald added subscribers: Naghasan, ldrumm, Anastasia, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The named address space overloads of builtins that take a po

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG91a0b464a853: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1178

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#3265665 , @Anastasia wrote: > The way I understand the spec for OpenCL C 2.0 is that whenever the address > space of the pointer is not listed it means generic has to be used, here is > one example: > https://www.khron

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

svenvh added a comment. Thanks for committing this! The corresponding TableGen changes are in D117899 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Ensure any use of a `read_write` image is guarded behind the `__op

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

svenvh added a comment. @airlied are you still planning to land this? I started looking at the corresponding .td changes when I realized we don't use `__opencl_c_read_write_images` in `opencl-c.h` either yet. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b85800bfd6c: [OpenCL] Set external linkage for block enqueue kernels (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" aganea wrote: > Hello @Anastasia, this line fails on my machin

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. I made some minor comments, that can be fixed before committing. Comment at: clang/docs/UsersManual.rst:3567 +Linking is done using `spirv-link` linker from `the SPI

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Mostly some minor comments that you can address at commit time. It would be good to get approval from another reviewer. Comment at: clang/docs/UsersManual.rst:3538 +

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. In D110742#3197183 , @stuart wrote: > Thanks! I have updated the review to use `__attribute__((pure))` only (i.e. > it no longer uses `__attribute__(

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

svenvh added a comment. > Does the langref need to be amended, first, or is it okay to interpret the > `readnone` attribute as it was clearly intended, without going through the > process of updating the langref first? > > I can update this review to use `__attribute__((pure))` for all address

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:10 +// SPV64-SAME: "-o" [[BC:".*bc"]] +// SPV64: {{".*llvm-spirv.*"}} [[BC]] "-o" {{".*o"}} + Anastasia wrote: > svenvh wrote: > > Any reason to not just check for `llvm-spirv{{.*}}`,

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. svenvh added a project: clang. Herald added a subscriber: ldrumm. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. All kernels can be called from the host as per the SPIR_KERNEL calling conven

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh requested changes to this revision. svenvh added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:3728 + // Linking separate translation units for SPIR-V is not supported yet. + // It can be done either by LLVM IR

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#2967565 , @Anastasia wrote: > In D107769#2960441 , @svenvh wrote: > >> I have done an alternative spin of this patch: instead of introducing >> `RequireDisabledExtension`, simpl

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG544d89e847d4: [OpenCL] Add atomic_half type builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D109740?vs=376467&id=378938#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

svenvh added a comment. > For the constant address space, the const attribute (or readnone) can be > used. As memory in the constant address space is immutable, the statement in > the langref that: "if a readnone function reads or writes memory visible to > the program, or has other side-effect

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

svenvh added a comment. Looks good at a first quick glance, but please fix the formatting errors that are reported on the lines that you are adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 __

  1   2   3   4   5   >