[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2414171 , @spatel wrote: > In D88712#2413877 , > @venkataramanan.kumar.llvm wrote: > >> In D88712#2413688 , @spatel

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2413688 , @spatel wrote: > In D88712#2412874 , > @venkataramanan.kumar.llvm wrote: > >> In D88712#2412366 , @MaskRay

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2412366 , @MaskRay wrote: > In D88712#2411841 , > @venkataramanan.kumar.llvm wrote: > >> > > For your example: > > extern double log (double) asm (""

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. Hi, I am on Ubuntu 18 machine and it has finite math header . This header is included by the glibc 2.27. This header has this following definition. extern double log (double) __asm__ ("" "__log_finite") __attribute__ ((__nothrow__ )); Consider the

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Thanks @spatel , @Florian and @fpetrogalli for the review comments and approval. Can someone please commit it on my behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 299280. venkataramanan.kumar.llvm added a comment. Remove an incorrect file that got attached with my earlier patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 Files:

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 299278. venkataramanan.kumar.llvm added a comment. Herald added a subscriber: dexonsmith. Added a test case for testing vector library calls for VF=2 and VF=8. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297925. venkataramanan.kumar.llvm added a comment. Updated the patch as per review comments received. The test cases are updated the checks based on the below comment from Francesco. ---Snip-- I think you are over-testing here. It is

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297654. venkataramanan.kumar.llvm added a comment. As per review comments from Sanjay, updated the test case to use metadata. Also autogenerated the checks in the test cases using llvm/utils/update_test_checks.py. CHANGES SINCE LAST

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297480. venkataramanan.kumar.llvm added a comment. Changed library naming to LIBMVEC-X86 as per comments and also selected based on Target Tripple in clang. I am still working on auto generating FileCheck for the test cases. CHANGES

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. In D88154#2314352 , @spatel wrote: > In D88154#2310653 , > @venkataramanan.kumar.llvm wrote: > >> In D88154#2290205 , @abique

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Pinging for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. In D88154#2290205 , @abique wrote: > Looks good to me. > Regarding the tests, it seems that you check if auto-vectorization takes > advantages of libmvec? > Would it be interesting to have a test which declares

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 296035. venkataramanan.kumar.llvm added a reviewer: spatel. venkataramanan.kumar.llvm added a comment. Herald added a subscriber: pengfei. Selection of Glibc vector math library is enabled via the option -fvec-lib=libmvec . CHANGES SINCE

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Initial version I supported the following vector functions (VF 2 and 4 ). sin cos exp pow log Also added test cases similar to SVML under X86. I am not sure about other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm created this revision. venkataramanan.kumar.llvm added reviewers: Florian, abique. Herald added subscribers: llvm-commits, cfe-commits, dang, dmgreen, hiraditya. Herald added projects: clang, LLVM. venkataramanan.kumar.llvm requested review of this revision. Initial