[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-09-04 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. jdoerfert marked an inline comment as done. Closed by commit rL370930: [OpenMP][Docs] Provide implementation status details (authored by jdoerfert, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-09-04 Thread Joachim Protze via Phabricator via cfe-commits
protze.joachim added inline comments. Comment at: clang/docs/OpenMPSupport.rst:165 ++--+--+--++ +| OMPD | OMPD

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-09-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/docs/OpenMPSupport.rst:204

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-09-04 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--++ +| device extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-09-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--++ +| device extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 217631. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Update according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-14 Thread Ravi Narayanaswamy via Phabricator via cfe-commits
RaviNarayanaswamy added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-02 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: clang/docs/OpenMPSupport.rst:233 ++--+--+--++ +| device extension | mapping

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-08-01 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 212957. jdoerfert added a comment. Improve based on two comments by @Hahnfeld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files: clang/docs/OpenMPSupport.rst

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-25 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D64375#1601163 , @jdoerfert wrote: > I'll add @Hahnfeld comments, anything else? If not, can someone approve this > and we do separate reviews for improvements? Update revision and I'll approve it. Repository: rG LLVM

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I'll add @Hahnfeld comments, anything else? If not, can someone approve this and we do separate reviews for improvements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-11 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: clang/docs/OpenMPSupport.rst:165 ++--+--+--++ +| OMPD | OMPD

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 209089. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Fixes according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:198 ++--+--+--++ +| device extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:207 ++--+--+--++ +| device extension | clause:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:184 ++--+--+--++ +| task extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:163 ++--+--+--++ +| memory mangagement | allocate

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 209073. jdoerfert marked 29 inline comments as done. jdoerfert added a comment. Add colors, updates according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D64375#1577153 , @jdoerfert wrote: > @lebedev.ri I'd like to see if we can transition this one into a more generic > one with version numbers etc. Is that OK? I have no further comment at the moment. Repository: rG

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I will update the table (hopefully tomorrow) and we can then see if we commit it and change it in-place or if we have more initial feedback. Thanks everyone for providing all this information! @lebedev.ri I'd like to see if we can transition this one into a more

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:161 ++--+--+--++ +| memory mangagement | memory

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a subscriber: protze.joachim. Hahnfeld added inline comments. Comment at: clang/docs/OpenMPSupport.rst:165 ++--+--+--++

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-09 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Nice, thank you for working on this! It would be also good to have a not OpenMP-5 specific, but an overview table - which OpenMP thingy was supported starting with which Clang version, very much like https://clang.llvm.org/cxx_status.html /

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D64375#1574698 , @jdoerfert wrote: > In D64375#1574662 , @ABataev wrote: > > > The scheme itself looks good in general. > > > Good. Once we agreed on a scheme we can improve the actual

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-08 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D64375#1574662 , @ABataev wrote: > The scheme itself looks good in general. Good. Once we agreed on a scheme we can improve the actual process, excel sheet, generator script,

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. The scheme itself looks good in general. Just as an improvement, it would be good to use coloring for the feature status. Also, what's the difference between claimed, mostly done and done? Comment at: clang/docs/OpenMPSupport.rst:153

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

2019-07-08 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: kkwli0, ABataev, RaviNarayanaswamy, gtbercea, Hahnfeld. Herald added subscribers: jfb, guansong, bollu. Herald added a project: clang. This adds a more fine-grained list of OpenMP features with their implementation status and associated