This revision was automatically updated to reflect the committed changes.
Closed by commit rG6a0c066c6102: [ASTMatchers] Adds a matcher called
`hasAnyOperatorName` (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D75040?vs=246335&id=246375#toc
Repository:
rG LLVM Git
njames93 updated this revision to Diff 246335.
njames93 added a comment.
- Rebase with trunk
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75040/new/
https://reviews.llvm.org/D75040
Files:
clang/docs/LibASTMatchersReference.html
clang/docs/too
njames93 updated this revision to Diff 246203.
njames93 added a comment.
- Improved docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75040/new/
https://reviews.llvm.org/D75040
Files:
clang/docs/LibASTMatchersReference.html
clang/docs/tools/d
njames93 requested review of this revision.
njames93 marked 3 inline comments as done.
njames93 added a comment.
I have fixed up the docs to be more in line with other matchers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75040/new/
https://review
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4772
+///
+/// FIXME: Tweak to improve docs generated
+extern const internal::VariadicFunction Any specific things you would like to improve? The f
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1870
+std::is_same::value,
+"unsupported class for matcher");
+ static_assert(std::is_same>::value,
--
njames93 updated this revision to Diff 246190.
njames93 marked an inline comment as done.
njames93 edited the summary of this revision.
njames93 added a comment.
- Address nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75040/new/
https://review
gribozavr2 added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4772
+///
+/// FIXME: Tweak to improve docs generated
+extern const internal::VariadicFunctionhttps://reviews.llvm.org/D75040/new/
https://reviews.llvm.org/D75040
_
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1880-1884
+for (const std::string &Name : Names) {
+ if (Name == OpName)
+return true;
+}
+return false;
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1870
+std::is_same::value,
+"unsupported class for matcher")
njames93 created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
njames93 edited the summary of this revision.
njames93 added reviewers: aaron.ballman, gribozavr2.
Acts on `BinaryOperator` and `UnaryOperator` and functions the same as
`anyOf(hasOperatorName(.
11 matches
Mail list logo